)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3ea0cb252002140d9c160498cfebc8c48e622d68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45e38fc6_0201cec0","updated":"2023-02-24 16:37:59.000000000","message":"I haven\u0027t tested it yet.","commit_id":"d1413a008d01d1135604318687e89ef3176b1f25"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1792f22b475b30054a32c00b6b646a211ad60222","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a78f4d9_9135de97","in_reply_to":"45e38fc6_0201cec0","updated":"2023-03-27 14:39:38.000000000","message":"Tested now, it works fine.","commit_id":"d1413a008d01d1135604318687e89ef3176b1f25"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"782323eae9eb435ec5a052cd1881d752641a616c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a400baf7_b3f69a08","updated":"2023-03-31 12:45:20.000000000","message":"Seems reasonable - it also works for the case when people bake the private CA into the base image.","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0fcf849728ba1224d737b42b3350c2d4734c6060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c338de6f_176835f5","updated":"2023-03-31 12:47:48.000000000","message":"Should we handle this as a bugfix to allow backporting? I\u0027ve hit the issue at a few sites.","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c322eca57688b9e5771ee60c2b0059d5dcfaa40a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cadf27cd_592e7ace","in_reply_to":"01497e66_faa15182","updated":"2023-03-31 16:18:00.000000000","message":"Done","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"eaa8110cdd2130c46ebc415e5d1867fef72ab593","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de5a4635_eaed7139","in_reply_to":"c338de6f_176835f5","updated":"2023-03-31 13:00:04.000000000","message":"It shouldn\u0027t change anything on existing deployments so I think it\u0027s a good idea. Would it require changing the reno category?","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c7cdd08fc61bced77a20095228db4988aad1d7f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01497e66_faa15182","in_reply_to":"de5a4635_eaed7139","updated":"2023-03-31 13:45:16.000000000","message":"+1 for`bugfix`","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0c6d64d0c26922d4320692ffd7a0c191417ed622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb9ad827_609f3d1c","updated":"2023-04-03 17:31:22.000000000","message":"IMO adding a global variable for a very restricted use case doesn\u0027t fit the kolla style. what\u0027s the reason not to simply use an override for the template in this case?\n\nI would also not agree on this being a bugfix rather than a feature, but that\u0027s secondary","commit_id":"842ce419575e8e16fb877232f2dab258fcde921f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"aaed5fa2af070f7273581eef5811798d92f9db62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8edf85f_ff5823e2","updated":"2023-04-03 08:38:17.000000000","message":"Looks good, thanks!","commit_id":"842ce419575e8e16fb877232f2dab258fcde921f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ec7744df2602b89641313c88e208d51d17d967bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6fe89945_a997a77a","in_reply_to":"1bc805d4_1f604535","updated":"2023-04-04 08:13:34.000000000","message":"I personally don\u0027t like having to maintain customised versions of config files, but if that is the agreed design philosophy, I will keep on doing it…","commit_id":"842ce419575e8e16fb877232f2dab258fcde921f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1659805d366ae3969318ce171fde62bde7f5fb7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1bc805d4_1f604535","in_reply_to":"eb9ad827_609f3d1c","updated":"2023-04-04 05:32:59.000000000","message":"I unfortunately agree, missed the fact we\u0027re not really copying the ca file automatically (thought it\u0027s mainly for monitoring OpenStack API endpoints) - but pointing to use it via extra_volumes. Sounds like something that can be achieved by usual template overrides - and that\u0027s against the approach we documented in the docs (https://docs.openstack.org/kolla/latest/contributor/kolla-design-philosophy.html#prefer-documented-configuration-via-config-overrides).","commit_id":"842ce419575e8e16fb877232f2dab258fcde921f"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"782323eae9eb435ec5a052cd1881d752641a616c","unresolved":true,"context_lines":[{"line_number":322,"context_line":"prometheus_node_exporter_cmdline_extras: \"\""},{"line_number":323,"context_line":"prometheus_openstack_exporter_cmdline_extras: \"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_blackbox_exporter_cafile: \"\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"prometheus_alertmanager_external_url: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb718b13_0746c0a8","line":325,"updated":"2023-03-31 12:45:20.000000000","message":"nit: Var name could imply that it needs to be an absolute file path","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c322eca57688b9e5771ee60c2b0059d5dcfaa40a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"prometheus_node_exporter_cmdline_extras: \"\""},{"line_number":323,"context_line":"prometheus_openstack_exporter_cmdline_extras: \"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_blackbox_exporter_cafile: \"\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"prometheus_alertmanager_external_url: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6208f971_8f716a30","line":325,"in_reply_to":"aeaec4bf_48379989","updated":"2023-03-31 16:18:00.000000000","message":"I amended the comment.","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5147e0a5abacc2fb6b7e8377455f3dd3e3fb3502","unresolved":true,"context_lines":[{"line_number":322,"context_line":"prometheus_node_exporter_cmdline_extras: \"\""},{"line_number":323,"context_line":"prometheus_openstack_exporter_cmdline_extras: \"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_blackbox_exporter_cafile: \"\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"prometheus_alertmanager_external_url: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e334bc91_1585e893","line":325,"in_reply_to":"cb718b13_0746c0a8","updated":"2023-03-31 12:58:56.000000000","message":"Do you mean that you would name it something like prometheus_blackbox_exporter_cafile_path?\n\nI went with naming similar to existing variables:\n\n* cafile\n* cloudkitty_prometheus_cafile\n* openstack_cacert\n* glance_ca_certificates_file\n\nOnly verify_ssl_path has \"path\" in its name.","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c7cdd08fc61bced77a20095228db4988aad1d7f5","unresolved":true,"context_lines":[{"line_number":322,"context_line":"prometheus_node_exporter_cmdline_extras: \"\""},{"line_number":323,"context_line":"prometheus_openstack_exporter_cmdline_extras: \"\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"prometheus_blackbox_exporter_cafile: \"\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"prometheus_alertmanager_external_url: \"{{ internal_protocol }}://{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_alertmanager_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"aeaec4bf_48379989","line":325,"in_reply_to":"e334bc91_1585e893","updated":"2023-03-31 13:45:16.000000000","message":"No big deal - perhaps an example in a comment would be more helpful. Initially I just wasn\u0027t sure if it would want a file name and search /etc/pki.. or the absolute path.","commit_id":"c8b561a2a5051c3436a3d976c5d198c2edc51c31"}]}