)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9c82a64f6f12d21da01d7dce2517b0fab223696d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew N Heler \u003cmatthew.heler@hotmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-26 13:05:39 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder: Set the etcd internal hostname and cacert for tls external"},{"line_number":8,"context_line":"enabled deployments"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This allows Cinder to work with etcd when coordination is enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6f74ca0c_b30f9fe2","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":66},"updated":"2023-03-02 10:10:47.000000000","message":"internal","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83a928ed5151909907961c4812718ccaae05eb21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew N Heler \u003cmatthew.heler@hotmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-26 13:05:39 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder: Set the etcd internal hostname and cacert for tls external"},{"line_number":8,"context_line":"enabled deployments"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This allows Cinder to work with etcd when coordination is enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e1888c13_8b039195","line":7,"range":{"start_line":7,"start_character":58,"end_line":7,"end_character":66},"in_reply_to":"6f74ca0c_b30f9fe2","updated":"2023-03-07 20:33:06.000000000","message":"Done","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9c82a64f6f12d21da01d7dce2517b0fab223696d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"enabled deployments"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This allows Cinder to work with etcd when coordination is enabled"},{"line_number":11,"context_line":"for TLS external deployments. Without this fix, etcd fails to start"},{"line_number":12,"context_line":"on cinder."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0c1d6b87e663e48c15a846a2774b0a4531a3ca68"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"448a7144_ddefd276","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":16},"updated":"2023-03-02 10:10:47.000000000","message":"internal","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83a928ed5151909907961c4812718ccaae05eb21","unresolved":false,"context_lines":[{"line_number":8,"context_line":"enabled deployments"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This allows Cinder to work with etcd when coordination is enabled"},{"line_number":11,"context_line":"for TLS external deployments. Without this fix, etcd fails to start"},{"line_number":12,"context_line":"on cinder."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0c1d6b87e663e48c15a846a2774b0a4531a3ca68"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3cd5b698_4b1fc914","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":16},"in_reply_to":"448a7144_ddefd276","updated":"2023-03-07 20:33:06.000000000","message":"Done","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c5e016a845e66ace513a55805f8ab0e8cf466e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38b92df9_c3330dcf","updated":"2023-03-02 10:10:10.000000000","message":"Could you add a release note?","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6894c951fec5b07d09c72ccad8cbacd79ae857e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35b04d92_45b33b46","updated":"2023-03-01 14:26:53.000000000","message":"Should we have a bug linked here so we can track backports?","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83a928ed5151909907961c4812718ccaae05eb21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"931cfd8b_3603940b","in_reply_to":"18246884_8ab4f36f","updated":"2023-03-07 20:33:06.000000000","message":"Done","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"5b29ae93ae2852b592656aef495a078ef7dca27a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c754f2e_8ae3d8a0","in_reply_to":"35b04d92_45b33b46","updated":"2023-03-01 18:19:47.000000000","message":"Maybe.. it is a regression from 874402, and if we are back-porting 874402 then we should also backport this patch.","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c5e016a845e66ace513a55805f8ab0e8cf466e23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18246884_8ab4f36f","in_reply_to":"8158ce99_fdbbadc1","updated":"2023-03-02 10:10:10.000000000","message":"Yes, please fix other affects projects in this patch.","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"95ebf8d9b02a2a643b264f9e7541b793f1c08ac4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8158ce99_fdbbadc1","in_reply_to":"9c754f2e_8ae3d8a0","updated":"2023-03-01 18:23:09.000000000","message":"Maybe we should include the scope of other projects in this patch? Looks like Ironic, and other services are impacted.","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"3043b60ae09d219e399d383e8ce10423bc637c2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16706cc7_fc69b55d","updated":"2023-03-02 12:50:11.000000000","message":"Let me know if any other changes are required.","commit_id":"5d3eed23a736144b69909f388300d1587f7862e2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"ef1f2d5282942dc6209de84588366afffa6ed0ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69ec4d07_3e7b80a0","updated":"2023-03-08 15:05:12.000000000","message":"recheck","commit_id":"5d3eed23a736144b69909f388300d1587f7862e2"},{"author":{"_account_id":29268,"name":"Matthew Heler","email":"matthew.heler@hotmail.com","username":"mheler"},"change_message_id":"2f4745dca423a12cd4b0e5808d40d24244f8cea6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db1cce85_38d02f70","updated":"2023-03-08 01:27:00.000000000","message":"recheck","commit_id":"5d3eed23a736144b69909f388300d1587f7862e2"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c5e016a845e66ace513a55805f8ab0e8cf466e23","unresolved":true,"context_lines":[{"line_number":242,"context_line":"# see https://bugs.launchpad.net/kolla-ansible/+bug/1854932"},{"line_number":243,"context_line":"# and https://review.opendev.org/466098 for details"},{"line_number":244,"context_line":"{% if kolla_enable_tls_external | bool %}"},{"line_number":245,"context_line":"backend_url \u003d etcd3+{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ etcd_client_port }}?ca_cert\u003d{{ openstack_cacert }}"},{"line_number":246,"context_line":"{% else %}"},{"line_number":247,"context_line":"backend_url \u003d etcd3+{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ etcd_client_port }}"},{"line_number":248,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"0591dada_b8ba4d70","line":245,"updated":"2023-03-02 10:10:10.000000000","message":"We can use the FQDN unconditionally here. And please make the CA cert conditional.\n\n backend_url \u003d etcd3+{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ etcd_client_port }}{% if openstack_cacert %}?ca_cert\u003d{{ openstack_cacert }}{% endif %}","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83a928ed5151909907961c4812718ccaae05eb21","unresolved":false,"context_lines":[{"line_number":242,"context_line":"# see https://bugs.launchpad.net/kolla-ansible/+bug/1854932"},{"line_number":243,"context_line":"# and https://review.opendev.org/466098 for details"},{"line_number":244,"context_line":"{% if kolla_enable_tls_external | bool %}"},{"line_number":245,"context_line":"backend_url \u003d etcd3+{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ etcd_client_port }}?ca_cert\u003d{{ openstack_cacert }}"},{"line_number":246,"context_line":"{% else %}"},{"line_number":247,"context_line":"backend_url \u003d etcd3+{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ etcd_client_port }}"},{"line_number":248,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"791f4752_9ee4db63","line":245,"in_reply_to":"0591dada_b8ba4d70","updated":"2023-03-07 20:33:06.000000000","message":"Done","commit_id":"387a597652bcd8a30e2a2e23a61f12617df234b2"}]}