)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5c157eb6d7358634c126d1044285b17995001cf1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31b6f8b3_0443ba2c","updated":"2023-03-02 10:04:00.000000000","message":"This will need to be backported and tailored to releases Wallaby through to Zed.","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"37261b93aeefd7aceb1a58b414f39e92bbbb97ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c326eff_18d8d01a","in_reply_to":"31b6f8b3_0443ba2c","updated":"2023-03-08 11:19:30.000000000","message":"Due to differences in Xena (and Wallaby) implementation, this patch was not cherry-picked. See separate patch chain here: https://review.opendev.org/c/openstack/kolla-ansible/+/876832","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"}],"ansible/roles/rabbitmq/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5b6bcc7819a3ff213014ae516482bcb09bf3db5","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  register: rabbitmq_policies"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Remove ha-all policy from RabbitMQ"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"rabbitmq\""},{"line_number":33,"context_line":"    service: \"{{ rabbitmq_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6fef3374_54e61019","line":30,"updated":"2023-03-13 09:49:17.000000000","message":"What\u0027s the case we\u0027re trying to catch here? Given that ha-all was off by default in zed, then on by default in the antelope release, I don\u0027t think using the defaults would require us to remove the policy. So that suggests it\u0027s for someone who has previously enabled om_enable_rabbitmq_high_availability and then disabled it. In which case you could argue it\u0027s not just an upgrade task, but also a deploy task.","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8d98dd4db65b0d0fea4a149f22796f9f129d64a5","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  register: rabbitmq_policies"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Remove ha-all policy from RabbitMQ"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"rabbitmq\""},{"line_number":33,"context_line":"    service: \"{{ rabbitmq_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a0b7992_6abb6f18","line":30,"in_reply_to":"3fbcec3e_a01dac14","updated":"2023-03-13 14:16:46.000000000","message":"Ok, this should move to a separate tasks file that can be imported to here and deploy.yml.","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"44fcfc00c5d96ff521021abce8f474cfc3d0c1b9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  register: rabbitmq_policies"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Remove ha-all policy from RabbitMQ"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"rabbitmq\""},{"line_number":33,"context_line":"    service: \"{{ rabbitmq_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f9add9c8_6b7ec45b","line":30,"in_reply_to":"5a0b7992_6abb6f18","updated":"2023-03-13 14:45:47.000000000","message":"Done","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"bd9be3d0e6909d0f058c4ee973a72ec6626c6cd6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  register: rabbitmq_policies"},{"line_number":28,"context_line":"  changed_when: false"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Remove ha-all policy from RabbitMQ"},{"line_number":31,"context_line":"  vars:"},{"line_number":32,"context_line":"    service_name: \"rabbitmq\""},{"line_number":33,"context_line":"    service: \"{{ rabbitmq_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fbcec3e_a01dac14","line":30,"in_reply_to":"6fef3374_54e61019","updated":"2023-03-13 11:04:43.000000000","message":"That\u0027s correct, this patch is here as `om_enable_rabbitmq_high_availability` is configurable so imo there should be support to handle disabling when it has previously been enabled.","commit_id":"e5c0fe4bfa8d5573e0c4346825b7f2775c96a538"}]}
