)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"477ca5f248d3ea7d50a28f7324d1876e83b4f3e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdb81124_90985780","updated":"2023-03-03 13:37:29.000000000","message":"Added Release note","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"12cd3741a996e643da77aa6ffdded27fefaac541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a32362a_de2f58ee","updated":"2023-03-06 12:00:17.000000000","message":"Good work Dawud - overall this looks great.\n\nI agree that it would be useful to define a variable to support switching between fully qualified / unqualifed names, which would also allow people to override via hostvars if they really need to.","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e7f788ab00358aa0732b66a23efd8dada2490462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bc6a7ae_6a472507","updated":"2023-03-03 14:48:04.000000000","message":"Looks good to me. Could possibly extract the value of the label into a variable so that users can customise it if the like. There is always going to be someone who wants fully qualified names 😄","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"ed0175aa6cbb796bf3e976f97982934afadc5ae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19b6ea54_d9e45b74","updated":"2023-03-06 09:31:41.000000000","message":"This change will result in entirely new set of time series, perhaps some users would want to avoid that. We should also mention it in the reno / docs.","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f5e4de3462fbe64295bad00c36f586901ecf9e4a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6bf6dc8_4a929b08","in_reply_to":"19b6ea54_d9e45b74","updated":"2023-05-17 12:49:05.000000000","message":"shouldn\u0027t we introduce new user breaking defaults with a grace period?\n\nthat is:\n\n- first release: add this as a new feature which is off by default; announce that you want to deprecate $old feature\n- next release: use this feature as the new default, announce again that the old behaviour is deprecated\n- next +1 release remove the old feature\n\nnow let me explain why is this \"breaking\" and why we should do this conversion:\n\n- this is breaking because if users have setup alerting on the old label names essentially means you\u0027re breaking downstream users alerting.\n- yes people should read release notes\n- people might need time to adjust their other stuff, like alerting to this change\n\nThanks for considering this.","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e44238774ab029a1d2c0415aca718418ccefd067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bcb8d469_0b88b7c7","in_reply_to":"5bc6a7ae_6a472507","updated":"2023-03-03 14:49:49.000000000","message":"Should we use fully qualified names by default?","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"567b628872c159adc13b71e1fc39712c55ccdb1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63cbcbcc_5be34cfd","in_reply_to":"bcb8d469_0b88b7c7","updated":"2023-03-03 14:55:04.000000000","message":"We use: `ansible_facts.nodename` in other parts of the code.","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c2ce8684af49db399ff48259b2e2128fc372f8ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"568d3bc9_23c53f4b","in_reply_to":"e6bf6dc8_4a929b08","updated":"2023-05-17 14:08:10.000000000","message":"Done","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f8a141ecc6c75bc59b23b0afeea255395fd0fe37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dd49e978_7394a66d","updated":"2023-03-13 13:49:34.000000000","message":"A very useful improvement, thanks Dawud!","commit_id":"6997a9de986aa3f8728d02c25665eaec62b5e1ae"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c1ef76de50f0e8795d5fe2cea1709e99060999f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c590b0d8_a09e0fc5","updated":"2023-03-10 10:41:43.000000000","message":"CI Passed, Please let me know what you think :) ","commit_id":"6997a9de986aa3f8728d02c25665eaec62b5e1ae"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"7aea8cef79cb60baa6fbda4956f0c72a8012d59a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b92e070f_f3d60057","updated":"2023-03-14 08:21:14.000000000","message":"Renos still don\u0027t mention dropped metrics.\n\nThis is backwards incompatible change ","commit_id":"6997a9de986aa3f8728d02c25665eaec62b5e1ae"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"efc465335bd782795426243bd30b55688b6f40f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5776e792_aa2f6481","in_reply_to":"b92e070f_f3d60057","updated":"2023-04-06 15:56:10.000000000","message":"Resolved","commit_id":"6997a9de986aa3f8728d02c25665eaec62b5e1ae"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ff63fe1585d5834090530e01ae2a158658630eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"33da78eb_c3d30f25","updated":"2023-05-15 08:18:01.000000000","message":"Please check the failed linter and release note jobs.","commit_id":"36d1952723e299b4243219d0d1ea7191aa22bdaa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"5e16c9a8c3c35b6ba09ab5a94f6b535c43568ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e998ec0f_05c51138","updated":"2023-05-12 17:37:56.000000000","message":"Resolved","commit_id":"36d1952723e299b4243219d0d1ea7191aa22bdaa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"8186524c6051e7063b4e87ea562dffaebb4c766d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b1ec21c6_ae82201f","updated":"2023-05-17 12:47:07.000000000","message":"docs are finally updated and render properly. Please could this be approved again :) Thank you!","commit_id":"7339d1edc9f0d29be8007f2663bb49d1169563da"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c2ce8684af49db399ff48259b2e2128fc372f8ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4e9e0f9c_0604c695","updated":"2023-05-17 14:08:10.000000000","message":"Thank you @sven. This has now been done","commit_id":"6da42fc14d2d5bf0121b9892f3d6cc6ae3806580"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"cc479ea6f270994a0db25a5bccb7cf9b9db8564c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"10655f15_3f634d73","updated":"2023-06-19 10:55:04.000000000","message":"Docs updated","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0a3e3b5780fde9fd238a465daab870fa3d8a33ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"72ec60d1_f61ea3b2","updated":"2023-06-07 12:34:51.000000000","message":"Thanks for updating Dawud - I think this is fine.","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"c687b8c9591de3d0fbd847236099a345527cdcb9","unresolved":true,"context_lines":[{"line_number":497,"context_line":"# Prometheus blackbox-exporter ports"},{"line_number":498,"context_line":"prometheus_blackbox_exporter_port: \"9115\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"# Prometheus instance label to use for alerting"},{"line_number":501,"context_line":"prometheus_instance_label: \"{{ ansible_facts.hostname }}\""},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"proxysql_admin_port: \"6032\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff41fa54_f1917d25","line":500,"updated":"2023-04-13 14:35:29.000000000","message":"nit: metrics","commit_id":"40dc39b22ec5cff652a36ef10f1a20c3abcd2ed5"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"8e51e0e5137d7821e1b8f81c769c1f31a5b56483","unresolved":false,"context_lines":[{"line_number":497,"context_line":"# Prometheus blackbox-exporter ports"},{"line_number":498,"context_line":"prometheus_blackbox_exporter_port: \"9115\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"# Prometheus instance label to use for alerting"},{"line_number":501,"context_line":"prometheus_instance_label: \"{{ ansible_facts.hostname }}\""},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"proxysql_admin_port: \"6032\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1b4871bc_3e0e2942","line":500,"in_reply_to":"ff41fa54_f1917d25","updated":"2023-04-24 17:49:01.000000000","message":"Done","commit_id":"40dc39b22ec5cff652a36ef10f1a20c3abcd2ed5"}],"ansible/roles/prometheus/templates/prometheus.yml.j2":[{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"ed0175aa6cbb796bf3e976f97982934afadc5ae7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  - job_name: prometheus"},{"line_number":21,"context_line":"    static_configs:"},{"line_number":22,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":23,"context_line":"      - targets:"},{"line_number":24,"context_line":"        - \u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_port }}\u0027"},{"line_number":25,"context_line":"        labels:"},{"line_number":26,"context_line":"          instance: \"{{ hostvars[host].ansible_facts.hostname }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d4353740_6ff7a33d","line":23,"updated":"2023-03-06 09:31:41.000000000","message":"I didn\u0027t realise scrape config allows a list of `target` statements which is actually nice.","commit_id":"bc875201876f3ebeaac508537acc1ab1a525a1e0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b146de43d8430afc4c4a10aa43d61013cdcc181a","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":23,"context_line":"      - targets:"},{"line_number":24,"context_line":"        - \u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_port }}\u0027"},{"line_number":25,"context_line":"{% if hostvars[host].prometheus_instance_label | default(false, true) %}"},{"line_number":26,"context_line":"        labels:"},{"line_number":27,"context_line":"          instance: \"{{ hostvars[host].prometheus_instance_label }}\""},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"b242db00_68f3e0b4","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":72},"updated":"2023-04-17 13:13:18.000000000","message":"Given that there is a default in group_vars/all, I\u0027m wondering when this would be false. You\u0027d need to explicitly override prometheus_instance_label to be empty/false/None, right?","commit_id":"40dc39b22ec5cff652a36ef10f1a20c3abcd2ed5"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9e7f797e912971dfd60e40ed1b004ec10937a084","unresolved":true,"context_lines":[{"line_number":22,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":23,"context_line":"      - targets:"},{"line_number":24,"context_line":"        - \u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_port }}\u0027"},{"line_number":25,"context_line":"{% if hostvars[host].prometheus_instance_label | default(false, true) %}"},{"line_number":26,"context_line":"        labels:"},{"line_number":27,"context_line":"          instance: \"{{ hostvars[host].prometheus_instance_label }}\""},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"f27804d4_f6761a0f","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":72},"in_reply_to":"b242db00_68f3e0b4","updated":"2023-04-17 13:18:37.000000000","message":"Please see the upgrade note.","commit_id":"40dc39b22ec5cff652a36ef10f1a20c3abcd2ed5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eec79f27ef2fb7b22b4ac5c8ca4bb707486d0aa8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{% for host in groups[\u0027prometheus\u0027] %}"},{"line_number":23,"context_line":"      - targets:"},{"line_number":24,"context_line":"        - \u0027{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_port }}\u0027"},{"line_number":25,"context_line":"{% if hostvars[host].prometheus_instance_label | default(false, true) %}"},{"line_number":26,"context_line":"        labels:"},{"line_number":27,"context_line":"          instance: \"{{ hostvars[host].prometheus_instance_label }}\""},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"55f0af8b_71e93551","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":72},"in_reply_to":"f27804d4_f6761a0f","updated":"2023-04-17 13:19:44.000000000","message":"gotcha","commit_id":"40dc39b22ec5cff652a36ef10f1a20c3abcd2ed5"}],"releasenotes/notes/friendly-hostnames-1bb1254b2b434a11.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"30619a2350990da143b2e9aa0cce2ba616bd8096","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    the target address which means that there is no issue of the hostname"},{"line_number":7,"context_line":"    being unresolvable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Labelling with hostnames is enabled by default but the behaviour can be"},{"line_number":10,"context_line":"    changed by setting the ``prometheus_instance_label`` variable to either:"},{"line_number":11,"context_line":"    - None: Instance labels will be IP addresses"},{"line_number":12,"context_line":"    - {{ ansible_facts.hostname }}: Instance labels will be hostnames (default)"},{"line_number":13,"context_line":"    - {{ ansible_facts.nodename }}: Instance labels will be FQDNs"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Using this change by default will result in duplicate metrics for a short"},{"line_number":16,"context_line":"    time whilst prometheus scrapes metrics with the new names. Be sure to set"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4b7b98f9_88218b9d","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":65},"updated":"2023-04-25 07:02:46.000000000","message":"The list doesn\u0027t render correctly, please fix. I would also wrap {{ ... }} in double backticks.","commit_id":"ea93307c8b889432b7299784017380a5d2fe6f17"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"5e16c9a8c3c35b6ba09ab5a94f6b535c43568ea1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the target address which means that there is no issue of the hostname"},{"line_number":7,"context_line":"    being unresolvable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Labelling with hostnames is enabled by default but the behaviour can be"},{"line_number":10,"context_line":"    changed by setting the ``prometheus_instance_label`` variable to either:"},{"line_number":11,"context_line":"    - None: Instance labels will be IP addresses"},{"line_number":12,"context_line":"    - {{ ansible_facts.hostname }}: Instance labels will be hostnames (default)"},{"line_number":13,"context_line":"    - {{ ansible_facts.nodename }}: Instance labels will be FQDNs"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Using this change by default will result in duplicate metrics for a short"},{"line_number":16,"context_line":"    time whilst prometheus scrapes metrics with the new names. Be sure to set"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"393d836c_d3cb2e6e","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"4b7b98f9_88218b9d","updated":"2023-05-12 17:37:56.000000000","message":"Done","commit_id":"ea93307c8b889432b7299784017380a5d2fe6f17"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"30619a2350990da143b2e9aa0cce2ba616bd8096","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Using this change by default will result in duplicate metrics for a short"},{"line_number":16,"context_line":"    time whilst prometheus scrapes metrics with the new names. Be sure to set"},{"line_number":17,"context_line":"    the ``prometheus_instance_label`` variable to None if you do not want to"},{"line_number":18,"context_line":"    use this feature."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"349b60fb_18d645e7","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":54},"updated":"2023-04-25 07:02:46.000000000","message":"``None``","commit_id":"ea93307c8b889432b7299784017380a5d2fe6f17"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"5e16c9a8c3c35b6ba09ab5a94f6b535c43568ea1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Using this change by default will result in duplicate metrics for a short"},{"line_number":16,"context_line":"    time whilst prometheus scrapes metrics with the new names. Be sure to set"},{"line_number":17,"context_line":"    the ``prometheus_instance_label`` variable to None if you do not want to"},{"line_number":18,"context_line":"    use this feature."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"caab8ae2_6a37b1cb","line":17,"range":{"start_line":17,"start_character":50,"end_line":17,"end_character":54},"in_reply_to":"349b60fb_18d645e7","updated":"2023-05-12 17:37:56.000000000","message":"Done","commit_id":"ea93307c8b889432b7299784017380a5d2fe6f17"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f6da2235f084bbabb32a8fecda21610f6a45496","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Replaces the instance label on prometheus metrics with the inventory"},{"line_number":5,"context_line":"    hostname as opposed to the ip address. The ip address is still used as"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b6779846_4a5c3bef","line":2,"updated":"2023-05-18 08:49:35.000000000","message":"Now it\u0027s just a feature - no change on upgrade","commit_id":"4926c96daeb7818c824ed78a0146ecaafbde008e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"72d6d04ef4a1209c8f049b037bc63ebe890e5c4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Replaces the instance label on prometheus metrics with the inventory"},{"line_number":5,"context_line":"    hostname as opposed to the ip address. The ip address is still used as"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"2d187413_914df421","line":2,"in_reply_to":"b6779846_4a5c3bef","updated":"2023-06-07 09:50:31.000000000","message":"Done","commit_id":"4926c96daeb7818c824ed78a0146ecaafbde008e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f6da2235f084bbabb32a8fecda21610f6a45496","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Replaces the instance label on prometheus metrics with the inventory"},{"line_number":5,"context_line":"    hostname as opposed to the ip address. The ip address is still used as"},{"line_number":6,"context_line":"    the target address which means that there is no issue of the hostname"},{"line_number":7,"context_line":"    being unresolvable."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"abfb664e_465a273f","line":4,"updated":"2023-05-18 08:49:35.000000000","message":"This wording needs to be updated to match the new default.\n\n* How to enable the feature\n* When will the default change","commit_id":"4926c96daeb7818c824ed78a0146ecaafbde008e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"72d6d04ef4a1209c8f049b037bc63ebe890e5c4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Replaces the instance label on prometheus metrics with the inventory"},{"line_number":5,"context_line":"    hostname as opposed to the ip address. The ip address is still used as"},{"line_number":6,"context_line":"    the target address which means that there is no issue of the hostname"},{"line_number":7,"context_line":"    being unresolvable."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fa6f53c8_9ef8bcdf","line":4,"in_reply_to":"abfb664e_465a273f","updated":"2023-06-07 09:50:31.000000000","message":"Done","commit_id":"4926c96daeb7818c824ed78a0146ecaafbde008e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"229646ae6a5e29122a56dedbd4daf46bbf298459","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for the instance label on prometheus metrics to be"},{"line_number":5,"context_line":"    replaced with the inventory hostname as opposed to using the ip address as"},{"line_number":6,"context_line":"    the metric label. The ip address is still used as the target address which"},{"line_number":7,"context_line":"    means that there is no issue of the hostname being unresolvable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Labelling with hostnames is disabled by default but the behaviour can be"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d02624ae_ea54d8a0","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":14},"updated":"2023-06-13 11:10:19.000000000","message":"instance?","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"bac540dffadb62c6c3ebde3016816f64f8a67f95","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for the instance label on prometheus metrics to be"},{"line_number":5,"context_line":"    replaced with the inventory hostname as opposed to using the ip address as"},{"line_number":6,"context_line":"    the metric label. The ip address is still used as the target address which"},{"line_number":7,"context_line":"    means that there is no issue of the hostname being unresolvable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Labelling with hostnames is disabled by default but the behaviour can be"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"c33b0cce_48bc3304","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":14},"in_reply_to":"3701bb25_23e075cb","updated":"2023-06-15 10:20:37.000000000","message":"Done","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"b45ca29484de251cd289c6a3d66f49c924a86d6b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the ability for the instance label on prometheus metrics to be"},{"line_number":5,"context_line":"    replaced with the inventory hostname as opposed to using the ip address as"},{"line_number":6,"context_line":"    the metric label. The ip address is still used as the target address which"},{"line_number":7,"context_line":"    means that there is no issue of the hostname being unresolvable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Labelling with hostnames is disabled by default but the behaviour can be"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3701bb25_23e075cb","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":14},"in_reply_to":"d02624ae_ea54d8a0","updated":"2023-06-15 10:20:18.000000000","message":"Same difference","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbd78f887ee5f7e5f91dadeeaf445705a3333193","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"087100bd_f3c42db0","line":24,"range":{"start_line":10,"start_character":68,"end_line":24,"end_character":0},"updated":"2023-06-15 16:19:28.000000000","message":"Can we have that in service specific doc, not the reno (and point in the reno to those docs)?","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"1e27bb15d10ca96f395d10203ceb301e15840714","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"53861233_92469487","line":24,"range":{"start_line":10,"start_character":68,"end_line":24,"end_character":0},"in_reply_to":"087100bd_f3c42db0","updated":"2023-06-15 16:24:05.000000000","message":"Can you point me to an example of how do this and I will do\n\nAnd also instead of going back and forth about docs can we aim to get this feature merged please as its been quite a while that this is sitting on the back burner. :)","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"cc479ea6f270994a0db25a5bccb7cf9b9db8564c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a05a00df_3356096c","line":24,"range":{"start_line":10,"start_character":68,"end_line":24,"end_character":0},"in_reply_to":"501689bb_1e1d8de5","updated":"2023-06-19 10:55:04.000000000","message":"Done","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8dc6728493b2cffed7e907a7aac30018f3b0c730","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"501689bb_1e1d8de5","line":24,"range":{"start_line":10,"start_character":68,"end_line":24,"end_character":0},"in_reply_to":"53861233_92469487","updated":"2023-06-16 07:28:20.000000000","message":"see e.g. here: https://review.opendev.org/c/openstack/kolla-ansible/+/877413/17/releasenotes/notes/multiple-ceph-backends-913051631c6e69ee.yaml\n\nthe release notes link to the external ceph guide, which was changed to accommodate for the changed behaviour:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/877413/17/doc/source/reference/storage/external-ceph-guide.rst\n\nas a general remark: documentation is equally important as the code itself and I find it not convincing to merge code on the basis of how long ago it was written.\n\nEspecially since this is only a convenience feature, which can break production alerts if done wrong on a end user part. so documentation is especially important for such a feature imho.\n\nThanks and HTH","commit_id":"19a974fab9d54164fdbb93ae2ebc1ac90d339bfa"}]}