)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"2124e2e384a44764ac3f367eb962ee5e79fc6d8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e398e82f_56765d9c","updated":"2023-03-09 19:28:21.000000000","message":"Created https://bugs.launchpad.net/kolla-ansible/+bug/2009884 with more details on the issue we are seeing and the reason for this change","commit_id":"5baad502e71b1f9d48a89eabf6e21049075f543a"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"8f7b70a56403fd342df19c1c5128351e9ca9acb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c180a2cd_62e40121","in_reply_to":"c62a9b61_6d4c1f53","updated":"2023-03-09 20:52:19.000000000","message":"Done","commit_id":"5baad502e71b1f9d48a89eabf6e21049075f543a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"575df4ca107f9bcbd55aa54afda451b6e3beb532","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c62a9b61_6d4c1f53","in_reply_to":"e398e82f_56765d9c","updated":"2023-03-09 19:39:52.000000000","message":"Thank you! Please reference it in the commit message with:\n\nCloses-Bug: #2009884","commit_id":"5baad502e71b1f9d48a89eabf6e21049075f543a"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"d9c14efb7ed11c67cacbfbcd5cb7a346b4379209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7acee341_68f3b3df","updated":"2023-06-28 23:34:06.000000000","message":"Just wanted to check, is there anything extra needed from my side to get this reviewed? Thanks!","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"5b0501a93e358754950b4bd76fbf8001edf98e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bfbc9083_fdb1d7c3","in_reply_to":"3d225458_fc73f4a3","updated":"2023-09-26 14:08:58.000000000","message":"Thanks for linking this. I\u0027ve updated the patch to include a release note.","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"753c64e7b4c21c269aa1c822692d9e4aa0bfcd48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d225458_fc73f4a3","in_reply_to":"7acee341_68f3b3df","updated":"2023-07-17 20:25:13.000000000","message":"You could add a release note, see https://docs.openstack.org/kolla-ansible/latest/contributor/release-notes.html for details.","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1f6a2a0b694b27dcff1bb2d7bc8d83985df3259","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79da95b9_79546b80","updated":"2023-09-26 18:44:26.000000000","message":"I\u0027m still not convinced changing this is not destructive for running workloads - and we\u0027re missing handling for the old volume (remove it?)\nIt might be easier to set state_path to /var/lib/neutron/kolla if it does fix the issue - and it would be easily backportable.","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"a9072b1e9f905252a1e68beb2a865f1d7a2a4021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ef43da1c_82a8007e","in_reply_to":"73c9460a_e2962897","updated":"2023-11-15 10:34:19.000000000","message":"Hi Michal. Just wanted to bump this. Are you happy with the current setup or do you think it would be better to change the","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"e65788207097074adff4cfffefa23984429be07f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"73c9460a_e2962897","in_reply_to":"79da95b9_79546b80","updated":"2023-09-27 11:43:53.000000000","message":"Hi Michal. That makes sense. I\u0027ve updated the patchset to instead set the state_path to /var/lib/neutron/kolla. \n\nThis also means we can remove the custom value for metadata_proxy_socket in the Neutron configuration reference as now $state_path/metadata_proxy \u003d\u003d /var/lib/neutron/kolla/metadata_proxy.\n\nThe reason I didn\u0027t do this initially was because I thought it might make the volume name a bit confusing. As you\u0027ve mentioned in another comment, we should probably call this neutron_state or neutron_agent instead but I\u0027m not sure how to go about that.","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2c0a7bbf60cbb9165201ca392eda3131b900c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a7927fa_055459a9","in_reply_to":"ef43da1c_82a8007e","updated":"2023-11-15 11:00:18.000000000","message":"I think it should be fine now.","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d443573fcafb059fa8df6a8350003daa44541116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a4711ec_af38980d","updated":"2023-10-06 09:21:51.000000000","message":"LGTM, can we resolve the comment @mnasiadka?","commit_id":"25244517e162a02e73503c56f9f370f9a71a1f7d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"10f46b476827996464995234ed5a4bb3a3ad8762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a9c770fb_799c8100","updated":"2023-11-15 11:00:33.000000000","message":"recheck (let\u0027s get some fresh results)","commit_id":"25244517e162a02e73503c56f9f370f9a71a1f7d"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"bfb398818b056315d12668984e54dfa5a43ba085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"47f409a4_1e6c7af9","updated":"2023-09-28 09:38:03.000000000","message":"recheck kolla-ansible-debian-upgrade-aarch64 due to seemingly unrelated DB connection failure","commit_id":"25244517e162a02e73503c56f9f370f9a71a1f7d"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"905040e2813827cdcf9d53cf0870be008da14ae6","unresolved":true,"context_lines":[{"line_number":486,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":487,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":488,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":489,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":490,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":491,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":492,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":493,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e18c2749_a63f0a77","line":490,"range":{"start_line":489,"start_character":0,"end_line":490,"end_character":53},"updated":"2023-08-28 09:59:25.000000000","message":"why do we need both now?","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"5b0501a93e358754950b4bd76fbf8001edf98e08","unresolved":false,"context_lines":[{"line_number":486,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":487,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":488,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":489,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":490,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":491,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":492,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":493,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dcc5a9a5_eb7c5436","line":490,"range":{"start_line":489,"start_character":0,"end_line":490,"end_character":53},"in_reply_to":"29089128_0f87b11f","updated":"2023-09-26 14:08:58.000000000","message":"That makes sense. Doing this also avoids potential issues with nested mounts.\n\nI\u0027ve updated the patch to move the Neutron sockets into the new Neutron state volume.\n\nThe change also ensures that the state volume is shared among the metadata containers instead of the neutron_metadata_socket.","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e04dde0bc8bc04dddec50e70d28c5aa197dfcc7f","unresolved":true,"context_lines":[{"line_number":486,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":487,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":488,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":489,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":490,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":491,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":492,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":493,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f67e76b0_f187ba5f","line":490,"range":{"start_line":489,"start_character":0,"end_line":490,"end_character":53},"in_reply_to":"29089128_0f87b11f","updated":"2023-09-26 14:10:24.000000000","message":"why do we want to deviate from upstream defaults and not use `/var/lib/neutron/`?","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f7f4f513abb428327c6b174c987e57e9bbb63469","unresolved":true,"context_lines":[{"line_number":486,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":487,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":488,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":489,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":490,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":491,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":492,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":493,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"29089128_0f87b11f","line":490,"range":{"start_line":489,"start_character":0,"end_line":490,"end_character":53},"in_reply_to":"e18c2749_a63f0a77","updated":"2023-08-28 10:01:51.000000000","message":"I think it would be better to just set state_path in neutron.conf?","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"bcc828ea269c4b73f97cd9df6fc7e3c0c96be8e7","unresolved":false,"context_lines":[{"line_number":486,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":487,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":488,"context_line":"  - \"/lib/modules:/lib/modules:ro\""},{"line_number":489,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":490,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":491,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":492,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":493,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6677757d_4ef55c87","line":490,"range":{"start_line":489,"start_character":0,"end_line":490,"end_character":53},"in_reply_to":"f67e76b0_f187ba5f","updated":"2023-09-26 14:24:09.000000000","message":"Sorry if I\u0027ve missed something here but I think that the latest patchset does use the upstream defaults for all of the state related values now.\n\nBefore, we deviated from the upstream defaults not for the state_path value, but for the metadata_proxy_socket value. This was to allow the socket to be in a volume.\n\nNow that we are putting everything into the volume (metadata_proxy_socket and the rest of the Neutron state), this patch actually removes the previous change where we deviated from the upstream default.","commit_id":"759486a6f52edff0cfed46cb69302e8fbe8d1cb6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e1f6a2a0b694b27dcff1bb2d7bc8d83985df3259","unresolved":true,"context_lines":[{"line_number":506,"context_line":"  - \"{{ node_config_directory }}/neutron-dhcp-agent/:{{ container_config_directory }}/:ro\""},{"line_number":507,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":508,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":509,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":510,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":511,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":512,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a772af6a_238e614e","line":509,"range":{"start_line":509,"start_character":5,"end_line":509,"end_character":27},"updated":"2023-09-26 18:44:26.000000000","message":"we call it the same everywhere - if we want to use the same everywhere - why not call it neutron_agent ?","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"},{"author":{"_account_id":35825,"name":"Adam Oswick","email":"adam@adamoswick.co.uk","username":"adamoswick","status":"GoDaddy"},"change_message_id":"e65788207097074adff4cfffefa23984429be07f","unresolved":false,"context_lines":[{"line_number":506,"context_line":"  - \"{{ node_config_directory }}/neutron-dhcp-agent/:{{ container_config_directory }}/:ro\""},{"line_number":507,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":508,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":509,"context_line":"  - \"neutron_l3_agent_state:/var/lib/neutron/\""},{"line_number":510,"context_line":"  - \"/run/netns:/run/netns:shared\""},{"line_number":511,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":512,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0b556def_1f71acf1","line":509,"range":{"start_line":509,"start_character":5,"end_line":509,"end_character":27},"in_reply_to":"a772af6a_238e614e","updated":"2023-09-27 11:43:53.000000000","message":"Marking as resolved given the response to the other comment.","commit_id":"aafaae99c88d1bff3e2282bb4fc1845c0aeb4146"}]}