)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7262bb2b87a52f60712f3fb5d474e176cd60f78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"472e9b7a_ecc44af4","updated":"2023-03-27 10:31:41.000000000","message":"Thanks Matt, nice job! I haven\u0027t explored in detail yet, but it appears that we get some improved response time metrics.\n\nThe fact that the original exporter has been archived makes it an easy decision to remove it. People will need to update their dashboards / alerts accordingly, so there is some impact.","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e7e8793afd197c976a0d9a8709eb7dbc82f30b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4f6971ac_a77e0b20","updated":"2023-11-27 11:18:29.000000000","message":"Thanks for updating - some comments inline.","commit_id":"cd37374093b341a0e30cf7a73f759e3f84b0f891"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"066d3f1c_f0e116de","updated":"2024-01-03 13:14:47.000000000","message":"Thanks for updating. I tested it and found some issues we need to fix.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"90636f673207d66ae9d76d2941ea02d7ce703df5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ee362c12_12ae6708","updated":"2024-01-05 10:23:06.000000000","message":"Thanks Dawud, just a couple of nits.","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"57feacc79a3095b77e429e4f936aa3d39cdeeb87","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"487e41ae_62866fdc","updated":"2024-02-14 11:05:18.000000000","message":"It looks like prometheus upgrade jobs are failing with that change on prechecks: \n    \"msg\": \"Ansible inventory does not contain the expected group prometheus-haproxy-exporter for service prometheus-haproxy-exporter in prometheus.\"","commit_id":"140722f74e63015240a1d6add50bc4603de57856"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4b6864a1167ff1f2785583f609af890688ef1025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"74f1ba77_e1f12aee","updated":"2024-01-08 17:55:00.000000000","message":"nit: variable names in the docs more readable if quoted or bold in style\nanyway LGTM","commit_id":"140722f74e63015240a1d6add50bc4603de57856"}],"ansible/roles/loadbalancer/tasks/upgrade.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"90636f673207d66ae9d76d2941ea02d7ce703df5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f842e07c_714ea104","line":2,"updated":"2024-01-05 10:23:06.000000000","message":"nit: Please add a TODO note here stating that we should replace these two tasks with a task to check the port is free in `precheck.yml` in the following release.","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"08a91c99b58fe9231b4774f907baf3677d4bdef2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_container:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"eb4eb71e_2ec13f03","line":2,"in_reply_to":"f842e07c_714ea104","updated":"2024-01-05 10:38:14.000000000","message":"Done","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"}],"ansible/roles/loadbalancer/templates/haproxy/haproxy_main.cfg.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7262bb2b87a52f60712f3fb5d474e176cd60f78f","unresolved":true,"context_lines":[{"line_number":39,"context_line":"   bind {{ api_interface_address }}:{{ haproxy_stats_port }}"},{"line_number":40,"context_line":"   mode http"},{"line_number":41,"context_line":"   stats enable"},{"line_number":42,"context_line":"   {% if enable_prometheus_haproxy_exporter | bool %}"},{"line_number":43,"context_line":"   option http-use-htx"},{"line_number":44,"context_line":"   http-request use-service prometheus-exporter if { path /metrics }"},{"line_number":45,"context_line":"   {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"685d33bf_a8010e38","line":42,"updated":"2023-03-27 10:31:41.000000000","message":"Given that we are removing the standalone exporter, is it possible to bind this to `prometheus_haproxy_exporter_port`?\n\nNo big deal if not. It would just make it easier for people who may have customised `prometheus_haproxy_exporter_port`, or are scraping it from outside KA (if there are any).","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"ddc10a9f69da363a82298d0cb19867171be83a51","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   bind {{ api_interface_address }}:{{ haproxy_stats_port }}"},{"line_number":40,"context_line":"   mode http"},{"line_number":41,"context_line":"   stats enable"},{"line_number":42,"context_line":"   {% if enable_prometheus_haproxy_exporter | bool %}"},{"line_number":43,"context_line":"   option http-use-htx"},{"line_number":44,"context_line":"   http-request use-service prometheus-exporter if { path /metrics }"},{"line_number":45,"context_line":"   {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"797d687f_2feb1b46","line":42,"in_reply_to":"685d33bf_a8010e38","updated":"2023-11-20 16:24:40.000000000","message":"Done","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e7e8793afd197c976a0d9a8709eb7dbc82f30b57","unresolved":true,"context_lines":[{"line_number":45,"context_line":"{% if enable_prometheus_haproxy_exporter | bool %}"},{"line_number":46,"context_line":"listen metrics"},{"line_number":47,"context_line":"   bind {{ api_interface_address }}:{{ prometheus_haproxy_exporter_port }}"},{"line_number":48,"context_line":"   mode http"},{"line_number":49,"context_line":"   http-request use-service prometheus-exporter if { path /metrics }"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7d74913c_35b4cfc5","line":48,"updated":"2023-11-27 11:18:29.000000000","message":"In the documentation, there is a note [1]:\n\n```\nYou must enable the new native HTTP representation (HTX) mode by adding option http-use-htx. Then, the http-request use-service line intercepts any requests for /metrics and directs them to the exporter. \n```\n\nWe don\u0027t have that option set, and we haven\u0027t got a combined section, shared with `stats`, as in the example in the documentation. I think we need to choose one or the other. \n\n[1] https://www.haproxy.com/blog/haproxy-exposes-a-prometheus-metrics-endpoint#configuring-haproxy","commit_id":"cd37374093b341a0e30cf7a73f759e3f84b0f891"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"ff462b0843059a572958f92983a5c9ecf1bfaa2d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"{% if enable_prometheus_haproxy_exporter | bool %}"},{"line_number":46,"context_line":"listen metrics"},{"line_number":47,"context_line":"   bind {{ api_interface_address }}:{{ prometheus_haproxy_exporter_port }}"},{"line_number":48,"context_line":"   mode http"},{"line_number":49,"context_line":"   http-request use-service prometheus-exporter if { path /metrics }"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"bed7e2a3_6a4b8601","line":48,"in_reply_to":"7d74913c_35b4cfc5","updated":"2023-11-27 11:34:11.000000000","message":"http-use-htx has been deprecated in the latest version of HAproxy. CI was failing with that option enabled. https://discourse.haproxy.org/t/docker-image-of-haproxy-latest-seems-doesnt-like-http-use-htx/7261/2\n\nIf we want to continue to use the prometheus-haproxy-exporter-port port then we need to open that port in the config and configure that to serve the /metrics end point. I don\u0027t think it\u0027s necessary to serve stats twice (unless I\u0027m missing something?). I\u0027ve tested that the patch is working as is.","commit_id":"cd37374093b341a0e30cf7a73f759e3f84b0f891"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d5234ad797cbd80a74c3a12293285bfdae24f9f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"{% if enable_prometheus_haproxy_exporter | bool %}"},{"line_number":46,"context_line":"listen metrics"},{"line_number":47,"context_line":"   bind {{ api_interface_address }}:{{ prometheus_haproxy_exporter_port }}"},{"line_number":48,"context_line":"   mode http"},{"line_number":49,"context_line":"   http-request use-service prometheus-exporter if { path /metrics }"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"cd895188_9ac0a37c","line":48,"in_reply_to":"bed7e2a3_6a4b8601","updated":"2023-11-27 12:53:07.000000000","message":"Thanks Dawud - good points. I agree with you that it\u0027s fine as-is.\n\nhttps://docs.haproxy.org/dev/configuration.html#http-request%20use-service","commit_id":"cd37374093b341a0e30cf7a73f759e3f84b0f891"}],"ansible/roles/prometheus/tasks/cleanup.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26ad1629d5501e3ae7bb412f9168896e248915ec","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  when:"},{"line_number":8,"context_line":"    - inventory_hostname in groups[loadbalancer]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Removing config for any disabled services"},{"line_number":11,"context_line":"  file:"},{"line_number":12,"context_line":"    path: \"{{ node_config_directory }}/prometheus-haproxy-exporter\""},{"line_number":13,"context_line":"    state: \"absent\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2f52932f_9ace4393","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":49},"updated":"2023-11-20 21:56:17.000000000","message":"haproxy exporter?","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"2ed8af9ede1729c620854fde984c10b8f7aeb51a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  when:"},{"line_number":8,"context_line":"    - inventory_hostname in groups[loadbalancer]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Removing config for any disabled services"},{"line_number":11,"context_line":"  file:"},{"line_number":12,"context_line":"    path: \"{{ node_config_directory }}/prometheus-haproxy-exporter\""},{"line_number":13,"context_line":"    state: \"absent\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f8e955a_1529dc5e","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":49},"in_reply_to":"2f52932f_9ace4393","updated":"2023-11-21 16:40:42.000000000","message":"Done","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"89c8e396_815ed22d","line":2,"updated":"2024-01-03 13:14:47.000000000","message":"We need to ensure that this cleanup happens /before/ the HAProxy service is reconfigured. Otherwise HAProxy will fail to start using the default port settings for HAProxy metrics. This is because the legacy exporter will be bound to the same port that the new metrics endpoint is trying to bind to when the HAProxy container is restarted.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"19ff417f_29db723c","line":2,"in_reply_to":"89c8e396_815ed22d","updated":"2024-01-03 16:44:36.000000000","message":"Moved this task to the upgrade section of the loadbalancer.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":6,"context_line":"    name: \"prometheus_haproxy_exporter\""},{"line_number":7,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"af2dae50_099f7273","line":4,"updated":"2024-01-03 13:14:47.000000000","message":"This is now `kolla_container:`","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Stop and remove containers for haproxy exporter containers"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":6,"context_line":"    name: \"prometheus_haproxy_exporter\""},{"line_number":7,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f40c10bd_e2590eb4","line":4,"in_reply_to":"af2dae50_099f7273","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":6,"context_line":"    name: \"prometheus_haproxy_exporter\""},{"line_number":7,"context_line":"  when:"},{"line_number":8,"context_line":"    - inventory_hostname in groups[loadbalancer]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Removing config for haproxy exporter"},{"line_number":11,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8a25458b_719c78db","line":8,"updated":"2024-01-03 13:14:47.000000000","message":"Missing quotes around loadbalancer","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    action: \"stop_and_remove_container\""},{"line_number":6,"context_line":"    name: \"prometheus_haproxy_exporter\""},{"line_number":7,"context_line":"  when:"},{"line_number":8,"context_line":"    - inventory_hostname in groups[loadbalancer]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Removing config for haproxy exporter"},{"line_number":11,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b9da34ed_89800bfe","line":8,"in_reply_to":"8a25458b_719c78db","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    state: \"absent\""},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - inventory_hostname in groups[loadbalancer]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a7743a9_47c11626","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":47},"updated":"2024-01-03 13:14:47.000000000","message":"Missing quotes around loadbalancer","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    state: \"absent\""},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - inventory_hostname in groups[loadbalancer]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"71fd2328_d90335dc","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":47},"in_reply_to":"9a7743a9_47c11626","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"}],"ansible/roles/prometheus/tasks/upgrade.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4e868dcd30e626fad8536a5f915c21a20e391369","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- import_tasks: cleanup.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- import_tasks: check-containers.yml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cd21234e_10b0c5a9","line":4,"updated":"2024-01-05 10:25:39.000000000","message":"Please remove this","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"08a91c99b58fe9231b4774f907baf3677d4bdef2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- import_tasks: cleanup.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- import_tasks: check-containers.yml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1426e54e_8d270f20","line":4,"in_reply_to":"cd21234e_10b0c5a9","updated":"2024-01-05 10:38:14.000000000","message":"Done","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"}],"releasenotes/notes/haproxy-metrics-endpoint-d62c0f34e29a10b2.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"10ae5ec348738fee48c37e756831a225819ddf5b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    it\u0027s repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee1aaf94_2c7ab7d5","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"updated":"2023-03-13 09:31:40.000000000","message":"its","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"21bb6c025a41bbac1d6e90dffa685333505e8d14","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    it\u0027s repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f6ce8302_ac89502c","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"in_reply_to":"333b37f2_3ca141d3","updated":"2023-11-20 16:24:23.000000000","message":"Done","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":34212,"name":"Matt Anson","email":"matta@stackhpc.com","username":"m-anson","status":"StackHPC"},"change_message_id":"ac5fd67ae2dea09d3dca8506b8a9645a6490383f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    it\u0027s repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"333b37f2_3ca141d3","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"in_reply_to":"ee1aaf94_2c7ab7d5","updated":"2023-03-13 13:22:36.000000000","message":"I thought too hard about this one! Fixed.","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"10ae5ec348738fee48c37e756831a225819ddf5b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d6cb35f_653ac27e","line":7,"updated":"2023-03-13 09:31:40.000000000","message":"You could mention that prometheus_haproxy_exporter containers need to be cleaned up manually.","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":34212,"name":"Matt Anson","email":"matta@stackhpc.com","username":"m-anson","status":"StackHPC"},"change_message_id":"ac5fd67ae2dea09d3dca8506b8a9645a6490383f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb21bd8c_2710f21b","line":7,"in_reply_to":"7d6cb35f_653ac27e","updated":"2023-03-13 13:22:36.000000000","message":"Added","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"21bb6c025a41bbac1d6e90dffa685333505e8d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab029d67_80175be6","line":7,"in_reply_to":"fb21bd8c_2710f21b","updated":"2023-11-20 16:24:23.000000000","message":"Done","commit_id":"e5ad355bf027b8f9e0ef8615cafc6c2806b980ae"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7262bb2b87a52f60712f3fb5d474e176cd60f78f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"94329461_a1aca827","line":5,"updated":"2023-03-27 10:31:41.000000000","message":"Please could we add an upgrade note to inform operators that they need to update any alerts or dashboards using the old metrics?","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"5cdbbbcaabafac082122334f2ed455d6da916cca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"49d24733_0fd1fe2b","line":5,"in_reply_to":"5a40e929_8628c72e","updated":"2023-12-21 19:50:34.000000000","message":"Done","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"21bb6c025a41bbac1d6e90dffa685333505e8d14","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e7410a39_9cfc06ac","line":5,"in_reply_to":"94329461_a1aca827","updated":"2023-11-20 16:24:23.000000000","message":"Done","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e7e8793afd197c976a0d9a8709eb7dbc82f30b57","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a40e929_8628c72e","line":5,"in_reply_to":"e7410a39_9cfc06ac","updated":"2023-11-27 11:18:29.000000000","message":"Please create a separate note, using `upgrade:`","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b90d0012eee04463f4f4efafb96e77dd335a71f0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5ffe30b9_b3be391e","line":7,"updated":"2023-03-15 09:51:33.000000000","message":"It\u0027s a shame to force a manual operation onto every prometheus operator when they upgrade to Antelope. How about adding a cleanup task to ansible/roles/prometheus/upgrade.yml? Similar to https://opendev.org/openstack/kolla-ansible/blame/branch/stable/zed/ansible/roles/monasca/tasks/cleanup.yml, but it could be hard coded for the haproxy exporter.","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"21bb6c025a41bbac1d6e90dffa685333505e8d14","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as"},{"line_number":5,"context_line":"    its repository is now archived. Instead use the metrics endpoint"},{"line_number":6,"context_line":"    exposed by HAProxy directly. Remaining prometheus-haproxy-exporter"},{"line_number":7,"context_line":"    containers should be stopped and removed manually."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"86d01dbc_e457c1b5","line":7,"in_reply_to":"5ffe30b9_b3be391e","updated":"2023-11-20 16:24:23.000000000","message":"Done","commit_id":"2f0ec032932501ba614672d8c5922ec99d90035e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ad1d26345f661fe3562bef0b9466d0dc5155428","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port `prometheus_haproxy_exporter_port`. Remaining"},{"line_number":7,"context_line":"    prometheus-haproxy-exporter containers and config are automatically"},{"line_number":8,"context_line":"    removed. Note: In some cases alerts and dashboards may need to be updated"},{"line_number":9,"context_line":"    to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"efb96ed2_502f0b7e","line":6,"range":{"start_line":6,"start_character":35,"end_line":6,"end_character":67},"updated":"2023-11-20 16:21:33.000000000","message":"double ticks needed","commit_id":"b0d43fe8157f1ab559624c715c091acd7bc321e3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"21bb6c025a41bbac1d6e90dffa685333505e8d14","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port `prometheus_haproxy_exporter_port`. Remaining"},{"line_number":7,"context_line":"    prometheus-haproxy-exporter containers and config are automatically"},{"line_number":8,"context_line":"    removed. Note: In some cases alerts and dashboards may need to be updated"},{"line_number":9,"context_line":"    to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5d57e610_3597f566","line":6,"range":{"start_line":6,"start_character":35,"end_line":6,"end_character":67},"in_reply_to":"efb96ed2_502f0b7e","updated":"2023-11-20 16:24:23.000000000","message":"Done","commit_id":"b0d43fe8157f1ab559624c715c091acd7bc321e3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26ad1629d5501e3ae7bb412f9168896e248915ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8bbb853f_88bf6e5b","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":70},"updated":"2023-11-20 21:56:17.000000000","message":"``prometheus-haproxy-exporter``","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"6a9b7da32fc18282ab47660cebd76c901a0ec4f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2cfa8dee_4cd73746","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":70},"in_reply_to":"8bbb853f_88bf6e5b","updated":"2023-11-21 16:40:54.000000000","message":"Done","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26ad1629d5501e3ae7bb412f9168896e248915ec","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fdb935bb_f8f61fff","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"updated":"2023-11-20 21:56:17.000000000","message":"HAProxy","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"6a9b7da32fc18282ab47660cebd76c901a0ec4f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f4cf7cb_bf471749","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"in_reply_to":"fdb935bb_f8f61fff","updated":"2023-11-21 16:40:54.000000000","message":"Done","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26ad1629d5501e3ae7bb412f9168896e248915ec","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bb05d0d0_3c3ef03b","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":41},"updated":"2023-11-20 21:56:17.000000000","message":"``prometheus-haproxy-exporter``","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"6a9b7da32fc18282ab47660cebd76c901a0ec4f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Remove configuration and deployment of prometheus-haproxy-exporter as its"},{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"128662b3_fefdd235","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":41},"in_reply_to":"bb05d0d0_3c3ef03b","updated":"2023-11-21 16:40:54.000000000","message":"Done","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"26ad1629d5501e3ae7bb412f9168896e248915ec","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b7123593_ff50cd4e","line":9,"range":{"start_line":8,"start_character":27,"end_line":9,"end_character":41},"updated":"2023-11-20 21:56:17.000000000","message":"which cases?","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"6a9b7da32fc18282ab47660cebd76c901a0ec4f1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAproxy contaienr on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining prometheus-haproxy-exporter containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4df3d6aa_b0802f3f","line":9,"range":{"start_line":8,"start_character":27,"end_line":9,"end_character":41},"in_reply_to":"b7123593_ff50cd4e","updated":"2023-11-21 16:40:54.000000000","message":"Done","commit_id":"b88a6883b66ee3b19e35b5df9b12c89f5b58d732"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of ``prometheus-haproxy-exporter`` as"},{"line_number":5,"context_line":"    its repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAProxy container on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining ``prometheus-haproxy-exporter`` containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics. Please refer to HAProxy documentation"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fcdd84fd_c9cc5267","line":6,"range":{"start_line":5,"start_character":35,"end_line":6,"end_character":33},"updated":"2024-01-03 13:14:47.000000000","message":"Instead we use the native support for Prometheus which is now built into HAProxy? We need to be very clear that the implementation has changed and it is not backwards compatible.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove configuration and deployment of ``prometheus-haproxy-exporter`` as"},{"line_number":5,"context_line":"    its repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAProxy container on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining ``prometheus-haproxy-exporter`` containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics. Please refer to HAProxy documentation"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"27fc288a_803fce98","line":6,"range":{"start_line":5,"start_character":35,"end_line":6,"end_character":33},"in_reply_to":"fcdd84fd_c9cc5267","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    its repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAProxy container on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining ``prometheus-haproxy-exporter`` containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics. Please refer to HAProxy documentation"},{"line_number":10,"context_line":"    to check if any metrics have changed."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"39d1a690_85c408dd","line":8,"updated":"2024-01-03 13:14:47.000000000","message":"We cover this in the upgrade section so we should remove it here to avoid duplication.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    its repository is now archived. Instead we expose a metrics endpoint on the"},{"line_number":6,"context_line":"    HAProxy container on the port ``prometheus_haproxy_exporter_port``."},{"line_number":7,"context_line":"    Remaining ``prometheus-haproxy-exporter`` containers and config are"},{"line_number":8,"context_line":"    automatically removed. Note: In some cases alerts and dashboards may need"},{"line_number":9,"context_line":"    to be updated to use the new metrics. Please refer to HAProxy documentation"},{"line_number":10,"context_line":"    to check if any metrics have changed."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"2e0c8f60_ea71bbb1","line":8,"in_reply_to":"39d1a690_85c408dd","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Due to the change from the ``prometheus-haproxy-exporter`` to using the"},{"line_number":15,"context_line":"    built in ``prometheus_haproxy_exporter_port`` metric names may have changed"},{"line_number":16,"context_line":"    and/or replaced/removed and in some cases alerts and dashboards may need to"},{"line_number":17,"context_line":"    be updated to use the new metrics. Please refer to HAProxy documentation to"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"10e13057_ad9261ff","line":14,"updated":"2024-01-03 13:14:47.000000000","message":"Similar to above - we need to emphasise that the new built in metrics endpoint is not backwards compatible.\n\nAll users /must/ review any configuration which references the old metrics, because they are now provided by a new implementation. Even when a metric with the same name is provided by the new implementation, the labels can be different. Eg. new:\n\n`haproxy_frontend_sessions_total{proxy\u003d\"nova_api_front\"} 2`\n\nvs old:\n\n`haproxy_frontend_sessions_total{frontend\u003d\"nova_api_front\"} 2`","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Due to the change from the ``prometheus-haproxy-exporter`` to using the"},{"line_number":15,"context_line":"    built in ``prometheus_haproxy_exporter_port`` metric names may have changed"},{"line_number":16,"context_line":"    and/or replaced/removed and in some cases alerts and dashboards may need to"},{"line_number":17,"context_line":"    be updated to use the new metrics. Please refer to HAProxy documentation to"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"95b61449_5a92956e","line":14,"in_reply_to":"10e13057_ad9261ff","updated":"2024-01-03 16:44:36.000000000","message":"Done","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ccdca4511f937d9b0f4e99f5cd2bdcfca9042f1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    built in ``prometheus_haproxy_exporter_port`` metric names may have changed"},{"line_number":16,"context_line":"    and/or replaced/removed and in some cases alerts and dashboards may need to"},{"line_number":17,"context_line":"    be updated to use the new metrics. Please refer to HAProxy documentation to"},{"line_number":18,"context_line":"    check if any metrics have changed."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"508bf1e7_767a507c","line":18,"updated":"2024-01-03 13:14:47.000000000","message":"I couldn\u0027t find a comparison of how the old metrics relate to the new implementation. Do you have a link?","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c16a732cfc4160e47ce3c70b7ce45732a43ee48c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    built in ``prometheus_haproxy_exporter_port`` metric names may have changed"},{"line_number":16,"context_line":"    and/or replaced/removed and in some cases alerts and dashboards may need to"},{"line_number":17,"context_line":"    be updated to use the new metrics. Please refer to HAProxy documentation to"},{"line_number":18,"context_line":"    check if any metrics have changed."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"75e2185f_caf13c07","line":18,"in_reply_to":"508bf1e7_767a507c","updated":"2024-01-03 16:44:36.000000000","message":"You\u0027re right I don\u0027t think there was a link. I have removed the mention of referring to docs.","commit_id":"62c096422db56080599757e46f48e0a983d92ef3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"90636f673207d66ae9d76d2941ea02d7ce703df5","unresolved":true,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Due to the change from using the ``prometheus-haproxy-exporter`` to using"},{"line_number":14,"context_line":"    the the native support for Prometheus which is now built into HAProxy,"},{"line_number":15,"context_line":"    metric names may have been replaced and/or removed, and in some cases the"},{"line_number":16,"context_line":"    metric names may have remained the same but the labels may have changed."},{"line_number":17,"context_line":"    Alerts and dashboards may also need to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4dd8c42a_3ee8bfe2","line":14,"updated":"2024-01-05 10:23:06.000000000","message":"nit: s/the the/the","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"08a91c99b58fe9231b4774f907baf3677d4bdef2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Due to the change from using the ``prometheus-haproxy-exporter`` to using"},{"line_number":14,"context_line":"    the the native support for Prometheus which is now built into HAProxy,"},{"line_number":15,"context_line":"    metric names may have been replaced and/or removed, and in some cases the"},{"line_number":16,"context_line":"    metric names may have remained the same but the labels may have changed."},{"line_number":17,"context_line":"    Alerts and dashboards may also need to be updated to use the new metrics."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"210a183d_754d6365","line":14,"in_reply_to":"4dd8c42a_3ee8bfe2","updated":"2024-01-05 10:38:14.000000000","message":"Done","commit_id":"d63a86132df7696ff416e62baa3766af78a24e21"}],"specs/prometheus.rst":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4b6864a1167ff1f2785583f609af890688ef1025","unresolved":true,"context_lines":[{"line_number":262,"context_line":"should control whether Prometheus is used at all.  Additionally, additional"},{"line_number":263,"context_line":"variables can be used to control individual exporters.  For example,"},{"line_number":264,"context_line":"enable_prometheus_haproxy_exporter could be used to enable/disable the HAProxy"},{"line_number":265,"context_line":"exporter to Prometheus.  By default Prometheus should be enabled and exporters"},{"line_number":266,"context_line":"should be enabled if both Prometheus and the associated service are enabled."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Limitations"}],"source_content_type":"text/x-rst","patch_set":12,"id":"b986fe07_cfec9203","line":265,"range":{"start_line":265,"start_character":47,"end_line":265,"end_character":53},"updated":"2024-01-08 17:55:00.000000000","message":"would?","commit_id":"140722f74e63015240a1d6add50bc4603de57856"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4b6864a1167ff1f2785583f609af890688ef1025","unresolved":true,"context_lines":[{"line_number":263,"context_line":"variables can be used to control individual exporters.  For example,"},{"line_number":264,"context_line":"enable_prometheus_haproxy_exporter could be used to enable/disable the HAProxy"},{"line_number":265,"context_line":"exporter to Prometheus.  By default Prometheus should be enabled and exporters"},{"line_number":266,"context_line":"should be enabled if both Prometheus and the associated service are enabled."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Limitations"},{"line_number":269,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"c471f417_87d5fc46","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":6},"updated":"2024-01-08 17:55:00.000000000","message":"would?","commit_id":"140722f74e63015240a1d6add50bc4603de57856"}]}