)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"84793122926a0c64574636fb04417422c4d295f3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since switching to use HAProxy to access Prometheus OpenStack exporter,"},{"line_number":10,"context_line":"scraping would fail when using internal TLS with an FQDN (rather than an"},{"line_number":11,"context_line":"IP address) to access the API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by using the FQDN instead of the VIP address."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"20966470_650a9c0a","line":11,"updated":"2023-11-09 11:17:44.000000000","message":"Isn\u0027t this saying the opposite? It should say:\n\n     scraping would fail when using internal TLS with an IP address (rather than the FQDN) to access the API.","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"04f76e175cc9172147c55775508269837200ce20","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since switching to use HAProxy to access Prometheus OpenStack exporter,"},{"line_number":10,"context_line":"scraping would fail when using internal TLS with an FQDN (rather than an"},{"line_number":11,"context_line":"IP address) to access the API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by using the FQDN instead of the VIP address."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c4bad93f_963e8a96","line":11,"in_reply_to":"20966470_650a9c0a","updated":"2023-11-14 11:44:46.000000000","message":"I think it depends on how you read it. I\u0027m trying to say that the OpenStack deployment is using internal TLS with an FQDN, but you are reading that prometheus is using the IP address.","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"e5c25d00c8371fc8e022ec2ba7e0b28d3435b01b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since switching to use HAProxy to access Prometheus OpenStack exporter,"},{"line_number":10,"context_line":"scraping would fail when using internal TLS with an FQDN (rather than an"},{"line_number":11,"context_line":"IP address) to access the API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by using the FQDN instead of the VIP address."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfa53f97_d86c64ef","line":11,"in_reply_to":"c4bad93f_963e8a96","updated":"2023-11-14 11:57:44.000000000","message":"Now I understand it. Thanks!","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"e5c25d00c8371fc8e022ec2ba7e0b28d3435b01b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fee28b3f_e6c43bc8","updated":"2023-11-14 11:57:44.000000000","message":"Thanks for the fix, we are using this patch as-is in our deployment. Would be good to have some comments from Maksim to get this merged.","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"980d86d949fa57836008c4b68f424932c46643ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c655e6eb_4f225d25","updated":"2023-11-09 11:14:52.000000000","message":"We hit this problem recently, and would be good to have this fixed upstream, here my suggestions to get this unblocked.","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"}],"ansible/roles/prometheus/templates/prometheus.yml.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e330c17e80671f92529ae6dec7541a90bdb4dbc8","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    honor_labels: true"},{"line_number":108,"context_line":"    static_configs:"},{"line_number":109,"context_line":"      - targets:"},{"line_number":110,"context_line":"        - \u0027{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\u0027"},{"line_number":111,"context_line":"{% endif %}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_prometheus_elasticsearch_exporter | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d00ad5d8_4e174148","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":33},"updated":"2023-08-26 20:36:17.000000000","message":"lets check for kolla_enable_tls_internal otherwise use kolla_internal_vip_address","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"04f76e175cc9172147c55775508269837200ce20","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    honor_labels: true"},{"line_number":108,"context_line":"    static_configs:"},{"line_number":109,"context_line":"      - targets:"},{"line_number":110,"context_line":"        - \u0027{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\u0027"},{"line_number":111,"context_line":"{% endif %}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_prometheus_elasticsearch_exporter | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"62718f21_6d3eac39","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":33},"in_reply_to":"2574013f_ec31170f","updated":"2023-11-14 11:44:46.000000000","message":"If you grep the codebase for fqdn or vip_address, generally we use the fqdn when referring to a remote address, and vip_address when referring to a local address.\n\nHere we\u0027re referring to a remote address.","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"980d86d949fa57836008c4b68f424932c46643ee","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    honor_labels: true"},{"line_number":108,"context_line":"    static_configs:"},{"line_number":109,"context_line":"      - targets:"},{"line_number":110,"context_line":"        - \u0027{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\u0027"},{"line_number":111,"context_line":"{% endif %}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_prometheus_elasticsearch_exporter | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ed711b66_09175bee","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":33},"in_reply_to":"d00ad5d8_4e174148","updated":"2023-11-09 11:14:52.000000000","message":"2 options here:\n\n- one liner:\n\n      {{ (kolla_internal_fqdn if kolla_enable_tls_internal else kolla_internal_vip_address) | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\n\n- verbose\n\n      {% if kolla_enable_tls_internal %}\n          {{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\n      {% else %}\n          {{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\n      {% endif %}","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"},{"author":{"_account_id":16363,"name":"Pedro Alvarez","email":"pedro.alvarez@softiron.com","username":"pedroalvarez"},"change_message_id":"dd65ab2ee818750acd8780d56c71b8bcd0387bca","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    honor_labels: true"},{"line_number":108,"context_line":"    static_configs:"},{"line_number":109,"context_line":"      - targets:"},{"line_number":110,"context_line":"        - \u0027{{ kolla_internal_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_openstack_exporter_port }}\u0027"},{"line_number":111,"context_line":"{% endif %}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_prometheus_elasticsearch_exporter | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2574013f_ec31170f","line":110,"range":{"start_line":110,"start_character":14,"end_line":110,"end_character":33},"in_reply_to":"ed711b66_09175bee","updated":"2023-11-09 11:40:26.000000000","message":"Thinking more about this, `kolla_internal_fqdn` should work for both cases (http and https), it even defaults to `kolla_internal_vip_address`. So no need to change this patch in my opinion","commit_id":"c2838823f1120cb571c1557b9c159d845d85f1a2"}]}