)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dfc426332cd05e2e708aeab902c2ee4fb8c219d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64983274_c12d837e","updated":"2023-03-23 09:56:32.000000000","message":"Does it mean that we don\u0027t update the pools from the file into the database anymore?","commit_id":"65ec728f5f4f4feed65f3f3353d7a6dae17bc2da"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"717a02574dd73eb4b5ab776046ea4dd0ba26f067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34751e04_1169e171","in_reply_to":"64983274_c12d837e","updated":"2023-03-23 10:19:38.000000000","message":"Nope, it just means we rely on the designate default file location that indeed is the one we hardcoded on kolla, however, by not calling for the --file it do fix an issue where designate-manage pool update --file \u003cpath\u003e command fail with a non zero return code.\n\nI can\u0027t exactly tell why but it seems there is an issue on designate-manage command as it fails any time we use the --file optional argument and succeed when not using it.\n\nTBN: Few people may well need a more impactfull designate-manage pool update --delete command to override this issue but I choose the safer path on this one as it doesn\u0027t introduce a new behavior that could lead to a loss of ZONES.","commit_id":"65ec728f5f4f4feed65f3f3353d7a6dae17bc2da"}],"ansible/roles/designate/tasks/update_pools.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e727b92756418f9ee92a993b5d79cc4795655da8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Non-destructive DNS pools update"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"{{ kolla_container_engine }} exec -t designate_worker designate-manage pool update\""},{"line_number":5,"context_line":"  run_once: True"},{"line_number":6,"context_line":"  delegate_to: \"{{ groups[\u0027designate-worker\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bc322cdf_be408d3a","line":4,"updated":"2023-08-24 08:32:16.000000000","message":"All that has changed here is you\u0027ve removed the --file argument which was passing in the default value. So as far as I can see this change has no effect.","commit_id":"65ec728f5f4f4feed65f3f3353d7a6dae17bc2da"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"89c3f4e45cb889ee7374398a0539485a5c5f5252","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Non-destructive DNS pools update"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: \"{{ kolla_container_engine }} exec -t designate_worker designate-manage pool update\""},{"line_number":5,"context_line":"  run_once: True"},{"line_number":6,"context_line":"  delegate_to: \"{{ groups[\u0027designate-worker\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd49033b_9a6848ac","line":4,"in_reply_to":"bc322cdf_be408d3a","updated":"2023-08-24 09:00:41.000000000","message":"Hi mark,\n\nYou’re right, this patch itself doesn’t have effect but is implicit default for designate that do not yet support multiple pools files.\n\nThis patch is made to goes with the designate patch rework as the pool file id will be generated then.","commit_id":"65ec728f5f4f4feed65f3f3353d7a6dae17bc2da"}]}