)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e5e403c31d0696f0ed5cb2e6940c465ed0bc525c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8b15729_c6c278ca","updated":"2023-03-23 09:52:50.000000000","message":"Needs docs update and analysis on user impact (especially we\u0027re removing some variables and introducing others) - so release note needs to be updated with user impact and recommendations.","commit_id":"74fd6b5e27fb42e6b45a732418c5ce59f31c404e"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"57e35a8f98b4652a64f0de3b5cd933c2f12aafdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65bb8347_89246ddb","in_reply_to":"99acd833_a6d6df7a","updated":"2023-03-24 12:16:30.000000000","message":"Done","commit_id":"74fd6b5e27fb42e6b45a732418c5ce59f31c404e"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"eb310503f264c8463d80cafe67e1ae7013bd8d98","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99acd833_a6d6df7a","in_reply_to":"e8b15729_c6c278ca","updated":"2023-03-23 09:58:39.000000000","message":"Neat! Will do, thanks.","commit_id":"74fd6b5e27fb42e6b45a732418c5ce59f31c404e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4412d56d86e9618f0b0542318343de61a79f8264","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"30251129_5cf5ea7e","updated":"2023-04-19 15:23:27.000000000","message":"I put additional comments here:\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2012537/comments/2\n\nmaybe this whole design warrants more discussion or even a blueprint, I don\u0027t know.\nIt changes significantly how dns_domains work in neutron.","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"03374ea2fa6c0371844a7cbcda0ce62415a46f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"451eb642_e6b9af37","in_reply_to":"30251129_5cf5ea7e","updated":"2023-04-19 16:04:57.000000000","message":"dns_domain doesn\u0027t change anything, it\u0027s not even used by normal kolla or openstack deployment as it provide a local DNS resolver that actually doesn\u0027t work with the current design.\n\nThis patch isn\u0027t disruptive for any existing production as I did tested it on our own large one production AND staging environment multiple plan.\n\nI won\u0027t have time to spend on a blueprint and endless discussion to fix a role that is broken with multiple bug reports existing.","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"464861b92d1d2ea5034af1770c1cf1c514dbafd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c90ad545_ec00c3f4","updated":"2023-08-01 10:48:12.000000000","message":"Can we merge this patch or is there something blocking it yet?\nI\u0027d like to backport it on xena/yoga/zed releases too.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"022cf9a1_d225ce82","updated":"2023-05-24 13:43:53.000000000","message":"Technical -2 to prevent this from merging so late in the cycle, otherwise -1.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"947a251db09d76622e478dea6fad88691be8f658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e677ddee_15bc8d1f","in_reply_to":"471e0963_ae5fd3fe","updated":"2023-08-01 22:25:37.000000000","message":"?? There is only one comment left unresolved and it\u0027s this one.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"72905602a08ed8314ee14b0e7f3126d9aa2a8393","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"471e0963_ae5fd3fe","in_reply_to":"c90ad545_ec00c3f4","updated":"2023-08-01 18:53:38.000000000","message":"you didn\u0027t address all the comments. replied \u0027Ack\u0027, but didn\u0027t fix.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d32a6d496de0041ada6c33442cd375d636a2b48b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"30524311_c98dd899","in_reply_to":"e677ddee_15bc8d1f","updated":"2023-08-02 07:19:02.000000000","message":"in the next patchset 15, you did after this question, you address them) thanks","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7118b699018fb52c9782afd78d58dc67f61b8fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"28e7b288_65b98411","updated":"2023-08-02 08:06:58.000000000","message":"ok perfect, I’ll fix the tox linter issue and then I think we’re good to go.","commit_id":"c5fe0b11484caa7ea921f9cffff967efa662637f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d8b1db4e_08f2e3b9","updated":"2023-08-07 08:07:43.000000000","message":"LGTM, besides some notes. sorry for the many comments, hope we can finish this soon :)","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"9c0d62d2dd4f5d310c8e6c9b0b4102069edc9ff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"53fed9b0_8b3a1510","updated":"2023-08-09 20:05:06.000000000","message":"Thanks a lot for all the reviewers!","commit_id":"f060e99091d9f337572c4ecda749921cd864b0fa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1a4979da5ccd9be1989a840fc4d6df973798a9cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"54d81399_34ad3f15","updated":"2023-08-10 07:12:27.000000000","message":"in the designated-guide.rs many wrong indentation blocks, weird, but rendered docs looks fine: https://3db17f90aec4c342ae1c-b38def2a49f1e94bd62e4be171bb57bc.ssl.cf1.rackcdn.com/878270/19/check/openstack-tox-docs/afbc7c9/docs/reference/networking/designate-guide.html","commit_id":"903853492f1d0a26295bf8408ecd5bbebafbeaa4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"09f2d077e259813c69307860885878ce7a60205f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7bff8c62_1b152619","updated":"2024-01-09 17:23:35.000000000","message":"@f","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"091a45a169c97a02c208bb69746b5fcb298e51a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7b998f91_da6d0056","updated":"2024-02-01 06:48:37.000000000","message":"Hi Fl1nt, I\u0027ve addressed this issue in https://review.opendev.org/q/topic:%22kolla-neutron-dns-integration%22 , can u please confirm that now it\u0027s implemented in correct way ? CI tests also added. If yes, please can u abandon this ? \n\nthanks 🙏","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9de24f60_8460f72b","updated":"2023-09-06 06:00:59.000000000","message":"I still argue that this patch is doing too many things at once and needs to be split. Some issues can simply be resolved by using \"{{ node_custom_config }}/designate/pools.yaml\" as an override. Also I do not see the need to change things in a backwards incompatible way.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2a38f51f67b40f672a2a9135007da44d781c8415","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"90003bff_f224d129","updated":"2023-11-10 21:35:00.000000000","message":"I will review this when I will have some time :)","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"9d2152cf9093914268042232eab026f8d481ad18","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b544ae42_f0ae7170","updated":"2023-09-01 00:04:58.000000000","message":"Is there still something blocking this patch to be merged?","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b8d1613701098950294976924bfc51e54454db51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"d0f50ad4_1238b927","updated":"2023-08-24 12:54:48.000000000","message":"recheck","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e2545741d899b925fd662d95dc13828e2d85001c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"c12949b9_d2937b2b","updated":"2023-08-26 17:30:22.000000000","message":"recheck debian issue should have been resolved","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"22fe41c56b596b0f5a45cc9909625db9aefd2996","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"932b9895_881cae73","in_reply_to":"00663717_177c9a05","updated":"2024-03-21 14:32:01.000000000","message":"Will do soon, sorry for the delay.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e188ce4e6c61f70efbbd0bef7f0ea4179f9e7e2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"00663717_177c9a05","in_reply_to":"09bc00b1_7da2ca99","updated":"2024-03-08 12:58:34.000000000","message":"Any news ?","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4c529c8fe937a3157f4b77b65cf4e86dd734e668","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"4db9b7f6_4a07c579","in_reply_to":"42dd82fb_f1ea94ff","updated":"2023-09-06 09:41:47.000000000","message":"I\u0027m not talking about the pools.yaml that kolla generates. you can override it with your own file without any templating.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"73d203b5e84ef343c9ee70e2b1cd988265eddc95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"adbcf2ba_f608a729","in_reply_to":"68200186_38905c12","updated":"2023-09-01 13:21:25.000000000","message":"just the reviews from people with +2 powers, I\u0027ll ping them via IRC. :)","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"491f8dc5b8b060cbf7a61ee8532659418c8cf697","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ffd176f7_9c50eaa0","in_reply_to":"7b998f91_da6d0056","updated":"2024-02-01 08:17:18.000000000","message":"Hi Michal, I just reviewed your neutron dns integration patch and yes it works as in this patchset, however, I can’t abandon this patchset as it contain more fix than just the neutron patch.\n\nIt also fix the pool management that was missing a properly managed UUID and the credentials used to set/delete FIP+Designate dns integration.\n\nI could probably however merge your patch on this one if it help or remove any changes that conflicts with yours?","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"09f2d077e259813c69307860885878ce7a60205f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"11e6674c_0b83405a","in_reply_to":"90003bff_f224d129","updated":"2024-01-09 17:23:35.000000000","message":"Hmm, I\u0027ve started to review this patch, am I correct if I say that there is no option to enable internal neutron dns resolving ? \n\n{% if enable_designate | bool %}\n{% if designate_ns_record is string %}\ndns_domain \u003d {{ designate_ns_record }}.\n{% endif %}\n\nBecause if dns_domain is not set it\u0027s openstacklocal by default and then dns features just not working , also extension is not allowed.\n\nI understand that it can be ovverriden in custom configs...\nBut does it mean that kolla don\u0027t have option to just enable internal neutron dns resolving ?","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"42dd82fb_f1ea94ff","in_reply_to":"9de24f60_8460f72b","updated":"2023-09-06 09:32:59.000000000","message":"Using the kolla current pools.yaml just doesn\u0027t work, it simply can\u0027t work like this as the current settings just doesn\u0027t fit upstream designate configuration requirements and when it work on few environment it\u0027s just a side effect of how designate work.\n\nThe current pools.yaml structure doesn\u0027t respect any designate requirements.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"43b1d33907ea01c04f4b31912195e2847953a6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"68200186_38905c12","in_reply_to":"b544ae42_f0ae7170","updated":"2023-09-01 00:06:13.000000000","message":"Done","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f0370162fc6ee6a98d6e39539fd38aecc729c8fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"09bc00b1_7da2ca99","in_reply_to":"db8c800d_a4d6d2ea","updated":"2024-02-01 10:54:27.000000000","message":"and if you can add some comment what remains and why ...","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"616217896537c97e0fd043f631823d0aa85069bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"db8c800d_a4d6d2ea","in_reply_to":"ffd176f7_9c50eaa0","updated":"2024-02-01 10:53:11.000000000","message":"Well, pool can be user defined but yeah ..you can rebase and I will check","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":998,"context_line":"# NOTE (Fl1nt): When using external, you can let the dns_domain name variable empty."},{"line_number":999,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1000,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1001,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1002,"context_line":"neutron_dns_domain: \"example.org\""},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"# Default DNS resolvers for virtual networks"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"59a8067d_9509cb9e","line":1001,"updated":"2023-05-24 13:43:53.000000000","message":"This doesn\u0027t make sense at all to me. Internal and external DNS integration in Neutron are two completely different things and non-exclusive.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":998,"context_line":"# NOTE (Fl1nt): When using external, you can let the dns_domain name variable empty."},{"line_number":999,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1000,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1001,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1002,"context_line":"neutron_dns_domain: \"example.org\""},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"# Default DNS resolvers for virtual networks"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7ed5208a_d8e1bd51","line":1001,"in_reply_to":"59a8067d_9509cb9e","updated":"2023-05-24 15:48:47.000000000","message":"You don’t get it yes, neutron itself can’t get both implemented at the same time.\n\nYou can get designate + neutron internal:\nIn this scenario, you can manage dns zone as a dns manager would do (godaddy style) but then you loose ability for nova/neutron resources to be automatically get resolution from your tenant managed zone and instead have a global nova/neutron resource name only usable from within your tenant and unique to the whole region.\n\nyou can get designate + neutron external:\nIn here you then acquire ability for your neutron + nova resources to leverage your tenant dns zones and floating reverse while style being able to gain DNSaaS service (godaddy style).\n\nyou can get no designate + neutron internal:\nThis one is the classical scenario where you don’t get DNSaaS feature but your nova/neutron get dns name resolution globally to the zone/region and is restricted to your tenant.\n\nand finally no designate + neutron None:\nIn here you just don’t get any specific dns name resolution, you can only leverage dns resolution from the vm dns that come from either the host, dnsmasq or a set of declarated dns server from the neutron network subnet setting.\n\nyou simply can’t get neutron dns integration to be designate and internal at the same time, it doesn’t mean you can’t get designate alone with neutron internal tho, hence why this variable only manage neutron side of things.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"64c5287dd3c8f9310a082d369cd7a4b417dbfaf6","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3e3d4651_4491bccb","side":"PARENT","line":1079,"updated":"2023-08-10 07:39:34.000000000","message":"This is not backwards compatible, users will need to change their configuration - can we make it more or less compatible and handle the old variable as well?","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9efae2fb2f98996babb21995f95ce5f46b35fd34","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"b7b616a0_459476ff","side":"PARENT","line":1079,"in_reply_to":"3e3d4651_4491bccb","updated":"2023-08-10 09:34:10.000000000","message":"OK, why to not modify reno with upgrade: so users will handle it during the upgrade ?","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"a679f7b60dea5acaecb18de0fe66ec631d328d08","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"f3d571a4_814bf0fa","side":"PARENT","line":1079,"in_reply_to":"654803a6_f1639f1c","updated":"2023-08-24 09:08:46.000000000","message":"Kolla constantly evolve from version to version or I wouldn’t have rant about then ansible-galaxy change last time.\n\nI can add a change warning on documentation but this variable change is more than cosmetic as it’s related to the native integration of designate pools and neutron/nova signaling.\n\ndesignate_ns_record is nonsense, it doesn’t have any relationship with the dns zone that your project will use later on as neutron will be able to use dns zone of your choice when linked to designate for network/FIP and subnets fqdn.","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cfbf590e79473d78c4c8846fe04744d0d5136ecd","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"a089c6ce_f7d0ba0a","side":"PARENT","line":1079,"in_reply_to":"893aa10b_44839812","updated":"2023-08-10 09:41:32.000000000","message":"No, historically this var was string and also list in same moment, string used in neutron conf and list in designate (below).\n\n{% if designate_ns_record is string %}\n    - hostname: {{ designate_ns_record }}.\n      priority: 1\n{% else %}\n{% for host in designate_ns_record %}\n    - hostname: {{ host }}.\n      priority: 1\n{% endfor %}\n\nSo, we delivered buggy code and users usually fixed by config overrides because kolla implementation is bad from the beginning.","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e864c0e8af18f44f3adaa22b56ade58c4eee21f8","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"654803a6_f1639f1c","side":"PARENT","line":1079,"in_reply_to":"a089c6ce_f7d0ba0a","updated":"2023-08-10 09:46:25.000000000","message":"That was added here: https://review.opendev.org/c/openstack/kolla-ansible/+/802304 - so not historically always.\nI agree it was probably bad from the beginning, but forcing users to change is not nice - upgrade is a hefty experience without it.\nWe could easily rework the default for designate_pools to include designate_ns_record and write a reno this is deprecated for removal in C.","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"269963394d0eb58d08f7fb8e7d53a254f9d48b3a","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"893aa10b_44839812","side":"PARENT","line":1079,"in_reply_to":"b7b616a0_459476ff","updated":"2023-08-10 09:38:04.000000000","message":"We usually encouraged users to use a new var (and deprecated it and marked for removal), but I don\u0027t think we ever enforced them to change it between releases.\nHistorically this var was a string, but we moved to a list (but still support string) - can\u0027t we do something similar here?","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c3fd742efb9ca481c2c0b177d63a5ba58a2a4ceb","unresolved":true,"context_lines":[{"line_number":1076,"context_line":"#######################"},{"line_number":1077,"context_line":"# Valid options are [ bind9, infoblox ]"},{"line_number":1078,"context_line":"designate_backend: \"bind9\""},{"line_number":1079,"context_line":"designate_ns_record:"},{"line_number":1080,"context_line":"  - \"ns1.example.org\""},{"line_number":1081,"context_line":"designate_backend_external: \"no\""},{"line_number":1082,"context_line":"designate_backend_external_bind9_nameservers: \"\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3a61bdd4_edb3fa4b","side":"PARENT","line":1079,"in_reply_to":"b7b616a0_459476ff","updated":"2023-08-10 09:37:25.000000000","message":"What I want to say that also remove ha-all from rabbit was not compatible and merged (when i was testing something i was very surprised :D ) .... I am ok with incompatibility - just add reno for upgrade. You can\u0027t be always backward compatible, moreover if variable was used for two different purposes...\n\nAnd maybe some prechecks that user migrated to new defined variables ?","commit_id":"acf9375edc8f21439db5b9ae4cce10a92a791bdc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"# NOTE (Fl1nt): This list can be either \u0027internal\u0027, \u0027external\u0027 or empty."},{"line_number":1108,"context_line":"neutron_dns_integration_type: \"internal\""},{"line_number":1109,"context_line":"# NOTE (Fl1nt): When using external, you can let the dns_domain name variable empty."},{"line_number":1110,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1111,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1112,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1113,"context_line":"neutron_dns_domain: \"example.org\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"4101f4f0_8ae4e208","line":1110,"updated":"2023-09-06 06:00:59.000000000","message":"Even if external DNS integration is enabled, neutron will still do the internal DNS resolution, too, so having this as an either/or variable is wrong.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"# NOTE (Fl1nt): This list can be either \u0027internal\u0027, \u0027external\u0027 or empty."},{"line_number":1108,"context_line":"neutron_dns_integration_type: \"internal\""},{"line_number":1109,"context_line":"# NOTE (Fl1nt): When using external, you can let the dns_domain name variable empty."},{"line_number":1110,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1111,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1112,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1113,"context_line":"neutron_dns_domain: \"example.org\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d5ea52c3_dc38a7dd","line":1110,"in_reply_to":"4101f4f0_8ae4e208","updated":"2023-09-06 09:32:59.000000000","message":"I can make the default scenario to be DNSaaS+Openstack integration+Neutron internal domain management, but this will confuse more people as they probably doesn\u0027t care for the internal domain resolver once they do activate neutron/nova integration for designate.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4c529c8fe937a3157f4b77b65cf4e86dd734e668","unresolved":true,"context_lines":[{"line_number":1107,"context_line":"# NOTE (Fl1nt): This list can be either \u0027internal\u0027, \u0027external\u0027 or empty."},{"line_number":1108,"context_line":"neutron_dns_integration_type: \"internal\""},{"line_number":1109,"context_line":"# NOTE (Fl1nt): When using external, you can let the dns_domain name variable empty."},{"line_number":1110,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1111,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1112,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1113,"context_line":"neutron_dns_domain: \"example.org\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"c0ba672c_fda602f2","line":1110,"in_reply_to":"d5ea52c3_dc38a7dd","updated":"2023-09-06 09:41:47.000000000","message":"that\u0027s certainly not the case in my deployment","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":1110,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1111,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1112,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1113,"context_line":"neutron_dns_domain: \"example.org\""},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":1116,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"2552ef29_1d62c930","line":1113,"updated":"2023-09-06 06:00:59.000000000","message":"Having example.org as default value is wrong, it needs to be an empty value unless the deployer overrides it.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"# as neutron will then rely on Designate to resolve DNS related requests."},{"line_number":1111,"context_line":"# NOTE (Fl1nt): When using internal, you need to set the dns_domain name."},{"line_number":1112,"context_line":"# this variable is then used by neutron to provide project scoped resolution."},{"line_number":1113,"context_line":"neutron_dns_domain: \"example.org\""},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":1116,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"0696c8ad_9a9e8693","line":1113,"in_reply_to":"2552ef29_1d62c930","updated":"2023-09-06 09:32:59.000000000","message":"It\u0027s the RFC compliant way to create sane default DNS related example and placeholder as for IANA recommendation, it is also how the official upstream openstack documentation usage.\n\nhttps://docs.openstack.org/neutron/latest/admin/config-dns-int.html\nhttps://www.iana.org/help/example-domains\nhttps://www.rfc-editor.org/rfc/rfc2606.html\nhttps://www.rfc-editor.org/rfc/rfc6761.html\n\nThe previous placeholder is not correct neither as it designate a fully qualified endpoint through: \"ns1.sample.openstack.org\" where this value should be a TLD.\n\nThis value can\u0027t be used as in the current available config as it do instruct neutron to use this FQDN as a designate_ns_record AND neutron dns_domain when enabling designate, it just doesn\u0027t work as:\n\n1°/- ns1.sample.openstack.org will be used by neutron as the domain name for VMs which isn\u0027t what you want as \u003cinstance_name\u003e.\u003cdomain\u003e.\u003ctld\u003e shouldn\u0027t be something like: example.ns1.sample.openstack.org this is non sense.\n\n2°/- dns_domain and designate TLD is completely two different things:\n\nThis variable is a sane default to replace the improper upper current value.\nAs kolla doesn\u0027t allow empty string default variable, it\u0027s a better choice as otherwise, someone will keep asking me why do we keep a neutron_dns_domain empty variable.\n\nAs a default, you can still override it on your globals.yml file.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"}],"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"67dd8739d7fb6562ddda043ae4d146c68a8a083f","unresolved":false,"context_lines":[{"line_number":323,"context_line":"## DNS NOTIFY packets to any additional servers."},{"line_number":324,"context_line":"designate_pools:"},{"line_number":325,"context_line":"  - name: \"default\""},{"line_number":326,"context_line":"    id: \"{{ designate_default_pool_id }}\""},{"line_number":327,"context_line":"    description: \"Default bind9 pool provided by kolla.\""},{"line_number":328,"context_line":"    scheduler_attributes:"},{"line_number":329,"context_line":"      - \"tier: standard\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d7eadda8_a74fcc74","line":326,"range":{"start_line":326,"start_character":12,"end_line":326,"end_character":37},"updated":"2023-04-19 18:44:20.000000000","message":"new and undefined variable","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"bebc1214084be28b3369746aa74c10c8209e14cc","unresolved":false,"context_lines":[{"line_number":323,"context_line":"## DNS NOTIFY packets to any additional servers."},{"line_number":324,"context_line":"designate_pools:"},{"line_number":325,"context_line":"  - name: \"default\""},{"line_number":326,"context_line":"    id: \"{{ designate_default_pool_id }}\""},{"line_number":327,"context_line":"    description: \"Default bind9 pool provided by kolla.\""},{"line_number":328,"context_line":"    scheduler_attributes:"},{"line_number":329,"context_line":"      - \"tier: standard\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7595d12b_c4c22ba0","line":326,"range":{"start_line":326,"start_character":12,"end_line":326,"end_character":37},"in_reply_to":"d7eadda8_a74fcc74","updated":"2023-05-17 13:10:08.000000000","message":"It\u0027s a rework of the old designate_pool_id as with the native multi-pool support we maintain the existing default designate pool id and let user ability to add new ones.\n\nThe variable comes from password.yml (Not my decisions, it\u0027s were the initial variable was set historically).","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":322,"context_line":"##"},{"line_number":323,"context_line":"## also_notifies variable us used by designate mDNS to send additional"},{"line_number":324,"context_line":"## DNS NOTIFY packets to any additional servers."},{"line_number":325,"context_line":"designate_pools:"},{"line_number":326,"context_line":"  - name: \"default\""},{"line_number":327,"context_line":"    id: \"{{ designate_default_pool_id }}\""},{"line_number":328,"context_line":"    description: \"Default bind9 pool provided by kolla.\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"e4440e2f_c5ebc4e4","line":325,"updated":"2023-09-06 06:00:59.000000000","message":"IMO this is not needed at all, you can use an override for more complicated environments.\n\nAlso having defaults pointing to example.org should not happen.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":322,"context_line":"##"},{"line_number":323,"context_line":"## also_notifies variable us used by designate mDNS to send additional"},{"line_number":324,"context_line":"## DNS NOTIFY packets to any additional servers."},{"line_number":325,"context_line":"designate_pools:"},{"line_number":326,"context_line":"  - name: \"default\""},{"line_number":327,"context_line":"    id: \"{{ designate_default_pool_id }}\""},{"line_number":328,"context_line":"    description: \"Default bind9 pool provided by kolla.\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"4570e867_c9624bbb","line":325,"in_reply_to":"e4440e2f_c5ebc4e4","updated":"2023-09-06 09:32:59.000000000","message":"This fix all listed bug about pools not being able to update/create properly as it create them according to expected designate structure:\n\nhttps://docs.openstack.org/designate/latest/admin/pools.html\n\nAdditionally, this make designate support for attributes and multiple pools management.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"{% if designate_backend_external is defined and designate_backend_external !\u003d \"no\" %}"},{"line_number":43,"context_line":"listen \u003d {{ \u0027dns\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":44,"context_line":"{% else %}"},{"line_number":45,"context_line":"listen \u003d {{ \u0027api\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"workers \u003d {{ designate_mdns_workers }}"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7b4f926b_7fc1c689","line":45,"updated":"2023-09-06 06:00:59.000000000","message":"I do not see the need for this, it should be a dedicated change if done at all, not related to the other changes.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4c529c8fe937a3157f4b77b65cf4e86dd734e668","unresolved":true,"context_lines":[{"line_number":42,"context_line":"{% if designate_backend_external is defined and designate_backend_external !\u003d \"no\" %}"},{"line_number":43,"context_line":"listen \u003d {{ \u0027dns\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":44,"context_line":"{% else %}"},{"line_number":45,"context_line":"listen \u003d {{ \u0027api\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"workers \u003d {{ designate_mdns_workers }}"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"107edcef_8383da4c","line":45,"in_reply_to":"40d617a4_9fd1bc45","updated":"2023-09-06 09:41:47.000000000","message":"mdns is not expected to be public, only reachable by the outward nameserver like bind or whatever you are using. this can be achieved in different ways depending on the deployment","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% if designate_backend_external is defined and designate_backend_external !\u003d \"no\" %}"},{"line_number":43,"context_line":"listen \u003d {{ \u0027dns\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":44,"context_line":"{% else %}"},{"line_number":45,"context_line":"listen \u003d {{ \u0027api\u0027 | kolla_address | put_address_in_context(\u0027url\u0027) }}:{{ designate_mdns_port }}"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"workers \u003d {{ designate_mdns_workers }}"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"40d617a4_9fd1bc45","line":45,"in_reply_to":"7b4f926b_7fc1c689","updated":"2023-09-06 09:32:59.000000000","message":"When setting up designate to use external DNS, you need mDNS to be publicly reachable, if you don\u0027t do that then designate can\u0027t update the remote master zone with appropriate AXFR request.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"}],"ansible/roles/designate/templates/pools.yaml.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# NOTE (Fl1nt): All notes and knowledge come from: "},{"line_number":3,"context_line":"# https://docs.openstack.org/designate/latest/admin/pools.html"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# designate-manage pool update work by matching value of the pool ID"},{"line_number":6,"context_line":"# it means we need to keep track on IDs OR use a destructive operation."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# also_notifies variable is used by designate mdns to send"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"b816ab72_6b4ef4d0","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":68},"updated":"2023-04-19 14:21:01.000000000","message":"typo, should probably read:\n`works by matching the value of the pool ID`","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE (Fl1nt): All notes and knowledge come from: "},{"line_number":3,"context_line":"# https://docs.openstack.org/designate/latest/admin/pools.html"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# designate-manage pool update work by matching value of the pool ID"},{"line_number":6,"context_line":"# it means we need to keep track on IDs OR use a destructive operation."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# also_notifies variable is used by designate mdns to send"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"75e6d8e3_6f998a87","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":68},"in_reply_to":"b816ab72_6b4ef4d0","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":17,"context_line":"{% for attribute in pool.scheduler_attributes %}"},{"line_number":18,"context_line":"    {{ attribute }}"},{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ad934203_871c6ac4","line":20,"range":{"start_line":20,"start_character":26,"end_line":20,"end_character":43},"updated":"2023-04-19 14:21:01.000000000","message":"designate is not restricted to a certain dns server implementation, this should probably read:\n`List of authoritative dns servers used at zone creation`","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% for attribute in pool.scheduler_attributes %}"},{"line_number":18,"context_line":"    {{ attribute }}"},{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7ae219bc_788d9dd5","line":20,"range":{"start_line":20,"start_character":26,"end_line":20,"end_character":43},"in_reply_to":"ad934203_871c6ac4","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"},{"line_number":24,"context_line":"  # publicly reachable."},{"line_number":25,"context_line":"  ns_records:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"65e17178_45b71825","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":10},"updated":"2023-04-19 14:21:01.000000000","message":"`towards`","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% endfor %}"},{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"},{"line_number":24,"context_line":"  # publicly reachable."},{"line_number":25,"context_line":"  ns_records:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"027ceed5_394ae26d","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":10},"in_reply_to":"65e17178_45b71825","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"},{"line_number":24,"context_line":"  # publicly reachable."},{"line_number":25,"context_line":"  ns_records:"},{"line_number":26,"context_line":"{% for ns_record in pool.ns_records %}"},{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"973232d0_78e12758","line":24,"range":{"start_line":23,"start_character":4,"end_line":24,"end_character":22},"updated":"2023-04-19 14:21:01.000000000","message":"that depends on the users and on the deployment scenario. you could also use auth. dns servers which are only reachable from a private network.","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used at zone creation."},{"line_number":21,"context_line":"  # When creating zones designate will create SOA and NS entries to point"},{"line_number":22,"context_line":"  # toward those nameservers."},{"line_number":23,"context_line":"  # For users to be able to contact zone DNS they need to be"},{"line_number":24,"context_line":"  # publicly reachable."},{"line_number":25,"context_line":"  ns_records:"},{"line_number":26,"context_line":"{% for ns_record in pool.ns_records %}"},{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"420eb8a6_33db2354","line":24,"range":{"start_line":23,"start_character":4,"end_line":24,"end_character":22},"in_reply_to":"973232d0_78e12758","updated":"2023-04-19 14:53:53.000000000","message":"I did used public terms as external, If you use kolla provided bind server you need it to be reachable by platform external network (Other DNS servers/DNS Cache servers or services).\n\nChanged the term to external.","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."},{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it do not directly "},{"line_number":33,"context_line":"  # write changes on nameservers."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"68b82d2c_de2e4a06","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":35},"updated":"2023-04-19 14:21:01.000000000","message":"see above, designate does not support only bind.","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."},{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it do not directly "},{"line_number":33,"context_line":"  # write changes on nameservers."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"587deb1f_25851bee","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":35},"in_reply_to":"68b82d2c_de2e4a06","updated":"2023-04-19 14:53:53.000000000","message":"I\u0027m on the Bind related specific loop in here, but changed it.","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it do not directly "},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"},{"line_number":35,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"75da2b88_7d8a6a5c","line":32,"range":{"start_line":31,"start_character":71,"end_line":32,"end_character":75},"updated":"2023-04-19 14:21:01.000000000","message":"`it doesn\u0027t directly`","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of Bind9 DNS Servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it do not directly "},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"},{"line_number":35,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1860d27d_d8b60bce","line":32,"range":{"start_line":31,"start_character":71,"end_line":32,"end_character":75},"in_reply_to":"75da2b88_7d8a6a5c","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  # changes on zone entries to be written, for scalability concerns"},{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."},{"line_number":51,"context_line":"  # mdns Servers always are kept private except with external deployuments"},{"line_number":52,"context_line":"  # where they need to be reachable by the external DNS servers for zones"},{"line_number":53,"context_line":"  # transfers requests."},{"line_number":54,"context_line":"  targets:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"52ee4008_8867d90c","line":51,"updated":"2023-04-19 14:21:01.000000000","message":"deployments","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  # changes on zone entries to be written, for scalability concerns"},{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."},{"line_number":51,"context_line":"  # mdns Servers always are kept private except with external deployuments"},{"line_number":52,"context_line":"  # where they need to be reachable by the external DNS servers for zones"},{"line_number":53,"context_line":"  # transfers requests."},{"line_number":54,"context_line":"  targets:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"4e3195c4_21e78065","line":51,"in_reply_to":"52ee4008_8867d90c","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7109c012ad035ac4094193fbaece2ca08c580660","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."},{"line_number":51,"context_line":"  # mdns Servers always are kept private except with external deployuments"},{"line_number":52,"context_line":"  # where they need to be reachable by the external DNS servers for zones"},{"line_number":53,"context_line":"  # transfers requests."},{"line_number":54,"context_line":"  targets:"},{"line_number":55,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ec8cca5f_369d7106","line":52,"updated":"2023-04-19 14:21:01.000000000","message":"zone","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e48d2604c8869ddca57930dc598177e2b8ed5bea","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."},{"line_number":51,"context_line":"  # mdns Servers always are kept private except with external deployuments"},{"line_number":52,"context_line":"  # where they need to be reachable by the external DNS servers for zones"},{"line_number":53,"context_line":"  # transfers requests."},{"line_number":54,"context_line":"  targets:"},{"line_number":55,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"397b234a_872894c1","line":52,"in_reply_to":"ec8cca5f_369d7106","updated":"2023-04-19 14:53:53.000000000","message":"Ack","commit_id":"0794eef859cb9b93d63de55d193b2da722724aae"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE (Fl1nt): All notes and knowledge come from: "},{"line_number":3,"context_line":"# https://docs.openstack.org/designate/latest/admin/pools.html"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# designate-manage pool update works by matching value of the pool ID"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"6c118504_c1b457bf","line":2,"updated":"2023-05-24 13:43:53.000000000","message":"trailing space","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE (Fl1nt): All notes and knowledge come from: "},{"line_number":3,"context_line":"# https://docs.openstack.org/designate/latest/admin/pools.html"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# designate-manage pool update works by matching value of the pool ID"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"8709b72a_7ad3f721","line":2,"in_reply_to":"6c118504_c1b457bf","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."},{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7ad91258_a01616ca","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":75},"updated":"2023-08-07 08:07:43.000000000","message":"validation of changes.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - hostname: {{ ns_record.hostname }}."},{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"b6f9f322_35bda15c","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":75},"in_reply_to":"7ad91258_a01616ca","updated":"2023-08-09 20:03:15.000000000","message":"Ok, replaced.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"40b83ea7_f4055dd3","line":31,"range":{"start_line":31,"start_character":71,"end_line":31,"end_character":75},"updated":"2023-08-07 08:07:43.000000000","message":"nit: looks","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      priority: {{ ns_record.priority }}"},{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"98c494ad_4ccf469e","line":31,"range":{"start_line":31,"start_character":71,"end_line":31,"end_character":75},"in_reply_to":"40b83ea7_f4055dd3","updated":"2023-08-09 20:03:15.000000000","message":"According to my UK Born colleague, you can\u0027t use looks in here as it designate (no pun intended) the fact that the tool look for something and do not think something is appealing, which indeed is validated by stackexchange too.\n\nhttps://ell.stackexchange.com/questions/131742/correct-usage-of-look-vs-looks-appearance-of-something#:~:text\u003dThere%20is%20no%20other%20way,correctly%2C%20you%20should%20use%20looks.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"},{"line_number":35,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"adfa11c9_0ac97db5","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":20},"updated":"2023-08-07 08:07:43.000000000","message":"the?","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endfor %}"},{"line_number":30,"context_line":"  # NOTE (Fl1nt): List of authoritative servers used for changes validation."},{"line_number":31,"context_line":"  # According to designate definition, a nameserver is where designate look"},{"line_number":32,"context_line":"  # to validate that changes (on zones) send to targets, it doesn\u0027t directly"},{"line_number":33,"context_line":"  # write changes on nameservers."},{"line_number":34,"context_line":"  nameservers:"},{"line_number":35,"context_line":"{% if designate_backend \u003d\u003d \u0027bind9\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9244b433_40c31462","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":20},"in_reply_to":"adfa11c9_0ac97db5","updated":"2023-08-09 20:03:15.000000000","message":"I have plurialize it to match the \"changes\" upper.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"{% endfor %}"},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":"  # NOTE (Fl1nt): List of mdns or real DNS Servers."},{"line_number":47,"context_line":"  # According to designate definition, a target server is where designate send"},{"line_number":48,"context_line":"  # changes on zone entries to be written, for scalability concerns"},{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"2b461ff9_e2be7228","line":47,"range":{"start_line":47,"start_character":74,"end_line":47,"end_character":78},"updated":"2023-08-07 08:07:43.000000000","message":"nit: sends","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% endfor %}"},{"line_number":45,"context_line":"{% endif %}"},{"line_number":46,"context_line":"  # NOTE (Fl1nt): List of mdns or real DNS Servers."},{"line_number":47,"context_line":"  # According to designate definition, a target server is where designate send"},{"line_number":48,"context_line":"  # changes on zone entries to be written, for scalability concerns"},{"line_number":49,"context_line":"  # usual designate deployments use it\u0027s mdns server as it can scale"},{"line_number":50,"context_line":"  # horizontally."}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"a2e010ef_9d1647b4","line":47,"range":{"start_line":47,"start_character":74,"end_line":47,"end_character":78},"in_reply_to":"2b461ff9_e2be7228","updated":"2023-08-09 20:03:15.000000000","message":"Same thing than with upper, using the subjonctive time in here.\n\nhttps://english.stackexchange.com/questions/186153/send-versus-sends-and-has-versus-have","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6bd227056ae04efba20f0c6f16c68f29f63d74ec","unresolved":true,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"2f17d647_a8be248c","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"updated":"2023-05-22 10:00:03.000000000","message":"I\u0027m not sure about this length check in combination with the defined check and our policies around them.\n\nI believe it is redundant to check if the variable is defined. if the variable is undefined the length check should afaik return false.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"88b4c08db44a6872ea6d4bf3e1cd98daf04648ba","unresolved":false,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"e27ad1f9_2ac6bed0","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"18f16cb0_c6278584","updated":"2023-05-22 16:48:21.000000000","message":"Sven, if variable is undefined the length wouldn\u0027t be evaluated.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"34178ec1a6742b290c62787fc0c83341415a9ca1","unresolved":true,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"d992c4db_12d493c2","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"2f17d647_a8be248c","updated":"2023-05-22 10:28:14.000000000","message":"this syntax is correct, what the policies you are talking about?","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"f7df8aea_995b00e2","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"8262ef66_b7afc9f2","updated":"2023-05-24 13:43:53.000000000","message":"Why should this depend on neutron_dns_integration_type? IMO that part of the condition should be dropped.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e7e524b4ef1715b806ad7e24a3d21a9043ad7f2f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"18f16cb0_c6278584","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"cf9e73c0_78cdbfd3","updated":"2023-05-22 13:03:41.000000000","message":"So, the idea here is that you can get a `dns_domain` either set or empty depending on the scenario.\n\nBut whatever the situation, you need to get a dns_domain defined but you don\u0027t always need neutron_dns_domain to be.\n\nWith that in mind you need to check both, that it actually exist as a variable key, but also that this variable isn\u0027t empty.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"631237a9532752deacd53fba50941467bd233aba","unresolved":true,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"cf9e73c0_78cdbfd3","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"d992c4db_12d493c2","updated":"2023-05-22 12:53:37.000000000","message":"as I said, but maybe I didn\u0027t express myself clearly: I know this syntax is correct. But afaik the length check already returns false if `neutron_dns_domain`\nis not defined.\n\nSo, strictly speaking, the check `neutron_dns_domain is defined` is redundant and can technically be removed.\n\nWe still might want to leave the check in, to make it explicit to the reader.\n\nI don\u0027t know how such cases are judged during code review, that was what I was referring to with \"policy\". Usually you have some code review guidelines what\u0027s in scope of a code review or what best practices look like for the project.\n\ncoding style guidelines, basically.\n\nthey might not be written down, but they sure exists.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"835e05d3a0a8fb9187708622b3164bbd8932d851","unresolved":false,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"8262ef66_b7afc9f2","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"e27ad1f9_2ac6bed0","updated":"2023-05-22 16:52:49.000000000","message":"exactly, and additionally that would mess up with scenario where you deploy designate but not use it for neutron integration or when you just doesn’t want to use dns resolving with neutron at all (externally managed resolving).","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":64,"context_line":"router_distributed \u003d True"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"755b7036_c9aec86c","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":115},"in_reply_to":"f7df8aea_995b00e2","updated":"2023-05-24 15:48:47.000000000","message":"you can’t I’ve extensively explain that upper.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""},{"line_number":71,"context_line":"{% endif %}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% if enable_designate | bool and neutron_dns_integration_type \u003d\u003d \"external\" %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fb21608c_a57e55f2","line":70,"updated":"2023-05-24 13:43:53.000000000","message":"Why is this needed? How is it different from not specifying this variable?","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""},{"line_number":71,"context_line":"{% endif %}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% if enable_designate | bool and neutron_dns_integration_type \u003d\u003d \"external\" %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"702dbe42_e05950c2","line":70,"in_reply_to":"fb21608c_a57e55f2","updated":"2023-05-24 15:48:47.000000000","message":"If you do not specify a null value then neutron fallback to internal default openstacklocal dns domain name which is not a good default value in 99% enterprise case.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":35010,"name":"Jack Hodgkiss","display_name":"jackhodgkiss","email":"jack@stackhpc.com","username":"jackhodgkiss"},"change_message_id":"468b41cbd73d040176c17af5b02ccd091c6af281","unresolved":true,"context_lines":[{"line_number":171,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":172,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":173,"context_line":"project_name \u003d service"},{"line_number":174,"context_line":"username \u003d {{ neutron_keystone_user }}"},{"line_number":175,"context_line":"password \u003d {{ neutron_keystone_password }}"},{"line_number":176,"context_line":"allow_reverse_dns_lookup \u003d True"},{"line_number":177,"context_line":"ipv4_ptr_zone_prefix_size \u003d 24"},{"line_number":178,"context_line":"ipv6_ptr_zone_prefix_size \u003d 116"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"6c86f242_b58dec16","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":42},"updated":"2023-08-02 09:35:49.000000000","message":"I would like to know the motivation behind the change from `designate` to `neutron` for username/password. Is this for better integration into neutron?","commit_id":"c5fe0b11484caa7ea921f9cffff967efa662637f"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"53431f4df31e98b80343f7193b8f15890aab304f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"project_domain_id \u003d {{ default_project_domain_id }}"},{"line_number":172,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":173,"context_line":"project_name \u003d service"},{"line_number":174,"context_line":"username \u003d {{ neutron_keystone_user }}"},{"line_number":175,"context_line":"password \u003d {{ neutron_keystone_password }}"},{"line_number":176,"context_line":"allow_reverse_dns_lookup \u003d True"},{"line_number":177,"context_line":"ipv4_ptr_zone_prefix_size \u003d 24"},{"line_number":178,"context_line":"ipv6_ptr_zone_prefix_size \u003d 116"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"8cd779c4_f09ff529","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":42},"in_reply_to":"6c86f242_b58dec16","updated":"2023-08-02 10:10:22.000000000","message":"Yes, this let designate able to create entry and reverse PTR for neutron related resources without having to use sink anymore.\n\nDesignate is now able to leverage neutron and nova APIs directly.","commit_id":"c5fe0b11484caa7ea921f9cffff967efa662637f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""},{"line_number":71,"context_line":"{% endif %}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% if enable_designate | bool and neutron_dns_integration_type \u003d\u003d \"external\" %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"47f84339_46d07785","line":70,"updated":"2023-09-06 06:00:59.000000000","message":"Even with external DNS integration enabled, internal DNS can still work if one sets this","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""},{"line_number":71,"context_line":"{% endif %}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% if enable_designate | bool and neutron_dns_integration_type \u003d\u003d \"external\" %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"83014bd1_bf6a1828","line":70,"in_reply_to":"47f84339_46d07785","updated":"2023-09-06 09:32:59.000000000","message":"Yes, the goal here is to use the sane default from openstack which is .openstacklocal.\n\nThere is literally three scenario there:\n\n1°/- You want designate as a DNSaaS, no openstack integration, neutron internal domain management.\n\n2°/- You want designate as a DNSaaS + openstack integration so each time you create a network and/or a nova instance you\u0027ll get it registered as a recordset and PTR on your network set zone.\n\n3°/- You want designate as a DNSaaS, no openstack integration, neutron default internal domain management.\n\nCurrently, as kolla do activate by default DNSaaS with full feature extensions on neutron, the first scenario isn\u0027t used by anyone and doesn\u0027t make sense as you can\u0027t redirect this internal resolver to your own external attached domain.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4c529c8fe937a3157f4b77b65cf4e86dd734e668","unresolved":true,"context_lines":[{"line_number":67,"context_line":"{% if neutron_dns_integration_type \u003d\u003d \"internal\" and neutron_dns_domain is defined and neutron_dns_domain|length %}"},{"line_number":68,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}."},{"line_number":69,"context_line":"{% else %}"},{"line_number":70,"context_line":"dns_domain \u003d \"\""},{"line_number":71,"context_line":"{% endif %}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"{% if enable_designate | bool and neutron_dns_integration_type \u003d\u003d \"external\" %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"39c6dfa7_c2a471e9","line":70,"in_reply_to":"83014bd1_bf6a1828","updated":"2023-09-06 09:41:47.000000000","message":"There is also 4) use both external and internal DNS integration in Neutron","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1fc75519fa99a04e97c5ea248520d1247e74890a","unresolved":true,"context_lines":[{"line_number":172,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":173,"context_line":"project_name \u003d service"},{"line_number":174,"context_line":"username \u003d {{ neutron_keystone_user }}"},{"line_number":175,"context_line":"password \u003d {{ neutron_keystone_password }}"},{"line_number":176,"context_line":"allow_reverse_dns_lookup \u003d True"},{"line_number":177,"context_line":"ipv4_ptr_zone_prefix_size \u003d 24"},{"line_number":178,"context_line":"ipv6_ptr_zone_prefix_size \u003d 116"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"c1d339c4_daeea76a","line":175,"updated":"2023-09-06 06:00:59.000000000","message":"completely unrelated change","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4c529c8fe937a3157f4b77b65cf4e86dd734e668","unresolved":true,"context_lines":[{"line_number":172,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":173,"context_line":"project_name \u003d service"},{"line_number":174,"context_line":"username \u003d {{ neutron_keystone_user }}"},{"line_number":175,"context_line":"password \u003d {{ neutron_keystone_password }}"},{"line_number":176,"context_line":"allow_reverse_dns_lookup \u003d True"},{"line_number":177,"context_line":"ipv4_ptr_zone_prefix_size \u003d 24"},{"line_number":178,"context_line":"ipv6_ptr_zone_prefix_size \u003d 116"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"30e51490_6d64cbbd","line":175,"in_reply_to":"488fbf09_2f6aaef9","updated":"2023-09-06 09:41:47.000000000","message":"Still this change can be done independent of any of the other changes in this patch","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"7c4b0840a65b73428ad5489a93a5007d5f1c7956","unresolved":false,"context_lines":[{"line_number":172,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":173,"context_line":"project_name \u003d service"},{"line_number":174,"context_line":"username \u003d {{ neutron_keystone_user }}"},{"line_number":175,"context_line":"password \u003d {{ neutron_keystone_password }}"},{"line_number":176,"context_line":"allow_reverse_dns_lookup \u003d True"},{"line_number":177,"context_line":"ipv4_ptr_zone_prefix_size \u003d 24"},{"line_number":178,"context_line":"ipv6_ptr_zone_prefix_size \u003d 116"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"488fbf09_2f6aaef9","line":175,"in_reply_to":"c1d339c4_daeea76a","updated":"2023-09-06 09:32:59.000000000","message":"Sorry to be rude there but I already explained WHY we NEED it to be changed there, when you want to enable neutron/nova complete and native integration without having to use sink and notifications topics, you need to get neutron to use its own credential to call the designate API natively.","commit_id":"ea150061a808f4be8648b39984bf5fdc068abb73"}],"doc/source/reference/networking/designate-guide.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. code-block:: yaml"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   enable_designate: \"yes\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"d9e96e9f_64974953","side":"PARENT","line":26,"updated":"2023-05-24 13:43:53.000000000","message":"keeping code blocks indented matching the start of the \"code-block\" statement would look better IMO","commit_id":"94a74f58c7891e41ca637c4e2a6450ca88cbfb56"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. code-block:: yaml"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"   enable_designate: \"yes\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"2af6a34e_80983679","side":"PARENT","line":26,"in_reply_to":"d9e96e9f_64974953","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"94a74f58c7891e41ca637c4e2a6450ca88cbfb56"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Backend configuration"},{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service support many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"167cd564_769012e1","line":39,"range":{"start_line":39,"start_character":28,"end_line":39,"end_character":35},"updated":"2023-05-24 13:43:53.000000000","message":"supports","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Backend configuration"},{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service support many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"0206a85c_91917ccf","line":39,"range":{"start_line":39,"start_character":28,"end_line":39,"end_character":35},"in_reply_to":"167cd564_769012e1","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service support many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"974d9d22_aa5bef8b","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":23},"updated":"2023-05-24 13:43:53.000000000","message":"\"supports\" or \"has support for\"","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service support many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"6fbfd106_7841c8c8","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":23},"in_reply_to":"974d9d22_aa5bef8b","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":86,"context_line":"Pools configuration"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Kolla-ansible support Designate multi-pool capability natively."},{"line_number":90,"context_line":"By default we create a kolla pool which use our own Bind9 image deployment"},{"line_number":91,"context_line":"as the default pool for the Designate central service."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9d43ef53_7b1c4981","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":21},"updated":"2023-05-24 13:43:53.000000000","message":"supports","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Pools configuration"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Kolla-ansible support Designate multi-pool capability natively."},{"line_number":90,"context_line":"By default we create a kolla pool which use our own Bind9 image deployment"},{"line_number":91,"context_line":"as the default pool for the Designate central service."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"655dc0eb_0fe1e5b3","line":89,"range":{"start_line":89,"start_character":14,"end_line":89,"end_character":21},"in_reply_to":"9d43ef53_7b1c4981","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":139,"context_line":"Designate miniDNS (mDNS) service is responsible to update the authoritative dns"},{"line_number":140,"context_line":"server with changes from ressources on tenants."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"miniDNS is specifically developped to let designate scale horizontally."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. important::"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"da0d88d6_b85874e2","line":142,"range":{"start_line":142,"start_character":24,"end_line":142,"end_character":34},"updated":"2023-05-24 13:43:53.000000000","message":"developed","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Designate miniDNS (mDNS) service is responsible to update the authoritative dns"},{"line_number":140,"context_line":"server with changes from ressources on tenants."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"miniDNS is specifically developped to let designate scale horizontally."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. important::"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"571086ea_32b88bd4","line":142,"range":{"start_line":142,"start_character":24,"end_line":142,"end_character":34},"in_reply_to":"da0d88d6_b85874e2","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":165,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Neutron and Nova integration is now automatically enabled by default."},{"line_number":168,"context_line":"Kolla-ansible now default to the `subnet-dns-publish-fixed-ip` neutron"},{"line_number":169,"context_line":"extension."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"With older version of designate and kolla-ansible you were required to use"}],"source_content_type":"text/x-rst","patch_set":13,"id":"bcb3eac4_2efc1f42","line":168,"range":{"start_line":168,"start_character":18,"end_line":168,"end_character":25},"updated":"2023-05-24 13:43:53.000000000","message":"defaults","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":165,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Neutron and Nova integration is now automatically enabled by default."},{"line_number":168,"context_line":"Kolla-ansible now default to the `subnet-dns-publish-fixed-ip` neutron"},{"line_number":169,"context_line":"extension."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"With older version of designate and kolla-ansible you were required to use"}],"source_content_type":"text/x-rst","patch_set":13,"id":"d2ae8932_095b1386","line":168,"range":{"start_line":168,"start_character":18,"end_line":168,"end_character":25},"in_reply_to":"bcb3eac4_2efc1f42","updated":"2023-05-24 15:48:47.000000000","message":"Ack","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Backend configuration"},{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service supports many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only has support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":17,"id":"0f546544_685e62f1","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":53},"updated":"2023-08-07 08:07:43.000000000","message":"nit: backends","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Backend configuration"},{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service supports many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only has support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":17,"id":"64634f89_07751b2a","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":53},"in_reply_to":"0f546544_685e62f1","updated":"2023-08-09 20:03:15.000000000","message":"Fixed","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service supports many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only has support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1006e65d_92cad465","line":40,"range":{"start_line":40,"start_character":24,"end_line":40,"end_character":63},"updated":"2023-08-07 08:07:43.000000000","message":"nit: for the ISC Bind 9 and Infoblox backend types.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"---------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Openstack Designate service supports many DNS backend however, kolla-ansible"},{"line_number":40,"context_line":"itself only has support for ISC Bind9 and Infoblox backend type."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. important::"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"c587f635_f972d0d9","line":40,"range":{"start_line":40,"start_character":24,"end_line":40,"end_character":63},"in_reply_to":"1006e65d_92cad465","updated":"2023-08-09 20:03:15.000000000","message":"Fixed","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  If you\u0027re willing to implement additional DNS Server backend feel free to"},{"line_number":45,"context_line":"  contribute to kolla-ansible."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ISC Bind9 backend"},{"line_number":48,"context_line":"^^^^^^^^^^^^^^^^^"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":17,"id":"cbcf2ea6_096d30a4","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":9},"updated":"2023-08-07 08:07:43.000000000","message":"nit: Bind 9","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  If you\u0027re willing to implement additional DNS Server backend feel free to"},{"line_number":45,"context_line":"  contribute to kolla-ansible."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ISC Bind9 backend"},{"line_number":48,"context_line":"^^^^^^^^^^^^^^^^^"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":17,"id":"0169f7ec_7f898fa3","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":9},"in_reply_to":"cbcf2ea6_096d30a4","updated":"2023-08-09 20:03:15.000000000","message":"Fixed","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. important::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  When using Infoblox as the Designate backend the MDNS node"},{"line_number":62,"context_line":"  requires the container to listen on port 53. As this is a privilaged"},{"line_number":63,"context_line":"  port you will need to build your designate-mdns container to run"},{"line_number":64,"context_line":"  as the user root rather than designate."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"bad4ac42_500e1637","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":40},"updated":"2023-08-07 08:07:43.000000000","message":"nit: privileged\n\nwe might want to add a security warning here like:\n\n\"When running a container in privileged mode, you\u0027re essentially disabling the security mechanisms provided by Docker and giving the container almost the same level of access to the host as applications running directly on the host system. This can lead to serious security issues.\"","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. important::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  When using Infoblox as the Designate backend the MDNS node"},{"line_number":62,"context_line":"  requires the container to listen on port 53. As this is a privilaged"},{"line_number":63,"context_line":"  port you will need to build your designate-mdns container to run"},{"line_number":64,"context_line":"  as the user root rather than designate."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"247d2b8f_e447988c","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":40},"in_reply_to":"bad4ac42_500e1637","updated":"2023-08-09 20:03:15.000000000","message":"Fixed, I\u0027ve used the generic approach as podman will soon land on master for container engines.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Kolla-ansible supports Designate multi-pool capability natively."},{"line_number":90,"context_line":"By default we create a kolla pool which use our own Bind9 image deployment"},{"line_number":91,"context_line":"as the default pool for the Designate central service."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"This pool is always used as the default pool for the Designate central service,"}],"source_content_type":"text/x-rst","patch_set":17,"id":"33b96c05_5e1689de","line":90,"range":{"start_line":90,"start_character":40,"end_line":90,"end_character":43},"updated":"2023-08-07 08:07:43.000000000","message":"nit: uses\n\"Bind 9\" not Bind9","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Kolla-ansible supports Designate multi-pool capability natively."},{"line_number":90,"context_line":"By default we create a kolla pool which use our own Bind9 image deployment"},{"line_number":91,"context_line":"as the default pool for the Designate central service."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"This pool is always used as the default pool for the Designate central service,"}],"source_content_type":"text/x-rst","patch_set":17,"id":"8fccac0f_4262b7d5","line":90,"range":{"start_line":90,"start_character":40,"end_line":90,"end_character":43},"in_reply_to":"33b96c05_5e1689de","updated":"2023-08-09 20:03:15.000000000","message":"Fixed","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  With such scenario, your external authoritative dns server need to access"},{"line_number":161,"context_line":"  miniDNS to retrieve updates of the openstack platform and made them"},{"line_number":162,"context_line":"  available to your company."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Neutron and Nova Integration"},{"line_number":165,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5cd56ed3_e0ebfb06","line":162,"range":{"start_line":162,"start_character":20,"end_line":162,"end_character":27},"updated":"2023-08-07 08:07:43.000000000","message":"s/company/organization/","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  With such scenario, your external authoritative dns server need to access"},{"line_number":161,"context_line":"  miniDNS to retrieve updates of the openstack platform and made them"},{"line_number":162,"context_line":"  available to your company."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Neutron and Nova Integration"},{"line_number":165,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"232d27bf_6cbdea2d","line":162,"range":{"start_line":162,"start_character":20,"end_line":162,"end_character":27},"in_reply_to":"5cd56ed3_e0ebfb06","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":169,"context_line":"extension."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"With older version of designate and kolla-ansible you were required to use"},{"line_number":172,"context_line":"designate-sink, however starting Wallaby release it\u0027s no longer required as"},{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"8017e0a4_8eb5847e","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":32},"updated":"2023-08-07 08:07:43.000000000","message":"starting with the","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"extension."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"With older version of designate and kolla-ansible you were required to use"},{"line_number":172,"context_line":"designate-sink, however starting Wallaby release it\u0027s no longer required as"},{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3ecc05e0_aa965ed9","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":32},"in_reply_to":"8017e0a4_8eb5847e","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"extension."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"With older version of designate and kolla-ansible you were required to use"},{"line_number":172,"context_line":"designate-sink, however starting Wallaby release it\u0027s no longer required as"},{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"aee283e5_233eef32","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":32},"in_reply_to":"8017e0a4_8eb5847e","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"If you need to use sink, feel free to use older neutron/nova or kolla-ansible"},{"line_number":177,"context_line":"release documentation."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"For further specific dns-integration implementation, feel free to refer to"}],"source_content_type":"text/x-rst","patch_set":17,"id":"e779e91e_3cfa0804","line":176,"range":{"start_line":176,"start_character":19,"end_line":176,"end_character":23},"updated":"2023-08-07 08:07:43.000000000","message":"designate-sink","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"If you need to use sink, feel free to use older neutron/nova or kolla-ansible"},{"line_number":177,"context_line":"release documentation."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"For further specific dns-integration implementation, feel free to refer to"}],"source_content_type":"text/x-rst","patch_set":17,"id":"2ac1c3e8_b084e753","line":176,"range":{"start_line":176,"start_character":19,"end_line":176,"end_character":23},"in_reply_to":"e779e91e_3cfa0804","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"everything is automatically and natively managed through neutron and nova"},{"line_number":174,"context_line":"services themselves."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"If you need to use sink, feel free to use older neutron/nova or kolla-ansible"},{"line_number":177,"context_line":"release documentation."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"For further specific dns-integration implementation, feel free to refer to"}],"source_content_type":"text/x-rst","patch_set":17,"id":"596fe3a9_484ae552","line":176,"range":{"start_line":176,"start_character":19,"end_line":176,"end_character":23},"in_reply_to":"e779e91e_3cfa0804","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"}],"etc/kolla/globals.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3601322b_a1abc783","line":168,"range":{"start_line":168,"start_character":48,"end_line":168,"end_character":50},"updated":"2023-08-07 08:07:43.000000000","message":"it\u0027s","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"e4cf4d00_87e442a4","line":168,"range":{"start_line":168,"start_character":31,"end_line":168,"end_character":37},"updated":"2023-08-07 08:07:43.000000000","message":"nit: behaves","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"c2204936_c236923c","line":168,"range":{"start_line":168,"start_character":7,"end_line":168,"end_character":14},"updated":"2023-08-07 08:07:43.000000000","message":"nit: controls","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bb344801_cddec417","line":168,"range":{"start_line":168,"start_character":48,"end_line":168,"end_character":50},"in_reply_to":"3601322b_a1abc783","updated":"2023-08-09 20:03:15.000000000","message":"Fixed with proper its","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"fafa26fb_302fab24","line":168,"range":{"start_line":168,"start_character":7,"end_line":168,"end_character":14},"in_reply_to":"c2204936_c236923c","updated":"2023-08-09 20:03:15.000000000","message":"Same things as upper, it designate the fact to achieve something, not the means to do it.\n\nhttps://www.proquest.com/openview/b2c5ec926ef6906ee518dd469b52b304/1?pq-origsite\u003dgscholar\u0026cbl\u003d26015#:~:text\u003dControl%20is%20the%20end%20to,quality%20control%20and%20performance%20monitoring.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Configure neutron DNS integration feature."},{"line_number":168,"context_line":"# This control the way neutron behave regarding it DNS requests management."},{"line_number":169,"context_line":"# By default we enable internal neutron DNS integration, letting it manage DNS name allocation and management."},{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"e69e8480_3aed936a","line":168,"range":{"start_line":168,"start_character":31,"end_line":168,"end_character":37},"in_reply_to":"e4cf4d00_87e442a4","updated":"2023-08-09 20:03:15.000000000","message":"Fixed","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cfea25e32383a1a4473c4a371d1dc1957ec4325f","unresolved":true,"context_lines":[{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"# Configure neutron DNS domain name used when internal native feature is used, otherwise we either do not integrate,"},{"line_number":174,"context_line":"# or we integrate with external DNS services such as designate."},{"line_number":175,"context_line":"# Directive type is: String."},{"line_number":176,"context_line":"# neutron_dns_domain: \"example.org\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"c86c486c_0e8e296a","line":173,"range":{"start_line":173,"start_character":41,"end_line":173,"end_character":45},"updated":"2023-08-07 08:07:43.000000000","message":"when the","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"b1147432ecfabc906f3268524e6616ce574b4ac0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"# Valid options are [ internal, external, no value], when no value is set, we don\u0027t enable neutron DNS integration."},{"line_number":171,"context_line":"# neutron_dns_integration_type: \"internal\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"# Configure neutron DNS domain name used when internal native feature is used, otherwise we either do not integrate,"},{"line_number":174,"context_line":"# or we integrate with external DNS services such as designate."},{"line_number":175,"context_line":"# Directive type is: String."},{"line_number":176,"context_line":"# neutron_dns_domain: \"example.org\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"2f9d5989_c131d64e","line":173,"range":{"start_line":173,"start_character":41,"end_line":173,"end_character":45},"in_reply_to":"c86c486c_0e8e296a","updated":"2023-08-09 20:03:15.000000000","message":"Fixed.","commit_id":"e8db04129cffe25f318beb3597b1fe299696f8f4"}],"releasenotes/notes/fix-designate-role-support-18e4c8ae34196ac7.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e5c59fb15d93075bb01acecfcba9f56d5ff82510","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improve designate support. Various drift and misconfiguration were found"},{"line_number":5,"context_line":"    within the designate and neutron role that would prohibit a clean"},{"line_number":6,"context_line":"    deployment of the DNSaaS service."},{"line_number":7,"context_line":"    This patch add the following new variables:"},{"line_number":8,"context_line":"    - \u0027neutron_dns_integration_type\u0027 used to choose neutron DNS integration"},{"line_number":9,"context_line":"    type to use, can be \u0027internal\u0027 or \u0027external\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bb9b6c73_06ca3883","line":6,"range":{"start_line":4,"start_character":31,"end_line":6,"end_character":37},"updated":"2023-04-19 15:15:19.000000000","message":"so what exactly is broken? I have seen multiple successful designate deployments using k-a.\n\nalso, the below linked bug reports, for \"a deeper understanding\" don\u0027t really explain anything.\n\none user reports some weird error in a second(?) deployment, but never posts the actual error, I already asked for clarification and the actual error message in the bug report as well.\n\nso if either in the bug reports or in the relnotes could be some explanation what is actually broken and why it needs/should be fixed this way, that would be really great.\n\nthanks!","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dac7e275dbbb8479235f5d223e067517aa846b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improve designate support. Various drift and misconfiguration were found"},{"line_number":5,"context_line":"    within the designate and neutron role that would prohibit a clean"},{"line_number":6,"context_line":"    deployment of the DNSaaS service."},{"line_number":7,"context_line":"    This patch add the following new variables:"},{"line_number":8,"context_line":"    - \u0027neutron_dns_integration_type\u0027 used to choose neutron DNS integration"},{"line_number":9,"context_line":"    type to use, can be \u0027internal\u0027 or \u0027external\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"674f5193_f2b96547","line":6,"range":{"start_line":4,"start_character":31,"end_line":6,"end_character":37},"in_reply_to":"433f88d0_bfc6a8ed","updated":"2023-04-19 16:27:58.000000000","message":"\u003e overhaul it works \"by accident\" as mdns/dns servers deployed are all exposed to any external ressources where mdns should never been exposed out of one specific scenario that this patch actually take care of.\n\nSo I hope I understood this correct, so please feel free to correct me if I\u0027m wrong, but I don\u0027t think this is by accident? according to the docs:\n\nhttps://docs.openstack.org/kolla-ansible/latest/reference/networking/designate-guide.html\n\n\u003e Designate MDNS node requires the dns_interface to be reachable from public network and instead just change the docs.\n\nThat being said, it might be worthwhile to not require public network access to mini dns.\n\nThanks for the provided answers, so far.","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"bebc1214084be28b3369746aa74c10c8209e14cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improve designate support. Various drift and misconfiguration were found"},{"line_number":5,"context_line":"    within the designate and neutron role that would prohibit a clean"},{"line_number":6,"context_line":"    deployment of the DNSaaS service."},{"line_number":7,"context_line":"    This patch add the following new variables:"},{"line_number":8,"context_line":"    - \u0027neutron_dns_integration_type\u0027 used to choose neutron DNS integration"},{"line_number":9,"context_line":"    type to use, can be \u0027internal\u0027 or \u0027external\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"47128498_c48177a0","line":6,"range":{"start_line":4,"start_character":31,"end_line":6,"end_character":37},"in_reply_to":"674f5193_f2b96547","updated":"2023-05-17 13:10:08.000000000","message":"I don\u0027t know who created the designated role, but all in all he didn\u0027t understood how it works, it was enforcing sink usage and wrote that statement on the doc which is completely at the opposite of the official designate documentation statement.\n\nThe only moment you need to get mDNS to be publicly available is when you want the DNS updates to be send to designate by an external DNS server (valid scenarios exist with this one hence why I made it functional too on the patch).\n\nI\u0027ll be glad to fix the doc too.","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"4bad93c5d9478a1e90a53474f8384a9f71645ad4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Improve designate support. Various drift and misconfiguration were found"},{"line_number":5,"context_line":"    within the designate and neutron role that would prohibit a clean"},{"line_number":6,"context_line":"    deployment of the DNSaaS service."},{"line_number":7,"context_line":"    This patch add the following new variables:"},{"line_number":8,"context_line":"    - \u0027neutron_dns_integration_type\u0027 used to choose neutron DNS integration"},{"line_number":9,"context_line":"    type to use, can be \u0027internal\u0027 or \u0027external\u0027."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"433f88d0_bfc6a8ed","line":6,"range":{"start_line":4,"start_character":31,"end_line":6,"end_character":37},"in_reply_to":"bb9b6c73_06ca3883","updated":"2023-04-19 15:47:08.000000000","message":"The current kolla-ansible deployment doesn\u0027t use mdns as expected neither the pools concept (same issue that when we fixed sink usage, misunderstanding of how the service works).\n\nExemple: On neutron we are using the designate_ns_record pool name/ID where we shouldn\u0027t as it can be either a FQDN, an IP address or a list of mixed types.\n\noverhaul it works \"by accident\" as mdns/dns servers deployed are all exposed to any external ressources where mdns should never been exposed out of one specific scenario that this patch actually take care of.\n\nDesignate second deployment doesn\u0027t works properly as the designate-manage pool update command, the command look to compare pools through the pool declaration ID, which isn\u0027t working currently as we don\u0027t set one.\n\nWill update the reno to be more explicit about issues fixed.","commit_id":"28dc39dc131d032b4d3489d9c9a9cf437bf01733"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dac7e275dbbb8479235f5d223e067517aa846b5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - \u0027neutron_dns_domain\u0027 used to choose DNS TLD used by neutron to create"},{"line_number":11,"context_line":"    ressource related FQDN (VMs interfaces) when in native module."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    This patch replace few variables as follow:"},{"line_number":14,"context_line":"    - \u0027designate_ns_record\u0027 replaced by \u0027designate_pools\u0027."},{"line_number":15,"context_line":"    - \u0027designate_pool_id\u0027 replaced by \u0027designate_default_pool_id\u0027."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d1f83f8e_295f3e08","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":22},"updated":"2023-04-19 16:27:58.000000000","message":"replaces the following variables:","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"3817fe8a93ad50cf9b2bb999f7f5faa60cc257de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - \u0027neutron_dns_domain\u0027 used to choose DNS TLD used by neutron to create"},{"line_number":11,"context_line":"    ressource related FQDN (VMs interfaces) when in native module."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    This patch replace few variables as follow:"},{"line_number":14,"context_line":"    - \u0027designate_ns_record\u0027 replaced by \u0027designate_pools\u0027."},{"line_number":15,"context_line":"    - \u0027designate_pool_id\u0027 replaced by \u0027designate_default_pool_id\u0027."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"51074b76_d8ffca74","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":22},"in_reply_to":"d1f83f8e_295f3e08","updated":"2023-05-17 13:10:35.000000000","message":"Done","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dac7e275dbbb8479235f5d223e067517aa846b5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    - \u0027designate_ns_record\u0027 replaced by \u0027designate_pools\u0027."},{"line_number":15,"context_line":"    - \u0027designate_pool_id\u0027 replaced by \u0027designate_default_pool_id\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    This patch imply that user need to migrate to the new variables and"},{"line_number":18,"context_line":"    structure."},{"line_number":19,"context_line":"    For a better understanding of the way designate service works, please have"},{"line_number":20,"context_line":"    a look at the following related documentation:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"04472b42_c90f0723","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":20},"updated":"2023-04-19 16:27:58.000000000","message":"implies","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"3817fe8a93ad50cf9b2bb999f7f5faa60cc257de","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - \u0027designate_ns_record\u0027 replaced by \u0027designate_pools\u0027."},{"line_number":15,"context_line":"    - \u0027designate_pool_id\u0027 replaced by \u0027designate_default_pool_id\u0027."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    This patch imply that user need to migrate to the new variables and"},{"line_number":18,"context_line":"    structure."},{"line_number":19,"context_line":"    For a better understanding of the way designate service works, please have"},{"line_number":20,"context_line":"    a look at the following related documentation:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"28fcd0c8_f8790535","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":20},"in_reply_to":"04472b42_c90f0723","updated":"2023-05-17 13:10:35.000000000","message":"Done","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6dac7e275dbbb8479235f5d223e067517aa846b5","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    This patch imply that user need to migrate to the new variables and"},{"line_number":18,"context_line":"    structure."},{"line_number":19,"context_line":"    For a better understanding of the way designate service works, please have"},{"line_number":20,"context_line":"    a look at the following related documentation:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    For deeper understanding of this patch, please have a look at the following"},{"line_number":23,"context_line":"    Launchpad bug records:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e02723a9_285c3dcf","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":50},"updated":"2023-04-19 16:27:58.000000000","message":"I guess here is a link missing to designate docs?","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"3817fe8a93ad50cf9b2bb999f7f5faa60cc257de","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    This patch imply that user need to migrate to the new variables and"},{"line_number":18,"context_line":"    structure."},{"line_number":19,"context_line":"    For a better understanding of the way designate service works, please have"},{"line_number":20,"context_line":"    a look at the following related documentation:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    For deeper understanding of this patch, please have a look at the following"},{"line_number":23,"context_line":"    Launchpad bug records:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5761a87c_7f222d49","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":50},"in_reply_to":"e02723a9_285c3dcf","updated":"2023-05-17 13:10:35.000000000","message":"Done","commit_id":"2dd85e2441dfb300f5a53055b06bba70384a549a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4510bcc6499892d1c363a1317d98442e4e46926f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    `bug 2012537"},{"line_number":29,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2012537\u003e`__,"},{"line_number":30,"context_line":"    `bug 2008691"},{"line_number":31,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2008691\u003e`__,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d30719c4_406f6d2e","line":31,"updated":"2023-05-24 13:43:53.000000000","message":"This needs an upgrade section describing the configuration changed that are needed to keep an existing deployment working.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"},{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"e1f330012ba33adc605db58bf79403cab7908c13","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    `bug 2012537"},{"line_number":29,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2012537\u003e`__,"},{"line_number":30,"context_line":"    `bug 2008691"},{"line_number":31,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2008691\u003e`__,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"b9ef9c89_f01d96f1","line":31,"in_reply_to":"d30719c4_406f6d2e","updated":"2023-05-24 15:48:47.000000000","message":"What do you mean by that? this was already there on the doc.","commit_id":"1737e655b06adf62f8252b11fbc70fcd5dd6ec68"}]}