)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"10a309dfdf530620ec911fadd6fa4249e48f46fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce99bbb6_5e5da296","updated":"2023-03-24 13:18:03.000000000","message":"ah, docker policy, not kolla policy, ok","commit_id":"cdcf622018f6ea59c1fb9fe5e9cc3a31526cc3f3"}],"ansible/module_utils/kolla_docker_worker.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b8508cc25f6d26baf4d429538b725539e03070bb","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                        **self.check_container())"},{"line_number":479,"context_line":"            else:"},{"line_number":480,"context_line":"                self.dc.stop(name, timeout\u003dgraceful_timeout)"},{"line_number":481,"context_line":"                self.dc.start(name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_volume(self):"},{"line_number":484,"context_line":"        if not self.check_volume():"}],"source_content_type":"text/x-python","patch_set":4,"id":"467a4016_5a34b3b4","line":481,"updated":"2023-03-24 09:49:45.000000000","message":"I\u0027m not sure about this part. To me, restart_policy\u003dno says: Do not restart containers. Why whould you want to restart them anyway?","commit_id":"cdcf622018f6ea59c1fb9fe5e9cc3a31526cc3f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd6b75d2e8169528fddfaea84a0b941dafc4869a","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                        **self.check_container())"},{"line_number":479,"context_line":"            else:"},{"line_number":480,"context_line":"                self.dc.stop(name, timeout\u003dgraceful_timeout)"},{"line_number":481,"context_line":"                self.dc.start(name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_volume(self):"},{"line_number":484,"context_line":"        if not self.check_volume():"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8250a98_d41454a6","line":481,"in_reply_to":"467a4016_5a34b3b4","updated":"2023-03-24 11:17:37.000000000","message":"before kolla_docker migrated to systemd - restart_policy was for Docker engine policies (if it restarts automatically on crash or smething similar). Since we set that to no in CI - any reconfigure fails silently (because it by default restarts using systemd unit, which is not there). It’s surely broken now.","commit_id":"cdcf622018f6ea59c1fb9fe5e9cc3a31526cc3f3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bcc35fb4dda29806a93222f3fd3a8b270f0e236d","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                        **self.check_container())"},{"line_number":479,"context_line":"            else:"},{"line_number":480,"context_line":"                self.dc.stop(name, timeout\u003dgraceful_timeout)"},{"line_number":481,"context_line":"                self.dc.start(name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_volume(self):"},{"line_number":484,"context_line":"        if not self.check_volume():"}],"source_content_type":"text/x-python","patch_set":4,"id":"b59ff4fc_09a1b132","line":481,"in_reply_to":"86c3644e_bd0cba61","updated":"2023-03-24 13:18:33.000000000","message":"Done","commit_id":"cdcf622018f6ea59c1fb9fe5e9cc3a31526cc3f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0e02905d8d80e77c3313bfee89e228548bce39b5","unresolved":true,"context_lines":[{"line_number":478,"context_line":"                        **self.check_container())"},{"line_number":479,"context_line":"            else:"},{"line_number":480,"context_line":"                self.dc.stop(name, timeout\u003dgraceful_timeout)"},{"line_number":481,"context_line":"                self.dc.start(name)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def create_volume(self):"},{"line_number":484,"context_line":"        if not self.check_volume():"}],"source_content_type":"text/x-python","patch_set":4,"id":"86c3644e_bd0cba61","line":481,"in_reply_to":"a8250a98_d41454a6","updated":"2023-03-24 11:18:34.000000000","message":"see https://docs.docker.com/config/containers/start-containers-automatically/","commit_id":"cdcf622018f6ea59c1fb9fe5e9cc3a31526cc3f3"}]}