)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"16ec697b601f804c639f1ff6e4b8d4207fea24b1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"698464a8_9c21cd61","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"updated":"2023-04-27 08:41:41.000000000","message":"I hadn\u0027t realised that. Do you know why?","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"212da6790ee87181d4207fc01df9b541c16a8d1b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"68b5bd91_c9ba40b3","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"61ef1954_a8ed6103","updated":"2023-04-27 09:23:20.000000000","message":"Agree, but that means we would need to support docker_restart_policy: \"oneshot\" - might be a better solution that just turning that off - let me try.","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1646794a50106063ad268c32c7d3f6fe93754219","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f12b86f6_ac11c98d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"61ef1954_a8ed6103","updated":"2023-04-27 09:21:48.000000000","message":"Yeah I totally agree, e.g. bootstrap containers probably don\u0027t need a systemd unit.\n\nas mentioned in my other comment I think that is the real problem: making the creation of a systemd unit a conditional of the restart policy. this are really two different things imho.\n\nthere might be containers which should be restarted that have no systemd unit and there might be containers with systemd units that should not be restarted automatically. I really fail to understand why it was apparently implemented this way in the first place in https://review.opendev.org/c/openstack/kolla-ansible/+/878358 . I guess because it was \"easy\"?\n\nIf I\u0027m overlooking something - which might be possible - please correct me where I\u0027m wrong. 😊","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"29209ceeef4c5431f76b6107980def06c06ab999","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ef6a989c_9b1b260d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"698464a8_9c21cd61","updated":"2023-04-27 08:47:01.000000000","message":"Well, that\u0027s how it was merged - because we use docker_restart_policy\u003dno for one-time containers (such as bootstrapping a service or something) - we could define a systemd unit with restart\u003dno (that does not do automatic restarts), but then we end up with a lot of systemd units on a real deployment. Any other ideas?","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed61f0638a59b38a984cc02299732fde16ec2150","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"61ef1954_a8ed6103","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"b580bfa4_154b3ba6","updated":"2023-04-27 09:16:18.000000000","message":"We might distinguish between \"one shot\" containers vs long-lived containers. Long-lived containers should probably have a systemd unit, but I\u0027m not sure what the implications of that would be on the design. One shot containers might not have a systemd unit.","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"404e5c1a5e3576eb27a4f3339b4b44e0e2499b78","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In the past it made sense, because we wanted to catch all container"},{"line_number":10,"context_line":"issues (without a restart loop or similar bells and whistles)."},{"line_number":11,"context_line":"Since we implemented systemd approach, docker_restart_policy \u003d \"no\""},{"line_number":12,"context_line":"means we don\u0027t install systemd units - and that\u0027s somewhat bad"},{"line_number":13,"context_line":"for catching CI errors in that implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I294e0c2226d5b9f0506368b1fd020f36bb5fc0cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b580bfa4_154b3ba6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"ef6a989c_9b1b260d","updated":"2023-04-27 09:04:58.000000000","message":"1. what\u0027s the problem with \"a lot of systemd untis\"?\n2. that way we would at least have a chance to detect unit/container failures, no (my question on how we detect container restart problems/loops above is still not answered)?","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"525db85cf1f61c00bd2b62edbb4d5d8ae824f2e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51bbbb76_ed558b3b","updated":"2023-04-21 08:31:16.000000000","message":"forgive me my maybe naive question, but how exactly are restart loops now detected?","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df61d9cd0d748665dca1f4e2f79bee906ccdae6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b6322cb_8b2e34c3","updated":"2023-04-27 09:10:43.000000000","message":"imho the real problem here is mixing the logic of restarting containers with the logic if systemd units should be created.\n\nthese are really two orthogonal things to me, aren\u0027t they?\n\nimho they should be separated.","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b963ee9e122b66b9c9cfae6171eb3f01d69fecf8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b47d6bcf_bd50ca2e","updated":"2023-04-27 09:08:02.000000000","message":"why does this Change not link to relevant other changes and bugs, e.g.:\nhttps://bugs.launchpad.net/kolla-ansible/+bug/2012654\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/878358","commit_id":"e979b612cdd1756c64e7611aa6b201ab334c54fb"}]}