)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f6e04e30d6f1a1cbb90a82791cb962d5ef29fdb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"397e0d30_441f65e6","updated":"2023-11-14 06:28:42.000000000","message":"needs a reno, this is user impacting","commit_id":"227afff9b94684d909b51f8a0acb26994d26adb9"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d504e9c6af98bde3fe4b1d7bc667149cd4c91a1f","unresolved":true,"context_lines":[{"line_number":1280,"context_line":"# this is UDP port"},{"line_number":1281,"context_line":"hacluster_corosync_port: 5405"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"######################"},{"line_number":1284,"context_line":"# Pure Storage options"},{"line_number":1285,"context_line":"######################"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"# Valid options are [ roce ] - more to come in next release"},{"line_number":1288,"context_line":"pure_nvme_transport: \"roce\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"31a8617a_d908adc9","line":1288,"range":{"start_line":1283,"start_character":0,"end_line":1288,"end_character":27},"updated":"2023-07-31 07:05:50.000000000","message":"since it\u0027s used only in cinder role - why put that in group_vars/all?","commit_id":"795b1e267d1468e99f86af2657c7dd5060eb9f2e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"407fe202d62e1f955a629fa498eefcf96e4f0a9a","unresolved":true,"context_lines":[{"line_number":1280,"context_line":"# this is UDP port"},{"line_number":1281,"context_line":"hacluster_corosync_port: 5405"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"######################"},{"line_number":1284,"context_line":"# Pure Storage options"},{"line_number":1285,"context_line":"######################"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"# Valid options are [ roce ] - more to come in next release"},{"line_number":1288,"context_line":"pure_nvme_transport: \"roce\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"37e81cd8_2b4019af","line":1288,"range":{"start_line":1283,"start_character":0,"end_line":1288,"end_character":27},"in_reply_to":"31a8617a_d908adc9","updated":"2023-07-31 14:37:15.000000000","message":"My bad - resolved.","commit_id":"795b1e267d1468e99f86af2657c7dd5060eb9f2e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8b3c5511ed89bfad188f7cf6cfc9fea61eb0877d","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"# this is UDP port"},{"line_number":1281,"context_line":"hacluster_corosync_port: 5405"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"######################"},{"line_number":1284,"context_line":"# Pure Storage options"},{"line_number":1285,"context_line":"######################"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"# Valid options are [ roce ] - more to come in next release"},{"line_number":1288,"context_line":"pure_nvme_transport: \"roce\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3eb83d7a_66f9a0ad","line":1288,"range":{"start_line":1283,"start_character":0,"end_line":1288,"end_character":27},"in_reply_to":"37e81cd8_2b4019af","updated":"2023-08-27 14:16:23.000000000","message":"Done","commit_id":"795b1e267d1468e99f86af2657c7dd5060eb9f2e"}],"doc/source/reference/storage/cinder-guide-pure.rst":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f6e04e30d6f1a1cbb90a82791cb962d5ef29fdb0","unresolved":true,"context_lines":[{"line_number":34,"context_line":".. code-block:: yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  enable_cinder_backend_pure_nvme: \"yes\""},{"line_number":37,"context_line":"  pure_nvme_transport: \"roce | tcp\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. end"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3dc37ade_7c83ddf4","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":35},"updated":"2023-11-14 06:28:42.000000000","message":"can we have just one as an example? I\u0027m afraid people will copy paste","commit_id":"227afff9b94684d909b51f8a0acb26994d26adb9"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"644bfb65e60aeb1f9131ab62c41cbc16b7e8f48d","unresolved":true,"context_lines":[{"line_number":865,"context_line":"#hacluster_corosync_port: 5405"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"######################"},{"line_number":868,"context_line":"# Pure Storge options"},{"line_number":869,"context_line":"######################"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# Valid options are [ roce ]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c6cd801a_728c7c12","line":868,"range":{"start_line":868,"start_character":0,"end_line":868,"end_character":21},"updated":"2023-08-26 21:50:40.000000000","message":"should we add all other Pure Storage options (pure_api_token, pure_san_ip) since we add this block it for all types of Pure Storage hardware?","commit_id":"325d097278f44ad4cb17f50e74011f9ba3240bfa"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8b3c5511ed89bfad188f7cf6cfc9fea61eb0877d","unresolved":false,"context_lines":[{"line_number":865,"context_line":"#hacluster_corosync_port: 5405"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"######################"},{"line_number":868,"context_line":"# Pure Storge options"},{"line_number":869,"context_line":"######################"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# Valid options are [ roce ]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d40cf12d_17ec176a","line":868,"range":{"start_line":868,"start_character":0,"end_line":868,"end_character":21},"in_reply_to":"c6cd801a_728c7c12","updated":"2023-08-27 14:16:23.000000000","message":"Done","commit_id":"325d097278f44ad4cb17f50e74011f9ba3240bfa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5626bb379b21f52d40961959b568fae151583045","unresolved":true,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# NVMe transport options are [ roce, tcp ]"},{"line_number":872,"context_line":"#pure_nvme_transport: \"roce\""},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"#pure_api_token:"},{"line_number":875,"context_line":"#pure_san_ip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"adfb4649_337c7da0","line":873,"updated":"2023-08-27 19:36:28.000000000","message":"\\# TCP options (if tcp transport used)","commit_id":"3f432e651650dd1cca3c2b8bf5b7630edd12ad72"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7d4b45fbe8a70c7bc34c114fc98c77a04a5ac695","unresolved":true,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# NVMe transport options are [ roce, tcp ]"},{"line_number":872,"context_line":"#pure_nvme_transport: \"roce\""},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"#pure_api_token:"},{"line_number":875,"context_line":"#pure_san_ip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"302e09cf_232d6b79","line":873,"in_reply_to":"0d35d8b8_1db305a7","updated":"2023-08-27 20:02:25.000000000","message":"ok, then add the correct comment for separated lines or remove an empty line","commit_id":"3f432e651650dd1cca3c2b8bf5b7630edd12ad72"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"17689e47f1376b4222154484f87c88de85e8c484","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# NVMe transport options are [ roce, tcp ]"},{"line_number":872,"context_line":"#pure_nvme_transport: \"roce\""},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"#pure_api_token:"},{"line_number":875,"context_line":"#pure_san_ip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"71bfc62b_be0fc30c","line":873,"in_reply_to":"302e09cf_232d6b79","updated":"2023-09-15 02:54:38.000000000","message":"Done","commit_id":"3f432e651650dd1cca3c2b8bf5b7630edd12ad72"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4fdfa8429e8873e20142aae48eb63a3650b0528f","unresolved":true,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# NVMe transport options are [ roce, tcp ]"},{"line_number":872,"context_line":"#pure_nvme_transport: \"roce\""},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"#pure_api_token:"},{"line_number":875,"context_line":"#pure_san_ip:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0d35d8b8_1db305a7","line":873,"in_reply_to":"adfb4649_337c7da0","updated":"2023-08-27 19:55:26.000000000","message":"pure_api_token and pure_san_ip are for all nvme transport types and for non-nvme drivers, ie iscsi and fc.\nThere are no specific TCP options other than setting pure_nvme_transport","commit_id":"3f432e651650dd1cca3c2b8bf5b7630edd12ad72"}]}