)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b362375e2b6ce48b0127a166d59499174e5977a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a75c0adb_3a3eb079","updated":"2023-04-18 09:51:32.000000000","message":"We need to merge https://review.opendev.org/c/openstack/kolla/+/877986 first to pass debian as I\u0027ve already tested in CI here -\u003e https://review.opendev.org/c/openstack/kolla-ansible/+/880678","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"931f80961d692ff2bd648feb40195bde21c99e01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5976b096_09255727","updated":"2023-04-18 15:52:47.000000000","message":"recheck use python3-venv to create virtual env already merged","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0f305b5ea977942f4fb0277e16c8478bc634e83a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61e85092_b9113d31","in_reply_to":"1f7b4b52_b1230882","updated":"2023-04-18 19:03:38.000000000","message":"congrats)","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7ee9eccf7c85327b085c62a4db6ceafa07a859ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cdcc0cc4_1dbb21cd","in_reply_to":"5976b096_09255727","updated":"2023-04-18 17:22:42.000000000","message":"I think you need to wait for the publish job - so tomorrow.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e21d6245b07bbfd6f1256894d86856a5dc12eb5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f7b4b52_b1230882","in_reply_to":"8f5d7891_194dbfba","updated":"2023-04-18 18:58:01.000000000","message":"vuala 😊","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eed6fabc97aecd99412e7f74bdcd0ee7dcb883d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f5d7891_194dbfba","in_reply_to":"cdcc0cc4_1dbb21cd","updated":"2023-04-18 18:36:46.000000000","message":"I think no and it will be merged today :), let\u0027s see.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"}],"ansible/roles/nova-cell/handlers/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1fc64e0f6f6280168bdab044d8492cad6802c52c","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d3d0354_7322b9b9","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"updated":"2023-04-11 06:21:49.000000000","message":"why not kolla_container_facts?","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fbe3b58abe5603648209adb5806583383cd3f8b6","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da5eeba9_4fccfbad","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"1d3d0354_7322b9b9","updated":"2023-04-17 13:43:04.000000000","message":"Need to wait for kolla_set_configs to complete rather than just container up.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"922cc2c4d3254b94508624648fbbd9ba7ca4cc7b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d5d3a9d_935b18f7","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"3d1bd6c1_569456e2","updated":"2023-04-17 14:32:50.000000000","message":"but we actually wait for container is ready and libvirtd is started.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e619d41d074e147592863d57382d98c9dec0096b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d0621c69_c35911ee","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"8f311c21_cbec5bfc","updated":"2023-04-17 14:18:55.000000000","message":"I\u0027m confused. You wrote \u0027need to wait\u0027.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ebd2484671139b681a97cf5cb5fbdec51a704656","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8f311c21_cbec5bfc","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"bd2ef0ba_e0d0ef9b","updated":"2023-04-17 14:13:40.000000000","message":"+2 because this patch does wait for kolla_set_configs to run","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f05769c87aa6b5061ad1e7b60748587099da709d","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3d1bd6c1_569456e2","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"d0621c69_c35911ee","updated":"2023-04-17 14:28:07.000000000","message":"I was responding to Michal\u0027s question:\n\n| why not kolla_container_facts?\n\nBecause we need to wait for kolla_set_configs to complete rather than just container being up. This patch does it already.","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9efbdca37a0ae0771fdd299e77e118693c30469b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd2ef0ba_e0d0ef9b","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"da5eeba9_4fccfbad","updated":"2023-04-17 13:51:02.000000000","message":"\u003e Need to wait for kolla_set_configs to complete rather than just container up.\nso why +2 ?","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"fc1bcdcc6526220427716a3781ce64fd44573056","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  # need to wait kolla_set_configs script to overwrite sasl config file"},{"line_number":119,"context_line":"- name: Checking libvirt container is ready"},{"line_number":120,"context_line":"  become: true"},{"line_number":121,"context_line":"  shell:"},{"line_number":122,"context_line":"    cmd: \u003e"},{"line_number":123,"context_line":"      set -o pipefail \u0026\u0026"},{"line_number":124,"context_line":"      {{ kolla_container_engine }} exec -i nova_libvirt ls /run/libvirtd.pid"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d5292c45_57d040bd","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":7},"in_reply_to":"da5eeba9_4fccfbad","updated":"2023-04-17 13:50:09.000000000","message":"Ack","commit_id":"46415123d59fbb6d281b4d0f32e4dbf527fe8c6e"}]}