)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c4b43e7e6c38c10c437b93e0b9c58ad35a5dc4ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-19 21:27:20 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial fix - add int filter for rabbitmq definitions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1d8021a1bc780449e3ca96183c6f4abaed17b382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4be900e8_4743a477","line":7,"updated":"2023-04-20 10:09:58.000000000","message":"\"Add int filter for rabbitmq_queue_expiry_ms definition\"\n\nwould have been my preferred choice of title, and then add the motivation to make it consistent with the other variable as message. But likely not worth a respin now that we have it documented in the review, just a hint for next time.","commit_id":"d1b24a413761293f3b3827df967023853ee2d93d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1bbda0f503a17d679a316e517a034faab2e40fa6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-19 21:27:20 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial fix - add int filter for rabbitmq definitions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1d8021a1bc780449e3ca96183c6f4abaed17b382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b61b4742_55d245a6","line":7,"in_reply_to":"4be900e8_4743a477","updated":"2023-04-20 11:14:37.000000000","message":"Thank you frickler :) , I\u0027ll think about it next time","commit_id":"d1b24a413761293f3b3827df967023853ee2d93d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"977f2a8a47899355d92bc5ce396cdab39f5622f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a5f9f8e_e4b57854","updated":"2023-04-20 09:18:06.000000000","message":"What is this fixing? I agree that it may be helpful to verify that the argument is indeed an integer as otherwise rmq might fail, but I\u0027d still consider this a feature, not a fix.","commit_id":"d1b24a413761293f3b3827df967023853ee2d93d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8e87b8751e1473f903fb56014653af9085c4adaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d38279a_f4f90cb0","in_reply_to":"43e7a59f_bdb3e20d","updated":"2023-04-20 09:23:34.000000000","message":"or correct is better word ? i hope u understand what i meant :D","commit_id":"d1b24a413761293f3b3827df967023853ee2d93d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3c04f5cad600f3591965da9671244b3e774b3416","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43e7a59f_bdb3e20d","in_reply_to":"7a5f9f8e_e4b57854","updated":"2023-04-20 09:23:07.000000000","message":"I would like to be just consistent in templates. Check https://review.opendev.org/c/openstack/kolla-ansible/+/872427 - rabbitmq_message_ttl_ms was added with int filter while rabbitmq_queue_expiry_ms was not. Both are miliseconds ...why it should be different ?","commit_id":"d1b24a413761293f3b3827df967023853ee2d93d"}]}
