)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"2779a1c63a6321fd020daaedee62d204bf8d9b0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2e9d038_9d951651","updated":"2023-05-18 18:27:39.000000000","message":"nice addition, thanks :)\n\ncan you just add a release notes about that using reno ?","commit_id":"924d45d81ba53fa37b8a81d3e506f0a46cc693d4"},{"author":{"_account_id":33775,"name":"Léo Gillot-Lamure","display_name":"Léo Gillot-Lamure (Socgen)","email":"leo.gillot-lamure-ext@socgen.com","username":"navaati-sg","status":"Société Générale"},"change_message_id":"fdc3c3c7e3ee4dd67a205144098ec4ff388b9a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"662c77d4_064166db","in_reply_to":"e2e9d038_9d951651","updated":"2023-05-18 19:20:03.000000000","message":"Done, correctly I hope.","commit_id":"924d45d81ba53fa37b8a81d3e506f0a46cc693d4"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"d2151a79d00b5a1aabe2190f4a8ff5e913ebe986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2783c42a_fd918eaf","updated":"2023-05-18 19:22:36.000000000","message":"LGTM","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2b097baf8d1258811cab3ac9e4859a693cc8d431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"33cf188c_f5fec507","updated":"2023-08-02 14:01:24.000000000","message":"cf. https://review.opendev.org/c/openstack/kolla-ansible/+/888034","commit_id":"e043828601d8e7cd0087ab6fc40ecc23cf8fd21d"}],"ansible/roles/loadbalancer/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"40fb0487488f22a4b05e2eb5d219840c5815ea80","unresolved":true,"context_lines":[{"line_number":53,"context_line":"haproxy_max_connections: 40000"},{"line_number":54,"context_line":"haproxy_threads: 1"},{"line_number":55,"context_line":"# More than 1 process is deprecated by HAProxy, prefer haproxy_threads"},{"line_number":56,"context_line":"haproxy_processes: 1"},{"line_number":57,"context_line":"haproxy_process_cpu_map: \"no\""},{"line_number":58,"context_line":"# Matches the mariadb 10000 max connections limit"},{"line_number":59,"context_line":"haproxy_defaults_max_connections: 10000"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"17fa9e54_63fb8f4a","line":56,"updated":"2023-08-02 14:00:56.000000000","message":"I wonder if we could just keep using this variable, even if the name is slightly off.","commit_id":"e043828601d8e7cd0087ab6fc40ecc23cf8fd21d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"18ca1140041852ad4e89937d39a141f98ea38c7d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"haproxy_max_connections: 40000"},{"line_number":54,"context_line":"haproxy_threads: 1"},{"line_number":55,"context_line":"# More than 1 process is deprecated by HAProxy, prefer haproxy_threads"},{"line_number":56,"context_line":"haproxy_processes: 1"},{"line_number":57,"context_line":"haproxy_process_cpu_map: \"no\""},{"line_number":58,"context_line":"# Matches the mariadb 10000 max connections limit"},{"line_number":59,"context_line":"haproxy_defaults_max_connections: 10000"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a2ddf6ee_fed816c7","line":56,"in_reply_to":"17fa9e54_63fb8f4a","updated":"2023-08-17 12:57:17.000000000","message":"Let\u0027s ask users to change their config in the last patch that drops nbproc","commit_id":"e043828601d8e7cd0087ab6fc40ecc23cf8fd21d"}],"ansible/roles/loadbalancer/templates/haproxy/haproxy_main.cfg.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8908e1781ce1cd6302255b7466831b4d22b56e88","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1492549c_d23f02a7","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"updated":"2023-05-18 21:03:58.000000000","message":"should we remove this?","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":33775,"name":"Léo Gillot-Lamure","display_name":"Léo Gillot-Lamure (Socgen)","email":"leo.gillot-lamure-ext@socgen.com","username":"navaati-sg","status":"Société Générale"},"change_message_id":"b249d26d839141081079af40f56b330e6d97d94a","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"398e4cf0_2a3ed428","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"1492549c_d23f02a7","updated":"2023-05-18 22:36:55.000000000","message":"Good question ! I think that _eventually_ yes, because nbproc is really not recommended by the HAProxy project and the existence of the option can be misleading for users.\n\nI did not touch it though, because I didn’t know what the policy on breaking change was for the kolla-ansible project. I would rather make another patchset, would that be good ?","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":33775,"name":"Léo Gillot-Lamure","display_name":"Léo Gillot-Lamure (Socgen)","email":"leo.gillot-lamure-ext@socgen.com","username":"navaati-sg","status":"Société Générale"},"change_message_id":"6bdf5a075da74f3fb54659c5e70324505b406024","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f34ec69_1b7bf103","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"398e4cf0_2a3ed428","updated":"2023-05-23 21:37:43.000000000","message":"I put haproxy_threads first in ansible/roles/loadbalancer/defaults/main.yml to encourage administrators to use it in priority, with a comment for haproxy_processes expliciting that it is deprecated.\n\nOn top of that, I created another (WIP) patch in 883982: loadbalancer: remove support for haproxy_processes | https://review.opendev.org/c/openstack/kolla-ansible/+/883982 so that we can have the discussion about the deprecation cycle there.\n\nIs that good for you ?","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"40fb0487488f22a4b05e2eb5d219840c5815ea80","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e8262065_48ffb1db","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"3c832232_dde8335c","updated":"2023-08-02 14:00:56.000000000","message":"nbproc is no longer supported by newer haproxy versions like the one on bookworm. so IMO we should drop this and also squash the stack of three patches into one","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"62dd6e656e0b62b0032de770a3350eccf095061d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fe907a23_db9ea719","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"5f34ec69_1b7bf103","updated":"2023-05-24 18:38:09.000000000","message":"zuul said all ok, but IMHO there is need to test this under heavy load in production.","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"18ca1140041852ad4e89937d39a141f98ea38c7d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3bffd1ca_a123e380","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"e8262065_48ffb1db","updated":"2023-08-17 12:57:17.000000000","message":"Let\u0027s merge them nearly as is, squashing them is a bit more work.","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"},{"author":{"_account_id":33775,"name":"Léo Gillot-Lamure","display_name":"Léo Gillot-Lamure (Socgen)","email":"leo.gillot-lamure-ext@socgen.com","username":"navaati-sg","status":"Société Générale"},"change_message_id":"46cb3229298e89e08c6ec419025b1210cd4cf83b","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    daemon"},{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_haproxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ haproxy_processes }}"},{"line_number":10,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":11,"context_line":"    {% if (haproxy_processes | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, haproxy_processes) %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3c832232_dde8335c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":34},"in_reply_to":"fe907a23_db9ea719","updated":"2023-06-03 21:13:27.000000000","message":"Note that this patch does not enable multithreading by default, it merely offers the administrator the possibility to use it. Users would have to test in their own environment anyway to go to production with a \u003e1 value of the variable.","commit_id":"ee66afa1451439959f03fb442f626d630be6b98a"}]}