)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"839844b39bf64aab7c700f439b44a52cad1386ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29849d11_22aa121c","updated":"2023-05-26 08:30:52.000000000","message":"Apparently this idea was rejected before :\u0027( https://review.opendev.org/c/openstack/kolla-ansible/+/818362","commit_id":"a984407563af23323f42c30877822c82eb57643c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1b3339ff5ec28f22cf549fe843571d319ceb2292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0a888e1_3d206aa7","in_reply_to":"29849d11_22aa121c","updated":"2023-05-26 08:40:51.000000000","message":"looking at the old changeset I read:\n\n\u003e  It\u0027s broken in some cases, in others maybe the correct internal DNS config is used already and this change would break them.\n\nSo maybe we can unbreak more/all usecases? Don\u0027t know enough about DNS in OVN though, need to read up on that topic.\n\nI certainly think that only providing docs when we know a config is broken is not really enough. But I don\u0027t know how hard it is to fix all usecases without breakage.","commit_id":"a984407563af23323f42c30877822c82eb57643c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"658ed824e2005f1a6ce2cda5937d5bcdc74fb265","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ed93742_d57e95f4","in_reply_to":"b0fb1d62_1475117c","updated":"2023-05-26 09:09:38.000000000","message":"Yes, I prefer your patch now I discovered it. I have extracted the docs from that, but restoring your patch would be better.","commit_id":"a984407563af23323f42c30877822c82eb57643c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9504a919c681b671783ad69573807c77e47329e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0fb1d62_1475117c","in_reply_to":"e0a888e1_3d206aa7","updated":"2023-05-26 08:47:27.000000000","message":"I\u0027m not sure that we need this, but I\u0027m also not sure if the documentation mentioned in the old patch was ever generated.\n\nIf there is a majority in favor of this, I\u0027d prefer to restore the original patch that at least doesn\u0027t change the default settings.","commit_id":"a984407563af23323f42c30877822c82eb57643c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7c362e52817d5fabb042c684404574548de2e90d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53983cd3_3eef998c","updated":"2024-06-28 07:53:28.000000000","message":"Is this patch abandoned @john.garbutt@stackhpc.com or do you plan to work on it, or should someone else take it over?\n\nI think the content, after some adjustment, would still be good to have, especially that we want to make ovn the new networking default.\n\nThanks","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"}],"doc/source/reference/networking/neutron.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e90a85dbdc623b9b92c16466b49875a4b9830326","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   neutron_plugin_agent: \"ovn\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"OVN cannot use the host\u0027s networking in order to forward DNS"},{"line_number":154,"context_line":"queries from instances, so there is a special setting indicating"},{"line_number":155,"context_line":"which nameservers should be announced to instances via DHCP,"},{"line_number":156,"context_line":"when no DNS servers are specificed in that neutron network:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"865da472_c6e9534d","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":36},"updated":"2023-05-30 09:07:06.000000000","message":"nit: I don\u0027t think this accurately describes the problem, from a technical perspective. Of course OVN could use the hosts networking to forward DNS queries.\nIt just doesn\u0027t do so.\nI think what is meant is, that OVN does not install or provide a local forwarding resolver.\n\nSee also: https://bugs.launchpad.net/neutron/+bug/1902950","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":153,"context_line":"OVN cannot use the host\u0027s networking in order to forward DNS"},{"line_number":154,"context_line":"queries from instances, so there is a special setting indicating"},{"line_number":155,"context_line":"which nameservers should be announced to instances via DHCP,"},{"line_number":156,"context_line":"when no DNS servers are specificed in that neutron network:"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. path /etc/kolla/config/neutron/ml2_conf.ini"},{"line_number":159,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1715ac59_a94d094e","line":156,"range":{"start_line":156,"start_character":24,"end_line":156,"end_character":34},"updated":"2023-05-30 09:00:02.000000000","message":"specified","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":159,"context_line":".. code-block:: yaml"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"   [ovn]"},{"line_number":162,"context_line":"   dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"You should likely override these defaults with the addresses of some"},{"line_number":165,"context_line":"local resolvers. Note that currently only IPv4 nameserver addresses"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0f68dd4d_b2825f2d","line":162,"updated":"2023-05-30 09:00:02.000000000","message":"If we advise to use some local resolvers in the reno, maybe we shouldn\u0027t endorse Cloudflare and Google in this example, but use the demo/doc prefixes? Like\n\ndns_servers: \"192.0.2.53,2001:db8::53\"\n\nThis is actually an argument in favor of having this only in the docs in comparison to having a default config in kolla, where we would likely prefer having default settings that just work for most people instead of caring about their privacy.","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d1cc2dda18d89d0f1050868d31626d215b03b04","unresolved":true,"context_lines":[{"line_number":161,"context_line":"   [ovn]"},{"line_number":162,"context_line":"   dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"You should likely override these defaults with the addresses of some"},{"line_number":165,"context_line":"local resolvers. Note that currently only IPv4 nameserver addresses"},{"line_number":166,"context_line":"are supported."},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"2ddad9cb_dee0eb25","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":41},"updated":"2023-05-26 09:32:34.000000000","message":"The wording sounds like the default is in yaml code block, but the default in Neutron is [] (https://github.com/openstack/neutron/blob/9e6675ec06d3f37564d3fa328afdb9b816a5384e/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py#L168) which then takes the resolv.conf from the host (where neutron_server container resides I assume) (https://github.com/openstack/neutron/blob/9e6675ec06d3f37564d3fa328afdb9b816a5384e/neutron/common/ovn/utils.py#L578) - should we clarify that?","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":161,"context_line":"   [ovn]"},{"line_number":162,"context_line":"   dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"You should likely override these defaults with the addresses of some"},{"line_number":165,"context_line":"local resolvers. Note that currently only IPv4 nameserver addresses"},{"line_number":166,"context_line":"are supported."},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ee75e8be_cf007920","line":164,"range":{"start_line":164,"start_character":18,"end_line":164,"end_character":41},"in_reply_to":"2ddad9cb_dee0eb25","updated":"2023-05-30 09:00:02.000000000","message":"Yes, this wording was only correct for the case when we actually have our own default in kolla. Better clarify that the above is an example for how to set some custom dns_servers.","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":162,"context_line":"   dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"You should likely override these defaults with the addresses of some"},{"line_number":165,"context_line":"local resolvers. Note that currently only IPv4 nameserver addresses"},{"line_number":166,"context_line":"are supported."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"When using OVN - Kolla Ansible will not enable distributed floating ip"},{"line_number":169,"context_line":"functionality (not enable external bridges on computes) by default."}],"source_content_type":"text/x-rst","patch_set":4,"id":"918c8414_64ca5b81","line":166,"range":{"start_line":165,"start_character":17,"end_line":166,"end_character":14},"updated":"2023-05-30 09:00:02.000000000","message":"afaict this is no longer true and can be dropped","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"}],"releasenotes/notes/add-ovn-dns-2626a31f9711192b.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OVN has no default dns_servers set by default. This means every user"},{"line_number":5,"context_line":"    create network, or user instance, needs special action to make DNS work."},{"line_number":6,"context_line":"    When you set the OVN config, DHCP will likely update the resolv.conf"},{"line_number":7,"context_line":"    in all severs, which may suprize users that have set their own values."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"332ba455_bf39d922","line":4,"updated":"2023-05-30 09:00:02.000000000","message":"Well this is only half true, the default is to use the setting specified in resolv.conf on the hypervisor, which wasn\u0027t too bad an idea until systemd came along and made this point to 127.0.0.53 on most modern hosts ... which of course isn\u0027t a helpful nameserver to tell instances to use via DHCP. But maybe this is too technical for a reno, so not sure how to rephrase.","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e1135fd329a826075942b1f314620402ce8b4a69","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    OVN has no default dns_servers set by default. This means every user"},{"line_number":5,"context_line":"    create network, or user instance, needs special action to make DNS work."},{"line_number":6,"context_line":"    When you set the OVN config, DHCP will likely update the resolv.conf"},{"line_number":7,"context_line":"    in all severs, which may suprize users that have set their own values."},{"line_number":8,"context_line":"    Ideally this is set to your local network DNS servers, so local DNS"},{"line_number":9,"context_line":"    entries can be resolved, and all networks get working DNS by default,"},{"line_number":10,"context_line":"    without users needing to set their own DNS on the network."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"25e3104a_24af75dd","line":7,"updated":"2023-05-30 09:00:02.000000000","message":"servers, surprize\n\nIf users override what they see from DHCP, they shouldn\u0027t really be affected if that changes, though?","commit_id":"3f5208388eb398332c4e1a86cfa58e211bba5cea"}]}