)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a57d77402c7c2d0f0d7b53a420cf2af127123c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e361dfc_c8e868eb","updated":"2023-09-04 19:19:59.000000000","message":"Hi Rafael, thanks for the review. I applied your suggestions.","commit_id":"f5a28029f515d00c695498c1690260a4f791a939"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"333320ce50e58cff3e1a0dc478301f4f2471d8fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d7023c1b_6915ba07","updated":"2023-09-05 08:37:35.000000000","message":"Hi Sven, Thanks for your review 😊.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"27fd297560bcbb19809bf51bb0e3fbee25b45344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f247e74d_18989ae6","updated":"2023-10-03 19:20:19.000000000","message":"Hi Michal, thanks for your suggestions.","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"43f8e08065c72bcd569e4c72727005fe2cd26f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"604c4f0d_b2c5d860","updated":"2023-10-10 13:45:25.000000000","message":"Hi Sven, thanks for the review.","commit_id":"06f15e5dffe75ae2c214d2489c0ad5fc79f79bae"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e021706ceac1ed56e0364d20f6539d5e9319c88e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"16acc1b5_61bd6d6e","updated":"2024-03-26 12:58:40.000000000","message":"Hello guys, \nAre we missing something here?","commit_id":"666ec78805fecdc58511cf186643c60c7d291ced"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"32424aca3f34aed47e41eaa9c204d6527085f4de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2fab3a54_ec6b35a8","updated":"2024-06-26 12:22:37.000000000","message":"Hi guys, is there something missing in this patch?","commit_id":"666ec78805fecdc58511cf186643c60c7d291ced"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ba9bbc978353a044b0b363b68923085847856e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"335620f9_bf109ce8","updated":"2024-06-26 12:34:15.000000000","message":"Hi, this patch looks good, thx","commit_id":"666ec78805fecdc58511cf186643c60c7d291ced"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ba9bbc978353a044b0b363b68923085847856e07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ac93d1d7_baa92c43","in_reply_to":"2fab3a54_ec6b35a8","updated":"2024-06-26 12:34:15.000000000","message":"I think we need bug report to be able to backport this change, please raise it here https://bugs.launchpad.net/kolla-ansible and link with \"Closes-Bug: #\" entry in the commit message.","commit_id":"666ec78805fecdc58511cf186643c60c7d291ced"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"261534d5cdba0b2280cefe3e6e34a97fdf40ff07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d800016e_5e4717ff","in_reply_to":"ac93d1d7_baa92c43","updated":"2024-06-26 12:42:15.000000000","message":"Sure, thanks Bartosz, I created the bug report in launchpad 😊","commit_id":"666ec78805fecdc58511cf186643c60c7d291ced"}],"ansible/module_utils/kolla_container_worker.py":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ee43f88660a369dcd7634651394caf106f59e3ad","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        pass"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @staticmethod"},{"line_number":209,"context_line":"    def dimensions_differ(a, b):"},{"line_number":210,"context_line":"        unit_sizes \u003d {"},{"line_number":211,"context_line":"            \u0027b\u0027: 1,"},{"line_number":212,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":4,"id":"2b8b3b94_44dd0634","line":209,"updated":"2023-09-04 11:55:46.000000000","message":"Maybe a documentation here in this method, with a link to the docker page where these possible units are presented.","commit_id":"f5a28029f515d00c695498c1690260a4f791a939"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a57d77402c7c2d0f0d7b53a420cf2af127123c97","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        pass"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @staticmethod"},{"line_number":209,"context_line":"    def dimensions_differ(a, b):"},{"line_number":210,"context_line":"        unit_sizes \u003d {"},{"line_number":211,"context_line":"            \u0027b\u0027: 1,"},{"line_number":212,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":4,"id":"af34e50e_e37d336f","line":209,"in_reply_to":"2b8b3b94_44dd0634","updated":"2023-09-04 19:19:59.000000000","message":"Done","commit_id":"f5a28029f515d00c695498c1690260a4f791a939"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ee43f88660a369dcd7634651394caf106f59e3ad","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        b \u003d str(b)"},{"line_number":218,"context_line":"        a_last_char \u003d a[-1].lower()"},{"line_number":219,"context_line":"        b_last_char \u003d b[-1].lower()"},{"line_number":220,"context_line":"        if a_last_char in unit_sizes:"},{"line_number":221,"context_line":"            a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":222,"context_line":"        if b_last_char in unit_sizes:"},{"line_number":223,"context_line":"            b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6a24825_38252a82","line":220,"updated":"2023-09-04 11:55:46.000000000","message":"Right now docker only allows one to use these two units. However, if a new unit is added, we might have the same issues again, which can be very difficult to pin-point. Therefore, what about a log here to indicate to operators when they are using an unexpected unit type in the code?\n\nThen, we can guide them to use the ones we support only.","commit_id":"f5a28029f515d00c695498c1690260a4f791a939"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a57d77402c7c2d0f0d7b53a420cf2af127123c97","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        b \u003d str(b)"},{"line_number":218,"context_line":"        a_last_char \u003d a[-1].lower()"},{"line_number":219,"context_line":"        b_last_char \u003d b[-1].lower()"},{"line_number":220,"context_line":"        if a_last_char in unit_sizes:"},{"line_number":221,"context_line":"            a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":222,"context_line":"        if b_last_char in unit_sizes:"},{"line_number":223,"context_line":"            b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ebe0d421_1eebe1f4","line":220,"in_reply_to":"a6a24825_38252a82","updated":"2023-09-04 19:19:59.000000000","message":"Done","commit_id":"f5a28029f515d00c695498c1690260a4f791a939"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc5e199e3205469f6c5fcab2ccc72cf4d59685f3","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        warn_msg \u003d (\"The docker dimension unit [%s] is not supported for \""},{"line_number":241,"context_line":"                    \"the dimension [%]. The currently supported units \""},{"line_number":242,"context_line":"                    \"are [\u0027b\u0027, \u0027k\u0027, \u0027m\u0027, \u0027g\u0027].\")"},{"line_number":243,"context_line":"        if not a_last_char.isnumeric():"},{"line_number":244,"context_line":"            if a_last_char in unit_sizes:"},{"line_number":245,"context_line":"                a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":246,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"12302386_e671c10e","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":9},"updated":"2023-09-05 08:04:12.000000000","message":"this check is not necessary, because we already check if `a_last_char` is a member of `unit_sizes`, it\u0027s redundant to also check that it is not numeric.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"333320ce50e58cff3e1a0dc478301f4f2471d8fa","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        warn_msg \u003d (\"The docker dimension unit [%s] is not supported for \""},{"line_number":241,"context_line":"                    \"the dimension [%]. The currently supported units \""},{"line_number":242,"context_line":"                    \"are [\u0027b\u0027, \u0027k\u0027, \u0027m\u0027, \u0027g\u0027].\")"},{"line_number":243,"context_line":"        if not a_last_char.isnumeric():"},{"line_number":244,"context_line":"            if a_last_char in unit_sizes:"},{"line_number":245,"context_line":"                a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":246,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"83905c4d_e7605fb5","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":9},"in_reply_to":"12302386_e671c10e","updated":"2023-09-05 08:37:35.000000000","message":"I did it to be possible to warn the operator if the one sets an invalid unit. For example, if the last character is numeric, so we should ignore and keep it as it is because it is not using units, so it is a raw number which is also accept by docker. If the last character is not a number, so it is a letter that represents the unit, so we should validate this unit to make sure it is a valid one checking if it is in the unit_sizes, If it is not in the unit sizes, we should warn the operator that the one configured an invalid unit for the dimension.\n\nIf we do not have this check and the last character is an invalid unit, for example \"1t\", then we can warn the operator about the valid units. And if for some reason a new docker release introduces a new unit, like \"t\" for terabytes, and an operator start using this new unit, the one can check this warn and open a ticket to extend this flow, or keep using the old valid units instead of trying to figure out why the containers are always restarting even if nothing changes 😊.\n\nSo this validation is to allow us to warn operators about invalid/not supported units.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"642a6661c861e708d20a19e92ab1038e08c6709c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        warn_msg \u003d (\"The docker dimension unit [%s] is not supported for \""},{"line_number":241,"context_line":"                    \"the dimension [%]. The currently supported units \""},{"line_number":242,"context_line":"                    \"are [\u0027b\u0027, \u0027k\u0027, \u0027m\u0027, \u0027g\u0027].\")"},{"line_number":243,"context_line":"        if not a_last_char.isnumeric():"},{"line_number":244,"context_line":"            if a_last_char in unit_sizes:"},{"line_number":245,"context_line":"                a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":246,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e09c70f6_73db51f9","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":9},"in_reply_to":"83905c4d_e7605fb5","updated":"2023-09-05 08:54:49.000000000","message":"Ack","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dc5e199e3205469f6c5fcab2ccc72cf4d59685f3","unresolved":true,"context_lines":[{"line_number":246,"context_line":"            else:"},{"line_number":247,"context_line":"                LOG.warning(warn_msg, a_last_char, a)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if not b_last_char.isnumeric():"},{"line_number":250,"context_line":"            if b_last_char in unit_sizes:"},{"line_number":251,"context_line":"                b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"},{"line_number":252,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b9db86fe_1cf11d39","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":9},"updated":"2023-09-05 08:04:12.000000000","message":"this check is not necessary, because we already check if `b_last_char` is a member of `unit_sizes`, it\u0027s redundant to also check that it is not numeric.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"642a6661c861e708d20a19e92ab1038e08c6709c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            else:"},{"line_number":247,"context_line":"                LOG.warning(warn_msg, a_last_char, a)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if not b_last_char.isnumeric():"},{"line_number":250,"context_line":"            if b_last_char in unit_sizes:"},{"line_number":251,"context_line":"                b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"},{"line_number":252,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"c16b21dd_9ff4a23c","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":9},"in_reply_to":"556f45d4_180db9e3","updated":"2023-09-05 08:54:49.000000000","message":"Ack","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"333320ce50e58cff3e1a0dc478301f4f2471d8fa","unresolved":true,"context_lines":[{"line_number":246,"context_line":"            else:"},{"line_number":247,"context_line":"                LOG.warning(warn_msg, a_last_char, a)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if not b_last_char.isnumeric():"},{"line_number":250,"context_line":"            if b_last_char in unit_sizes:"},{"line_number":251,"context_line":"                b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"},{"line_number":252,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"556f45d4_180db9e3","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":9},"in_reply_to":"b9db86fe_1cf11d39","updated":"2023-09-05 08:37:35.000000000","message":"the same as above.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"feda7e625f3e80286a2b3e2a4addced7076f49f7","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if a is None or b is None:"},{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"03a9a5fa_b1c140ef","line":234,"updated":"2023-10-03 17:21:18.000000000","message":"Are we sure those logs are going to show up correctly?","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"27fd297560bcbb19809bf51bb0e3fbee25b45344","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if a is None or b is None:"},{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9c82b5_d8d3b97a","line":234,"in_reply_to":"03a9a5fa_b1c140ef","updated":"2023-10-03 19:20:19.000000000","message":"If the appender is set correctly, it should display in the ansible logs (not in the standard output/terminal), there is also some other places that uses log actually in kolla-ansible. \n\nBut something that shows a message to operator direct in the stdout in the ansible running process I do not know, do you know any way to do it?","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"c019a318127a044ab4e48bafc34c2e78751a24cb","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if a is None or b is None:"},{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"bd77a883_d6b16870","line":234,"in_reply_to":"40004e43_ef251edf","updated":"2023-10-10 13:45:44.000000000","message":"Done","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"41ff394c653c7bf033e51e0e2575e6159732a564","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if a is None or b is None:"},{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"40004e43_ef251edf","line":234,"in_reply_to":"571c6791_40478b9a","updated":"2023-10-04 09:37:06.000000000","message":"I see, thanks for the suggestion of using fail_json. I applied it and did some tests. Thanks.","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a1bd6b5eb3f987758b8d3cc9c583af49974126d7","unresolved":true,"context_lines":[{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if a is None or b is None:"},{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"571c6791_40478b9a","line":234,"in_reply_to":"da9c82b5_d8d3b97a","updated":"2023-10-04 06:46:46.000000000","message":"IIRC unfortunately there\u0027s no way to log that to stdout - so module.fail_json would be better","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"feda7e625f3e80286a2b3e2a4addced7076f49f7","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":"        unit_sizes \u003d {"},{"line_number":239,"context_line":"            \u0027b\u0027: 1,"},{"line_number":240,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb828342_e7cd01a6","line":237,"updated":"2023-10-03 17:21:18.000000000","message":"Should we fail here?","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"41ff394c653c7bf033e51e0e2575e6159732a564","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":"        unit_sizes \u003d {"},{"line_number":239,"context_line":"            \u0027b\u0027: 1,"},{"line_number":240,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":6,"id":"77e4ee1a_65ecf74f","line":237,"in_reply_to":"14db666a_b6dc5fc8","updated":"2023-10-04 09:37:06.000000000","message":"Ok, I agree, set this fail_json to fail the ansible process if the dimensions key is no more supported. 😊","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"c019a318127a044ab4e48bafc34c2e78751a24cb","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":"        unit_sizes \u003d {"},{"line_number":239,"context_line":"            \u0027b\u0027: 1,"},{"line_number":240,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":6,"id":"199090ad_9ff6890e","line":237,"in_reply_to":"77e4ee1a_65ecf74f","updated":"2023-10-10 13:45:44.000000000","message":"Done","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"27fd297560bcbb19809bf51bb0e3fbee25b45344","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":"        unit_sizes \u003d {"},{"line_number":239,"context_line":"            \u0027b\u0027: 1,"},{"line_number":240,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":6,"id":"df4f9742_9688de4d","line":237,"in_reply_to":"cb828342_e7cd01a6","updated":"2023-10-03 19:20:19.000000000","message":"Good question, I actually do not know, we thought in only ignore the change and move on with the process, but raising an error could be also an alternative, so the operator could fix the confs and run the ansible again.","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a1bd6b5eb3f987758b8d3cc9c583af49974126d7","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            LOG.warning(\"The dimension [%s] is no more supported by Docker, \""},{"line_number":235,"context_line":"                        \"please remove it from yours configs or change \""},{"line_number":236,"context_line":"                        \"to the new one.\", key)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":"        unit_sizes \u003d {"},{"line_number":239,"context_line":"            \u0027b\u0027: 1,"},{"line_number":240,"context_line":"            \u0027k\u0027: 1024"}],"source_content_type":"text/x-python","patch_set":6,"id":"14db666a_b6dc5fc8","line":237,"in_reply_to":"df4f9742_9688de4d","updated":"2023-10-04 06:46:46.000000000","message":"I think failing here would be better, because the operator can live under the false assumption it\u0027s configured - especially that LOG.warning is only showing that in ansible log - not on stdout.","commit_id":"aaa6d83b212916ac144ddf36c4bde27a9d637b71"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"830b436b3b5b67384f8a995b1c2dd7fbbbb80483","unresolved":true,"context_lines":[{"line_number":256,"context_line":"            if a_last_char in unit_sizes:"},{"line_number":257,"context_line":"                a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                LOG.warning(warn_msg, a_last_char, a)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if not b_last_char.isnumeric():"},{"line_number":262,"context_line":"            if b_last_char in unit_sizes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb7df5ab_f5891ba7","line":259,"range":{"start_line":259,"start_character":20,"end_line":259,"end_character":27},"updated":"2023-10-10 07:59:49.000000000","message":"why are we only issuing a warning and not an error if something is not supported?","commit_id":"06f15e5dffe75ae2c214d2489c0ad5fc79f79bae"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"43f8e08065c72bcd569e4c72727005fe2cd26f15","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            if a_last_char in unit_sizes:"},{"line_number":257,"context_line":"                a \u003d str(int(a[:-1]) * unit_sizes[a_last_char])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                LOG.warning(warn_msg, a_last_char, a)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if not b_last_char.isnumeric():"},{"line_number":262,"context_line":"            if b_last_char in unit_sizes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"154d5eaf_e86eff5f","line":259,"range":{"start_line":259,"start_character":20,"end_line":259,"end_character":27},"in_reply_to":"eb7df5ab_f5891ba7","updated":"2023-10-10 13:45:25.000000000","message":"yes, it makes sense, as we are throwing error when the key is not valid, we should do the same for invalid units.","commit_id":"06f15e5dffe75ae2c214d2489c0ad5fc79f79bae"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"830b436b3b5b67384f8a995b1c2dd7fbbbb80483","unresolved":true,"context_lines":[{"line_number":262,"context_line":"            if b_last_char in unit_sizes:"},{"line_number":263,"context_line":"                b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"},{"line_number":264,"context_line":"            else:"},{"line_number":265,"context_line":"                LOG.warning(warn_msg, b_last_char, b)"},{"line_number":266,"context_line":"        return a !\u003d b"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def compare_dimensions(self, container_info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"38a05b6c_964d4383","line":265,"range":{"start_line":265,"start_character":20,"end_line":265,"end_character":27},"updated":"2023-10-10 07:59:49.000000000","message":"why are we only issuing a warning and not an error if something is not supported?","commit_id":"06f15e5dffe75ae2c214d2489c0ad5fc79f79bae"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"43f8e08065c72bcd569e4c72727005fe2cd26f15","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            if b_last_char in unit_sizes:"},{"line_number":263,"context_line":"                b \u003d str(int(b[:-1]) * unit_sizes[b_last_char])"},{"line_number":264,"context_line":"            else:"},{"line_number":265,"context_line":"                LOG.warning(warn_msg, b_last_char, b)"},{"line_number":266,"context_line":"        return a !\u003d b"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def compare_dimensions(self, container_info):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1976f45f_d9214583","line":265,"range":{"start_line":265,"start_character":20,"end_line":265,"end_character":27},"in_reply_to":"38a05b6c_964d4383","updated":"2023-10-10 13:45:25.000000000","message":"Ack","commit_id":"06f15e5dffe75ae2c214d2489c0ad5fc79f79bae"}],"tests/kolla_docker_tests/test_docker_worker.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"642a6661c861e708d20a19e92ab1038e08c6709c","unresolved":true,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"a1a577af_7527ae9c","line":1399,"range":{"start_line":1399,"start_character":26,"end_line":1399,"end_character":29},"updated":"2023-09-05 08:54:49.000000000","message":"1m","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a52b645b2e628791acbd4a2c221ea9f79d757d3a","unresolved":true,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3b5880a4_11ca0445","line":1399,"range":{"start_line":1399,"start_character":26,"end_line":1399,"end_character":29},"in_reply_to":"a1a577af_7527ae9c","updated":"2023-09-05 09:16:50.000000000","message":"Hi Sven, Is there any special reason to change it to \u00271m\u0027 ?","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dffa2bb6366781ac5758c16e919e7ae5261901e0","unresolved":false,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa2c7213_6545e355","line":1399,"range":{"start_line":1399,"start_character":26,"end_line":1399,"end_character":29},"in_reply_to":"a1a577af_7527ae9c","updated":"2023-09-05 09:17:11.000000000","message":"nvm, this is the \"changed\" test case.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"642a6661c861e708d20a19e92ab1038e08c6709c","unresolved":true,"context_lines":[{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"},{"line_number":1403,"context_line":"            \u0027CpuPeriod\u0027: 0, \u0027KernelMemory\u0027: 0, \u0027Memory\u0027: 1024, \u0027CpuQuota\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"267026c6_9476e875","line":1400,"range":{"start_line":1400,"start_character":30,"end_line":1400,"end_character":32},"updated":"2023-09-05 08:54:49.000000000","message":"2g","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a52b645b2e628791acbd4a2c221ea9f79d757d3a","unresolved":true,"context_lines":[{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"},{"line_number":1403,"context_line":"            \u0027CpuPeriod\u0027: 0, \u0027KernelMemory\u0027: 0, \u0027Memory\u0027: 1024, \u0027CpuQuota\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a77b653_29423ff4","line":1400,"range":{"start_line":1400,"start_character":30,"end_line":1400,"end_character":32},"in_reply_to":"267026c6_9476e875","updated":"2023-09-05 09:16:50.000000000","message":"The same here, is there any specific reason to change this value to \u00272g\u0027? I mean it could be any valid values which is different from 3g, as the test here is to make sure that the function can detect changes when using the docker dimensions short notation. 😊","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dffa2bb6366781ac5758c16e919e7ae5261901e0","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"    def test_compare_dimensions_using_short_notation_changed(self):"},{"line_number":1398,"context_line":"        self.fake_data[\u0027params\u0027][\u0027dimensions\u0027] \u003d {"},{"line_number":1399,"context_line":"            \u0027mem_limit\u0027: \u002710m\u0027, \u0027mem_reservation\u0027: \u00273M\u0027,"},{"line_number":1400,"context_line":"            \u0027memswap_limit\u0027: \u00271g\u0027}"},{"line_number":1401,"context_line":"        container_info \u003d dict()"},{"line_number":1402,"context_line":"        container_info[\u0027HostConfig\u0027] \u003d {"},{"line_number":1403,"context_line":"            \u0027CpuPeriod\u0027: 0, \u0027KernelMemory\u0027: 0, \u0027Memory\u0027: 1024, \u0027CpuQuota\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c92fefb1_65ba6237","line":1400,"range":{"start_line":1400,"start_character":30,"end_line":1400,"end_character":32},"in_reply_to":"267026c6_9476e875","updated":"2023-09-05 09:17:11.000000000","message":"nvm, this is the \"changed\" test case.","commit_id":"7e420b89a93ec5fceeab39f16bad5206e73b5aaa"}]}