)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"25865835ef052e827108db6f17b8e9769e5eba60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68815d44_e8f7bbc7","updated":"2023-06-21 10:19:26.000000000","message":"Adam, you also should add the line\nRelated-Bug: #2024554\nin the commit message","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"76e65ba17c848b690d5c4423b4ea6a4f149a217b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33d11791_c34e8025","updated":"2023-06-21 10:06:12.000000000","message":"same question as https://review.opendev.org/c/openstack/kolla-ansible/+/886583 , but i still don\u0027t understand how you can colid.","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e93c70117a854d7980fe4fc6ea452c0ffdecfbd3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ecf9a5c_b4add467","in_reply_to":"2f05cb8c_7af9a73b","updated":"2023-06-21 10:19:57.000000000","message":"Ok, understand, so in your setup you are now using config override in /etc/kolla/config/proxysql/proxysql.yaml ?","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"90ab862bcd0f81d71aeb3d0b2bdd9bc54d290526","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f05cb8c_7af9a73b","in_reply_to":"33d11791_c34e8025","updated":"2023-06-21 10:14:42.000000000","message":"So reasoning for this one is that if I have mariadb listen on say 3307 because I want proxysql listen on both the VIP and local ip on 3306 for containers to use. The current template assumes database_port is used which will be 3306.\n\nI switched this template to use mariadb_port as by default this just points to database_port anyway and is only changed if explicitly stated so shouldn\u0027t affect default behaviour.\n\nAny questions tho feel free","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"e47b11bb01eb7f742b33e013a4510b343b739951","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b88988e6_3db3e17c","in_reply_to":"4ecf9a5c_b4add467","updated":"2023-06-21 10:21:41.000000000","message":"Yeah in my setup I am overriding the config provided by kolla with the same change. Just thought the change to the above would be useful upstream also hence pushing up.","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"53f431bf287cc3f1c6f99e9f9b4bf238900add38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6af4824_461bade9","in_reply_to":"5db36f4c_470e4f81","updated":"2023-06-21 14:34:47.000000000","message":"Added release notes, hopefully it is all in order","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ea9544f05bd9a78cdf3d3d67c3f23b9c79d3bfaa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fa341a8_1de4c476","in_reply_to":"68815d44_e8f7bbc7","updated":"2023-06-21 14:37:31.000000000","message":"don\u0027t forgot this","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"c2c9031ed6e6fa39b7d4be6ef5b780d57721a9ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecbf906e_f136d3eb","in_reply_to":"8fa341a8_1de4c476","updated":"2023-06-21 14:38:44.000000000","message":"Yeah wasn\u0027t sure if it should be included or not. Thanks added","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a84af03c049b474c27a3a16d50a66f4b51594dfb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5db36f4c_470e4f81","in_reply_to":"b88988e6_3db3e17c","updated":"2023-06-21 10:26:29.000000000","message":"yes, agree, actually database_port was introduced as frontend port for haproxy, and mariadb_port for backend host here [1]\n\n[1] releasenotes/notes/fix-haproxy-database-port-mapping-46bdf2a0ffc253c7.yaml\n\nSo, I am ok with this patch.\n\nPlease, add release note for this change and examine usage.\n\n\nhttps://docs.openstack.org/kolla-ansible/latest/contributor/release-notes.html\n\n+ check other releasenotes for inspiration","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"5acc1a05907a4cdd6b5bacbde8728bc309731560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc647170_558b04d8","in_reply_to":"e6af4824_461bade9","updated":"2023-06-21 15:31:34.000000000","message":"Done","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"5acc1a05907a4cdd6b5bacbde8728bc309731560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d09876ea_16321603","in_reply_to":"ecbf906e_f136d3eb","updated":"2023-06-21 15:31:34.000000000","message":"Done","commit_id":"ff51904bb4db980f4a434702b0397093514ddb32"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1f0a8330bf530b8f437343f47d95a1bd5062cb1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0e5726c_752f1a58","updated":"2023-08-21 13:44:56.000000000","message":"I think this needs https://review.opendev.org/c/openstack/kolla-ansible/+/886581 in order to work but I don\u0027t think I see this reflected in gerrit? apologies if I missed something.\n\notherwise LGTM","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"1fb8cc7c0379193b0b82804992f22bf675743cdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ee9f3a6_1defcfed","updated":"2023-08-21 07:55:29.000000000","message":"Not sure why this is in the \"my turn\" column. I seem to be just waiting for another review I think","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6b3e8150e49b956aca3cae3d744aa157f9bbf9b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9a44d85_d355513a","updated":"2024-10-02 15:18:12.000000000","message":"merging as this is really trivial","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"267dea349a3ccff8c9bc75f3f881d9f7bf3ce140","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75e05f68_135f0c36","updated":"2024-09-20 23:14:08.000000000","message":"ping","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3d275fc52c79d438b53e02a2599a49b593ffdd92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fa3a2fc_72509825","in_reply_to":"5437e4bb_abf8a883","updated":"2023-08-22 14:50:03.000000000","message":"I just was under the impression the bugfix was needed for this to work, but I guess I was just wrong.\n\nI\u0027m happy to keep seperate changes separate, resolved for me, if no one else objects.","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"46af7958eb4e6d6592e440e77c84581b1d0dd4eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f960852f_ce75662f","in_reply_to":"c0e5726c_752f1a58","updated":"2023-08-21 14:40:37.000000000","message":"two different things, but it would be better to change port in one commit maybe..but I am also ok to have it like this, maybe rebase against second review to have patches stacked in Gerrit ?","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"},{"author":{"_account_id":36114,"name":"Adam Stackhouse","display_name":"adstak","email":"adstak@gmail.com","username":"adstak","status":"Godaddy"},"change_message_id":"105e997df9928159e6787c30b047ae0fc1a824dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5437e4bb_abf8a883","in_reply_to":"f960852f_ce75662f","updated":"2023-08-22 11:07:46.000000000","message":"They are separate changes though similar. They both set the same variable but this one is specifically for setups in proxysql which want to use different ports for the backend dbs while the other change is more of a bug to fix tests when other ports are used.\n\nI would consider this a feature/ quality of life change and the other a bug fix. However happy to do it how ever you prefer? Can rebase or keep separate","commit_id":"675b040b3b32f8426819bd67d1f4ffef993559b0"}]}