)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eca08b46adcf26d33052ba8d4ea71b187629d2a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"859376c9_193cf3a3","updated":"2023-06-22 12:59:19.000000000","message":"if this is an issue, please create the bug report and attach it","commit_id":"50112267dd1d9d7eff18f50f930c71a06508cd1f"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"5871aeb835a37535166050dc6aacc0ad9c866151","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1696c7cf_468207cc","updated":"2023-08-02 09:29:36.000000000","message":"Thanks for this findings !","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0a41071d036052691d40b2f1589baa96f9651721","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"295831ee_ac39ac25","updated":"2023-08-30 15:19:04.000000000","message":"this change is missing a release note as it changes the default behaviour which might be surprising for existing users.","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bbb7dd614fc3e646f60078c0874b184262d59bf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1617627_24e3c9a5","in_reply_to":"295831ee_ac39ac25","updated":"2023-08-30 15:22:26.000000000","message":"no exactly, it binds only ip not 0.0.0.0, so it will not break anything.\nyou can made backports to 2023.1 and zed where it needed too and add releasenote if so?","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"beae950de10084e3efa3d1d0231edd9d190d8db0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2698288_7d133631","in_reply_to":"49b71b80_b6467ad9","updated":"2023-08-30 15:42:37.000000000","message":"yep, it should be bound only on api interface. the author was so lazy to do so. this is fixes the issue which can (in some cases) lead to security problem too)","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4aa75409d5f004e343a695db6c2afa560376fb4c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49b71b80_b6467ad9","in_reply_to":"a1617627_24e3c9a5","updated":"2023-08-30 15:38:29.000000000","message":"that is the point! before it was bound on _all_ interfaces, now only on api_interface.\n\nsee: https://www.baeldung.com/linux/difference-ip-address#1-server-listening-interface\n\nthis is at least a difference in behaviour. We could maybe argue that we don\u0027t support any configuration other than the api interface, but is that documented somewhere?\n\nI can imagine a scenario where a user uses some internal only IP address that is not the api interface to use ironic tftp.\n\nI sometimes wish reviews wouldn\u0027t be so fast.","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fe100de89cd534d05ac467d81557723acc5121d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f24efd00_2b16cbdb","in_reply_to":"b2698288_7d133631","updated":"2023-08-30 15:44:03.000000000","message":"can you write some text for releasenote as followup? we cherry-pick both in stable branches as one change later.","commit_id":"81948f5b16babde3b77af4c8af5ee9dbb8d7fcc3"}]}