)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f6f8be6b68dc9d039b63341267e6be2e03dca3ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"90045e99_5ef16529","updated":"2023-06-27 11:45:41.000000000","message":"The other approach is to allow disabling keepalived script and use that in CI, opinions?","commit_id":"6560f4cbc23c04f6fc279e72858cdaddbb21e70b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83c012b612e5445020a9dd3dfc162d816c5654b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9347b34b_aab8cdc1","in_reply_to":"90045e99_5ef16529","updated":"2023-06-27 12:21:56.000000000","message":"actually check_alive script might be failing due to some other reasons than unavailability of haproxy (or lack of response) - so allow disabling script is probably better","commit_id":"6560f4cbc23c04f6fc279e72858cdaddbb21e70b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cc5091346e34d8be3c2feb9c237c5ba3d7252b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5c0fa12_d520063b","in_reply_to":"9347b34b_aab8cdc1","updated":"2023-06-27 20:10:35.000000000","message":"Done","commit_id":"6560f4cbc23c04f6fc279e72858cdaddbb21e70b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9e9ce2be20f1364cbb4239b94558863eeff7f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eef47577_917afbde","updated":"2023-06-27 17:26:50.000000000","message":"Add a reno mentioning the new var? Not sure whether there\u0027s a usecase other than single-node CI envs though","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"90661ecca4161525a4a83de3a8258de16bf83de9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"926a7cf2_aa0b1f79","updated":"2023-06-28 10:58:44.000000000","message":"zun and cephadm upgrade jobs are being worked on the next patchset in chain","commit_id":"a0e614ee10937eb0930d1c5481293a6d2dc8d915"}],"ansible/roles/loadbalancer/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9e9ce2be20f1364cbb4239b94558863eeff7f05","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"kolla_externally_managed_cert: False"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"keepalived_track_script: True"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bac0ec80_994d53da","line":150,"updated":"2023-06-27 17:26:50.000000000","message":"A small comment would be useful?","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cc5091346e34d8be3c2feb9c237c5ba3d7252b00","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"kolla_externally_managed_cert: False"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"keepalived_track_script: True"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"56a5bf90_41677426","line":150,"in_reply_to":"bac0ec80_994d53da","updated":"2023-06-27 20:10:35.000000000","message":"Done","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9edab00306ebfcbe67c4fc6397694ae540d0344b","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# Allow to disable keepalived tracking script (e.g. for single node environments"},{"line_number":151,"context_line":"# where this proves problematic in some cases)"},{"line_number":152,"context_line":"keepalived_track_script: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"43c17fd3_b13f45d9","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":23},"updated":"2023-06-28 07:55:19.000000000","message":"imho \"keepalived_track_script_enabled\" would be more clear/precise?","commit_id":"a6e15d7cf29879a2d512b5dc3ebbb769c3f61bfe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1c886780b0e548e74b39a92436c56d6f0bfefad6","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# Allow to disable keepalived tracking script (e.g. for single node environments"},{"line_number":151,"context_line":"# where this proves problematic in some cases)"},{"line_number":152,"context_line":"keepalived_track_script: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8986b47f_26d6dd3b","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":23},"in_reply_to":"35ae73b0_3e5ebda3","updated":"2023-06-28 09:05:30.000000000","message":"That actually might be misleading, so let\u0027s go with keepalived_track_script_enabled ;-)","commit_id":"a6e15d7cf29879a2d512b5dc3ebbb769c3f61bfe"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d6d07b44c1a6deee9f51969338709f19b146f4bf","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"# Allow to disable keepalived tracking script (e.g. for single node environments"},{"line_number":151,"context_line":"# where this proves problematic in some cases)"},{"line_number":152,"context_line":"keepalived_track_script: True"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"35ae73b0_3e5ebda3","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":23},"in_reply_to":"43c17fd3_b13f45d9","updated":"2023-06-28 08:55:38.000000000","message":"I would say keepalived_health_probe_script or something similar ... but I don\u0027t care","commit_id":"a6e15d7cf29879a2d512b5dc3ebbb769c3f61bfe"}],"ansible/roles/loadbalancer/tasks/config.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9e9ce2be20f1364cbb4239b94558863eeff7f05","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  become: true"},{"line_number":99,"context_line":"  with_dict: \"{{ loadbalancer_services }}\""},{"line_number":100,"context_line":"  when:"},{"line_number":101,"context_line":"    - groups[service.group] | length \u003e 1"},{"line_number":102,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":103,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":104,"context_line":"    - item.key !\u003d \u0027keepalived\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"321689b9_9b229405","line":101,"updated":"2023-06-27 17:26:50.000000000","message":"I think you want to use the new var here?","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cc5091346e34d8be3c2feb9c237c5ba3d7252b00","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  become: true"},{"line_number":99,"context_line":"  with_dict: \"{{ loadbalancer_services }}\""},{"line_number":100,"context_line":"  when:"},{"line_number":101,"context_line":"    - groups[service.group] | length \u003e 1"},{"line_number":102,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":103,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":104,"context_line":"    - item.key !\u003d \u0027keepalived\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"74e8a797_00dbada9","line":101,"in_reply_to":"321689b9_9b229405","updated":"2023-06-27 20:10:35.000000000","message":"That\u0027s not needed at all since we don\u0027t use the script at all in the template.","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9e9ce2be20f1364cbb4239b94558863eeff7f05","unresolved":true,"context_lines":[{"line_number":204,"context_line":"{% endif %}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"{% if groups[\u0027all\u0027] | length \u003d\u003d 1 %}"},{"line_number":207,"context_line":"keepalived_track_script: false"},{"line_number":208,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"43f488a7_6e3cd8d9","line":207,"updated":"2023-06-27 17:26:50.000000000","message":"Why not use yes/no like everywhere else?\nAlso missing newline at the end of the file","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cc5091346e34d8be3c2feb9c237c5ba3d7252b00","unresolved":false,"context_lines":[{"line_number":204,"context_line":"{% endif %}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"{% if groups[\u0027all\u0027] | length \u003d\u003d 1 %}"},{"line_number":207,"context_line":"keepalived_track_script: false"},{"line_number":208,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9d15df88_b8f26eed","line":207,"in_reply_to":"43f488a7_6e3cd8d9","updated":"2023-06-27 20:10:35.000000000","message":"Done","commit_id":"37ecb0d879f6c5922d55ff2b772a4d72a9ffa946"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"97b910c441f8acc3f3acac27e456d91d746d2a26","unresolved":true,"context_lines":[{"line_number":203,"context_line":"enable_venus: \"yes\""},{"line_number":204,"context_line":"{% endif %}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"{% if groups[\u0027all\u0027] | length \u003d\u003d 1 %}"},{"line_number":207,"context_line":"keepalived_track_script_enabled: \"no\""},{"line_number":208,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"da7c7d61_4857756f","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":36},"updated":"2023-06-28 11:05:22.000000000","message":"I know that in zuul it does not matter if you specify groups[\u0027all\u0027] or groups[\u0027loadbalancer\u0027] as there is only one node for openstack and on the same node kolla-ansible is installed. But i think it\u0027s better to specify groups[\u0027loadbalancer\u0027], for someone globals-default.j2 can be a reference for single deployment and it\u0027s better to specify loadbalancer group, what do you think ?","commit_id":"a0e614ee10937eb0930d1c5481293a6d2dc8d915"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fed88d3929d7fa7c2d498b476f4abb82e985d371","unresolved":false,"context_lines":[{"line_number":203,"context_line":"enable_venus: \"yes\""},{"line_number":204,"context_line":"{% endif %}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"{% if groups[\u0027all\u0027] | length \u003d\u003d 1 %}"},{"line_number":207,"context_line":"keepalived_track_script_enabled: \"no\""},{"line_number":208,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"46164379_0b03a1c4","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":36},"in_reply_to":"da7c7d61_4857756f","updated":"2023-06-28 11:35:24.000000000","message":"In general I agree, but this template is in the tests/ folder which is only for CI, so IMO this is fine.","commit_id":"a0e614ee10937eb0930d1c5481293a6d2dc8d915"}]}