)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bbb9893549d29845af57958619d3c2a8ce3123c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"111dd93a_c650e99d","updated":"2023-07-04 10:14:14.000000000","message":"why two issues in one change?","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5383589b03759652d95f945aaef16a0fc4502307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80810b01_09b4a7b9","in_reply_to":"111dd93a_c650e99d","updated":"2023-07-04 10:24:48.000000000","message":"ack, split this into two patches","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"},{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"79aa04c1b6dd71933cb1316f46c6acca6e271e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bc1f8267_fb014309","in_reply_to":"80810b01_09b4a7b9","updated":"2023-07-04 12:33:20.000000000","message":"both horizon and skyline are not working when openid federation is enabled, this pr is fixing it, not sure why splitting is a way to go","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"}],"ansible/roles/horizon/templates/local_settings.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bbb9893549d29845af57958619d3c2a8ce3123c0","unresolved":true,"context_lines":[{"line_number":224,"context_line":"# Do not remove the mandatory credentials mechanism."},{"line_number":225,"context_line":"# Note: The last two tuples are sample mapping keys to a identity provider"},{"line_number":226,"context_line":"# and federation protocol combination (WEBSSO_IDP_MAPPING)."},{"line_number":227,"context_line":"WEBSSO_KEYSTONE_URL \u003d \"{{ keystone_public_url }}/v3\""},{"line_number":228,"context_line":"WEBSSO_CHOICES \u003d ("},{"line_number":229,"context_line":"    (\"credentials\", _(\"Keystone Credentials\")),"},{"line_number":230,"context_line":"    {% for idp in keystone_identity_providers %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"95440e6b_8f2935e9","line":227,"updated":"2023-07-04 10:14:14.000000000","message":"why /v3 is not part of keystone_public_url?","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"},{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"79aa04c1b6dd71933cb1316f46c6acca6e271e3a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"# Do not remove the mandatory credentials mechanism."},{"line_number":225,"context_line":"# Note: The last two tuples are sample mapping keys to a identity provider"},{"line_number":226,"context_line":"# and federation protocol combination (WEBSSO_IDP_MAPPING)."},{"line_number":227,"context_line":"WEBSSO_KEYSTONE_URL \u003d \"{{ keystone_public_url }}/v3\""},{"line_number":228,"context_line":"WEBSSO_CHOICES \u003d ("},{"line_number":229,"context_line":"    (\"credentials\", _(\"Keystone Credentials\")),"},{"line_number":230,"context_line":"    {% for idp in keystone_identity_providers %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"95bc3b94_33de594b","line":227,"in_reply_to":"59dc2a38_ff927d92","updated":"2023-07-04 12:33:20.000000000","message":"no, the problem is elsewhere, apache locations are prefixed with /v3, see https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/keystone/templates/wsgi-keystone.conf.j2#L90","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5383589b03759652d95f945aaef16a0fc4502307","unresolved":true,"context_lines":[{"line_number":224,"context_line":"# Do not remove the mandatory credentials mechanism."},{"line_number":225,"context_line":"# Note: The last two tuples are sample mapping keys to a identity provider"},{"line_number":226,"context_line":"# and federation protocol combination (WEBSSO_IDP_MAPPING)."},{"line_number":227,"context_line":"WEBSSO_KEYSTONE_URL \u003d \"{{ keystone_public_url }}/v3\""},{"line_number":228,"context_line":"WEBSSO_CHOICES \u003d ("},{"line_number":229,"context_line":"    (\"credentials\", _(\"Keystone Credentials\")),"},{"line_number":230,"context_line":"    {% for idp in keystone_identity_providers %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"59dc2a38_ff927d92","line":227,"in_reply_to":"95440e6b_8f2935e9","updated":"2023-07-04 10:24:48.000000000","message":"because the /v3 is the version selector within the API, it is not part of the endpoint\n\nthe real question is why the websso implemention fails to do proper version detection. to me this looks like a bug in horizon which should be reported there. we can still add the workaround here, but should add a comment and a bug reference","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5383589b03759652d95f945aaef16a0fc4502307","unresolved":true,"context_lines":[{"line_number":150,"context_line":"  - admin"},{"line_number":151,"context_line":"skyline_system_reader_roles:"},{"line_number":152,"context_line":"  - system_reader"},{"line_number":153,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":154,"context_line":"skyline_use_keystone_public_url: \"{% if keystone_enable_federation_openid | bool %}true{% else %}false{% endif %}\""},{"line_number":155,"context_line":"skyline_session_name: session"},{"line_number":156,"context_line":"skyline_reclaim_instance_interval: 604800"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"421b828b_41de4cad","line":153,"updated":"2023-07-04 10:24:48.000000000","message":"same as for horizon, this is a bug in skyline IMO\n\nalso instead of this complicated logic, we maybe want to switch to using the public endpoint by default?","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"},{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"79aa04c1b6dd71933cb1316f46c6acca6e271e3a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"  - admin"},{"line_number":151,"context_line":"skyline_system_reader_roles:"},{"line_number":152,"context_line":"  - system_reader"},{"line_number":153,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":154,"context_line":"skyline_use_keystone_public_url: \"{% if keystone_enable_federation_openid | bool %}true{% else %}false{% endif %}\""},{"line_number":155,"context_line":"skyline_session_name: session"},{"line_number":156,"context_line":"skyline_reclaim_instance_interval: 604800"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b2766d22_22583ab7","line":153,"in_reply_to":"421b828b_41de4cad","updated":"2023-07-04 12:33:20.000000000","message":"why? as a user/admin I want to have an option to use internal keystone endpoint, its the same case as for horizon_use_keystone_public_url","commit_id":"0b3940c79295b75d192f1b3653e2b1a4828078e1"}]}