)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"ac21c9cde1b1c35fbe0d050987cba51985a8181a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"723845e6_266db5c5","updated":"2023-07-12 10:12:56.000000000","message":"Note to reviewers: currently the -zun non-voting tests trigger some of this codepath. etcd needs 3 controllers to operate normally, and doing an add-node was the way we discovered the issue.","commit_id":"7b2576ca30bfc308c1c54a740a18f6f330e18301"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"3f0fdfad1429235311819eecfb81a3a3fc620aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2d2e8b13_38e45505","updated":"2023-08-07 15:49:52.000000000","message":"recheck (keystone error on rocky)","commit_id":"d3dcc1d4040f4691ec3c864a99878a0f6158bce9"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"df5a30b46a6bbe0100bb1d33544236ee89db9f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30eb2652_f1b53c61","updated":"2023-09-06 12:38:14.000000000","message":"Good news is that much of this workflow is tested and passing on the cephadm upgrade jobs. They still have unrelated flakiness (but seem to be more stable now). So this series (up till https://review.opendev.org/c/openstack/kolla-ansible/+/890465 ) has only one known regression (dropping support for zun, when etcd\u0027s version gets bumped).","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"72c557cdd21d6eb3a48067c16718071a62aaa6ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c9a4fe17_a05e4c21","updated":"2023-09-11 09:34:34.000000000","message":"LGTM aside from these comments","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"988df907763a3d3adef85ab795a3e41630f8f280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91b1cb2e_d5bbb0ee","updated":"2023-11-17 11:02:16.000000000","message":"agreeing with the comments, looking forward to the new patchset.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"07b9afd58a8e1169dc95042f80b4d79194d6eafc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5b425481_0e38cbeb","in_reply_to":"30eb2652_f1b53c61","updated":"2023-09-11 07:41:53.000000000","message":"the dropped support for zun must be mentioned in the relnotes, please. at least I didn\u0027t find it, but it\u0027s possible I\u0027ve lost track of it across all the reviews on this topic 😊","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2357a2ab3c5b90be7694484e306c35c02fda574c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"baca6d4b_f61b7a24","in_reply_to":"34fd525e_e3205d30","updated":"2023-09-11 14:28:00.000000000","message":"Ack","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8efa9a9a0fcad577b97bfd207b634f337c82e9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6681b805_90eba93f","in_reply_to":"5b425481_0e38cbeb","updated":"2023-09-11 07:44:10.000000000","message":"If we are dropping zun support - then we should remove all remnants of it - or we\u0027re leaving old etcd called etcd-zun and rework zun to use it, and then upgrade the usual etcd.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"aba9ca79aeb98493a521a86e94e652e7a491bcd5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e205268a_9916df9f","in_reply_to":"6681b805_90eba93f","updated":"2023-09-11 09:22:03.000000000","message":"Leaving two parallel versions of etcd would be a high bar in my opinion :-( \n\nThe two reviews in this series are useful regardless of the etcd upgrade, but I think it\u0027s worth discussing the path forward for zun (and etcd).","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"407c67241ea60f481f2f9da0420538095a655434","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34fd525e_e3205d30","in_reply_to":"e205268a_9916df9f","updated":"2023-09-11 09:25:31.000000000","message":"@Sven this review and https://review.opendev.org/c/openstack/kolla-ansible/+/890208 don\u0027t affect zun or etcd versions, but they\u0027re very useful if the etcd version ever gets upgraded.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"054da33e076eb67dd9c4fe0bcadd661ee254a3d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dd46fa4e_6642f3e5","updated":"2023-11-28 17:37:51.000000000","message":"cephadm jobs are broken by this:\n\nERROR! couldn\u0027t resolve module/action \u0027kolla_docker\u0027. This often indicates a misspelling, missing collection, or incorrect module path.","commit_id":"6527cb6a83f685ff07b0c7c4ae6b34826e28475c"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"596bb9d493a94d195831aaa6c6dc0e1e5db49f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"84f8aeaf_c52ccbf5","updated":"2023-11-28 17:43:12.000000000","message":"yeah needs a sed s/kolla_docker/kolla_container/ and the voting paths don\u0027t exercise these.","commit_id":"6527cb6a83f685ff07b0c7c4ae6b34826e28475c"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"4c00c0224b7bd6639a5155f849924bf326973f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"80308eb9_dc362b17","updated":"2023-11-28 17:44:32.000000000","message":"yell if you want me to do the rename and doublecheck, I can squeeze in a few minutes tomorrow.","commit_id":"6527cb6a83f685ff07b0c7c4ae6b34826e28475c"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"92884e295968987176199ed393216afd9d3d9699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b83a2c46_3cbcc717","updated":"2023-11-28 21:19:49.000000000","message":"Aaah cephadm is going to keep breaking because etcd\u0027s already been upgraded.\n\nWith https://review.opendev.org/c/openstack/kolla/+/890464 merged we need this change too before it will pass: https://review.opendev.org/c/openstack/kolla-ansible/+/890465/11/ansible/roles/cinder/templates/cinder.conf.j2","commit_id":"ed3b27cc923144a9f437e931a5af3571e801ea33"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c83c61d53b7fb4e37a14cf4c999264978de1c3e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"92662fa2_ac5333bc","updated":"2023-11-29 05:06:22.000000000","message":"o.k., so since we don\u0027t want to revert the change in kolla, let\u0027s move forward and get this whole stack merged\n\nre-applying previous +2 since I only did a trivial fix","commit_id":"ed3b27cc923144a9f437e931a5af3571e801ea33"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f7cc2cd72e146a7346a85afe4e7558585b3f02f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aec82c1f_fdb34fba","updated":"2023-11-29 07:09:10.000000000","message":"recheck (debian/ubuntu mysql errors)","commit_id":"ed3b27cc923144a9f437e931a5af3571e801ea33"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8964988190bd1c3121248fcf0f14215bf0885d38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7b600e40_742ea666","updated":"2023-11-29 07:08:31.000000000","message":"reverify (debian/ubuntu mysql errors)","commit_id":"ed3b27cc923144a9f437e931a5af3571e801ea33"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"48733b2622db18eda4fe283716e1ca612e6fed74","unresolved":true,"context_lines":[{"line_number":337,"context_line":"etcd_peer_port: \"2380\""},{"line_number":338,"context_line":"etcd_enable_tls: \"{{ kolla_enable_tls_backend }}\""},{"line_number":339,"context_line":"etcd_protocol: \"{{ \u0027https\u0027 if etcd_enable_tls | bool else \u0027http\u0027 }}\""},{"line_number":340,"context_line":"etcd_remove_deleted_members: \"no\""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"fluentd_syslog_port: \"5140\""},{"line_number":343,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d5155855_a5c2d10e","line":340,"updated":"2023-08-07 13:22:09.000000000","message":"why not in etcd role defaults?","commit_id":"d3dcc1d4040f4691ec3c864a99878a0f6158bce9"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"fe546c11e669d3de54e73e32c9c77fe840230fe8","unresolved":false,"context_lines":[{"line_number":337,"context_line":"etcd_peer_port: \"2380\""},{"line_number":338,"context_line":"etcd_enable_tls: \"{{ kolla_enable_tls_backend }}\""},{"line_number":339,"context_line":"etcd_protocol: \"{{ \u0027https\u0027 if etcd_enable_tls | bool else \u0027http\u0027 }}\""},{"line_number":340,"context_line":"etcd_remove_deleted_members: \"no\""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"fluentd_syslog_port: \"5140\""},{"line_number":343,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2c4dca44_9f43ded9","line":340,"in_reply_to":"d5155855_a5c2d10e","updated":"2023-08-08 13:27:27.000000000","message":"Yeah, it makes more sense there, thanks, will add that in the next respin","commit_id":"d3dcc1d4040f4691ec3c864a99878a0f6158bce9"}],"ansible/roles/etcd/tasks/bootstrap_cluster.yml":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"ed430a0639324589b3cc3d702757960910cb41d3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  register: result"},{"line_number":56,"context_line":"  until:"},{"line_number":57,"context_line":"    - result is success"},{"line_number":58,"context_line":"    - \u0027\"is healthy\" in result.stdout\u0027"},{"line_number":59,"context_line":"  retries: 10"},{"line_number":60,"context_line":"  delay: 6"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9cf7c99f_302f4404","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":37},"updated":"2023-07-09 19:51:34.000000000","message":"Note to reviewers: previous versions of etcd did not emit json for `etcd endpoint health`.","commit_id":"af522dd70924dfb392b365a8ff1821e5ad75aa53"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"72c557cdd21d6eb3a48067c16718071a62aaa6ef","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":26,"context_line":"      ETCD_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":27,"context_line":"      ETCD_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":28,"context_line":"      ETCD_PEER_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":29,"context_line":"      ETCD_PEER_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":30,"context_line":"    image: \"{{ service.image }}\""},{"line_number":31,"context_line":"    name: \"{{ service.container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b47aca20_6f66188f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":25},"updated":"2023-09-11 09:34:34.000000000","message":"is the peer cert file really supposed to be the same as the cert file?\nI don\u0027t know enough about this part of etcd to answer this myself.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"76926a6bf1fcdb85184dfcfbc19cf4483bf09680","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":26,"context_line":"      ETCD_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":27,"context_line":"      ETCD_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":28,"context_line":"      ETCD_PEER_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":29,"context_line":"      ETCD_PEER_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":30,"context_line":"    image: \"{{ service.image }}\""},{"line_number":31,"context_line":"    name: \"{{ service.container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"56096e77_0348f83c","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":25},"in_reply_to":"679c9355_c4cf6ee5","updated":"2023-09-11 10:07:32.000000000","message":"Thanks for the provided context. If this was done this way in the past I can see the difficulty in changing this.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"c6b4fb6142e5a9bbd61d67987de57a76992a54f5","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":26,"context_line":"      ETCD_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":27,"context_line":"      ETCD_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":28,"context_line":"      ETCD_PEER_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":29,"context_line":"      ETCD_PEER_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":30,"context_line":"    image: \"{{ service.image }}\""},{"line_number":31,"context_line":"    name: \"{{ service.container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"679c9355_c4cf6ee5","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":25},"in_reply_to":"b47aca20_6f66188f","updated":"2023-09-11 09:51:08.000000000","message":"Unfortunately this is a holdover from the original implementation. Changing this without a migration path would certainly break things.\n\nAs far as I can tell the model in use here sets up etcd as an internal service. Clients and peers use the same cert to trust the endpoints. It\u0027s certainly better security practice to use separate certs.\n\nGood news is that the newer version of etcd supports reading config from files. That might open up a slight path of using drop-in config to aid migration.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"72c557cdd21d6eb3a48067c16718071a62aaa6ef","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      ETCD_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":27,"context_line":"      ETCD_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":28,"context_line":"      ETCD_PEER_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":29,"context_line":"      ETCD_PEER_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":30,"context_line":"    image: \"{{ service.image }}\""},{"line_number":31,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":32,"context_line":"    volumes: \"{{ service.volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"19712ba1_894a85e3","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":24},"updated":"2023-09-11 09:34:34.000000000","message":"is the peer key file really supposed to be the same as the key file?\nI don\u0027t know enough about this part of etcd to answer this myself.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"76926a6bf1fcdb85184dfcfbc19cf4483bf09680","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      ETCD_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":27,"context_line":"      ETCD_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":28,"context_line":"      ETCD_PEER_CERT_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-cert.pem{% endif %}\""},{"line_number":29,"context_line":"      ETCD_PEER_KEY_FILE: \"{% if etcd_enable_tls | bool %}/etc/etcd/certs/etcd-key.pem{% endif %}\""},{"line_number":30,"context_line":"    image: \"{{ service.image }}\""},{"line_number":31,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":32,"context_line":"    volumes: \"{{ service.volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"55d33c30_9e1e9e14","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":24},"in_reply_to":"19712ba1_894a85e3","updated":"2023-09-11 10:07:32.000000000","message":"see above","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"}],"ansible/roles/etcd/tasks/bootstrap_services.yml":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"596bb9d493a94d195831aaa6c6dc0e1e5db49f1d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    service_name: \"etcd\""},{"line_number":16,"context_line":"    service: \"{{ etcd_services[service_name] }}\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  kolla_docker:"},{"line_number":19,"context_line":"    action: \"start_container\""},{"line_number":20,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":21,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0904698b_268e4e82","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":14},"updated":"2023-11-28 17:43:12.000000000","message":"aha, this needs changing.","commit_id":"6527cb6a83f685ff07b0c7c4ae6b34826e28475c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32d586115a33148bef0a7b92b7cfbf1303539620","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    service_name: \"etcd\""},{"line_number":16,"context_line":"    service: \"{{ etcd_services[service_name] }}\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  kolla_docker:"},{"line_number":19,"context_line":"    action: \"start_container\""},{"line_number":20,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":21,"context_line":"    environment:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b24ff36a_3c85d764","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":14},"in_reply_to":"0904698b_268e4e82","updated":"2023-11-28 17:46:28.000000000","message":"Done","commit_id":"6527cb6a83f685ff07b0c7c4ae6b34826e28475c"}],"ansible/roles/etcd/tasks/lookup_leader.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a8b5903a752474b59759820a1f2fcbb252cf592d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  # handle an upgrade scenario from older etcd containers. These can be"},{"line_number":10,"context_line":"  # removed once the new workflow has been in place for a cycle or two."},{"line_number":11,"context_line":"  command: \u003e-"},{"line_number":12,"context_line":"    docker exec"},{"line_number":13,"context_line":"    -e ETCDCTL_API\u003d3"},{"line_number":14,"context_line":"    -e ETCDCTL_ENDPOINTS\u003d\"{{ etcd_client_internal_endpoint }}\""},{"line_number":15,"context_line":"    -e ETCDCTL_WRITE_OUT\u003d\"json\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"955bc5c6_48667bfd","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":10},"updated":"2023-11-17 07:10:21.000000000","message":"container_runtime? could also use https://docs.ansible.com/ansible/latest/collections/community/general/etcd_lookup.html instead","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d156513603deebc76a6fdc37eac19e2b4336745f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  # handle an upgrade scenario from older etcd containers. These can be"},{"line_number":10,"context_line":"  # removed once the new workflow has been in place for a cycle or two."},{"line_number":11,"context_line":"  command: \u003e-"},{"line_number":12,"context_line":"    docker exec"},{"line_number":13,"context_line":"    -e ETCDCTL_API\u003d3"},{"line_number":14,"context_line":"    -e ETCDCTL_ENDPOINTS\u003d\"{{ etcd_client_internal_endpoint }}\""},{"line_number":15,"context_line":"    -e ETCDCTL_WRITE_OUT\u003d\"json\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"33ae460b_93870360","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":10},"in_reply_to":"1aa15611_b6f45a09","updated":"2023-11-17 16:14:53.000000000","message":"Done","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"72de97e362ba7bc0458b4bfb08f2c6f9940771e4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  # handle an upgrade scenario from older etcd containers. These can be"},{"line_number":10,"context_line":"  # removed once the new workflow has been in place for a cycle or two."},{"line_number":11,"context_line":"  command: \u003e-"},{"line_number":12,"context_line":"    docker exec"},{"line_number":13,"context_line":"    -e ETCDCTL_API\u003d3"},{"line_number":14,"context_line":"    -e ETCDCTL_ENDPOINTS\u003d\"{{ etcd_client_internal_endpoint }}\""},{"line_number":15,"context_line":"    -e ETCDCTL_WRITE_OUT\u003d\"json\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa15611_b6f45a09","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":10},"in_reply_to":"955bc5c6_48667bfd","updated":"2023-11-17 10:59:51.000000000","message":"yeah, this was done before podman, will send up a review tomorrow!\n\nI\u0027ll take a look but at first glance I\u0027m unsure if the etcd lookup will be suitable here (it seems to be looking up key/value pairs in the etcd db). I tried some basic things, but I haven\u0027t been able to check member list from the kvs.","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"}],"ansible/roles/etcd/tasks/remove_deleted_members.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a8b5903a752474b59759820a1f2fcbb252cf592d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    service: \"{{ etcd_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  command: \u003e-"},{"line_number":8,"context_line":"    docker exec {{ service.container_name }}"},{"line_number":9,"context_line":"    etcdctl member list"},{"line_number":10,"context_line":"  changed_when: false"},{"line_number":11,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d0763206_94570480","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":10},"updated":"2023-11-17 07:10:21.000000000","message":"container_runtime?","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d156513603deebc76a6fdc37eac19e2b4336745f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    service: \"{{ etcd_services[service_name] }}\""},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  command: \u003e-"},{"line_number":8,"context_line":"    docker exec {{ service.container_name }}"},{"line_number":9,"context_line":"    etcdctl member list"},{"line_number":10,"context_line":"  changed_when: false"},{"line_number":11,"context_line":"  run_once: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2549d18a_bdf7129a","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":10},"in_reply_to":"d0763206_94570480","updated":"2023-11-17 16:14:53.000000000","message":"Done","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a8b5903a752474b59759820a1f2fcbb252cf592d","unresolved":true,"context_lines":[{"line_number":30,"context_line":"      | json_query(\u0027members[].{key: name, value: ID}\u0027) | items2dict }}"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: \u003e-"},{"line_number":33,"context_line":"    docker exec {{ service.container_name }}"},{"line_number":34,"context_line":"    etcdctl member remove {{ \u0027%x\u0027 % etcd_member_id[etcd_deleted_member] }}"},{"line_number":35,"context_line":"  run_once: true"},{"line_number":36,"context_line":"  delegate_to: \"{{ etcd_cluster_leader | default(groups[service.group][0]) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fbeab479_aaad744d","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":10},"updated":"2023-11-17 07:10:21.000000000","message":"container_runtime?","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d156513603deebc76a6fdc37eac19e2b4336745f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      | json_query(\u0027members[].{key: name, value: ID}\u0027) | items2dict }}"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: \u003e-"},{"line_number":33,"context_line":"    docker exec {{ service.container_name }}"},{"line_number":34,"context_line":"    etcdctl member remove {{ \u0027%x\u0027 % etcd_member_id[etcd_deleted_member] }}"},{"line_number":35,"context_line":"  run_once: true"},{"line_number":36,"context_line":"  delegate_to: \"{{ etcd_cluster_leader | default(groups[service.group][0]) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ebda6825_0ea3b9a8","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":10},"in_reply_to":"fbeab479_aaad744d","updated":"2023-11-17 16:14:53.000000000","message":"Done","commit_id":"45c13c10b2719ceef30d74580e6d579396c2a7e3"}],"releasenotes/notes/managed-etcd-72fb2d3fbba516d9.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a86381d81d33ed011e684642dd212b7ae2b0ad83","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `etcd` tooling has been updated to better serialize restarts when"},{"line_number":5,"context_line":"    applying configuration or updates. Previously minor outages might occur"},{"line_number":6,"context_line":"    since all services were restarted in the same task."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The `etcd` tooling has been updated to handle adding and removing nodes."},{"line_number":9,"context_line":"    Previously this was an undocumented manual process and required creating"},{"line_number":10,"context_line":"    service containers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eead774e_11576857","line":10,"range":{"start_line":4,"start_character":0,"end_line":10,"end_character":23},"updated":"2023-08-07 09:09:04.000000000","message":"please reference the new docs you wrote here for the operator audience.","commit_id":"7b2576ca30bfc308c1c54a740a18f6f330e18301"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"b33dfb438c01e5dc155ffa185c17088cd7aecaf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The `etcd` tooling has been updated to better serialize restarts when"},{"line_number":5,"context_line":"    applying configuration or updates. Previously minor outages might occur"},{"line_number":6,"context_line":"    since all services were restarted in the same task."},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The `etcd` tooling has been updated to handle adding and removing nodes."},{"line_number":9,"context_line":"    Previously this was an undocumented manual process and required creating"},{"line_number":10,"context_line":"    service containers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"100410bc_1dc26049","line":10,"range":{"start_line":4,"start_character":0,"end_line":10,"end_character":23},"in_reply_to":"eead774e_11576857","updated":"2023-08-08 13:28:43.000000000","message":"Link added, I _think_ it should point to the right place after publication.","commit_id":"7b2576ca30bfc308c1c54a740a18f6f330e18301"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"d2b1efe857e64c1704091b8655c222c4c3802e44","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":125,"context_line":"# kolla-ansible vars"},{"line_number":126,"context_line":"enable_cinder: \"yes\""},{"line_number":127,"context_line":"# External Ceph"},{"line_number":128,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":129,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"cff0501d_074aa34a","line":126,"updated":"2023-07-12 10:27:31.000000000","message":"One possible candidate to test the etcd role a bit more would be to set\n  enable_etcd: \"yes\"\nhere.","commit_id":"7b2576ca30bfc308c1c54a740a18f6f330e18301"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"0bdc9996490c2fb8dd05d05aa6a403c33a137668","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"{% if scenario \u003d\u003d \"cephadm\" %}"},{"line_number":125,"context_line":"# kolla-ansible vars"},{"line_number":126,"context_line":"enable_cinder: \"yes\""},{"line_number":127,"context_line":"# External Ceph"},{"line_number":128,"context_line":"glance_backend_ceph: \"yes\""},{"line_number":129,"context_line":"cinder_backend_ceph: \"yes\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"aacb4484_23b10efa","line":126,"in_reply_to":"cff0501d_074aa34a","updated":"2023-08-01 14:33:01.000000000","message":"Done","commit_id":"7b2576ca30bfc308c1c54a740a18f6f330e18301"}]}