)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e09e6f2e9196ebac0a64e9b0c590c9925dc9ac4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4ffab7d9_387d2da2","updated":"2023-08-18 07:55:00.000000000","message":"That needs built images for bookworm and we should rework it to add host os support in that patch","commit_id":"f34641201967aeaf8e70fe62468c54647ba6d55f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"26eb3813795573af4f5b0dace4c0b73f13e30ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e66987b6_0da057d5","updated":"2023-08-21 15:21:39.000000000","message":"the change itself LGTM, aside from the workflow questions on when this can be merged.","commit_id":"f34641201967aeaf8e70fe62468c54647ba6d55f"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"30da1ea158eccc23bbdf444557d212c7e45216b2","unresolved":true,"context_lines":[{"line_number":1170,"context_line":"#########################"},{"line_number":1171,"context_line":"# Internal Image options"},{"line_number":1172,"context_line":"#########################"},{"line_number":1173,"context_line":"distro_python_version_map: {"},{"line_number":1174,"context_line":"  \"centos\": \"3.9\","},{"line_number":1175,"context_line":"  \"debian\": \"3.9\","},{"line_number":1176,"context_line":"  \"rocky\": \"3.9\","}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ed8e640f_2666a292","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":0,"end_line":1173,"end_character":25},"updated":"2023-08-03 15:14:57.000000000","message":"This proposal may need to be rebased on top of this one: https://review.opendev.org/c/openstack/kolla-ansible/+/874990, as python version are being dropped there.","commit_id":"49d891e85f8b8db931822a194354f863618ae42b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"12dfcec8e9c0897971d6969ac2b7c35b2ace3a08","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"#########################"},{"line_number":1171,"context_line":"# Internal Image options"},{"line_number":1172,"context_line":"#########################"},{"line_number":1173,"context_line":"distro_python_version_map: {"},{"line_number":1174,"context_line":"  \"centos\": \"3.9\","},{"line_number":1175,"context_line":"  \"debian\": \"3.9\","},{"line_number":1176,"context_line":"  \"rocky\": \"3.9\","}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e8e79652_297475b6","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":0,"end_line":1173,"end_character":25},"in_reply_to":"ed8e640f_2666a292","updated":"2023-08-17 16:01:17.000000000","message":"Ack","commit_id":"49d891e85f8b8db931822a194354f863618ae42b"}],"ansible/roles/loadbalancer/templates/haproxy/haproxy_main.cfg.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4f7e7ffed2a562b6dcc9fc26f4b129d432734aba","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":10,"context_line":"    {% if (haproxy_threads | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":11,"context_line":"    cpu-map auto:1/all 0-63"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"    stats socket /var/lib/kolla/haproxy/haproxy.sock group kolla mode 660{% if haproxy_socket_level_admin | bool %} level admin{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"b4e4c1ff_fa2c56fb","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":27},"updated":"2023-08-17 16:52:54.000000000","message":"is it suitable as defaults for all servers? not sure","commit_id":"f83fd0bfc4f009f48f9d093f7908d8116b7ca705"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f83624138ea782ed520fe36bcbf4c6ab5eafabe9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":10,"context_line":"    {% if (haproxy_threads | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":11,"context_line":"    cpu-map auto:1/all 0-63"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"    stats socket /var/lib/kolla/haproxy/haproxy.sock group kolla mode 660{% if haproxy_socket_level_admin | bool %} level admin{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"8780d86e_115fbd0e","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":27},"in_reply_to":"84b82b1f_eeb564ef","updated":"2023-08-17 19:37:44.000000000","message":"maybe default variable which can be overridden would be good right now?","commit_id":"f83fd0bfc4f009f48f9d093f7908d8116b7ca705"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"64b455114222b06528b3b948e5556ae3aa3c0b95","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    maxconn {{ haproxy_max_connections }}"},{"line_number":9,"context_line":"    nbthread {{ haproxy_threads }}"},{"line_number":10,"context_line":"    {% if (haproxy_threads | int \u003e 1) and (haproxy_process_cpu_map | bool) %}"},{"line_number":11,"context_line":"    cpu-map auto:1/all 0-63"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"    stats socket /var/lib/kolla/haproxy/haproxy.sock group kolla mode 660{% if haproxy_socket_level_admin | bool %} level admin{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"84b82b1f_eeb564ef","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":27},"in_reply_to":"b4e4c1ff_fa2c56fb","updated":"2023-08-17 19:19:16.000000000","message":"it will bind each thread to exactly one cpu - see https://docs.haproxy.org/2.6/configuration.html#cpu-map\nI agree it might not suit all servers, but we can improve that later.","commit_id":"f83fd0bfc4f009f48f9d093f7908d8116b7ca705"}]}
