)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7a1d056f99c5cfb16e77e106a8ce80de4c9f6a4f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Lukas Mrtvy \u003clukas.mrtvy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-13 20:34:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: enable SSO for Skyline ; add variable for setting trusted_dashboards for Skyline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34c9c3135dc7f7bc2b6c8033573c7674453a3e0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f2f5109c_abec2899","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":86},"updated":"2023-07-14 08:59:24.000000000","message":"Adds SSO support for Skyline.","commit_id":"b56b7593e54a33ba34b854bb200bc084b4936c5f"},{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"69f9e4c1c1b03f212dc8749d8600555540e50f3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lukas Mrtvy \u003clukas.mrtvy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-13 20:34:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: enable SSO for Skyline ; add variable for setting trusted_dashboards for Skyline"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34c9c3135dc7f7bc2b6c8033573c7674453a3e0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"70bf09b9_2d830e3a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":86},"in_reply_to":"f2f5109c_abec2899","updated":"2023-07-14 09:52:17.000000000","message":"Done","commit_id":"b56b7593e54a33ba34b854bb200bc084b4936c5f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"f5b5a9ea45f06bf82cac75504b48846e41dc5d53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f35e1ecc_759ef9da","updated":"2023-07-17 21:13:14.000000000","message":"recheck","commit_id":"4b0c241a065b5e180d88547d36228327ab143831"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6611e3c92d9cafee9e2fc511b6f722376881b53f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bf6dfd29_38480ce6","updated":"2024-02-27 10:18:45.000000000","message":"Hi and thanks for all the effort spend on this.\nIs this still being worked on? Because we also have https://review.opendev.org/c/openstack/kolla-ansible/+/905860 which seems it works. We just need to decide on which patch we want to work.\n\nThanks","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"1bd093e324a6033499aa8af5d1971181235e9ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0999b5cd_d9f08e2f","updated":"2024-02-18 19:03:00.000000000","message":"See https://review.opendev.org/c/openstack/kolla-ansible/+/905860 for another change to fix this.","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67619b020bb6630a2414a8510f5ce5b9aba607cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b85bdb16_1d30d9e4","updated":"2024-01-18 09:20:24.000000000","message":"recheck just get some fresh logs","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7a1d056f99c5cfb16e77e106a8ce80de4c9f6a4f","unresolved":true,"context_lines":[{"line_number":237,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":238,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":239,"context_line":"keystone_horizon_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":240,"context_line":"keystone_skyline_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (skyline_public_endpoint)] if enable_skyline | bool else [] }}\""},{"line_number":241,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":242,"context_line":"keystone_should_remove_attribute_mappings: False"},{"line_number":243,"context_line":"keystone_should_remove_identity_providers: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"224c1aa9_77a3e025","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":35},"updated":"2023-07-14 08:59:24.000000000","message":"also as in the parent review this variable name shouldn\u0027t be changed.\nto add support for Skyline add the second element in the list.","commit_id":"b56b7593e54a33ba34b854bb200bc084b4936c5f"},{"author":{"_account_id":35887,"name":"Lukas M","display_name":"Lukas M","email":"lukas.mrtvy@gmail.com","username":"muhaha"},"change_message_id":"7cd3698d96ad6e9d1e2e3299053884f4f66df0f3","unresolved":false,"context_lines":[{"line_number":237,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":238,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":239,"context_line":"keystone_horizon_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":240,"context_line":"keystone_skyline_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (skyline_public_endpoint)] if enable_skyline | bool else [] }}\""},{"line_number":241,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":242,"context_line":"keystone_should_remove_attribute_mappings: False"},{"line_number":243,"context_line":"keystone_should_remove_identity_providers: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3c6cc28f_acbcdda4","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":35},"in_reply_to":"224c1aa9_77a3e025","updated":"2023-07-14 10:55:51.000000000","message":"Done","commit_id":"b56b7593e54a33ba34b854bb200bc084b4936c5f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67619b020bb6630a2414a8510f5ce5b9aba607cb","unresolved":true,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":238,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":239,"context_line":"keystone_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":240,"context_line":"skyline_trusted_dashboards: \"{{ [\u0027%s/auth/websso/\u0027 % (skyline_public_endpoint)] if enable_skyline | bool else [] }}\""},{"line_number":241,"context_line":"keystone_trusted_dashboards: \"{{ horizon_trusted_dashboards + skyline_trusted_dashboards }}\""},{"line_number":242,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"649b77b7_04484b92","line":239,"updated":"2024-01-18 09:20:24.000000000","message":"please keep the name keystone_horizon_trusted_dashboards here","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"},{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"edc80cbadae46452704095300b6d76b339c6feda","unresolved":true,"context_lines":[{"line_number":237,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":238,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":239,"context_line":"keystone_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":240,"context_line":"skyline_trusted_dashboards: \"{{ [\u0027%s/auth/websso/\u0027 % (skyline_public_endpoint)] if enable_skyline | bool else [] }}\""},{"line_number":241,"context_line":"keystone_trusted_dashboards: \"{{ horizon_trusted_dashboards + skyline_trusted_dashboards }}\""},{"line_number":242,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":243,"context_line":"keystone_should_remove_attribute_mappings: False"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"906d21f3_994ea006","line":240,"updated":"2024-01-22 07:16:57.000000000","message":"I\u0027m not 100% sure but in our setup the url has to be\nhttps://\u003cpublic-fqn\u003e/api/openstack/skyline/api/v1/websso","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67619b020bb6630a2414a8510f5ce5b9aba607cb","unresolved":true,"context_lines":[{"line_number":237,"context_line":"# These variables are used to define multiple trusted Horizon dashboards."},{"line_number":238,"context_line":"# keystone_trusted_dashboards: [\u0027\u003chttps://dashboardServerOne/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerTwo/auth/websso/\u003e\u0027, \u0027\u003chttps://dashboardServerN/auth/websso/\u003e\u0027]"},{"line_number":239,"context_line":"keystone_trusted_dashboards: \"{{ [\u0027%s://%s/auth/websso/\u0027 % (public_protocol, kolla_external_fqdn), \u0027%s/auth/websso/\u0027 % (horizon_public_endpoint)] if enable_horizon | bool else [] }}\""},{"line_number":240,"context_line":"skyline_trusted_dashboards: \"{{ [\u0027%s/auth/websso/\u0027 % (skyline_public_endpoint)] if enable_skyline | bool else [] }}\""},{"line_number":241,"context_line":"keystone_trusted_dashboards: \"{{ horizon_trusted_dashboards + skyline_trusted_dashboards }}\""},{"line_number":242,"context_line":"keystone_enable_federation_openid: \"{{ enable_keystone_federation | bool and keystone_identity_providers | selectattr(\u0027protocol\u0027, \u0027equalto\u0027, \u0027openid\u0027) | list | count \u003e 0 }}\""},{"line_number":243,"context_line":"keystone_should_remove_attribute_mappings: False"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"426ab08a_9a9c0e2a","line":240,"updated":"2024-01-18 09:20:24.000000000","message":"this should then be keystone_skyline_trusted_dashboards","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":36709,"name":"Uwe Jäger","display_name":"Uwe","email":"uwe.jaeger@valiton.com","username":"uwej711"},"change_message_id":"edc80cbadae46452704095300b6d76b339c6feda","unresolved":true,"context_lines":[{"line_number":151,"context_line":"skyline_system_reader_roles:"},{"line_number":152,"context_line":"  - system_reader"},{"line_number":153,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":154,"context_line":"skyline_use_keystone_public_url: \"{% if keystone_enable_federation_openid | bool %}true{% else %}false{% endif %}\""},{"line_number":155,"context_line":"skyline_session_name: session"},{"line_number":156,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e5fa7440_dbc333eb","line":154,"updated":"2024-01-22 07:16:57.000000000","message":"I think it has to be the public endpoint since the Skyline SSO redirects the user\u0027s browser directly to that endpoint","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67619b020bb6630a2414a8510f5ce5b9aba607cb","unresolved":true,"context_lines":[{"line_number":151,"context_line":"skyline_system_reader_roles:"},{"line_number":152,"context_line":"  - system_reader"},{"line_number":153,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":154,"context_line":"skyline_use_keystone_public_url: \"{% if keystone_enable_federation_openid | bool %}true{% else %}false{% endif %}\""},{"line_number":155,"context_line":"skyline_session_name: session"},{"line_number":156,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa2a2164_27db0837","line":154,"updated":"2024-01-18 09:20:24.000000000","message":"why not simply always use the public keystone endpoint?","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"}],"ansible/roles/skyline/templates/skyline.yaml.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67619b020bb6630a2414a8510f5ce5b9aba607cb","unresolved":true,"context_lines":[{"line_number":28,"context_line":"{% if enable_neutron_vpnaas | bool %}"},{"line_number":29,"context_line":"    vpnaas: neutron_vpn"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":"{% if keystone_enable_federation_openid | bool %}"},{"line_number":32,"context_line":"    sso_enabled: true"},{"line_number":33,"context_line":"    sso_protocols:"},{"line_number":34,"context_line":"    - openid"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"58377ca5_d569b89d","line":31,"updated":"2024-01-18 09:20:24.000000000","message":"I\u0027m not sure yet whether it makes sense to have this automatism, or whether to have a dedicated flag as proposed in https://review.opendev.org/c/openstack/kolla-ansible/+/905860. Or whether this can be solved by just telling deployments to use an overlay that is introduced with https://review.opendev.org/c/openstack/kolla-ansible/+/902182","commit_id":"a55e7dcbd69e94e070cd17b47532e13534c36e2a"}]}