)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4deb3fbec5cd03a014e539fe929480b642873ff2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set haproxy for cyborg module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fix bug: cyborg-api in controller not work at kolla_external_fqdn with"},{"line_number":10,"context_line":"port 6666, there is no haproxy setting for cyborg module"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2020088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e7bae209_cd1e4eee","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":37},"updated":"2023-08-25 09:44:04.000000000","message":"\"does not work\"","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"52c1f257bb44b1480e1a0ebf61339c1fe2b2822e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set haproxy for cyborg module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fix bug: cyborg-api in controller not work at kolla_external_fqdn with"},{"line_number":10,"context_line":"port 6666, there is no haproxy setting for cyborg module"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2020088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"107b3784_ce9b1496","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":37},"in_reply_to":"e7bae209_cd1e4eee","updated":"2023-08-27 00:50:50.000000000","message":"Done","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ccb9db65c9bc4a0c4cc25ebdcf166048b75c934a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74189acb_4f6b49d5","updated":"2023-08-08 06:16:15.000000000","message":"you may need to add a release note ?","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bbb777ca17a6d3ab0014875d40ede81513b14e75","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c08d27a_c31c8db4","updated":"2024-11-05 16:40:04.000000000","message":"LGTM but should we also fix TLS setup in this patch? see my suggestion.\nNot a cyborg user myself.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"986a2cd78faf6109ebbb922802e37ba80e81487e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb8da100_e4151e63","updated":"2024-11-05 17:53:03.000000000","message":"While we\u0027re at it - do we have cyborg deployed in any of the CI jobs?","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e9a30609356029ee320e247984f3cb21d40fd1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41a77e13_f1a81d9a","updated":"2024-11-05 16:49:50.000000000","message":"waiting with W+1 until zuul CI is happy.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"42fd75e32e94923b03004c78f8a874d2dc6a9c28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41652017_dbd744eb","in_reply_to":"1b1d24b8_ea167625","updated":"2024-11-06 05:28:14.000000000","message":"Leave this review as it\u0027s now - that\u0027s my opinion.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e9a30609356029ee320e247984f3cb21d40fd1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3264ad0_801b66ce","in_reply_to":"2c08d27a_c31c8db4","updated":"2024-11-05 16:49:50.000000000","message":"okay, let\u0027s fix bugs first and add TLS feature later.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d4a18fe04d9111f36b31111a8e3e1e6c2fc39676","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b823f437_4a2df1a6","in_reply_to":"41652017_dbd744eb","updated":"2024-11-06 05:39:29.000000000","message":"Please, check \n\n```\n- include_tasks: copy-certs.yml\n  when:\n    - kolla_copy_ca_into_containers | bool\n```\n\nto\n\n-\n\n```\n- include_tasks: copy-certs.yml\n  when:\n    - kolla_copy_ca_into_containers | bool or cyborg_enable_tls_backend | bool\n```\n\nin ansible/roles/cyborg/tasks/config.yml and fix conditional as now we have cyborg_enable_tls_backend. \n\nAlso, change the release note and commit message if TLS enabled.\n\nAnd on the end - in my opinion, it would be best to split these two things and put them into separate review/commit. What do the others think?","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"f57598501a29e2137c07dcbba4e1817655a38c0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f3287614_0cbed573","in_reply_to":"b823f437_4a2df1a6","updated":"2024-11-06 09:17:34.000000000","message":"both done. I also would tend to agree on splitting the patches, I can submit a second one for the internal TLS feature, and keep this one as simply fixing the actual cyborg feature.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"79520c1619d22497f9b36794e005930697430146","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e45c9a2e_1bd570d7","in_reply_to":"bb8da100_e4151e63","updated":"2024-11-05 18:16:16.000000000","message":"probbly not, I can look into it.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"458568c8f1c55baab4570681a07974d2ed44c00c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87cf8c16_4087015e","in_reply_to":"e3264ad0_801b66ce","updated":"2024-11-05 19:04:53.000000000","message":"This took not very long so I added it anyways.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"0f32adef4c6ff81197e53f83141944222c1c5477","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b1d24b8_ea167625","in_reply_to":"e45c9a2e_1bd570d7","updated":"2024-11-05 19:11:07.000000000","message":"should we include it in this review or make a separate one to unlock the feature faster tho ? I can get make a second review to enable tests.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"82ec1da1ae2a24a188d6784ebe893b7da339fce8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c82ffae2_83c8efe3","in_reply_to":"f3287614_0cbed573","updated":"2024-11-06 14:00:44.000000000","message":"I removed the internal TLS changes, and I\u0027ll submit another patch for it.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c58e9f6b1d5f53e2ca075122fcea1dd4e33cb1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bad32df9_7331401e","updated":"2024-11-06 11:51:16.000000000","message":"the backend TLS feature needs to be a separate patch, we can\u0027t backport features","commit_id":"d0440edfd2d2393897d587e8a52c80532e30a98e"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"82ec1da1ae2a24a188d6784ebe893b7da339fce8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d870ed4d_f098528a","in_reply_to":"bad32df9_7331401e","updated":"2024-11-06 14:00:44.000000000","message":"I removed the internal TLS bit, so this one should be backportable now. I\u0027ll make another one for enabling internal TLS.","commit_id":"d0440edfd2d2393897d587e8a52c80532e30a98e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2c96a1504558e3a51fb2f58228b3e9a8e7f7fdf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"78c00e27_802e13ff","updated":"2024-11-07 09:27:35.000000000","message":"LGTM, imho we can add tests in a separate change.","commit_id":"2adc14887d0f292287cea2c8d4e5cc815564c632"}],"ansible/roles/cyborg/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4deb3fbec5cd03a014e539fe929480b642873ff2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a3b93d12_5e1325ec","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"updated":"2023-08-25 09:44:04.000000000","message":"afaik this role does only get triggered if enable_cyborg is true\nso this value is always true, so just write:\n\nenabled: true\n\nam I missing something?","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"52c1f257bb44b1480e1a0ebf61339c1fe2b2822e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ef19cdc8_366d7e21","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"6c9619d3_1fcaaa36","updated":"2023-08-27 00:50:50.000000000","message":"Done","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2199d5fea1da5a36641b70998dae1c3d132cf163","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c9619d3_1fcaaa36","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"a3b93d12_5e1325ec","updated":"2023-08-25 10:37:20.000000000","message":"nit","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4deb3fbec5cd03a014e539fe929480b642873ff2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""},{"line_number":21,"context_line":"        external: true"},{"line_number":22,"context_line":"        external_fqdn: \"{{ cyborg_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"12cc2233_f0c335d1","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2023-08-25 09:44:04.000000000","message":"see comment above","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2199d5fea1da5a36641b70998dae1c3d132cf163","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""},{"line_number":21,"context_line":"        external: true"},{"line_number":22,"context_line":"        external_fqdn: \"{{ cyborg_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f84776f6_8edf5de5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"12cc2233_f0c335d1","updated":"2023-08-25 10:37:20.000000000","message":"nit","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"52c1f257bb44b1480e1a0ebf61339c1fe2b2822e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""},{"line_number":21,"context_line":"        external: true"},{"line_number":22,"context_line":"        external_fqdn: \"{{ cyborg_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3846430a_ff1dfe91","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"f84776f6_8edf5de5","updated":"2023-08-27 00:50:50.000000000","message":"Done","commit_id":"fb2e275a0346d94babcbaef38510963592673e3b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bc63ecdbe75673f3a3a92e9ff7da0f930d22f8d1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: true"},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f1e17959_d80e0cf2","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":21},"updated":"2024-11-05 14:15:16.000000000","message":"enabled: \"{{ enable_cyborg }}\" ?","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"04719f2e53be2f0fefe6248905bff39b97c07574","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: true"},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6cbbea2b_a1c3c221","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":21},"in_reply_to":"00c04f3e_3d1a68c4","updated":"2024-11-05 17:48:46.000000000","message":"he will turn off haproxy...","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9da3dce07bc6920adabe16fea9f9fe7fc9c928e4","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: true"},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"00c04f3e_3d1a68c4","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":21},"in_reply_to":"4800dfdb_d746ed3a","updated":"2024-11-05 17:42:03.000000000","message":"Michal, what if someone want deploy a service but without Haproxy on the one host.","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"070e7dae3974fa787aa27df7fafff7b2761c001c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    healthcheck: \"{{ cyborg_api_healthcheck }}\""},{"line_number":11,"context_line":"    haproxy:"},{"line_number":12,"context_line":"      cyborg_api:"},{"line_number":13,"context_line":"        enabled: true"},{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4800dfdb_d746ed3a","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":21},"in_reply_to":"f1e17959_d80e0cf2","updated":"2024-11-05 14:39:49.000000000","message":"indeed this wasn\u0027t correct.","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bc63ecdbe75673f3a3a92e9ff7da0f930d22f8d1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: true"},{"line_number":20,"context_line":"        mode: \"http\""},{"line_number":21,"context_line":"        external: true"},{"line_number":22,"context_line":"        external_fqdn: \"{{ cyborg_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f0626b7a_66256a39","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":21},"updated":"2024-11-05 14:15:16.000000000","message":"ditto","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"070e7dae3974fa787aa27df7fafff7b2761c001c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: true"},{"line_number":20,"context_line":"        mode: \"http\""},{"line_number":21,"context_line":"        external: true"},{"line_number":22,"context_line":"        external_fqdn: \"{{ cyborg_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"61936939_2d53d5c5","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":21},"in_reply_to":"f0626b7a_66256a39","updated":"2024-11-05 14:39:49.000000000","message":"done","commit_id":"b54bd5859f1d97f9e644e27d9ed6abe5364247aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bbb777ca17a6d3ab0014875d40ede81513b14e75","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2f6bdfa0_3308b750","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":51},"updated":"2024-11-05 16:40:04.000000000","message":"what about:\n\n```suggestion\n        listen_port: \"{{ cyborg_api_listen_port }}\"\n        tls_backend: \"{{ cyborg_enable_tls_backend }}\"\n```\n\nas far as I read the cyborg API does seem to support TLS:\n\nhttps://docs.openstack.org/cyborg/latest/configuration/sample-config.html\n\nwhat do you think?\n\nof course we would need to define it in this same file as well:\n\n```\ncyborg_enable_tls_backend: \"{{ kolla_enable_tls_backend }}\"\n```","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c2387b9b161ce55d19dbad1c37e1162d3a66491e","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fda8f422_1ca1164a","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":51},"in_reply_to":"2f6bdfa0_3308b750","updated":"2024-11-05 16:42:04.000000000","message":"I was also wondering about this, but commit is clear - fixing access to cyborg. TLS is feature and can be delivered in another commit. There are more services tls don\u0027t have.","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e9a30609356029ee320e247984f3cb21d40fd1f1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        mode: \"http\""},{"line_number":15,"context_line":"        external: false"},{"line_number":16,"context_line":"        port: \"{{ cyborg_api_port }}\""},{"line_number":17,"context_line":"        listen_port: \"{{ cyborg_api_listen_port }}\""},{"line_number":18,"context_line":"      cyborg_api_external:"},{"line_number":19,"context_line":"        enabled: \"{{ enable_cyborg }}\""},{"line_number":20,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"56c4df40_2fab03ff","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":51},"in_reply_to":"fda8f422_1ca1164a","updated":"2024-11-05 16:49:50.000000000","message":"Acknowledged","commit_id":"d1031cfba996e192b48c9f2f87394fc022925b5b"}]}