)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ef4302774a994ee35ce7ecb8abf16364b3d77c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"58230ba8_ef8f4628","updated":"2023-09-08 19:07:57.000000000","message":"recheck - double checking","commit_id":"eb972eaa7e998d7b98526c1a6fbf69cfef21a7f9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cb1847f86fa487b6204da883e152e4eb67cf51de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46fc502a_db641d74","updated":"2023-09-11 08:46:43.000000000","message":"nit: imho this does not do what the commit message says: it does not add a hardware type to the tests, but swaps the machine type on x64.\n\nI assume that\u0027s what we want to do, though, so we don\u0027t explode our test matrix by a factor of 2.","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4eb1c6a72ff00d269a740366c3eab05dafdbf34c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7f245b30_ad526c0c","in_reply_to":"46fc502a_db641d74","updated":"2023-09-11 09:04:04.000000000","message":"it is not swapping to q35. It as running first default i440fx, and then q35 only on x86","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0236caf2272dfbc4c10931e5107430cb69ff7d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"adaf78a4_bcc71df0","in_reply_to":"7f245b30_ad526c0c","updated":"2023-09-11 09:24:59.000000000","message":"ah, thanks for the correction! I had a hunch I\u0027d misunderstood this.","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"}],"tests/test-core-openstack.sh":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e169d1460911f5289044737fa0a5c3c4bd81cd8b","unresolved":true,"context_lines":[{"line_number":289,"context_line":"function test_instance_boot {"},{"line_number":290,"context_line":"    local fip_addr"},{"line_number":291,"context_line":"    local machine_type\u003d\"${1}\""},{"line_number":292,"context_line":"    local fip_file\u003d\"/tmp/kolla_ci_pre_upgrade_fip_addr${machine_type:+_$machine_type}\""},{"line_number":293,"context_line":"    local upgrade_instance_name\u003d\"kolla_upgrade_test${machine_type:+_$machine_type}\""},{"line_number":294,"context_line":"    local volume_name\u003d\"durable_volume${machine_type:+_$machine_type}\""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"42f987bc_8d72abed","line":292,"range":{"start_line":292,"start_character":25,"end_line":292,"end_character":54},"updated":"2023-09-11 11:29:40.000000000","message":"kolla_ci_pre_upgrade_fip_addr_$$_\nthe good practice to create process related temp files to avoid races","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"8a5efb6bdbf647c4e299094f8013d26869f8632e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"function test_instance_boot {"},{"line_number":290,"context_line":"    local fip_addr"},{"line_number":291,"context_line":"    local machine_type\u003d\"${1}\""},{"line_number":292,"context_line":"    local fip_file\u003d\"/tmp/kolla_ci_pre_upgrade_fip_addr${machine_type:+_$machine_type}\""},{"line_number":293,"context_line":"    local upgrade_instance_name\u003d\"kolla_upgrade_test${machine_type:+_$machine_type}\""},{"line_number":294,"context_line":"    local volume_name\u003d\"durable_volume${machine_type:+_$machine_type}\""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"c7222be7_54c923b1","line":292,"range":{"start_line":292,"start_character":25,"end_line":292,"end_character":54},"in_reply_to":"42f987bc_8d72abed","updated":"2023-09-11 11:58:02.000000000","message":"well, in upgrade jobs we\u0027re running it once with this name (second run - on x86 q35 - is running with different name). So it won\u0027t race here - if it fails, then stops whole job - as it didn\u0027t previously in upgrade jobs - if you feel that it should have it, please propose it in follow up.\n\nbtw: here if machine_type is not defined it won\u0027t extend with this var (+ behaviour in bash):\n\nexample (arm and first run x86 - i440fx):\n+ local fip_file\u003d/tmp/kolla_ci_pre_upgrade_fip_addr\n\nexample (x86 second run q35):\n+ local fip_file\u003d/tmp/kolla_ci_pre_upgrade_fip_addr_q35","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"67a7df87040f0472a36797ef208bc3467dd82e21","unresolved":false,"context_lines":[{"line_number":289,"context_line":"function test_instance_boot {"},{"line_number":290,"context_line":"    local fip_addr"},{"line_number":291,"context_line":"    local machine_type\u003d\"${1}\""},{"line_number":292,"context_line":"    local fip_file\u003d\"/tmp/kolla_ci_pre_upgrade_fip_addr${machine_type:+_$machine_type}\""},{"line_number":293,"context_line":"    local upgrade_instance_name\u003d\"kolla_upgrade_test${machine_type:+_$machine_type}\""},{"line_number":294,"context_line":"    local volume_name\u003d\"durable_volume${machine_type:+_$machine_type}\""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"88bdbd9b_fafe4f44","line":292,"range":{"start_line":292,"start_character":25,"end_line":292,"end_character":54},"in_reply_to":"c7222be7_54c923b1","updated":"2023-09-11 14:17:10.000000000","message":"ok, but anyway this is best practice to work with /tmp","commit_id":"30fca662bc4a22abef0add5662c720c0ed6e1dd7"}]}