)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aaa43f5b485dbe4d65652ee729459731b01caf43","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e379816_16223618","updated":"2023-09-13 11:23:17.000000000","message":"reno and docs?","commit_id":"1431bd5b19541100e169447ebc53d67613622405"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"daf536c6df072b57634ccfc0d1ac6636372e7f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1daa57a1_2185bbaa","in_reply_to":"1e379816_16223618","updated":"2023-09-13 12:09:31.000000000","message":"Done","commit_id":"1431bd5b19541100e169447ebc53d67613622405"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1cb1921a7f8974682802d182fff14213086d92f8","unresolved":true,"context_lines":[{"line_number":716,"context_line":"# Neutron modules"},{"line_number":717,"context_line":"####################"},{"line_number":718,"context_line":"neutron_modules_default:"},{"line_number":719,"context_line":"  - {\u0027name\u0027: ip6_tables}"},{"line_number":720,"context_line":"neutron_modules_extra: []"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0c638b61_b4fe1e88","line":719,"updated":"2023-09-12 12:56:31.000000000","message":"nit: whitespace missing","commit_id":"938b4a97c9d1c842f74f6e162f110ba6c1543955"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"86ae974eddd8584921bc119e672eb3cf4cce66d8","unresolved":false,"context_lines":[{"line_number":716,"context_line":"# Neutron modules"},{"line_number":717,"context_line":"####################"},{"line_number":718,"context_line":"neutron_modules_default:"},{"line_number":719,"context_line":"  - {\u0027name\u0027: ip6_tables}"},{"line_number":720,"context_line":"neutron_modules_extra: []"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a62200e_edbb7984","line":719,"in_reply_to":"0c638b61_b4fe1e88","updated":"2023-09-13 10:59:45.000000000","message":"Done","commit_id":"938b4a97c9d1c842f74f6e162f110ba6c1543955"}],"ansible/roles/neutron/tasks/config-host.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ed826328f1df5fa8b60d04d462098e11cd1d42fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Load and persist ip6_tables module"},{"line_number":3,"context_line":"  include_role:"},{"line_number":4,"context_line":"    name: module-load"},{"line_number":5,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5bbc0199_a87a31f2","line":2,"updated":"2023-09-14 04:54:26.000000000","message":"The name of the task should be amended","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"038c8a07487f4e656377a116d839cd66bf3494e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Load and persist ip6_tables module"},{"line_number":3,"context_line":"  include_role:"},{"line_number":4,"context_line":"    name: module-load"},{"line_number":5,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"31fecbb0_951d2e06","line":2,"in_reply_to":"5bbc0199_a87a31f2","updated":"2023-09-18 12:33:59.000000000","message":"Done","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ed826328f1df5fa8b60d04d462098e11cd1d42fa","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    neutron_services |"},{"line_number":9,"context_line":"    select_services_enabled_and_mapped_to_host |"},{"line_number":10,"context_line":"    list |"},{"line_number":11,"context_line":"    intersect([\"neutron-l3-agent\", \"neutron-linuxbridge-agent\", \"neutron-openvswitch-agent\"]) |"},{"line_number":12,"context_line":"    list |"},{"line_number":13,"context_line":"    length \u003e 0"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3624ef32_3d0bbf1f","line":11,"updated":"2023-09-14 04:54:26.000000000","message":"I think this restriction should be mentioned in the doc. Or should it be made more flexible, too? like can kernel modules also be needed for OVN?","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"038c8a07487f4e656377a116d839cd66bf3494e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    neutron_services |"},{"line_number":9,"context_line":"    select_services_enabled_and_mapped_to_host |"},{"line_number":10,"context_line":"    list |"},{"line_number":11,"context_line":"    intersect([\"neutron-l3-agent\", \"neutron-linuxbridge-agent\", \"neutron-openvswitch-agent\"]) |"},{"line_number":12,"context_line":"    list |"},{"line_number":13,"context_line":"    length \u003e 0"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"10e15563_96639c67","line":11,"in_reply_to":"3624ef32_3d0bbf1f","updated":"2023-09-18 12:33:59.000000000","message":"Those are all neutron services needs kernel modules at this point.","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"}],"releasenotes/notes/add-neutron-custom-kernel-modules-d105d3f84665e0a4.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ed826328f1df5fa8b60d04d462098e11cd1d42fa","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added capability to specify custom kernel modules for Neutron:"},{"line_number":5,"context_line":"    - `neutron_modules_default`: Lists default modules."},{"line_number":6,"context_line":"    - `neutron_modules_extra`: For custom modules and parameters."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ae47b65d_be08f0d9","line":6,"updated":"2023-09-14 04:54:26.000000000","message":"This doesn\u0027t render properly, maybe reword this as floating text instead of a list","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"038c8a07487f4e656377a116d839cd66bf3494e4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added capability to specify custom kernel modules for Neutron:"},{"line_number":5,"context_line":"    - `neutron_modules_default`: Lists default modules."},{"line_number":6,"context_line":"    - `neutron_modules_extra`: For custom modules and parameters."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3d707700_b4d4e1a5","line":6,"in_reply_to":"ae47b65d_be08f0d9","updated":"2023-09-18 12:33:59.000000000","message":"Done","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ed826328f1df5fa8b60d04d462098e11cd1d42fa","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_modules_extra:"},{"line_number":203,"context_line":"  - name: \u0027nf_conntrack_tftp\u0027"},{"line_number":204,"context_line":"  - name: \u0027nf_nat_tftp\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"d3106e11_19046d98","line":204,"updated":"2023-09-14 04:54:26.000000000","message":"Is there something special about this modules that we could test? Or should we just add a check that they actually get loaded?","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bf8dba4d77d80798f51b7c33c73681bc2da7677d","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_modules_extra:"},{"line_number":203,"context_line":"  - name: \u0027nf_conntrack_tftp\u0027"},{"line_number":204,"context_line":"  - name: \u0027nf_nat_tftp\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7c51ccc2_92ae7812","line":204,"in_reply_to":"02ecc989_337e874d","updated":"2023-09-22 09:24:37.000000000","message":"So can we add something to test that this is actually working and not just a no-op? Or are we sure that \"does not stop with an error\" is a good enough test?","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"047cc1a52ff2cef440b541540af628401fb64205","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_modules_extra:"},{"line_number":203,"context_line":"  - name: \u0027nf_conntrack_tftp\u0027"},{"line_number":204,"context_line":"  - name: \u0027nf_nat_tftp\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a7daa592_fd4b4a13","line":204,"in_reply_to":"7c51ccc2_92ae7812","updated":"2023-09-22 09:26:53.000000000","message":"I\u0027ve added a test which is checking for existence of those modules in /proc/modules, I think that\u0027s a decent check if module got loaded","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d193c6b7c8d369e8918c3afeff5d86478230581e","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_modules_extra:"},{"line_number":203,"context_line":"  - name: \u0027nf_conntrack_tftp\u0027"},{"line_number":204,"context_line":"  - name: \u0027nf_nat_tftp\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"66887bf8_682c4d72","line":204,"in_reply_to":"a7daa592_fd4b4a13","updated":"2023-09-22 12:32:00.000000000","message":"Oh, I missed that, sorry.","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"038c8a07487f4e656377a116d839cd66bf3494e4","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_modules_extra:"},{"line_number":203,"context_line":"  - name: \u0027nf_conntrack_tftp\u0027"},{"line_number":204,"context_line":"  - name: \u0027nf_nat_tftp\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"02ecc989_337e874d","line":204,"in_reply_to":"d3106e11_19046d98","updated":"2023-09-18 12:33:59.000000000","message":"this example is needed for neutron conntrack helpers for tftp traffic - https://bugzilla.redhat.com/show_bug.cgi?id\u003d1940667","commit_id":"c14545f2ea934d2274a70114571b4e5f0f824998"}]}