)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7b319efa1b4e10941debf8dc1ed22869ef78ebd4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c8e7c81_12ba8093","updated":"2023-09-25 07:25:36.000000000","message":"We\u0027re not packaging any Cluster API driver - should we start with that?","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"efadcf193a26a1753f4020278058746bc62db99d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fda8d89e_e89ef2b4","updated":"2023-11-20 06:52:27.000000000","message":"What holding this patch to move forward?","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b57bcf5319430a0f5f3a585befc6fdb46ed1263b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c732dda2_6d5d5d5a","in_reply_to":"7c8e7c81_12ba8093","updated":"2023-10-05 07:47:13.000000000","message":"Not yet. We use the Vexxhost plugin on our side. You only have to install Helm + the plugin in the Magnum container images. This change is required to be able to use the Vexxhost plugin.","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1aae404446cf8e24afc3de3741d8dc071ea77707","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"963d19c6_5d592682","in_reply_to":"9fbfc8a9_ddd95d0f","updated":"2023-11-29 07:13:35.000000000","message":"Done","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1aae404446cf8e24afc3de3741d8dc071ea77707","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65dfc167_052d22ec","in_reply_to":"a1b116b4_00baabf6","updated":"2023-11-29 07:13:35.000000000","message":"Done","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a293864d94ca958e015f46c94421b1e8b40e54ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fbfc8a9_ddd95d0f","in_reply_to":"c732dda2_6d5d5d5a","updated":"2023-10-05 07:51:56.000000000","message":"So let\u0027s just install the vexxhost plugin in the Kolla Magnum image? It\u0027s getting a lot of community - so I\u0027m fine with that.","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5352d6d5316272770dc2ffec974864635abe2988","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a1b116b4_00baabf6","in_reply_to":"fda8d89e_e89ef2b4","updated":"2023-11-20 08:47:35.000000000","message":"Kolla Magnum images don’t have a driver that needs that.","commit_id":"6c799441f1855dfed9301548397057ed221ce8af"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"7242646749f8c872634b7d6643e1580229e6b3de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f90c915a_f8f7a606","updated":"2023-11-28 17:48:07.000000000","message":"I made the necessary change to introduce it into the Kolla images and added it as a dependent change.","commit_id":"60c6f36a538748f805ebe7b95578bf7c3f7d3244"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"15db46c1a2856f3617569e243d00ae66ed27324e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f91cce37_d4c226c5","updated":"2023-11-28 22:39:17.000000000","message":"Hmm, it seems that `magnum_kubeconfig_file` needs to be defined somewhere but I\u0027m not familiar enough with the codebase to make the right place to add it.  Should I add it to the defaults for the Magnum role?","commit_id":"3cdcd09df58fe9f783072b2992bfea7d195d8fe4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92261eafc2d36cc391df50d829d95daf30223792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a835e54d_c50837b1","in_reply_to":"811115e7_1abe6494","updated":"2023-12-01 07:15:15.000000000","message":"Done","commit_id":"3cdcd09df58fe9f783072b2992bfea7d195d8fe4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"adf3d5687d423fbc0f5336be201fc315d51cdd0d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"811115e7_1abe6494","in_reply_to":"f91cce37_d4c226c5","updated":"2023-11-29 14:42:49.000000000","message":"I\u0027m also not 100% sure, but I would just stick it into `kolla-ansible/ansible/group_vars/all.yml` with an unset default for now? like this: `magnum_kubeconfig_file: \"\"`\n\n@mnasiadka do you think this is okay or should this go into the magnum role itself? but I see no reason for that?","commit_id":"3cdcd09df58fe9f783072b2992bfea7d195d8fe4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92261eafc2d36cc391df50d829d95daf30223792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c6808c03_7106d25a","updated":"2023-12-01 07:15:15.000000000","message":"Failing on podman jobs, rebasing on fix.","commit_id":"fcca8d858803c5ee29d9a4775be7006e05863358"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"31a55cdbc54b18b2c71e0edf5e48adf13dd5e9f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cd08178e_fc469646","updated":"2023-11-30 17:52:20.000000000","message":"Went with copying what we already do in ceilometer role","commit_id":"fcca8d858803c5ee29d9a4775be7006e05863358"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7e15797f9e1a1070bd3632a32311570a68131fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3b715f9_e0414bf3","updated":"2023-12-01 06:05:07.000000000","message":"single merging last patch nefore release","commit_id":"fcca8d858803c5ee29d9a4775be7006e05863358"}],"ansible/roles/magnum/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"70f07da64794ab665cee7f9d503c3d74e6840301","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - magnum_policy.results"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Check if kubeconfig file is supplied"},{"line_number":35,"context_line":"  stat:"},{"line_number":36,"context_line":"    path: \"{{ node_custom_config }}/magnum/kubeconfig\""},{"line_number":37,"context_line":"  delegate_to: localhost"},{"line_number":38,"context_line":"  run_once: True"},{"line_number":39,"context_line":"  register: magnum_kubeconfig_file"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Copying over kubeconfig file"},{"line_number":42,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bdb1129f_5087a335","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":34},"updated":"2023-12-01 08:10:04.000000000","message":"this should be allowed to fail, no?","commit_id":"c939504da66a0c9a5f02f309e4c1e60872c0f9d7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"54c488af8e4c4bea6e1dad9c91c9cc4dbfacffec","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - magnum_policy.results"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Check if kubeconfig file is supplied"},{"line_number":35,"context_line":"  stat:"},{"line_number":36,"context_line":"    path: \"{{ node_custom_config }}/magnum/kubeconfig\""},{"line_number":37,"context_line":"  delegate_to: localhost"},{"line_number":38,"context_line":"  run_once: True"},{"line_number":39,"context_line":"  register: magnum_kubeconfig_file"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Copying over kubeconfig file"},{"line_number":42,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2957e9d5_6bf98a0d","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":34},"in_reply_to":"bdb1129f_5087a335","updated":"2023-12-01 08:32:45.000000000","message":"it will never fail - magnum_kubeconfig_file.stat.exists will just be false","commit_id":"c939504da66a0c9a5f02f309e4c1e60872c0f9d7"}]}