)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1add86c4b3f18d668db9f322e9bd21d1fa27757e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make designate bind9 cmdline configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This simple patch adding option to define"},{"line_number":10,"context_line":"extra cmdline parameters for bind."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2037272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"be06e261_471e4e14","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":24},"updated":"2023-09-26 04:56:27.000000000","message":"adds an","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c2110ee67f8577e90c9e8608d9349e367594b148","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make designate bind9 cmdline configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This simple patch adding option to define"},{"line_number":10,"context_line":"extra cmdline parameters for bind."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2037272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fae6f089_88fb2448","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":24},"in_reply_to":"be06e261_471e4e14","updated":"2023-11-13 16:21:18.000000000","message":"Done","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b12f29baff84d7ef2fd9b2bcc74f72c9c978f1a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d05f39e3_f6d77179","updated":"2023-09-25 09:48:48.000000000","message":"Guys, as config.json is not overrideable let me propose this simple patch which is adding option to pass extra params to bind9 binary execution.\n\nIn our case we are adding \u0027-4\u0027 to disable ipv6 resolving as we don\u0027t need it and therefore bind9 is faster.","commit_id":"da9842e3d1ecc57ea4bc45a14e215e35da19cac5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4696bb7f4d477419a26aba2505f388fa25f63b75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6c73ec26_ce786a59","updated":"2023-12-20 10:18:04.000000000","message":"what about this ? can we merge ?","commit_id":"21cff07c4911006626e6bed7574375340ea16fe9"}],"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55adab78fff145862593162620ceb9974542306b","unresolved":true,"context_lines":[{"line_number":313,"context_line":"designate_recursion: \"no\""},{"line_number":314,"context_line":"## Example for designate_forwarders_addresses: \"10.199.200.1; 10.199.100.1\""},{"line_number":315,"context_line":"designate_forwarders_addresses: \"\""},{"line_number":316,"context_line":"designate_backend_bind9_cmdline_extras: \"-U {{ designate_backend_bind9_workers }} -g\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"####################"},{"line_number":319,"context_line":"# Infoblox"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ebab2398_e17314e9","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":85},"updated":"2023-09-26 04:19:58.000000000","message":"I think it would be better if we would do:\ndesignate_backend_bind9_cmdline: \"/usr/sbin/whatever -U {{ designate_backend_bind9_workers -g {{ designate_backend_bind9_cmdline_extra }}\"\ndesignate_backend_bind9_cmdline_extra: \"\"","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c2110ee67f8577e90c9e8608d9349e367594b148","unresolved":false,"context_lines":[{"line_number":313,"context_line":"designate_recursion: \"no\""},{"line_number":314,"context_line":"## Example for designate_forwarders_addresses: \"10.199.200.1; 10.199.100.1\""},{"line_number":315,"context_line":"designate_forwarders_addresses: \"\""},{"line_number":316,"context_line":"designate_backend_bind9_cmdline_extras: \"-U {{ designate_backend_bind9_workers }} -g\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"####################"},{"line_number":319,"context_line":"# Infoblox"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a3a70507_34be1c3e","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":85},"in_reply_to":"2853a5da_02e05788","updated":"2023-11-13 16:21:18.000000000","message":"Done","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f3e4e4981697e20f9537e5de0cccc131aca5b4e9","unresolved":true,"context_lines":[{"line_number":313,"context_line":"designate_recursion: \"no\""},{"line_number":314,"context_line":"## Example for designate_forwarders_addresses: \"10.199.200.1; 10.199.100.1\""},{"line_number":315,"context_line":"designate_forwarders_addresses: \"\""},{"line_number":316,"context_line":"designate_backend_bind9_cmdline_extras: \"-U {{ designate_backend_bind9_workers }} -g\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"####################"},{"line_number":319,"context_line":"# Infoblox"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2853a5da_02e05788","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":85},"in_reply_to":"8faac2e2_31add6e0","updated":"2023-09-26 05:02:18.000000000","message":"Right, it seems my morning coffee did not work yet - thanks for correcting ;-)","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1add86c4b3f18d668db9f322e9bd21d1fa27757e","unresolved":true,"context_lines":[{"line_number":313,"context_line":"designate_recursion: \"no\""},{"line_number":314,"context_line":"## Example for designate_forwarders_addresses: \"10.199.200.1; 10.199.100.1\""},{"line_number":315,"context_line":"designate_forwarders_addresses: \"\""},{"line_number":316,"context_line":"designate_backend_bind9_cmdline_extras: \"-U {{ designate_backend_bind9_workers }} -g\""},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"####################"},{"line_number":319,"context_line":"# Infoblox"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8faac2e2_31add6e0","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":85},"in_reply_to":"ebab2398_e17314e9","updated":"2023-09-26 04:56:27.000000000","message":"I don\u0027t agree that the executable name should necessarily be part of the cmdline, it is given by the container image, why would you want to override that?\n\nI do agree that \"*_extra\" should be empty by default.","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"}],"ansible/roles/designate/templates/designate-backend-bind9.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33eaf30dd028f0ebc375ef2afad065548eb1050d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {% if designate_backend_bind9_cmdline_extras %}{{ designate_backend_bind9_cmdline_extras }}{% endif %}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8910e609_7e7b7b38","line":5,"range":{"start_line":5,"start_character":84,"end_line":5,"end_character":176},"updated":"2023-09-25 09:54:01.000000000","message":"do we need that if? the default is empty","commit_id":"5901f532fdc922dc68522596b00527f829d1492e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4711647281b1044d40daf3a443af07d0690eb101","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {% if designate_backend_bind9_cmdline_extras %}{{ designate_backend_bind9_cmdline_extras }}{% endif %}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e43fdf77_27a61528","line":5,"range":{"start_line":5,"start_character":84,"end_line":5,"end_character":176},"in_reply_to":"7095e8dd_d33f8bc7","updated":"2023-09-25 10:01:11.000000000","message":"Aaaa, yeah, sorry :)\n\nLet me do it.","commit_id":"5901f532fdc922dc68522596b00527f829d1492e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e31b6bfdc7cbc28455b0b7fc79638e02a2444a28","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {% if designate_backend_bind9_cmdline_extras %}{{ designate_backend_bind9_cmdline_extras }}{% endif %}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7095e8dd_d33f8bc7","line":5,"range":{"start_line":5,"start_character":84,"end_line":5,"end_character":176},"in_reply_to":"867bab89_5d4d0e2f","updated":"2023-09-25 09:58:59.000000000","message":"I have asked about the implementation, not why do you want to do it.\nSince designate_backend_bind9_cmdline_extras is empty by default, you don\u0027t need the \"if\" \"endif\" statement.\nIf you\u0027ll attach a bug - we can backport that.","commit_id":"5901f532fdc922dc68522596b00527f829d1492e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3dea34aba99279fae478d74dd0847eea127aa3e7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {% if designate_backend_bind9_cmdline_extras %}{{ designate_backend_bind9_cmdline_extras }}{% endif %}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"867bab89_5d4d0e2f","line":5,"range":{"start_line":5,"start_character":84,"end_line":5,"end_character":176},"in_reply_to":"8910e609_7e7b7b38","updated":"2023-09-25 09:56:50.000000000","message":"Did you read message I\u0027ve sent to you when I was adding you as reviewers ? \n\n\u003e\u003e\n\nGuys, as config.json is not overrideable let me propose this simple patch which is adding option to pass extra params to bind9 binary execution.\n\nIn our case we are adding \u0027-4\u0027 to disable ipv6 resolving as we don\u0027t need it and therefore bind9 is faster.\n\n\u003c\u003c","commit_id":"5901f532fdc922dc68522596b00527f829d1492e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f85d08d5749a83be767a93ffebf37fa6b756dcbf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {% if designate_backend_bind9_cmdline_extras %}{{ designate_backend_bind9_cmdline_extras }}{% endif %}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"28d92216_9f5ac1fe","line":5,"range":{"start_line":5,"start_character":84,"end_line":5,"end_character":176},"in_reply_to":"e43fdf77_27a61528","updated":"2023-09-25 10:09:10.000000000","message":"Done","commit_id":"5901f532fdc922dc68522596b00527f829d1492e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e08b08cce90256041d4eccecfd7fad32dc74e96a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"022f3cb1_7a382ba6","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"updated":"2023-09-25 11:10:41.000000000","message":"lets move this to the designate_backend_bind9_cmdline_extras and rename it to designate_backend_bind9_cmdline","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d6cba528d1f7448e816404988e7c73368fc570b9","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"a7bd9182_3454c0e8","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"022f3cb1_7a382ba6","updated":"2023-09-25 12:10:32.000000000","message":"Hmm, i think this is good idea, but don\u0027t you think designate_backend_bind9_cmdline_extras will be better name ? \n\nBecause designate_backend_bind9_cmdline sounds like entire command...\n\nWDYT ?","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c2e55bf38d6283763ea1f87adc47e7aa93b20dae","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e9c53731_64f27d9b","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"07bb2790_a0ef35cb","updated":"2023-09-25 12:23:23.000000000","message":"if you like designate_backend_bind9_cmdline_extras then we need to declare designate_backend_bind9_cmdline_defaults \u003d \"-U {{ designate_backend_bind9_workers }} -g\", then declare designate_backend_bind9_cmdline_extras \u003d \"\" (an empty string), then declare designate_backend_bind9_cmdline \u003d \"{{ designate_backend_bind9_cmdline_default }} + {{ designate_backend_bind9_cmdline_extras }}\" and then use designate_backend_bind9_cmdline here.","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2766efd0ac3b8ff685fd98a0ac1a7529f8e07c5a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"24e81fae_9978c04a","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"2cda6c8a_e2195b18","updated":"2023-09-25 21:39:46.000000000","message":"Okay, let\u0027s go with simplest approach and move options to variable as a compromise.","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d8eb42ec2ac8d718f9b22c4c86e96f6b346998df","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"2cda6c8a_e2195b18","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"47518347_af29e6c8","updated":"2023-09-25 20:46:38.000000000","message":"you asked me, I\u0027m answered)","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1974dcb4ffaa85272583a10971ded2608a37a390","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"07bb2790_a0ef35cb","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"8858f6b1_489d2e7f","updated":"2023-09-25 12:18:55.000000000","message":"Can you be more specific ? :)","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5812b17328fa870942c3431131059adbfd7ba5ad","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8858f6b1_489d2e7f","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"a7bd9182_3454c0e8","updated":"2023-09-25 12:17:18.000000000","message":"so this way to _default + _extras pattern)","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"22022fabd0154e346c1b488fffcade8d2aa88c0e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"},{"line_number":5,"context_line":"    \"command\": \"/usr/sbin/{{ bind_cmd }} -U {{ designate_backend_bind9_workers }} -g {{ designate_backend_bind9_cmdline_extras }}\","},{"line_number":6,"context_line":"    \"config_files\": ["},{"line_number":7,"context_line":"        {"},{"line_number":8,"context_line":"            \"source\": \"{{ container_config_directory }}/named.conf\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"47518347_af29e6c8","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":84},"in_reply_to":"e9c53731_64f27d9b","updated":"2023-09-25 12:32:23.000000000","message":"Why to propose additional vars ? \n\nCmdline won\u0027t be different - it will be always bind9.\nSo i think it\u0027s enough to create designate_backend_bind9_cmdline_extras and move all to this var as default, isn\u0027t it ?","commit_id":"07ed281a27717b432fde8d2dd2624b4ef66abf31"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"55adab78fff145862593162620ceb9974542306b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set bind_cmd \u003d \u0027named\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named\u0027 %}"},{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6aab0a65_635b7f35","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":86},"updated":"2023-09-26 04:19:58.000000000","message":"not counting this is useless? ;-)","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c2110ee67f8577e90c9e8608d9349e367594b148","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set bind_cmd \u003d \u0027named\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named\u0027 %}"},{"line_number":2,"context_line":"{% set bind_file \u003d \u0027bind/named.conf\u0027 if kolla_base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] else \u0027named.conf\u0027 %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"339cda8f_f8dedd85","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":86},"in_reply_to":"6aab0a65_635b7f35","updated":"2023-11-13 16:21:18.000000000","message":"Done","commit_id":"d15e4230c5b047019c0423c8f2f30b62a0ec298e"}]}