)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"548566a746617b351a796eabe730f8e283b0ec4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62becd45_63b47151","updated":"2023-11-10 16:24:39.000000000","message":"basically agreeing with the other reviewers here 😊","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"}],"ansible/roles/nova-cell/templates/nova.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"457ad37f8c4e8c187c663e15f236ee777122386e","unresolved":true,"context_lines":[{"line_number":102,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":103,"context_line":"auth_type \u003d password"},{"line_number":104,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":105,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":106,"context_line":"project_name \u003d service"},{"line_number":107,"context_line":"username \u003d {{ glance_keystone_user }}"},{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f10bccbd_eb0a3fc3","line":105,"updated":"2023-10-24 12:12:32.000000000","message":"why not user_domain_name like above?","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"548566a746617b351a796eabe730f8e283b0ec4e","unresolved":true,"context_lines":[{"line_number":102,"context_line":"auth_url \u003d {{ keystone_internal_url }}"},{"line_number":103,"context_line":"auth_type \u003d password"},{"line_number":104,"context_line":"project_domain_name \u003d {{ default_project_domain_name }}"},{"line_number":105,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":106,"context_line":"project_name \u003d service"},{"line_number":107,"context_line":"username \u003d {{ glance_keystone_user }}"},{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"49cf3ab0_2a1f0af0","line":105,"in_reply_to":"f10bccbd_eb0a3fc3","updated":"2023-11-10 16:24:39.000000000","message":"Ack","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"457ad37f8c4e8c187c663e15f236ee777122386e","unresolved":true,"context_lines":[{"line_number":105,"context_line":"user_domain_id \u003d {{ default_user_domain_id }}"},{"line_number":106,"context_line":"project_name \u003d service"},{"line_number":107,"context_line":"username \u003d {{ glance_keystone_user }}"},{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"},{"line_number":109,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":110,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":111,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d3db2565_b78d7c97","line":108,"updated":"2023-10-24 12:12:32.000000000","message":"IMO this should use the nova user, not the glance user","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cfe8d14df7f98eebe8cc251fb5ecd48996416dea","unresolved":true,"context_lines":[{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"},{"line_number":109,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":110,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":111,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_cinder | bool %}"},{"line_number":114,"context_line":"[cinder]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"de46b882_724c3a75","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":49},"updated":"2023-10-06 10:59:33.000000000","message":"lets drop this and leave defaults","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"457ad37f8c4e8c187c663e15f236ee777122386e","unresolved":true,"context_lines":[{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"},{"line_number":109,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":110,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":111,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_cinder | bool %}"},{"line_number":114,"context_line":"[cinder]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e022e339_373ab139","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":49},"in_reply_to":"de46b882_724c3a75","updated":"2023-10-24 12:12:32.000000000","message":"Ack","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"548566a746617b351a796eabe730f8e283b0ec4e","unresolved":true,"context_lines":[{"line_number":108,"context_line":"password \u003d {{ glance_keystone_password }}"},{"line_number":109,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":110,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":111,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"{% if enable_cinder | bool %}"},{"line_number":114,"context_line":"[cinder]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"539a8fb4_b659861b","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":49},"in_reply_to":"e022e339_373ab139","updated":"2023-11-10 16:24:39.000000000","message":"Ack\n\nnit: if we drop this it would be nice to add a reference that this was changed in upstream:\n\nhttps://review.opendev.org/c/openstack/nova/+/740389","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eb5f4296ea1d5f300e7e2fc3633079df870b98dc","unresolved":true,"context_lines":[{"line_number":65,"context_line":"username \u003d {{ glance_keystone_user }}"},{"line_number":66,"context_line":"password \u003d {{ glance_keystone_password }}"},{"line_number":67,"context_line":"cafile \u003d {{ openstack_cacert }}"},{"line_number":68,"context_line":"num_retries \u003d {{ groups[\u0027glance-api\u0027] | length }}"},{"line_number":69,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"{% if enable_cinder | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3ec37de5_0ab29c43","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":49},"updated":"2023-10-06 11:00:00.000000000","message":"ditto","commit_id":"d4ecd6e07a9a55b5f57f5e0548fb1b2ac429047e"}]}