)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"67a469c2c460a0745fdb1b9a1f275b5950880112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"665d59f5_e5cc3952","updated":"2023-11-27 18:16:08.000000000","message":"recheck get fresh CI results","commit_id":"04bf8e7c1ecf97ead104f901f0ab9d33d3fd0ccf"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"a28a8aa0a1d7b2c49b465e09b0013533daf7c50f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ae40a69_99bb5bcd","updated":"2024-02-05 08:14:42.000000000","message":"recheck - galaxy issues","commit_id":"3621849b3533d39fd8517867a46cbe1b751d2c22"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc581918704aa3b05f547c1f079bf47fca5a50b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a9e62838_b1face14","updated":"2024-02-27 06:45:23.000000000","message":"recheck - new images landed, slurp job should pass","commit_id":"099433eba4a6750c8468b78425b236dc561f0d92"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a25e35f19aa5a40e0b86d43ab3afe126b926faff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4b00bcbb_2ca32559","updated":"2024-02-26 17:12:37.000000000","message":"recheck ssh host key failure in kolla-ansible-debian-podman POST_FAILURE (unrelated)","commit_id":"099433eba4a6750c8468b78425b236dc561f0d92"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cee83bb19e264e1e76f34c431367ccbd97babed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"99797ebd_ec17be23","updated":"2024-04-29 07:22:20.000000000","message":"This has been here for too long and has previous +2s","commit_id":"ed1b410af98342835892494a1040cd4502fb9a7f"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1702b0425a6b0558a5702b136e70be7f20a1dc19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6fb78264_2834481c","updated":"2024-02-27 10:35:28.000000000","message":"let me check the CI, before I give +1.","commit_id":"ed1b410af98342835892494a1040cd4502fb9a7f"}],"tests/reconfigure.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"67a469c2c460a0745fdb1b9a1f275b5950880112","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":18,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/reconfigure-prechecks"},{"line_number":21,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv reconfigure \u0026\u003e /tmp/logs/ansible/reconfigure"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1b8e46d5_b44701b8","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"updated":"2023-11-27 18:16:08.000000000","message":"I guess this shouldn\u0027t be prepared just yet for a docker-\u003epodman switch, should it?\neither way I guess that should probably be done in a separate change.","commit_id":"04bf8e7c1ecf97ead104f901f0ab9d33d3fd0ccf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9d6534cb84451405b0ddfcf54d6f605661fa64a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":18,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/reconfigure-prechecks"},{"line_number":21,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv reconfigure \u0026\u003e /tmp/logs/ansible/reconfigure"}],"source_content_type":"text/x-sh","patch_set":4,"id":"2cdec3db_b7262360","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":19},"in_reply_to":"1b8e46d5_b44701b8","updated":"2023-11-29 13:56:28.000000000","message":"yes, will do that in separate change","commit_id":"04bf8e7c1ecf97ead104f901f0ab9d33d3fd0ccf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"6ea2a37dcf45777d6b197a0c8221561c08058b7e","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # TODO(mnasiadka): use container engine dependent commands here when adding podman jobs"},{"line_number":18,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":19,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":20,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"b4ff0b89_79d0c54e","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":89},"updated":"2024-02-05 11:16:51.000000000","message":"can we have some kind of tracking issue for this, or how do you keep track of all the code todos?\nor better yet, implement this for podman and docker? there are plenty of code examples floating around for both.","commit_id":"3621849b3533d39fd8517867a46cbe1b751d2c22"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8680ec456b4f15747ae35f6586a5fa3297f85d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # TODO(mnasiadka): use container engine dependent commands here when adding podman jobs"},{"line_number":18,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":19,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":20,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"d5e233fa_2ff5b627","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":89},"in_reply_to":"65ee6362_0eb4946b","updated":"2024-02-26 08:53:15.000000000","message":"Done","commit_id":"3621849b3533d39fd8517867a46cbe1b751d2c22"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1db8bd2d0fe0200be366c010a2ee3b7307277ad6","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # TODO(mnasiadka): use container engine dependent commands here when adding podman jobs"},{"line_number":18,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":19,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":20,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"f64fa1e1_7f3a6790","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":89},"in_reply_to":"b4ff0b89_79d0c54e","updated":"2024-02-05 11:20:33.000000000","message":"But the job runs only on docker, what sense does it make to waste extra hours on this?","commit_id":"3621849b3533d39fd8517867a46cbe1b751d2c22"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c802610c1d43f502730a6427a1d56aea142f03ce","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # TODO(jeffrey4l): make some configure file change and"},{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # TODO(mnasiadka): use container engine dependent commands here when adding podman jobs"},{"line_number":18,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":19,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":20,"context_line":"        sudo docker rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"65ee6362_0eb4946b","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":89},"in_reply_to":"f64fa1e1_7f3a6790","updated":"2024-02-05 11:24:20.000000000","message":"are you saying it doesn\u0027t matter if this is running in docker or podman thus docker is sufficient? than I don\u0027t see a point in this comment.\n\nmaybe replace it instead by:\n```#attention: this is on purpose only tested in docker because we want to preserve resources and there is no benefit in testing in both docker and podman.```\n\na TODO comments should be actionable imho. if we never plan to do what is in the TODO, than there is no point in making that comment, no? ;)","commit_id":"3621849b3533d39fd8517867a46cbe1b751d2c22"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3beccfe62c4739476a51119c6e42cb252b8daddc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":18,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":19,"context_line":"        sudo ${CONTAINER_ENGINE} rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/reconfigure-prechecks"},{"line_number":22,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv reconfigure \u0026\u003e /tmp/logs/ansible/reconfigure"}],"source_content_type":"text/x-sh","patch_set":8,"id":"f6629288_ff97c3fe","line":19,"range":{"start_line":19,"start_character":67,"end_line":19,"end_character":73},"updated":"2024-02-27 10:31:45.000000000","message":"${CONTAINER_ENGINE}","commit_id":"099433eba4a6750c8468b78425b236dc561f0d92"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1702b0425a6b0558a5702b136e70be7f20a1dc19","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # trigger a real reconfigure"},{"line_number":17,"context_line":"    # NOTE(mnasiadka): Remove OVN DB containers and volumes on primary to test recreation"},{"line_number":18,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":19,"context_line":"        sudo ${CONTAINER_ENGINE} rm -f ovn_nb_db ovn_sb_db \u0026\u0026 sudo docker volume rm ovn_nb_db ovn_sb_db"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/reconfigure-prechecks"},{"line_number":22,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv reconfigure \u0026\u003e /tmp/logs/ansible/reconfigure"}],"source_content_type":"text/x-sh","patch_set":8,"id":"f59461a7_5cf5edd2","line":19,"range":{"start_line":19,"start_character":67,"end_line":19,"end_character":73},"in_reply_to":"f6629288_ff97c3fe","updated":"2024-02-27 10:35:28.000000000","message":"Done","commit_id":"099433eba4a6750c8468b78425b236dc561f0d92"}]}