)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5629f8cc6fc57fc9021d558008be595afeaa2329","unresolved":true,"context_lines":[{"line_number":10,"context_line":"to enable quorum queues for each service in RabbitMQ, similar to"},{"line_number":11,"context_line":"what was done for HA[0]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Quorum Queues are disabled by default for now."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Quorum queues are more reliable, safer, simpler and faster than"},{"line_number":16,"context_line":"replicated mirrored classic queues[1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"38a9fdb8_5e43855c","line":13,"updated":"2023-11-30 07:24:42.000000000","message":"This sentence seems to be wrong in the current state of the patch?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"548546499cdf2e913a0150fdff6572da95864e5d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to enable quorum queues for each service in RabbitMQ, similar to"},{"line_number":11,"context_line":"what was done for HA[0]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Quorum Queues are disabled by default for now."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Quorum queues are more reliable, safer, simpler and faster than"},{"line_number":16,"context_line":"replicated mirrored classic queues[1]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"22dc3174_0a118a8f","line":13,"in_reply_to":"38a9fdb8_5e43855c","updated":"2023-11-30 10:33:32.000000000","message":"Done","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"44c9360e87f888b32bc0d0c3dcb2a655ba3156a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1548c64a_73dd409e","updated":"2023-10-23 13:05:56.000000000","message":"Thanks for proposing this!","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":35536,"name":"Jakub Neumann","display_name":"Jakub Neumann (Cloudferro)","email":"jakub.neumann@gmail.com","username":"jneumann"},"change_message_id":"97cf9d73e6016a42927a689e215d1c2e0e734bd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cf20ebd_4047974d","updated":"2023-10-23 13:27:54.000000000","message":"We use it on production yoga and it works good enough.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"58e6b402f556c9b27e5bd8d63df1e3b6be6126a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a5a98b0_77636d31","updated":"2023-10-24 12:08:27.000000000","message":"lgtm, but need tests on CI as discussed on PTG session","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f1f20c1df2d046d0b65e961ac1808726948fb23c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06f92ae7_e9b4bdaa","in_reply_to":"5cf20ebd_4047974d","updated":"2023-10-23 13:56:31.000000000","message":"Thanks, that\u0027s encouraging! Is there anything to be aware of? Eg. Performance at scale, reliability in the event of fail-over etc.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"620d45b1aec8881ebbafe7ccb886bb05d5e8105a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84acd716_d835774c","updated":"2023-10-25 08:41:56.000000000","message":"do not merge! - only testing CI with enabled quorum queues.","commit_id":"10c08bed53c0b2530efc93084b39059332fa31aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"211712c546f36ec6c08f35d85e3d8ccdf6cc68c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"461d5740_2bb09edc","in_reply_to":"29e941d5_080bb5da","updated":"2023-10-25 11:57:42.000000000","message":"seems I was wrong, at least it\u0027s not in the docs, thanks for letting me know:\n\nhttps://review.opendev.org/Documentation/intro-user.html#wip","commit_id":"10c08bed53c0b2530efc93084b39059332fa31aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fc8713b4c68b88e865984d88775eff0bac3b5eb4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29e941d5_080bb5da","in_reply_to":"7263506e_114e9825","updated":"2023-10-25 11:51:39.000000000","message":"I thought that marking a change as \"WIP\" would not trigger the CI. Is that wrong?","commit_id":"10c08bed53c0b2530efc93084b39059332fa31aa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"214a78cd5b2f9352fad061763f61e37eca3b038f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7263506e_114e9825","in_reply_to":"84acd716_d835774c","updated":"2023-10-25 08:51:14.000000000","message":"set WIP for this change)","commit_id":"10c08bed53c0b2530efc93084b39059332fa31aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1e35e966b59391faf9e527ec453baf8386d7f568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"451751e0_f892e405","updated":"2023-10-27 09:30:31.000000000","message":"as a side note, while debugging this, here is the semi-official statement that classic HA mirrored queues are not any more supported from upstream:\n\nhttps://github.com/rabbitmq/rabbitmq-server/discussions/9716#discussioncomment-7303951","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d2769a40500d8e78db13dce37417aa9cd26233c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f18c3829_24578483","updated":"2023-10-25 12:47:18.000000000","message":"in WIP gerrit don\u0027t send emails and don\u0027t notify reviewers only","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e5a1203f0841bb64793f6088b10cfe27e97e059b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c92e9159_dbf146a3","updated":"2023-11-17 10:33:16.000000000","message":"necessary backport was merged: https://review.opendev.org/c/openstack/oslo.messaging/+/900891","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3ff80c9b1893c36a3890407785f449dca2ef4559","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4731fb57_4ecea811","updated":"2023-11-15 13:10:30.000000000","message":"recheck new oslo messaging fix https://review.opendev.org/c/openstack/oslo.messaging/+/889313","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9ea6a1735311ec8b4ef217e82023b6cb565a743d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71ad0e1a_80603c66","updated":"2023-10-27 09:18:54.000000000","message":"recheck ubuntu upgrade cephadm unstable","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0a9d84328fd60d12e4852e442ea9cc940fccb43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"978e75c5_2edd6d4f","in_reply_to":"451751e0_f892e405","updated":"2023-10-27 10:27:04.000000000","message":"It\u0027s interesting that the bug is for non-mirrored queues - I\u0027m pretty sure we have seen that too (without quorum queues enabled however). As you noted, hopefully [4] provides a path forward.","commit_id":"bd7503c640f158872f4110bd5f09b7a0528f176c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"520295b79f42d7b3b67d03b1d63e08184d27d446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"241f0cf3_3cd79eb0","updated":"2023-11-29 17:44:35.000000000","message":"I\u0027ve tested the migration procedure on a small test env (the services which use rabbitmq being cinder,heat,keystone,neutron,nova). Seems to work with the same steps as migrating to HA queues https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#high-availability.\n\nNotably, rabbit does not need to be reconfigured when migrating from non-HA queues (the current default) to quorum queues.\n\nThe migration procedure also works from ``om_enable_rabbitmq_high_availability: true`` to ``om_enable_rabbitmq_quorum_queues: true`` :)","commit_id":"15dd5e4009ba8e35a28d84c569d65fe2a6b04718"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3e461b39503e47e05229cf42328c9dee2cbf0b2e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b0b40760_39fa81e6","in_reply_to":"241f0cf3_3cd79eb0","updated":"2023-11-29 17:47:39.000000000","message":"So the key question is - should we merge this and make it the default?","commit_id":"15dd5e4009ba8e35a28d84c569d65fe2a6b04718"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c18f2ff520dcd4a21faffc868de7881b037dfd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a85c6d65_53781934","in_reply_to":"b0b40760_39fa81e6","updated":"2023-11-30 07:03:15.000000000","message":"well, it\u0027s the default - we need just the upgrade handling for this.","commit_id":"15dd5e4009ba8e35a28d84c569d65fe2a6b04718"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac8dada6c9c2395234a9acb8223fd4f07203ec5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"61b1a988_c3d611c9","updated":"2023-11-30 07:23:52.000000000","message":"IMO this needs much better documentation about the upgrade path.\n\nmaybe really just add the option but enable it only next cycle by default?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eb6b6284e63608dc43a269bbefe6ef773048a14a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b06802df_d0a02516","updated":"2023-11-30 13:53:30.000000000","message":"Weird thing is - this change was building images in gate although it shouldn\u0027t have - rebased to check if that helps","commit_id":"64575519aa742236fa1ebd493e7f198b7b1d26ba"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"03ad452aab9c4def63d6ec9d286b184931d2e428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b286d94b_3727be7e","updated":"2023-11-30 14:24:35.000000000","message":"just a small bit about the reno, fine for a followup","commit_id":"64575519aa742236fa1ebd493e7f198b7b1d26ba"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"44c9360e87f888b32bc0d0c3dcb2a655ba3156a5","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":239,"context_line":"# Only enable quorum queues if you disable om_enable_rabbitmq_high_availability"},{"line_number":240,"context_line":"om_enable_rabbitmq_quorum_queues: false"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"####################"},{"line_number":243,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"483615de_00959bc0","line":240,"updated":"2023-10-23 13:05:56.000000000","message":"Have you tried enabling quorum queues to see if CI passes?\n\nI\u0027m curious if any of the issues reported here are seen: https://github.com/rabbitmq/rabbitmq-server/discussions/4457","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e5a1203f0841bb64793f6088b10cfe27e97e059b","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":239,"context_line":"# Only enable quorum queues if you disable om_enable_rabbitmq_high_availability"},{"line_number":240,"context_line":"om_enable_rabbitmq_quorum_queues: false"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"####################"},{"line_number":243,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c2c18fc9_885fb56e","line":240,"in_reply_to":"296aa46a_439b11ae","updated":"2023-11-17 10:33:16.000000000","message":"Done","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a817ddd4baa2cc27226272cbe2e7b7308e2093b8","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":239,"context_line":"# Only enable quorum queues if you disable om_enable_rabbitmq_high_availability"},{"line_number":240,"context_line":"om_enable_rabbitmq_quorum_queues: false"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"####################"},{"line_number":243,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a70bb727_942dc12c","line":240,"in_reply_to":"483615de_00959bc0","updated":"2023-10-23 15:24:48.000000000","message":"not yet, no, thanks for the hint to that discussion, I haven\u0027t seen that one yet.\n\nIt is documented that quorum queues use more resources, might add that to the release notes.\n\nThe issue in the linked github discussion did occur on a rather old - EOL - version though, and it seems it wasn\u0027t checked if sytemd or docker ulimits where the culprit.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"620d45b1aec8881ebbafe7ccb886bb05d5e8105a","unresolved":true,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"om_enable_rabbitmq_high_availability: true"},{"line_number":239,"context_line":"# Only enable quorum queues if you disable om_enable_rabbitmq_high_availability"},{"line_number":240,"context_line":"om_enable_rabbitmq_quorum_queues: false"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"####################"},{"line_number":243,"context_line":"# Networking options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"296aa46a_439b11ae","line":240,"in_reply_to":"a70bb727_942dc12c","updated":"2023-10-25 08:41:56.000000000","message":"So let\u0027s see if this breaks, I just enabled it.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"}],"ansible/roles/prechecks/tasks/service_checks.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"eb5db1f7c9e399c0a770912f770a8a11b5ddf09e","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  fail:"},{"line_number":77,"context_line":"    msg: |"},{"line_number":78,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":79,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"735a07aa_6e90969b","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":21},"updated":"2023-10-17 09:54:32.000000000","message":"TODO: this will also fail when both are false, which should be improved I guess 😊","commit_id":"cef710e86b3e06157244b98dee443eeb74cd6b5c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a64fc06640a5d48815b7144db9f7bba89411a634","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  fail:"},{"line_number":77,"context_line":"    msg: |"},{"line_number":78,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":79,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ddbe59ec_2f160d96","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":21},"in_reply_to":"1e5aa489_1d6dfb6c","updated":"2023-11-29 10:24:51.000000000","message":"I think this should be moved to ``kolla-ansible/ansible/roles/rabbitmq/tasks/precheck.yml``, as right now it will not be caught by ``kolla-ansible prechecks --tags rabbitmq``.\n\nAlso given we now aim to enable quorum queues by default in Caracal instead, this should only fail when they are both true.","commit_id":"cef710e86b3e06157244b98dee443eeb74cd6b5c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4f57546e5de07ddb1b669ff7cf373b0c85757be8","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  fail:"},{"line_number":77,"context_line":"    msg: |"},{"line_number":78,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":79,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1e5aa489_1d6dfb6c","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":21},"in_reply_to":"735a07aa_6e90969b","updated":"2023-10-24 10:34:22.000000000","message":"I thought about this a bit more with a colleague of the OSBA and we conclude that we only imho want to support ha queues or quorum queues to make this more robust.\n\na single node deployment can also easily use quorum queues.\n\nTODO: Document this.","commit_id":"cef710e86b3e06157244b98dee443eeb74cd6b5c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d660053ace96d9b5aed3582ba71bb1d677fbba25","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  fail:"},{"line_number":77,"context_line":"    msg: |"},{"line_number":78,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":79,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e254fc45_0f68ee8f","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":21},"in_reply_to":"ddbe59ec_2f160d96","updated":"2023-11-29 10:37:38.000000000","message":"Upon further thought, we want this to be caught on all the services that use RabbitMQ too. So I reckon it should be moved to ``kolla-ansible/ansible/roles/service-precheck/tasks/main.yml``","commit_id":"cef710e86b3e06157244b98dee443eeb74cd6b5c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ad6a532592de81616b50c60d3f8f168d08ea6c5a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  fail:"},{"line_number":77,"context_line":"    msg: |"},{"line_number":78,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":79,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bcae9760_075524d7","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":21},"in_reply_to":"e254fc45_0f68ee8f","updated":"2023-11-29 14:23:38.000000000","message":"As discussed in the IRC weekly meeting, I will instead propose follow-up patches for more prechecks.","commit_id":"cef710e86b3e06157244b98dee443eeb74cd6b5c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac8dada6c9c2395234a9acb8223fd4f07203ec5f","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aec8bf7_bf3f1763","line":81,"updated":"2023-11-30 07:23:52.000000000","message":"Why is it no valid option to keep both disabled?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4d893b61eb048622c5f58c796709e47c5fd59701","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e433033c_0d24fbcb","line":81,"in_reply_to":"12d2cad5_c2574dfe","updated":"2023-11-30 09:40:22.000000000","message":"Well, it\u0027s in global prechecks and there\u0027s no variable to skip the check?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"28de2c50c1fb96f865ae0d217696243a8c3883e3","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6dd8ca9b_08b308bc","line":81,"in_reply_to":"23cd4537_6d9e791a","updated":"2023-11-30 10:05:04.000000000","message":"Some stubborn users, but then we need to say that we don\u0027t support deployments that don\u0027t use classic mirrored or quorum queues anymore.","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6db6f7f725949e0a97799f19d2e6e3ba336be037","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d18f62a5_4516c3ce","line":81,"in_reply_to":"38542e84_706f0fb5","updated":"2023-11-30 09:26:46.000000000","message":"Well, if somebody desires to disable any HA - should we disallow it?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d704b6650f99369acb45d1d9ff00372f085da7fa","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"38542e84_706f0fb5","line":81,"in_reply_to":"3aec8bf7_bf3f1763","updated":"2023-11-30 09:09:09.000000000","message":"it improves reliability by a lot and doesn\u0027t really cost much, it\u0027s basically there to cut down on our support matrix (supporting fewer options, when there is no strong reason to keep them around).\n\nquorum queues should be the most reliable option for all users.","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"548546499cdf2e913a0150fdff6572da95864e5d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ee094043_69b4e5a7","line":81,"in_reply_to":"6dd8ca9b_08b308bc","updated":"2023-11-30 10:33:32.000000000","message":"Done","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"487edfd52d2be979ec02917248485137df517ef0","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"12d2cad5_c2574dfe","line":81,"in_reply_to":"d18f62a5_4516c3ce","updated":"2023-11-30 09:37:25.000000000","message":"they can also disable the precheck then?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fbc00f865fd70b2ffe7b82967cbce5988ba2d31a","unresolved":true,"context_lines":[{"line_number":78,"context_line":"  fail:"},{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"23cd4537_6d9e791a","line":81,"in_reply_to":"e433033c_0d24fbcb","updated":"2023-11-30 10:00:26.000000000","message":"so, this was meant as a stop gap for people not doing HA deployments and after the fact complaining that their deployment is not HA - that is, losing messages and being generally unreliable.\n\nI have seen many such deployments, because we didn\u0027t enforce HA for old upgraded releases in the past and people tend to think that upstream takes care of such things.\n\nSo my and Marcs thinking when enabling this was: \"we should provide a reliable out of the box experience where the user can\u0027t shoot themselves in the foot without literally going in and removing this code\".\n\nso when I wrote they can disable the precheck I meant to say: they would have to patch this out. That would imho be a strong signal that they really know what they are doing.\n\nI can see no downside in not allowing ha queues by default.\n\nCan you describe a scenario where you want to run without HA queues?","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"}],"releasenotes/notes/make-quorum-queues-usable-552bfb2e8975f83f.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"44c9360e87f888b32bc0d0c3dcb2a655ba3156a5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2a77e1cc_a4026bfa","line":4,"updated":"2023-10-23 13:05:56.000000000","message":"Do you need to re-declare all the queues when enabling this in systems which have already been deployed? If so, it would be helpful to have a note about that somewhere.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d704b6650f99369acb45d1d9ff00372f085da7fa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"474fee53_11c0f651","line":4,"in_reply_to":"0506d30a_a8fdb7c7","updated":"2023-11-30 09:09:09.000000000","message":"as agreed during caracal ptg this will be documented in a follow up patch.","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac8dada6c9c2395234a9acb8223fd4f07203ec5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0506d30a_a8fdb7c7","line":4,"in_reply_to":"2a77e1cc_a4026bfa","updated":"2023-11-30 07:23:52.000000000","message":"Looking at tests/upgrade.sh this does seems to have some upgrade impact, so indeed we need an update section documenting how operators should handle this","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"548546499cdf2e913a0150fdff6572da95864e5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bd7495f7_1108d5cc","line":4,"in_reply_to":"474fee53_11c0f651","updated":"2023-11-30 10:33:32.000000000","message":"Done","commit_id":"48bb445947cbcaf258d0bafc3a45376ba570aa76"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac8dada6c9c2395234a9acb8223fd4f07203ec5f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a0c32edc_131eb910","line":5,"updated":"2023-11-30 07:23:52.000000000","message":"Please use double backticks for these quotes","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d704b6650f99369acb45d1d9ff00372f085da7fa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    You can now enable the usage of quorum queues in RabbitMQ for all services"},{"line_number":5,"context_line":"    by setting the variable `om_enable_rabbitmq_quorum_queues` to `true`."},{"line_number":6,"context_line":"    Notice that you can\u0027t use quorum queues and high availability at the same"},{"line_number":7,"context_line":"    time. This is caught by a precheck."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d32b03c3_84a75f35","line":5,"in_reply_to":"a0c32edc_131eb910","updated":"2023-11-30 09:09:09.000000000","message":"Done","commit_id":"51038415836fc69b315c09a1fa166f3cc1e4cba6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"03ad452aab9c4def63d6ec9d286b184931d2e428","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    Support for non-HA RabbitMQ queues is dropped. Either quorum queues that"},{"line_number":16,"context_line":"    are enabled by default, or classic mirrored queues are required now."},{"line_number":17,"context_line":"    `Migration procedure from non-HA to HA"},{"line_number":18,"context_line":"    \u003chttps://docs.openstack.org/kolla-ansible/zed/reference/message-queues/rabbitmq.html#high-availability\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"de4c8e12_42950a15","line":18,"range":{"start_line":18,"start_character":46,"end_line":18,"end_character":49},"updated":"2023-11-30 14:24:35.000000000","message":"Since we modify that doc in the current release, this should be either \"2023.2\" or \"latest\"?","commit_id":"64575519aa742236fa1ebd493e7f198b7b1d26ba"}]}