)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9f699d07050190a6aa9bf21caae5af7b92944444","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for OpenSearch 2.x as CloudKitty storage backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A precheck is added to catch cloudkitty_storage_backend being set to"},{"line_number":10,"context_line":"elasticsearch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cloudkitty/+/880739"},{"line_number":13,"context_line":"Change-Id: Ib8d7182cc4b8a0c7d320ba2c51b2157782030317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f21aae95_d0d2b58f","line":10,"range":{"start_line":9,"start_character":23,"end_line":10,"end_character":14},"updated":"2023-12-15 12:45:07.000000000","message":"imvho better wording: \"A precheck is added to fail if elasticsearch is still in use\nas a cloudkitty_storage_backend. Elasticsearch is no longer supported for this\nusecase in kolla-ansible.\"","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for OpenSearch 2.x as CloudKitty storage backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A precheck is added to catch cloudkitty_storage_backend being set to"},{"line_number":10,"context_line":"elasticsearch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cloudkitty/+/880739"},{"line_number":13,"context_line":"Change-Id: Ib8d7182cc4b8a0c7d320ba2c51b2157782030317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"44c44843_714b8ace","line":10,"range":{"start_line":9,"start_character":23,"end_line":10,"end_character":14},"in_reply_to":"f21aae95_d0d2b58f","updated":"2024-05-13 04:54:24.000000000","message":"I have removed the precheck since we are keeping the elasticsearch support.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32398,"name":"Gaël THEROND","display_name":"Fl1nt","email":"gael.therond@bitswalk.com","username":"Fl1nt"},"change_message_id":"75cc0571e123f7fc8a7aa507b3df447a3b5c6876","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4be42050_e8f2a0a0","updated":"2024-01-19 12:15:47.000000000","message":"Hi folks, just to let you know that cloudkitty on kolla is indeed broken since YOGA, not only ZED. At least for all RHEL/CentOS based platforms.\n\nIndeed, when passing from Yoga CentOS Stream 8 to 9 (Because of the migration path to ZED) you\u0027re required to pass from binary to sources, BUT, Kolla deny Elasticsearch images build on sources because of a signature being SHA1 instead of SHA512 (This is kinda rude), this lead anyone willing to migrate and follow the releases cycles orphan of either ES AND/OR Cloudkitty, as you can\u0027t build ES, have to replace it with OpenSearch but then in the meantime, cloudkitty can\u0027t bootstrap itself on an OpenSearch based system.\n\nI know that everyone is doing its best, it\u0027s just for you to be aware in case of.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e3a6b67d83c55b6bcd77262804cbceeb4bdb0af5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c0c6bbb8_3e3a1e7c","updated":"2024-03-13 16:28:02.000000000","message":"please address the open comments, notice that we should still provide elasticsearch support in the sense, that there might be users out there using the \"external elasticsearch cluster\" functionality.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5d03aa61_c28db243","in_reply_to":"4be42050_e8f2a0a0","updated":"2024-05-13 04:54:24.000000000","message":"Once backported, this change should resolve your issue.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"704ab180_44eb92d5","in_reply_to":"c0c6bbb8_3e3a1e7c","updated":"2024-05-13 04:54:24.000000000","message":"Done","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1019e83442a84c7d0c84224300c098e6ddd4584b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9ae0601b_5bda779e","updated":"2024-07-15 13:48:42.000000000","message":"Been here for too long.","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"729c31bebe1fa23a3966e193e4bb98c1fb4b8c83","unresolved":true,"context_lines":[{"line_number":934,"context_line":"# Logging options"},{"line_number":935,"context_line":"####################"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"# NOTE: If an external ElasticSearch cluster address is configured, all"},{"line_number":938,"context_line":"# services with ElasticSearch endpoints should be configured to log"},{"line_number":939,"context_line":"# to the external cluster by default. This is for backwards compatibility."},{"line_number":940,"context_line":"opensearch_address: \"{{ elasticsearch_address if elasticsearch_address is defined else kolla_internal_fqdn }}\""},{"line_number":941,"context_line":"enable_opensearch: \"{{ enable_central_logging | bool or enable_osprofiler | bool or (enable_cloudkitty | bool and cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"671e2610_47d3c2d3","line":938,"range":{"start_line":937,"start_character":23,"end_line":938,"end_character":29},"updated":"2023-12-15 11:07:41.000000000","message":"_if_ we change this to opensearch support only - and I\u0027m not sure we do - the comment must be adjusted accordingly.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[{"line_number":934,"context_line":"# Logging options"},{"line_number":935,"context_line":"####################"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"# NOTE: If an external ElasticSearch cluster address is configured, all"},{"line_number":938,"context_line":"# services with ElasticSearch endpoints should be configured to log"},{"line_number":939,"context_line":"# to the external cluster by default. This is for backwards compatibility."},{"line_number":940,"context_line":"opensearch_address: \"{{ elasticsearch_address if elasticsearch_address is defined else kolla_internal_fqdn }}\""},{"line_number":941,"context_line":"enable_opensearch: \"{{ enable_central_logging | bool or enable_osprofiler | bool or (enable_cloudkitty | bool and cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"417db42a_ae789f3d","line":938,"range":{"start_line":937,"start_character":23,"end_line":938,"end_character":29},"in_reply_to":"671e2610_47d3c2d3","updated":"2024-05-13 04:54:24.000000000","message":"Acknowledged","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"}],"ansible/roles/cloudkitty/defaults/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"729c31bebe1fa23a3966e193e4bb98c1fb4b8c83","unresolved":true,"context_lines":[{"line_number":166,"context_line":"cloudkitty_influxdb_name: \"cloudkitty\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Set the opensearch index name."},{"line_number":169,"context_line":"cloudkitty_opensearch_index_name: \"cloudkitty\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# Set the opensearch host URL."},{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e285f341_e9960a80","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":2},"updated":"2023-12-15 11:07:41.000000000","message":"why not use a backwards compatible way which is not really much work for us, but saves work for every admin configuring this?\n```yaml\ncloudkitty_elasticsearch_index_name: \"cloudkitty\"\ncloudkitty_opensearch_index_name: \"{{ cloudkitty_elasticsearch_index_name }}\"\n```","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"cloudkitty_influxdb_name: \"cloudkitty\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Set the opensearch index name."},{"line_number":169,"context_line":"cloudkitty_opensearch_index_name: \"cloudkitty\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# Set the opensearch host URL."},{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ae619ef6_de913256","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":2},"in_reply_to":"e285f341_e9960a80","updated":"2024-05-13 04:54:24.000000000","message":"Done","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"729c31bebe1fa23a3966e193e4bb98c1fb4b8c83","unresolved":true,"context_lines":[{"line_number":169,"context_line":"cloudkitty_opensearch_index_name: \"cloudkitty\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# Set the opensearch host URL."},{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":175,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a1b64842_9902d96c","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":25},"updated":"2023-12-15 11:07:41.000000000","message":"similar to the above, why not just make it backwards compatible for at least one release?\n\n```yaml\ncloudkitty_elasticsearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port}}\"\ncloudkitty_opensearch_url: \"{{ cloudkitty_elasticsearch_url }}\"\n```","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8c45fe74b25975a273748dee4ebb49a9273192f6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"cloudkitty_opensearch_index_name: \"cloudkitty\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# Set the opensearch host URL."},{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":175,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"098a022b_2b900d7b","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":25},"in_reply_to":"a1b64842_9902d96c","updated":"2024-05-13 04:54:24.000000000","message":"Done","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"729c31bebe1fa23a3966e193e4bb98c1fb4b8c83","unresolved":true,"context_lines":[{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":175,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":178,"context_line":"# This means, HTTPS connections without validating the certificate used by opensearch"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"52f58cb7_2963522b","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":30},"updated":"2023-12-15 11:07:41.000000000","message":"not sure why this is actually commented out and was before? is this a bug?","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9c2bd5a20abbde09d5d48076ef1fa1a530aec060","unresolved":true,"context_lines":[{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":175,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":178,"context_line":"# This means, HTTPS connections without validating the certificate used by opensearch"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"abaf71d3_9afab530","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":30},"in_reply_to":"52f58cb7_2963522b","updated":"2023-12-15 11:19:11.000000000","message":"This is covered in another change: https://review.opendev.org/c/openstack/kolla-ansible/+/866598","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8770c637fb8b9f1481edb2a294e43bf09288b189","unresolved":false,"context_lines":[{"line_number":172,"context_line":"cloudkitty_opensearch_url: \"{{ internal_protocol }}://{{ opensearch_address }}:{{ opensearch_port }}\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":175,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":178,"context_line":"# This means, HTTPS connections without validating the certificate used by opensearch"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ab7e7a24_9dead8eb","line":175,"range":{"start_line":175,"start_character":2,"end_line":175,"end_character":30},"in_reply_to":"abaf71d3_9afab530","updated":"2023-12-15 12:42:37.000000000","message":"Acknowledged","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac0f391bf331ab058c800dc7607683fef13233a8","unresolved":true,"context_lines":[{"line_number":181,"context_line":"cloudkitty_elasticsearch_insecure_connections: false"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c17fd270_2dddc512","line":184,"updated":"2024-05-13 12:20:58.000000000","message":"I\u0027d prefer that we define this default. It should not cause any problems to do so and makes it more consistent with other CA file usage in k-a.\n\n(Yes, other similar variables should be fixed too, I have given Matt C task to do this.)","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"48cb054e7eb3f63021f45d10bf6f0d8a5ea79da5","unresolved":true,"context_lines":[{"line_number":181,"context_line":"cloudkitty_elasticsearch_insecure_connections: false"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c779ab3a_bad940c1","line":184,"in_reply_to":"c17fd270_2dddc512","updated":"2024-05-13 13:01:51.000000000","message":"As mentioned in another comment, this change is covered by https://review.opendev.org/c/openstack/kolla-ansible/+/866598. I would prefer not to mix the two changes.","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3d412fa2c9dbd401d173f0f7b530e4880f422131","unresolved":false,"context_lines":[{"line_number":181,"context_line":"cloudkitty_elasticsearch_insecure_connections: false"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"# cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"317937c4_0318afdc","line":184,"in_reply_to":"c779ab3a_bad940c1","updated":"2024-05-13 14:13:23.000000000","message":"Oh wow, that change could really use another review. Let\u0027s merge this first then update the other for opensearch.","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2d3bf27d5170d501c4ddbfb0f0498a8024228e6e","unresolved":true,"context_lines":[{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"},{"line_number":188,"context_line":"# OpenSearch."},{"line_number":189,"context_line":"cloudkitty_opensearch_insecure_connections: false"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a8be7b7d_1aaad608","line":188,"range":{"start_line":186,"start_character":1,"end_line":188,"end_character":13},"updated":"2024-05-27 15:28:39.000000000","message":"nit: I think this comment is overly complicated, why not just write:\n\"set to true to not require HTTPS certificate validation, which is insecure.\"","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fbd098c31c37f107fcf06b8a780f185fbf3c48bb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"},{"line_number":188,"context_line":"# OpenSearch."},{"line_number":189,"context_line":"cloudkitty_opensearch_insecure_connections: false"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c54a816a_1bcfdadc","line":188,"range":{"start_line":186,"start_character":1,"end_line":188,"end_character":13},"in_reply_to":"a63ab5a1_9ad10c76","updated":"2024-05-28 09:39:42.000000000","message":"okay, if it\u0027s a verbatim copy I think it can stay this way. Ack.","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"383b97cfcfdbb5087ec6ff7c527e121530199920","unresolved":true,"context_lines":[{"line_number":183,"context_line":"# Path of the CA certificate to trust for HTTPS connections."},{"line_number":184,"context_line":"cloudkitty_opensearch_cafile: \"{{ openstack_cacert }}\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Set to true to authorize insecure HTTPS connections to OpenSearch."},{"line_number":187,"context_line":"# This means, HTTPS connections without validating the certificate used by"},{"line_number":188,"context_line":"# OpenSearch."},{"line_number":189,"context_line":"cloudkitty_opensearch_insecure_connections: false"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a63ab5a1_9ad10c76","line":188,"range":{"start_line":186,"start_character":1,"end_line":188,"end_character":13},"in_reply_to":"a8be7b7d_1aaad608","updated":"2024-05-27 15:33:23.000000000","message":"I just copied the existing comments. I can fix it but then I should fix the other ones, which could cause conflicts during backports.","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"}],"ansible/roles/cloudkitty/tasks/bootstrap.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac0f391bf331ab058c800dc7607683fef13233a8","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      status_code: 200, 404"},{"line_number":73,"context_line":"  run_once: true"},{"line_number":74,"context_line":"  delegate_to: \"{{ groups[\u0027cloudkitty-api\u0027][0] }}\""},{"line_number":75,"context_line":"  register: cloudkitty_index"},{"line_number":76,"context_line":"  when: cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Creating Cloudkitty elasticsearch index"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"629da196_4b3622e2","line":75,"updated":"2024-05-13 12:20:58.000000000","message":"This will shadow the variable of the same name registered in the previous task.","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1e5d787223d85f0ed76b8ee7e3921d0fa7077bae","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      status_code: 200, 404"},{"line_number":73,"context_line":"  run_once: true"},{"line_number":74,"context_line":"  delegate_to: \"{{ groups[\u0027cloudkitty-api\u0027][0] }}\""},{"line_number":75,"context_line":"  register: cloudkitty_index"},{"line_number":76,"context_line":"  when: cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Creating Cloudkitty elasticsearch index"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"667f4a92_aa5938e2","line":75,"in_reply_to":"240cea53_b4ca91a8","updated":"2024-05-16 07:08:29.000000000","message":"Done","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3d412fa2c9dbd401d173f0f7b530e4880f422131","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      status_code: 200, 404"},{"line_number":73,"context_line":"  run_once: true"},{"line_number":74,"context_line":"  delegate_to: \"{{ groups[\u0027cloudkitty-api\u0027][0] }}\""},{"line_number":75,"context_line":"  register: cloudkitty_index"},{"line_number":76,"context_line":"  when: cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Creating Cloudkitty elasticsearch index"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"240cea53_b4ca91a8","line":75,"in_reply_to":"2739d9f3_1063a110","updated":"2024-05-13 14:13:23.000000000","message":"Yes. The variable will store the task\u0027s result, including whether it was skipped.","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"48cb054e7eb3f63021f45d10bf6f0d8a5ea79da5","unresolved":true,"context_lines":[{"line_number":72,"context_line":"      status_code: 200, 404"},{"line_number":73,"context_line":"  run_once: true"},{"line_number":74,"context_line":"  delegate_to: \"{{ groups[\u0027cloudkitty-api\u0027][0] }}\""},{"line_number":75,"context_line":"  register: cloudkitty_index"},{"line_number":76,"context_line":"  when: cloudkitty_storage_backend \u003d\u003d \u0027opensearch\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Creating Cloudkitty elasticsearch index"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2739d9f3_1063a110","line":75,"in_reply_to":"629da196_4b3622e2","updated":"2024-05-13 13:01:51.000000000","message":"Does it still shadow the variable even if the task is skipped? (because cloudkitty_storage_backend cannot be equal to elasticsearch and opensearch at the same time)","commit_id":"b8aa8043f750af8cab059c9ade7e4c06b69104ee"}],"ansible/roles/cloudkitty/tasks/precheck.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"729c31bebe1fa23a3966e193e4bb98c1fb4b8c83","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"932f54c7_3d05afe0","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"updated":"2023-12-15 11:07:41.000000000","message":"so this is not what the commit message is saying this commit does.\n\nso I\u0027d at least prefer this to be split up: the addition of opensearch has nothing to do with the deprecation of another storage backend, after all.\n\nat the very least the commit message must mention that elasticsearch support is being dropped.\n\nand furthermore it should be discussed if, when and why we want to deprecate elasticsearch already now.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"24390da4fcc4b293d0dfb460ad9c86b84987ce25","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4dfd3e7b_0b0b656a","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"in_reply_to":"11b61d47_b1343023","updated":"2023-12-15 15:49:04.000000000","message":"No I guess I\u0027m fine with the provided explanation. I think these are enough cycles for users to migrate. I just did forget how fast time flies by 😊","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8770c637fb8b9f1481edb2a294e43bf09288b189","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5e4b6579_15fee1ae","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"in_reply_to":"3984025e_a9eccadb","updated":"2023-12-15 12:42:37.000000000","message":"Acknowledged","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2fd0cc505b4ef8a6ac8ca69009de7ac91b9c6107","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a13a020_341eac9c","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"in_reply_to":"4dfd3e7b_0b0b656a","updated":"2024-03-13 14:49:00.000000000","message":"This patch was discussed in the weekly meeting today. It was decided that we should keep Elasticsearch support here for now, because KA still has external Elasticsearch support.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2c0eaa9c4aed298f8ff600fe1e7e593c4853bbbf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"11b61d47_b1343023","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"in_reply_to":"5e4b6579_15fee1ae","updated":"2023-12-15 14:29:43.000000000","message":"But if you think it is appropriate to keep Elasticsearch support, for example if we expect operators could be using an external Elasticsearch service or maintaining Elasticsearch in a fork of kolla/kolla-ansible, I could change this patch to support both.\n\nIt wouldn\u0027t really be more work since I need to do it for Yoga anyway.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9c2bd5a20abbde09d5d48076ef1fa1a530aec060","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    - container_facts[\u0027cloudkitty_api\u0027] is not defined"},{"line_number":26,"context_line":"    - inventory_hostname in groups[\u0027cloudkitty-api\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail when Elasticsearch is used as storage backend"},{"line_number":29,"context_line":"  fail:"},{"line_number":30,"context_line":"    msg: \u003e"},{"line_number":31,"context_line":"      CloudKitty is configured to use Elasticsearch as storage backend, which"},{"line_number":32,"context_line":"      is not supported by Kolla Ansible anymore. Please change"},{"line_number":33,"context_line":"      the cloudkitty_storage_backend variable to \u0027opensearch\u0027."},{"line_number":34,"context_line":"  run_once: True"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - cloudkitty_storage_backend \u003d\u003d \"elasticsearch\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3984025e_a9eccadb","line":36,"range":{"start_line":28,"start_character":2,"end_line":36,"end_character":51},"in_reply_to":"932f54c7_3d05afe0","updated":"2023-12-15 11:19:11.000000000","message":"Elasticsearch was dropped from kolla-ansible in the Zed release, with Yoga including migration support. CloudKitty support for OpenSearch 2.x took a while to be ready, but it is essentially broken from Zed without this change.\n\nI was intending to backport this up to Zed, and for Yoga to have a different patch with dual support for Elasticsearch and OpenSearch.","commit_id":"57e1fa885cd7f4c30e2fb20d0a5ebb9266b47fbc"}],"ansible/roles/cloudkitty/templates/cloudkitty.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0d2477fa4a0535671394d58d31abc693869de6c3","unresolved":true,"context_lines":[{"line_number":165,"context_line":"index_name \u003d {{ cloudkitty_opensearch_index_name }}"},{"line_number":166,"context_line":"insecure \u003d {{ cloudkitty_opensearch_insecure_connections }}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% if cloudkitty_opensearch_cafile is defined %}"},{"line_number":169,"context_line":"cafile \u003d {{ cloudkitty_opensearch_cafile }}"},{"line_number":170,"context_line":"{% endif %}"},{"line_number":171,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"d5aab778_907e940c","line":168,"updated":"2024-05-15 16:06:27.000000000","message":"nit: now always defined","commit_id":"46a61ccdad18fbd5d31e2ce08fd1e646f0ed5919"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1e5d787223d85f0ed76b8ee7e3921d0fa7077bae","unresolved":false,"context_lines":[{"line_number":165,"context_line":"index_name \u003d {{ cloudkitty_opensearch_index_name }}"},{"line_number":166,"context_line":"insecure \u003d {{ cloudkitty_opensearch_insecure_connections }}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% if cloudkitty_opensearch_cafile is defined %}"},{"line_number":169,"context_line":"cafile \u003d {{ cloudkitty_opensearch_cafile }}"},{"line_number":170,"context_line":"{% endif %}"},{"line_number":171,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"c44b3ba4_5874df4f","line":168,"in_reply_to":"d5aab778_907e940c","updated":"2024-05-16 07:08:29.000000000","message":"Done","commit_id":"46a61ccdad18fbd5d31e2ce08fd1e646f0ed5919"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9450d9d0dae76665a03ff92c1342741ab7367ff6","unresolved":true,"context_lines":[{"line_number":154,"context_line":"index_name \u003d {{ cloudkitty_elasticsearch_index_name }}"},{"line_number":155,"context_line":"insecure \u003d {{ cloudkitty_elasticsearch_insecure_connections }}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{% if cloudkitty_elasticsearch_cafile | length \u003e 0 %}"},{"line_number":158,"context_line":"cafile \u003d {{ cloudkitty_elasticsearch_cafile }}"},{"line_number":159,"context_line":"{% endif %}"},{"line_number":160,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"f97d1e38_e8c42907","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":50},"updated":"2024-05-28 11:19:48.000000000","message":"not needed","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1019e83442a84c7d0c84224300c098e6ddd4584b","unresolved":false,"context_lines":[{"line_number":154,"context_line":"index_name \u003d {{ cloudkitty_elasticsearch_index_name }}"},{"line_number":155,"context_line":"insecure \u003d {{ cloudkitty_elasticsearch_insecure_connections }}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{% if cloudkitty_elasticsearch_cafile | length \u003e 0 %}"},{"line_number":158,"context_line":"cafile \u003d {{ cloudkitty_elasticsearch_cafile }}"},{"line_number":159,"context_line":"{% endif %}"},{"line_number":160,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"883678b0_ea1912b9","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":50},"in_reply_to":"84795a92_53c9df6e","updated":"2024-07-15 13:48:42.000000000","message":"Done","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"01836d7c694d240812894396c0b2751d7f65c517","unresolved":true,"context_lines":[{"line_number":154,"context_line":"index_name \u003d {{ cloudkitty_elasticsearch_index_name }}"},{"line_number":155,"context_line":"insecure \u003d {{ cloudkitty_elasticsearch_insecure_connections }}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{% if cloudkitty_elasticsearch_cafile | length \u003e 0 %}"},{"line_number":158,"context_line":"cafile \u003d {{ cloudkitty_elasticsearch_cafile }}"},{"line_number":159,"context_line":"{% endif %}"},{"line_number":160,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"84795a92_53c9df6e","line":157,"range":{"start_line":157,"start_character":47,"end_line":157,"end_character":50},"in_reply_to":"f97d1e38_e8c42907","updated":"2024-05-28 15:59:37.000000000","message":"This is the pattern generally used in the kolla-ansible code base though.","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9450d9d0dae76665a03ff92c1342741ab7367ff6","unresolved":true,"context_lines":[{"line_number":165,"context_line":"index_name \u003d {{ cloudkitty_opensearch_index_name }}"},{"line_number":166,"context_line":"insecure \u003d {{ cloudkitty_opensearch_insecure_connections }}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% if cloudkitty_opensearch_cafile | length \u003e 0 %}"},{"line_number":169,"context_line":"cafile \u003d {{ cloudkitty_opensearch_cafile }}"},{"line_number":170,"context_line":"{% endif %}"},{"line_number":171,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"946b77e5_e79ee0f7","line":168,"range":{"start_line":168,"start_character":44,"end_line":168,"end_character":47},"updated":"2024-05-28 11:19:48.000000000","message":"ditto","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1019e83442a84c7d0c84224300c098e6ddd4584b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"index_name \u003d {{ cloudkitty_opensearch_index_name }}"},{"line_number":166,"context_line":"insecure \u003d {{ cloudkitty_opensearch_insecure_connections }}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% if cloudkitty_opensearch_cafile | length \u003e 0 %}"},{"line_number":169,"context_line":"cafile \u003d {{ cloudkitty_opensearch_cafile }}"},{"line_number":170,"context_line":"{% endif %}"},{"line_number":171,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"a60b18c4_e7083ff7","line":168,"range":{"start_line":168,"start_character":44,"end_line":168,"end_character":47},"in_reply_to":"4dc85c7a_8e516ad3","updated":"2024-07-15 13:48:42.000000000","message":"Done","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"01836d7c694d240812894396c0b2751d7f65c517","unresolved":true,"context_lines":[{"line_number":165,"context_line":"index_name \u003d {{ cloudkitty_opensearch_index_name }}"},{"line_number":166,"context_line":"insecure \u003d {{ cloudkitty_opensearch_insecure_connections }}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"{% if cloudkitty_opensearch_cafile | length \u003e 0 %}"},{"line_number":169,"context_line":"cafile \u003d {{ cloudkitty_opensearch_cafile }}"},{"line_number":170,"context_line":"{% endif %}"},{"line_number":171,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"4dc85c7a_8e516ad3","line":168,"range":{"start_line":168,"start_character":44,"end_line":168,"end_character":47},"in_reply_to":"946b77e5_e79ee0f7","updated":"2024-05-28 15:59:37.000000000","message":"This is the pattern generally used in the kolla-ansible code base though.","commit_id":"8581497acb8726b14c669bcbb426fdf144e9e646"}]}