)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5943106e2db4efb28d89713803bb79790966108b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the `grafana` volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes the grafana volume due to the issues mentioned in the bug"},{"line_number":10,"context_line":"report."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2039498"},{"line_number":13,"context_line":"Change-Id: Ibcffa5d8922c470f655f447558d4a9c73b1ba361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4ea93394_a202d784","line":10,"range":{"start_line":9,"start_character":43,"end_line":10,"end_character":7},"updated":"2023-10-18 13:18:31.000000000","message":"its better to have short description here not a mention about a bugreport somewhere","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"dd466c0685ae9e5db7dce3e0cf78989e300722a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the `grafana` volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This removes the grafana volume due to the issues mentioned in the bug"},{"line_number":10,"context_line":"report."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2039498"},{"line_number":13,"context_line":"Change-Id: Ibcffa5d8922c470f655f447558d4a9c73b1ba361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"493074da_840fc2eb","line":10,"range":{"start_line":9,"start_character":43,"end_line":10,"end_character":7},"in_reply_to":"4ea93394_a202d784","updated":"2023-10-18 13:28:47.000000000","message":"Ack","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8dc62d427cef5e8eadded5cc41db6e65171d75f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83ac1ae6_c0111c72","updated":"2023-10-18 13:10:31.000000000","message":"Can\u0027t see a direct conclusion from daily pattern in the index to let\u0027s remove a volume.\nSecond thing is we need to clean up and it at least needs a solid reno\nThird thing is - is that only a Yoga bug?","commit_id":"48322eaaf191da6ac8f0202e4a79cc2603a06b93"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"5901dc7e83679e76c13af5654b809fd7ea26bd97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff12e013_7a70eeb0","in_reply_to":"83ac1ae6_c0111c72","updated":"2023-10-18 13:12:43.000000000","message":"Wrong bug was linked. Apologies. Fixed now","commit_id":"48322eaaf191da6ac8f0202e4a79cc2603a06b93"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"ab66376e4396cac2cca3ae207e195756a9e6d873","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd9ab951_58b6f217","in_reply_to":"ff12e013_7a70eeb0","updated":"2023-10-18 13:17:08.000000000","message":"2 - I\u0027ll add a reno\n3 - I dont think so","commit_id":"48322eaaf191da6ac8f0202e4a79cc2603a06b93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f747b56274b6663cb52da622325f5ac02d008c40","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcc314bb_0443c8e0","updated":"2023-10-18 13:20:16.000000000","message":"Now the correct bug is linked, but I don\u0027t think we can safely assume all dashboards are defined in code, so we need to find a better solution.\nNot counting we need to handle the existing volume somehow.","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5943106e2db4efb28d89713803bb79790966108b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"782deb04_c92f4bd4","updated":"2023-10-18 13:18:31.000000000","message":"also missing relno","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4fce62aebd24ab2159d8f7f780c361cff79243c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1cfc4213_e5b5856b","in_reply_to":"bc6b28d9_c7749812","updated":"2023-10-23 15:40:23.000000000","message":"Done","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"d04701572bd8d95b6dd00197e711c237989046a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc6b28d9_c7749812","in_reply_to":"bcc314bb_0443c8e0","updated":"2023-10-18 13:27:58.000000000","message":"Even if dashboards aren\u0027t defined as code they are saved to the database and so it shouldn\u0027t matter how the dashboards are made?\n\nFor the existing volume we can add in the reno to do a docker volume rm/prune etc.","commit_id":"426620f1bf7a4b1df1dd8cf26cd785f580700211"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c26a419025d1f50dcc019100be71dcc3d87dbfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"37a2fffb_54e9d4ff","updated":"2023-10-24 10:46:05.000000000","message":"-2 because a fix like this needs to go into the master branch first and can only then be backported. discussion how exactly the fix should look like can probably better happen on the bug report initially.","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a44f66e8358f36b56bdd5ecdee48de0f46f1d6d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"efaf0377_d7a8412d","updated":"2023-10-24 10:30:37.000000000","message":"also as Michal said there are many peoples already use the volume in their installations.","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5055830772f7ae649168271bce758d03000f5fee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"319f513d_ed5ef0be","updated":"2023-10-23 19:28:44.000000000","message":"i\u0027m unsure that this should fix an issue","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d8b75017fa2c819b9be2589d82fa1b5bec006b35","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4ee93122_48065f8b","updated":"2023-10-23 15:48:27.000000000","message":"only on yoga?","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e4aa1cc88e303870039c1d5dfff90644c277b721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12d034fd_67caf42f","updated":"2023-10-23 19:35:35.000000000","message":"ups... forgot -1 ;)","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4c29e4f91d2a5ac48b6e26676dfeaa93aabb4aac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"789d88c4_7a91b75e","in_reply_to":"306bb77a_4d61e7ee","updated":"2023-10-24 10:29:39.000000000","message":"becouse volume is only persistent storage of the grafana\u0027s data. to do anything with plugins you should use grafana\u0027s cli. this sould be fixed from the kolla-ansible side during redeploy.","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"05194bb5ad7e3688eba4521988d4224c48e16b28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"306bb77a_4d61e7ee","in_reply_to":"319f513d_ed5ef0be","updated":"2023-10-24 10:01:40.000000000","message":"Why do you think this?","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"b3da0d23f4555be363d32ab4b754f933bb0703df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48db2c62_d9c7b049","in_reply_to":"37a2fffb_54e9d4ff","updated":"2023-10-24 10:51:00.000000000","message":"Thanks","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"58b3acd505564e478fc99fdb4f298fea2b75ae59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6775f098_8e2fe885","in_reply_to":"44441d81_f60a41de","updated":"2023-10-23 16:50:45.000000000","message":"then start with master","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"7b789f10ef438dff51ab0543903345c555677db7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44441d81_f60a41de","in_reply_to":"4ee93122_48065f8b","updated":"2023-10-23 15:49:31.000000000","message":"No, Yoga onwards.","commit_id":"4cedc47fbb9ab3a2ae2d15e59aa3ec57ac6a2e62"}],"ansible/roles/grafana/defaults/main.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"775034e49a435ca956b170f90b8f6a1f161deba2","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  - \"{{ node_config_directory }}/grafana/:{{ container_config_directory }}/:ro\""},{"line_number":88,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":89,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":90,"context_line":"  - \"grafana:/var/lib/grafana/\""},{"line_number":91,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":92,"context_line":"grafana_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f924092c_cb441425","side":"PARENT","line":90,"updated":"2023-10-23 17:00:46.000000000","message":"My vote is to keep the container immutable and use a volume here for the dashboards folder only. To keep the change simple, I\u0027d be happy if you just made a new volume for this purpose and removed the old one automatically. As you\u0027ve pointed out, dashboards should be stored in Kolla config / the Grafana DB, so this shouldn\u0027t be an issue.","commit_id":"f59edacf46ef07070b566def523b4ddb7c8f98ae"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c81f2ca7c2ec4644d815da841d65b39f45617634","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  - \"{{ node_config_directory }}/grafana/:{{ container_config_directory }}/:ro\""},{"line_number":88,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":89,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":90,"context_line":"  - \"grafana:/var/lib/grafana/\""},{"line_number":91,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":92,"context_line":"grafana_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a4e1fc1a_803f1254","side":"PARENT","line":90,"in_reply_to":"28986241_13ec4a69","updated":"2023-10-23 19:30:14.000000000","message":"Well, nothing is stopping you copying dashboards into that volume outside of KA. What are you getting at? Maybe I missed something?","commit_id":"f59edacf46ef07070b566def523b4ddb7c8f98ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6801681cd6465e34fec7e2fb94bf64e2b4e5d1fe","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  - \"{{ node_config_directory }}/grafana/:{{ container_config_directory }}/:ro\""},{"line_number":88,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":89,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":90,"context_line":"  - \"grafana:/var/lib/grafana/\""},{"line_number":91,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":92,"context_line":"grafana_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"581c9609_594e8afc","side":"PARENT","line":90,"in_reply_to":"a4e1fc1a_803f1254","updated":"2023-10-24 07:46:11.000000000","message":"I just meant that if we remove that volume, I wouldn\u0027t like to be in the position of users blaming us that we broke their Grafana. Should doesn\u0027t mean that we\u0027re 100% sure, right?","commit_id":"f59edacf46ef07070b566def523b4ddb7c8f98ae"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4fa1abdb45ed81db37d1fd67b75b594ff93ebce2","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  - \"{{ node_config_directory }}/grafana/:{{ container_config_directory }}/:ro\""},{"line_number":88,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":89,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else \u0027\u0027 }}\""},{"line_number":90,"context_line":"  - \"grafana:/var/lib/grafana/\""},{"line_number":91,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":92,"context_line":"grafana_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"28986241_13ec4a69","side":"PARENT","line":90,"in_reply_to":"f924092c_cb441425","updated":"2023-10-23 17:17:59.000000000","message":"should? can we be more sure?","commit_id":"f59edacf46ef07070b566def523b4ddb7c8f98ae"}]}