)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2871586808f44a65878ffcd8bc033786c3f04092","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be7f98b2_896079dc","updated":"2024-03-07 11:31:31.000000000","message":"Okay, now I got it ..you can\u0027t modify project because you will break other stuff in role ... so you need to change kolla_role_name to include ovsdpdk_services in image-pull role ... \n\nThank you for bugfix.","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2f64a240a35810ba1b67e0e1c284f3ba2dad2f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a59f265_e36fa692","updated":"2024-03-07 11:26:25.000000000","message":"Release note missing also..","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8ec2f6076137e3db727abb8bdea3e7c7361360ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c5b6cb1_a1f22680","updated":"2024-03-07 11:23:31.000000000","message":"Why ? I think it\u0027s enough to change project_name: \"ovs\" to project_name: \"ovs-dpdk\" .\n\nCould you try please ?","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2782d2d4445fd428edc6151e8dbea1fa8fbe2301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"272ed3e5_c9b688b2","updated":"2024-03-07 12:01:15.000000000","message":"Sorry for amending your commit, but we are also facing this issue. I\u0027ve changed commit message so now it\u0027s visible that this commit fixes image pulling. Reno added.","commit_id":"c42002ad77c5e262b3cd2075adf9939a92442b05"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"30962e9d3c1f98bdbd494035f7c831577f8ba4d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0ef34b4_74d8ad8f","updated":"2024-03-14 14:36:55.000000000","message":"recheck","commit_id":"a81a53092d870a584b854e9ba0ce7e61ebf59c2a"}],"ansible/roles/ovs-dpdk/vars/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bacd3e0094400479e3928799f84c6800664a0488","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"ovs\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kolla_role_name: \"ovsdpdk\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"81609768_74809596","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":25},"updated":"2023-11-03 18:50:15.000000000","message":"ovs-dpdk ?","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"abc6887abd49318d402d1826015624f7f1976ef0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"ovs\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kolla_role_name: \"ovsdpdk\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6eb5f89d_a5701b5d","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":25},"in_reply_to":"3d833711_28b543df","updated":"2023-11-07 22:59:32.000000000","message":"you mean option 2 is most proper right now to fix the issue. ok, lets fix this way.","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"36fdef0cc0040f73a6f21bf10ffcea9e251179e7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"ovs\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kolla_role_name: \"ovsdpdk\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a88ce87_35038705","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":25},"in_reply_to":"58353622_b54d5140","updated":"2023-11-03 19:30:06.000000000","message":"role name \u0027ovs-dpdk\u0027 not \u0027ovsdpdk\u0027","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":36090,"name":"German Espinoza Tuesta","display_name":"German Espinoza T.","email":"gespinoza@whitestack.com","username":"gespinozat"},"change_message_id":"e9c511a1ae57df6c71f9b6f2514753340cbcc633","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"ovs\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kolla_role_name: \"ovsdpdk\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3d833711_28b543df","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":25},"in_reply_to":"5a88ce87_35038705","updated":"2023-11-07 19:15:23.000000000","message":"I think that there are 3 options:\n\n1. Define kolla_role_name as \u0027ovs_dpdk\u0027, which will require refactoring vars prefix and tasks in ovs-dpdk role. This is a similar approach to what has been done in:\nhttps://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/nova-cell/vars/main.yml\nhttps://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/ovn-controller/vars/main.yml\n\n2. Change project_name to \u0027ovsdpdk\u0027, which may require some changes in service-precheck and service-stop roles\n\n3. Only define kolla_role_name as \u0027ovsdpdk\u0027\n\nOption 1 seems the most proper, and this patch could be superseded by a new one.","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"},{"author":{"_account_id":36090,"name":"German Espinoza Tuesta","display_name":"German Espinoza T.","email":"gespinoza@whitestack.com","username":"gespinozat"},"change_message_id":"37c3114fd4a1d01d65bf44ab9227d24c536f7fdc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"ovs\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kolla_role_name: \"ovsdpdk\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"58353622_b54d5140","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":25},"in_reply_to":"81609768_74809596","updated":"2023-11-03 19:23:24.000000000","message":"that would require changing default var, currently defined as:\n\n```\novsdpdk_services:\n\n```\n\nthe service-images-pull role uses `(kolla_role_name | default(project_name)) + \u0027_services\u0027 `","commit_id":"3e9aaa9c91d9f9b5f38fe5c7d034a514484992cc"}]}