)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"390ba328726d4622114ac8fb840c2a7fffe2adfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"df99a3d5_857749cc","updated":"2023-11-09 11:05:04.000000000","message":"I was kind of ok with the implicit default, since it would have made it easier to simply switch it later, but I guess the current solution is clearer and thus better","commit_id":"5e54663e20b2484ee0c7fd761b743a9a0c61bc51"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"56d4a4d2960a206e94a93b141dd2a307f7569bdb","unresolved":true,"context_lines":[{"line_number":92,"context_line":"  container_engine:"},{"line_number":93,"context_line":"    description:"},{"line_number":94,"context_line":"      - Name of container engine to use"},{"line_number":95,"context_line":"    required: True"},{"line_number":96,"context_line":"    type: str"},{"line_number":97,"context_line":"  detach:"},{"line_number":98,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":5,"id":"24781e84_21ceaeac","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":18},"updated":"2023-11-08 14:17:12.000000000","message":"true or false?","commit_id":"d64ba9880e9dbbdfaeb9c2a44025dab5a3108dfe"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f836fc8451a5d60fcf5ce8d5a3e12a7743ad2de3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  container_engine:"},{"line_number":93,"context_line":"    description:"},{"line_number":94,"context_line":"      - Name of container engine to use"},{"line_number":95,"context_line":"    required: True"},{"line_number":96,"context_line":"    type: str"},{"line_number":97,"context_line":"  detach:"},{"line_number":98,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":5,"id":"187824b7_1d6bf1c1","line":95,"range":{"start_line":95,"start_character":14,"end_line":95,"end_character":18},"in_reply_to":"24781e84_21ceaeac","updated":"2023-11-09 00:43:40.000000000","message":"Done..","commit_id":"d64ba9880e9dbbdfaeb9c2a44025dab5a3108dfe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"49a3030fed84c9e25869adcf79217de8e730e8f3","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":290,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":291,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":292,"context_line":"        container_engine\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":293,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":294,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":295,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"6baea706_dddc5de0","line":292,"range":{"start_line":292,"start_character":7,"end_line":292,"end_character":58},"updated":"2023-11-09 08:24:15.000000000","message":"if it\u0027s not required, but kind of required looking at code, should we default to docker or podman? Currently we sort of default to docker, but that\u0027s not documented.","commit_id":"1c7205ed3ec0d0b6baf7cc1f1fbaf64b077fcfd9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a9543b477ea1f0c0495072412950f81ac6d9a17d","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":290,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":291,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":292,"context_line":"        container_engine\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":293,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":294,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":295,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"81a3425c_17984c65","line":292,"range":{"start_line":292,"start_character":7,"end_line":292,"end_character":58},"in_reply_to":"6baea706_dddc5de0","updated":"2023-11-09 10:44:17.000000000","message":"Well, maybe you remember but I\u0027ve already fixed this module in past because common_options param was not working (https://review.opendev.org/c/openstack/kolla-ansible/+/870798 there is also discussion why if I remember)\n\nSo, IF we want to have default value set to \u0027docker\u0027, we can\u0027t define it in argument_spec (because we want to be able to override via common_options) ...but in  common_options_defaults, in a while I will send new patchset.","commit_id":"1c7205ed3ec0d0b6baf7cc1f1fbaf64b077fcfd9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5b97fe4fd7637ee9569b7f67d0fb90c86a7b9682","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":290,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":291,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":292,"context_line":"        container_engine\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":293,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":294,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":295,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"12fa3ae4_4bc59fcc","line":292,"range":{"start_line":292,"start_character":7,"end_line":292,"end_character":58},"in_reply_to":"81a3425c_17984c65","updated":"2023-11-09 12:37:36.000000000","message":"Ack","commit_id":"1c7205ed3ec0d0b6baf7cc1f1fbaf64b077fcfd9"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"39857f982c31b983667bcb1bd9485cdaedf28128","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        auth_registry\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":290,"context_line":"        auth_username\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":291,"context_line":"        command\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":292,"context_line":"        container_engine\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":293,"context_line":"        detach\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":294,"context_line":"        labels\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":295,"context_line":"        name\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"771ea634_2f313d2e","line":292,"range":{"start_line":292,"start_character":7,"end_line":292,"end_character":58},"in_reply_to":"81a3425c_17984c65","updated":"2023-11-09 10:49:55.000000000","message":"Done","commit_id":"1c7205ed3ec0d0b6baf7cc1f1fbaf64b077fcfd9"}]}
