)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Marc Schöchlin \u003cschoechlin@osb-alliance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-19 10:55:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configuration improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reliability and performance improvements for"},{"line_number":10,"context_line":"the general broker configuration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4d5d49a6_46ba5fe7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"updated":"2023-12-19 12:39:12.000000000","message":"rabbitmq: configuration improvements","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marc Schöchlin \u003cschoechlin@osb-alliance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-19 10:55:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configuration improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reliability and performance improvements for"},{"line_number":10,"context_line":"the general broker configuration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8121271f_1626e2d6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"in_reply_to":"4d5d49a6_46ba5fe7","updated":"2023-12-19 16:02:07.000000000","message":"Done","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marc Schöchlin \u003cschoechlin@osb-alliance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-19 10:55:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configuration improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reliability and performance improvements for"},{"line_number":10,"context_line":"the general broker configuration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7e9918dd_5455a410","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"in_reply_to":"8121271f_1626e2d6","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Done","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ec67e7b_e3288422","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":44},"updated":"2023-12-19 12:39:12.000000000","message":"nit: amnesia","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"82062d7e_72309a9e","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":38},"updated":"2023-12-19 12:39:12.000000000","message":"nit: erlang","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f3b445f2_792d0fd0","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":44},"in_reply_to":"18893735_628dbf44","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Erlang often describes that als nesia or mnesia.\n\u003e Changed it to \"mnesia\" (see https://www.erlang.org/doc/man/mnesia.html).","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"18893735_628dbf44","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":44},"in_reply_to":"1ec67e7b_e3288422","updated":"2023-12-19 16:02:07.000000000","message":"Erlang often describes that als nesia or mnesia.\nChanged it to \"mnesia\" (see https://www.erlang.org/doc/man/mnesia.html).","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eb9796db_53a8e7e7","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":38},"in_reply_to":"7523fe75_f2b75a36","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s)"},{"line_number":14,"context_line":"- fix: increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":15,"context_line":"  startup times of the brokers"},{"line_number":16,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":17,"context_line":"  binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7523fe75_f2b75a36","line":14,"range":{"start_line":14,"start_character":33,"end_line":14,"end_character":38},"in_reply_to":"82062d7e_72309a9e","updated":"2023-12-19 16:02:07.000000000","message":"Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cf25fd25c132e70b4c88467dd955f7ecc57c4008","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s), set it to"},{"line_number":14,"context_line":"  10s is quorum queues are enabled"},{"line_number":15,"context_line":"- fix: increase the default of 2 erlang mnesia table loaders to 20 for faster"},{"line_number":16,"context_line":"  startup times of the brokers"},{"line_number":17,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a7f7deff_23d1e63b","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":8},"updated":"2024-05-27 12:46:10.000000000","message":"nit: typo: \"if\"","commit_id":"1567259d3a525f3e5e9840c7938e212f82fb3d9c"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"af1fd27b5f80666b317d2cb49241045ce908ac0b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- feature: allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":13,"context_line":"  for faster detection of broken nodes (default value is 60s), set it to"},{"line_number":14,"context_line":"  10s is quorum queues are enabled"},{"line_number":15,"context_line":"- fix: increase the default of 2 erlang mnesia table loaders to 20 for faster"},{"line_number":16,"context_line":"  startup times of the brokers"},{"line_number":17,"context_line":"- fix: change the default behavior of the rabbitmq erlang scheduler-to-core"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9b787220_b1c0f1b8","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":8},"in_reply_to":"a7f7deff_23d1e63b","updated":"2024-05-27 12:56:00.000000000","message":"Done","commit_id":"1567259d3a525f3e5e9840c7938e212f82fb3d9c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96f84e03_e7dfe1a8","updated":"2023-12-12 16:18:19.000000000","message":"Sorry, for the delay. I missed to send the reply - still in progress to get a friend of Gerrit :-)","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7768299bf8c97aae42c9b8e05e3d3b14ce66071b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2d4b03a_fa0929c9","updated":"2023-12-13 11:47:03.000000000","message":"please upload the new patchset, so we can review again, ty :)","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"352707d2af44c0645155bf06b3df05cada1f2d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62440761_e3fdc14b","updated":"2023-12-19 09:56:29.000000000","message":"Performed the suggested changes.","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"223335ea57f0ae2fb939a2dadbefd659879d7604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d89a1db1_b5eee346","updated":"2024-03-08 10:35:02.000000000","message":"recheck : flaky tests, ci problems appeared which do not seem to be related to my changes","commit_id":"b5b41546c14660722bcff25366557992e8e649b1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b2af84ab8ed421a50edf71d4a0095547358d6749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91ffdb4c_6845f5a2","updated":"2024-01-29 15:04:51.000000000","message":"recheck ansible collection mirror issue","commit_id":"b5b41546c14660722bcff25366557992e8e649b1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8b0220387ce57c98415717b6efbc10413c00e2d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"10aebe59_8cab6daa","updated":"2024-01-30 15:32:05.000000000","message":"the test-core-openstack in the ubuntu-upgrade-cephadm job suddenly ends with:\n\n```\nSUCCESS: Instance (Nova and Neutron) upgrade stability (PHASE: deploy)\n\n+ unset_cirros_image_q35_machine_type\n\n+ openstack image unset --property hw_machine_type cirros\n\n```\n\nwith no further output. either the ouput got somehow truncated (I doubt it) or there was some kind of timeout or job execution interruption.\n\neither way it doesn\u0027t look like it\u0027s related to the patchset imho.","commit_id":"b5b41546c14660722bcff25366557992e8e649b1"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"ff20d0160336f09c6e35d099ee5e88ebf90a1bd0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6608dbdc_d0770ba8","updated":"2024-03-11 11:31:58.000000000","message":"Again, `job-output.txt` lists that `deploy.sh` ran into a problem (\"non-zero return code\", \"rc\": 2) on \"primary\".\n\nAnalyzing the \"/primary/logs/ansible/deploy\" resulted in a error message which describes the following problem.\n\n```\n    \"msg\": \"Container exited with non-zero return code 2\",\n    \"rc\": 2,\n    \"stderr\": \"+ sudo -E kolla_set_configs\\nINFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json\\nERROR:__main__:Unexpected error:\\nTraceback (most recent call last):\\n  File \\\"/usr/local/bin/kolla_set_configs\\\", line 419, in main\\n    config \u003d load_config()\\n  File \\\"/usr/local/bin/kolla_set_configs\\\", line 292, in+ load_config\\n    config \u003d load_from_file()\\n  File \\\"/usr/local/bin/kolla_set_configs\\\", line 282, in load_from_file\\n    with open(config_file) as f:\\nFileNotFoundError: [Errno 2] No such file or directory: \u0027/var/lib/kolla/config_files/config.json\u0027\\n\",\n    \"stderr_lines\": [\n        \"+ sudo -E kolla_set_configs\",\n        \"INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json\",\n        \"ERROR:__main__:Unexpected error:\",\n        \"Traceback (most recent call last):\",\n        \"  File \\\"/usr/local/bin/kolla_set_configs\\\", line 419, in main\",\n        \"    config \u003d load_config()\",\n        \"  File \\\"/usr/local/bin/kolla_set_configs\\\", line 292, in load_config\",\n        \"    config \u003d load_from_file()\",\n        \"  File \\\"/usr/local/bin/kolla_set_configs\\\", line 282, in load_from_file\",\n        \"    with open(config_file) as f:\",\n        \"FileNotFoundError: [Errno 2] No such file or directory: \u0027/var/lib/kolla/config_files/config.json\u0027\"\n    ],\n    \"stdout\": \"\",\n    \"stdout_lines\": []\n}\n\n```\n\nSorry, i have not enough background so solve this and i am assuming that this is not caused by my changes.","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7e8455f988af0f2d2bf49b2602cbe73cd8c88105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1e93fdbf_81035c5d","updated":"2024-03-11 15:22:51.000000000","message":"looking into the CI failures now..","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"8f5c7097a65f13c36f2982699a5ba9a131e081dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"92c4ba09_bda3e12a","updated":"2024-03-11 08:27:36.000000000","message":"recheck : again - flaky tests, ci problems appeared which do not seem to be related to my changes\n\n\nI invested some time in downloading and analyzing logs of the previous run.\nIt seems that the ci runs are failing in completely unrelated parts (like glance-api and mariadb). My changeset only touch the rabbitmq configugration, therefore I am trying it again in the hope that the master branch improved over the weekend or for the potential that i am lucky to get a successful run :-)\n(according to https://zuul.opendev.org/t/openstack/builds?job_name\u003dkolla-ansible-debian-podman it seems that it happens very often that jobs with the master revsion are failing last week)","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"e304cbaf7e45113a2188ab41483c9a63521a8bc5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7698af6d_151a34b0","in_reply_to":"0ecc9dbc_a8b3eef9","updated":"2024-03-12 07:22:16.000000000","message":"recheck: tooz 5.0.0 is released/merged, probably this eliminates the described problems (see mailinglist).","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3756cbc9bfde519737a8601e4d1a525bd54dce9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5bbe7227_411b4e8e","in_reply_to":"1e93fdbf_81035c5d","updated":"2024-03-11 15:27:26.000000000","message":"Multinode jobs are broken now, they should get back to functioning state tomorrow, when the new images with tooz pinned to 5.0.0 will be published.","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"1f7a8214f13969463f13cf4b0877da35577b4085","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d641fde2_f2a225d0","in_reply_to":"6608dbdc_d0770ba8","updated":"2024-03-11 11:58:05.000000000","message":"Another tasked failed in `test-core-openstack`withe the following error message.\n\n```\nInstantiating volume client: \u003cclass \u0027cinderclient.v3.client.Client\u0027\u003e\nREQ: curl -g -i -X GET http://192.0.2.10:8776/v3/c147c61fb40747db9e88577bc2ffc40f/os-services -H \"Accept: application/json\" -H \"User-Agent: python-cinderclient\"+ -H \"X-Auth-Token: {SHA256}db8eb8efb07613b020b941e8d797c87faa63a28fb4de3c33bd991a257265b9a3\"\nStarting new HTTP connection (1): 192.0.2.10:8776\nhttp://192.0.2.10:8776 \"GET /v3/c147c61fb40747db9e88577bc2ffc40f/os-services HTTP/1.1\" 500 609\nRESP: [500] content-length: 609 content-type: text/html; charset\u003diso-8859-1 date: Mon, 11 Mar 2024 09:07:54 GMT server: Apache/2.4.52 (Ubuntu)\nRESP BODY: Omitted, Content-Type is set to text/html; charset\u003diso-8859-1. Only application/json, text/plain responses have their bodies logged.\nInternal Server Error (HTTP 500)\nTraceback (most recent call last):\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cliff/app.py\", line 410, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/osc_lib/command/command.py\", line 38, in run\n    return super(Command, self).run(parsed_args)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cliff/display.py\", line 117, in run\n    column_names, data \u003d self.take_action(parsed_args)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/openstackclient/volume/v2/service.py\", line 70, in take_action\n    data \u003d service_client.services.list(\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cinderclient/v3/services.py\", line 54, in list\n    return self._list(url, \"services\")\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cinderclient/base.py\", line 78, in _list\n    resp, body \u003d self.api.client.get(url)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cinderclient/client.py\", line 220, in get\n    return self._cs_request(url, \u0027GET\u0027, **kwargs)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cinderclient/client.py\", line 211, in _cs_request\n    return self.request(url, method, **kwargs)\n  File \"/home/zuul/openstackclient-venv/lib/python3.10/site-packages/cinderclient/client.py\", line 197, in request\n    raise exceptions.from_response(resp, body)\ncinderclient.exceptions.ClientException: Internal Server Error (HTTP 500)\nclean_up ListService: Internal Server Error (HTTP 500)\nEND return value: 1\n```","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"5c7d3d3a80a329641a05d7ec62e7153a4bbfeecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"88151593_9617a71c","in_reply_to":"7698af6d_151a34b0","updated":"2024-03-12 10:01:18.000000000","message":"That seems to be fixed now :-)","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"3a91ba5780faa4e59bbbd600f4fde613130dc028","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0ecc9dbc_a8b3eef9","in_reply_to":"841a4467_57629eff","updated":"2024-03-11 16:21:14.000000000","message":"for reference, this might be related to this fix in tooz, which tried to fix broken redis sentinel support: https://review.opendev.org/c/openstack/tooz/+/911648","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"27fec2d6e6f240969d3d6c9110bd90a6d8c52640","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"841a4467_57629eff","in_reply_to":"d641fde2_f2a225d0","updated":"2024-03-11 16:17:27.000000000","message":"So, in https://zuul.opendev.org/t/openstack/build/1e921c571a814fa8ab36ce036d5396f3/log/primary/logs/ansible/deploy (kolla-ansible-rocky9-podman) I find one failed task at the end of the playbook:\n\n```\n}\n\n\nTASK [nova-cell : Waiting for nova-compute services to register themselves] ****\n\ntask path: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/nova-cell/tasks/wait_discover_computes.yml:8\n\nMonday 11 March 2024  08:54:42 +0000 (0:00:00.092)       0:12:43.746 ********** \n\nUsing module file /home/zuul/kolla-ansible-venv/lib64/python3.9/site-packages/ansible/modules/command.py\n\nPipelining is enabled.\n\n\u003c213.32.79.226\u003e ESTABLISH SSH CONNECTION FOR USER: None\n\n\u003c213.32.79.226\u003e SSH: EXEC ssh -C -o ControlMaster\u003dauto -o ControlPersist\u003d300 -o StrictHostKeyChecking\u003dno -o KbdInteractiveAuthentication\u003dno -o PreferredAuthentications\u003dgssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication\u003dno -o ConnectTimeout\u003d10 -o \u0027ControlPath\u003d\"/home/zuul/.ansible/cp/907b56099f\"\u0027 213.32.79.226 \u0027/bin/sh -c \u0027\"\u0027\"\u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027echo BECOME-SUCCESS-tmsenjdldzogdfhinjcmqyjpfjjpfkzp ; /usr/bin/python3\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\"\u0027\"\u0027\u0027\n\nEscalation succeeded\n\n\u003c213.32.79.226\u003e (1, b\u0027\\n{\"changed\": true, \"stdout\": \"\", \"stderr\": \"internal endpoint for compute service in RegionOne region not found\", \"rc\": 1, \"cmd\": [\"podman\", \"exec\", \"kolla_toolbox\", \"openstack\", \"--os-interface\", \"internal\", \"--os-auth-url\", \"https://192.0.2.10:5000\", \"--os-project-domain-name\", \"default\", \"--os-project-name\", \"admin\", \"--os-username\", \"admin\", \"--os-password\", \"zOIrka0FPeG3pBXmFd4JQyzEIIlEHLxpeu0HfNqi\", \"--os-identity-api-version\", \"3\", \"--os-user-domain-name\", \"default\", \"--os-region-name\", \"RegionOne\", \"--os-cacert\", \"/etc/pki/tls/certs/ca-bundle.crt\", \"compute\", \"service\", \"list\", \"--format\", \"json\", \"--column\", \"Host\", \"--service\", \"nova-compute\"], \"start\": \"2024-03-11 08:54:43.763067\", \"end\": \"2024-03-11 08:54:45.845313\", \"delta\": \"0:00:02.082246\", \"failed\": true, \"msg\": \"non-zero return code\", \"invocation\": {\"module_args\": {\"_raw_params\": \"podman exec kolla_toolbox openstack --os-interface internal --os-auth-url https://192.0.2.10:5000 --os-project-domain-name default --os-project-name admin --os-username admin --os-password zOIrka0FPeG3pBXmFd4JQyzEIIlEHLxpeu0HfNqi --os-identity-api-version 3 --os-user-domain-name default --os-region-name RegionOne --os-cacert /etc/pki/tls/certs/ca-bundle.crt compute service list --format json --column Host --service nova-compute\\\\n\", \"_uses_shell\": false, \"stdin_add_newline\": true, \"strip_empty_ends\": true, \"argv\": null, \"chdir\": null, \"executable\": null, \"creates\": null, \"removes\": null, \"stdin\": null}}}\\n\u0027, b\u0027\u0027)\n\n\u003c213.32.79.226\u003e Failed to connect to the host via ssh: \n\nfatal: [primary]: FAILED! \u003d\u003e {\n```\n\nwhich is \"just\" an ssh failure to connect to the host (happens sometimes). So I would just retry that CI run, looking at only this job.\n\nThe next failed job is https://zuul.opendev.org/t/openstack/build/16d2186a3db84a958b2858ddd14ce4ae which is \"kolla-ansible-rocky9-cephadm (non-voting)\"\nand failed on: `deploy.sh script failed running on host primary`\n\nThis is the error Marc cited above (the first one), however looking at the start of the failed task I see:\n\n```\nTASK [placement : Running placement bootstrap container] ***********************\n[..]\n\u003c23.253.166.172\u003e Failed to connect to the host via ssh: \n```\n\nbefore the rest of the error message Marc posted above, so I also suspect that this failing ssh connection is the main culprit here and I would also rerun the CI to see if this failure persists.\n\nThe next job that failed is: kolla-ansible-ubuntu-cephadm (non-voting)FAILURE\n(https://zuul.opendev.org/t/openstack/build/995f77b643d34228b5d41a2a69001c60)\n\nThis one failed during `test-core-openstack.sh script failed running on host primary`\n\nThe error was the cinder client error which got an 500 internal server error, Marc cited it above.\n\nLooking at the cinder api error log we see a traceback regarding multiple configured redis backends?:\n\nhttps://zuul.opendev.org/t/openstack/build/995f77b643d34228b5d41a2a69001c60/log/primary/logs/kolla/cinder/cinder-api-error.txt\n\n```\n2024-03-11 08:51:54.645578 mod_wsgi (pid\u003d19): Failed to exec Python script file \u0027/var/www/cgi-bin/cinder/cinder-wsgi\u0027.\n\n2024-03-11 08:51:54.645616 mod_wsgi (pid\u003d19): Exception occurred processing WSGI script \u0027/var/www/cgi-bin/cinder/cinder-wsgi\u0027.\n\n2024-03-11 08:51:54.646269 Traceback (most recent call last):\n\n2024-03-11 08:51:54.646328   File \"/var/www/cgi-bin/cinder/cinder-wsgi\", line 52, in \u003cmodule\u003e\n\n2024-03-11 08:51:54.646332     application \u003d initialize_application()\n\n2024-03-11 08:51:54.646337   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/cinder/wsgi/wsgi.py\", line 44, in initialize_application\n\n2024-03-11 08:51:54.646340     coordination.COORDINATOR.start()\n\n2024-03-11 08:51:54.646344   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/cinder/coordination.py\", line 87, in start\n\n2024-03-11 08:51:54.646347     self.coordinator.start(start_heart\u003dTrue)\n\n2024-03-11 08:51:54.646350   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/tooz/coordination.py\", line 689, in start\n\n2024-03-11 08:51:54.646353     super(CoordinationDriverWithExecutor, self).start(start_heart)\n\n2024-03-11 08:51:54.646357   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/tooz/coordination.py\", line 426, in start\n\n2024-03-11 08:51:54.646359     self._start()\n\n2024-03-11 08:51:54.646363   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/tooz/drivers/redis.py\", line 53, in wrapper\n\n2024-03-11 08:51:54.646365     return func(*args, **kwargs)\n\n2024-03-11 08:51:54.646369   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/tooz/drivers/redis.py\", line 491, in _start\n\n2024-03-11 08:51:54.646372     self._client \u003d self._make_client(self._parsed_url, self._options,\n\n2024-03-11 08:51:54.646375   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/tooz/drivers/redis.py\", line 477, in _make_client\n\n2024-03-11 08:51:54.646378     sentinel_server \u003d sentinel.Sentinel(\n\n2024-03-11 08:51:54.646382   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/redis/sentinel.py\", line 234, in __init__\n\n2024-03-11 08:51:54.646384     self.sentinels \u003d [\n\n2024-03-11 08:51:54.646388   File \"/var/lib/kolla/venv/lib/python3.10/site-packages/redis/sentinel.py\", line 235, in \u003clistcomp\u003e\n\n2024-03-11 08:51:54.646390     Redis(hostname, port, **self.sentinel_kwargs)\n\n2024-03-11 08:51:54.646404 TypeError: Redis.__init__() got multiple values for argument \u0027host\u0027\n```\n\nthe `cinder.conf` in this job has the following (key, value) for the coordination backend:\n\n```\n\n[coordination]\n\nbackend_url \u003d redis://admin:Hl9iOr8LmTuGc4gSHXMKwRQE2wuCGyqwHdqa0t3D@192.0.2.1:26379?sentinel\u003dkolla\u0026sentinel_fallback\u003d192.0.2.2:26379\u0026sentinel_fallback\u003d192.0.2.3:26379\u0026db\u003d0\u0026socket_timeout\u003d60\u0026retry_on_timeout\u003dyes\n\n```\n\nI\u0027m investigating if this can be related to the recently introduced changes to the tooz library, which cinder uses to use redis-sentinel.","commit_id":"518cba4363a9ac042a7417bfbfea0bc830146709"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"af1fd27b5f80666b317d2cb49241045ce908ac0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9410ac5f_e87f4d0e","updated":"2024-05-27 12:56:00.000000000","message":"Fixed","commit_id":"1567259d3a525f3e5e9840c7938e212f82fb3d9c"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"bf6efed03aa08ceff57781227dada0acb6dbc488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"25ab890f_5304e7ef","updated":"2024-03-12 14:02:38.000000000","message":"LGTM, we probably could have better docs for tuning rabbitmq in general, but I think the current state is fine for now (everything relevant is in the release notes at least).","commit_id":"1567259d3a525f3e5e9840c7938e212f82fb3d9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f820a6444fda5911b87a89186d9fa29507efbb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"850cd82d_52ffd86c","updated":"2024-05-27 12:55:01.000000000","message":"recheck logs expired","commit_id":"1567259d3a525f3e5e9840c7938e212f82fb3d9c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6b337293e279a91366ff2a868c8238315c70dbd6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ee7a8679_5c56635f","updated":"2024-08-27 10:47:52.000000000","message":"I have a feeling it\u0027s a lot of changes in one patch, if something breaks - we\u0027ll have problems tracking which change caused it.\nCan we maybe split that to a patch per functionality (or per fix) and gradually merge them one by one with some delays?\n\nI\u0027m just worried we\u0027re touching a bit fragile component.","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"91d0436579938822131f526e6661e5457e10e82a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eac53794_8401926e","updated":"2024-10-14 12:30:56.000000000","message":"Since we\u0027re aiming for releasing D - let\u0027s postpone it to the E cycle.","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"258f7989277c827909aaf370e4349bf1642649cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ebf19dd7_d320b81a","updated":"2024-05-28 10:01:37.000000000","message":"so we talked about this via IRC (mainly me and frickler I guess).\n\nThere is a fear of regressions being introduced and this might very well be possible but I still think it should be spelled out exactly which parts are the most likely to cause regressions and what should be done about them.\n\nOne solution might be to split this into smaller independent changes, which always reduces risk and allows for easier reverts, if necessary. But then we need an assessment first what should be split out.\n\nif we want to test this in production before we can maybe stand up a test cluster to test this internally beforehand.\n\nat least CI is super green, which is not always the case in other patchsets, which personally inspires at least a little confidence in myself.\n\nThanks.","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"7ee5483e8e01ce0fdea5eaa6d63715328dc7ca90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0ac21b63_c4e35d2f","in_reply_to":"40f71f18_aabff372","updated":"2025-08-12 00:42:11.000000000","message":"In the meantime I have left the SCS project as project employee (because the funding by the german government ended) and therefore i have less to do with kolla-based environments or the working capacity to test the change more intensively\n\nI think that the changes were well justified and sufficiently analyzed with @sven_oss@posteo.de  at the time. I can still make a few changes to the change, but from my experience I am rather skeptical whether this will ever become reality :-)","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":26319,"name":"Michel Raabe","display_name":"Michel Raabe (rmichel)","email":"rmichel@devnu11.net","username":"rmichel","status":"openstack 💚\nceph 💚\n\nworking for B1 Systems GmbH"},"change_message_id":"343f4261d055065c68ccb85d2169b1cbe99fa462","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6561a785_ed020b84","in_reply_to":"eac53794_8401926e","updated":"2026-03-27 14:34:24.000000000","message":"We\u0027re are on the way to the G cycle - any chance of getting this merged?","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"3c46e746899fabf797553d4beb431e19b683c355","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"40f71f18_aabff372","in_reply_to":"ee7a8679_5c56635f","updated":"2024-10-14 09:33:17.000000000","message":"Sure, i can do that. \n\nHowever, I don\u0027t think there are any practical benefits to reducing the risk of this change if we do the integration of the changes in stages, as many users would probably adapt them in one go with the next major release and test infrastructure typically does not perform high-workload tests to detect problems.\n\nThis change has been open for some time now and I have initially discussed most of the details of the implemented configuration with Sven. If you have any doubts, a deeper discussion of the details would be more beneficial instead. \n\nMy current impression is that the objectives and the effects of the change simply seem difficult for you to assess, because it would be necessary to deal with them in greater conceptual depth (this is not just a bit of code). Furthermore, I am not yet a well-known person in your environment, so you could simply trust me.\nI understand that, but it\u0027s not much fun for me :-))\n\nWhat else I can offer to reduce the risk: If necessary, I can run stress tests in the [Sovereign Cloud Stack Hardware Landscape](https://github.com/SovereignCloudStack/hardware-landscape/pull/54) with larger transaction volumes to see if there are any negative effects.","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"62adad06_f5486d86","line":59,"updated":"2023-12-05 09:01:03.000000000","message":"The name should be prefixed with \"rabbitmq_\". Also the \"_value\" suffix seems redundant.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7768299bf8c97aae42c9b8e05e3d3b14ce66071b","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2f9cc762_0dccc397","line":59,"in_reply_to":"22b221a2_8c69597a","updated":"2023-12-13 11:47:03.000000000","message":"please only mark items as resolved once a new patchset has been published that actually fixes things.\n\nI think you still need to publish patchset 3? ;)","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"613c7b4ef3ff81945f4435a7f9bc5e26359bba20","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"294c3c51_47b09992","line":59,"in_reply_to":"2f9cc762_0dccc397","updated":"2023-12-18 14:35:15.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"b89f33a04ac7d1b31ed2aa4b8aa92e8b8cec0d23","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"441fe8b1_4d27063f","line":59,"in_reply_to":"2f9cc762_0dccc397","updated":"2023-12-18 14:51:36.000000000","message":"Sorry, Gerrit and I are not really friends at the moment. I did a \"git review\" (as discussed) and used it to create the patchset. \n\nDoes that work and was this correct from your view?\n\nIs there a description of the procedure for Gerrit in the Openstack environment that also covers this case (reworking a change)?","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"15e9ea4857b6feb79599ff7d8b693139d4837261","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"397e464d_790ad210","line":59,"in_reply_to":"441fe8b1_4d27063f","updated":"2023-12-19 09:44:35.000000000","message":"Sure, you can find the contributor guide here:\n\nhttps://docs.openstack.org/contributors/code-and-documentation/index.html\n\nvery relevant are these sections:\n\nhttps://docs.openstack.org/contributors/common/git.html#commit-messages\n\nhttps://docs.openstack.org/contributors/common/setup-gerrit.html#individual-contributor-license-agreement-icla\n\nhttps://docs.openstack.org/contributors/common/setup-gerrit.html#git-review\n\nhttps://docs.openstack.org/contributors/code-and-documentation/patch-best-practices.html\n\nhttps://docs.openstack.org/contributors/code-and-documentation/patch-series-tutorial.html\n\nhttps://docs.openstack.org/contributors/code-and-documentation/devstack.html\n\nHTH\n\nLet\u0027s move this part of the discussion to Matrix though, as it is not directly related to the change.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Rabbitmq defines a default total dimension of usable memory of"},{"line_number":58,"context_line":"# \"5G * rabbitmq_vm_memory_high_watermark_relative\" memory size used for the the broker itself."},{"line_number":59,"context_line":"total_memory_available_override_value: 5G"},{"line_number":60,"context_line":"# If you define a \"mem_reservation\" in \"dimension\" this value is used for total_memory_available_override_value instead."},{"line_number":61,"context_line":"# The total memory is then: \"mem_reservation * rabbitmq_vm_memory_high_watermark_relative\""},{"line_number":62,"context_line":"rabbitmq_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"22b221a2_8c69597a","line":59,"in_reply_to":"62adad06_f5486d86","updated":"2023-12-12 16:18:19.000000000","message":"You\u0027re right, I had completely overlooked that. I have now renamed the parameter to \"rabbitmq_total_memory_available_override\".","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# If you reduce this, the cluster can only form correctly if all rabbitmq instances of the cluster were restarted"},{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83f8e1c2_e52039d9","line":121,"updated":"2023-12-05 09:01:03.000000000","message":"The large scale sig claims that the default value is good for this, do you have evidence that changing this is an improvement?\n\nhttps://docs.openstack.org/large-scale/journey/configure/rabbitmq.html#net-ticktime-and-heartbeat","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# If you reduce this, the cluster can only form correctly if all rabbitmq instances of the cluster were restarted"},{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"924cf160_7971cabc","line":121,"in_reply_to":"83f8e1c2_e52039d9","updated":"2023-12-12 16:18:19.000000000","message":"I found a few references, such as the lecture by Felix Huettner (https://www.youtube.com/watch?v\u003dcknfE7xymeQ -\u003e minute 1:24). \n\nBy reducing the value, the cluster can adapt more quickly to nodes that have disappeared or reappeared. However, an really overloaded network or defective network links would also cause \"unrest\" in the RabbitMQ cluster more quickly. It seems plausible to us that this setting is advantageous on the whole.\n\n\nI would have liked to reduce the value to 10 seconds in general, but this requires a short but simultaneous shutdown of all Rabbitmq instances beforehand. \n\nHowever, I have improved the description a little.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"# https://www.rabbitmq.com/nettick.html"},{"line_number":122,"context_line":"# The default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d98f3a7c_b06f9106","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":25},"updated":"2023-12-19 12:39:12.000000000","message":"should we set this to 10 in Caracal if quorum queues are enabled?","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"69a63d7442628b43f65f0c08d705df29668627bb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"# https://www.rabbitmq.com/nettick.html"},{"line_number":122,"context_line":"# The default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"64c67183_e7904cc6","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":25},"in_reply_to":"4d4fd0a1_72c189c9","updated":"2024-01-02 16:49:29.000000000","message":"It seems that a complete reset of rabbitmq is required if someone activates quorum queues (https://review.opendev.org/c/openstack/kolla-ansible/+/900528?tab\u003dcomments , https://review.opendev.org/c/openstack/kolla-ansible/+/898543/12/doc/source/reference/message-queues/rabbitmq.rst).\n\nFrom this point of view, it would be a good idea to set the existing mandatory restart to the desired value.\n\nSo I could set the default of the parameter rabbitmq_net_ticktime to 10 seconds depending on the parameter om_enable_rabbitmq_quorum_queues.\n\nTherefore i added the new default now.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"# https://www.rabbitmq.com/nettick.html"},{"line_number":122,"context_line":"# The default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a7a43ef1_0a4728b7","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":25},"in_reply_to":"64c67183_e7904cc6","updated":"2024-05-04 12:14:00.000000000","message":"\u003e It seems that a complete reset of rabbitmq is required if someone activates quorum queues (https://review.opendev.org/c/openstack/kolla-ansible/+/900528?tab\u003dcomments , https://review.opendev.org/c/openstack/kolla-ansible/+/898543/12/doc/source/reference/message-queues/rabbitmq.rst).\n\u003e \n\u003e From this point of view, it would be a good idea to set the existing mandatory restart to the desired value.\n\u003e \n\u003e So I could set the default of the parameter rabbitmq_net_ticktime to 10 seconds depending on the parameter om_enable_rabbitmq_quorum_queues.\n\u003e \n\u003e Therefore i added the new default now.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# For new setups it is recommended to set this to 10 seconds (will be the future default after the quorum queue migration)"},{"line_number":121,"context_line":"# https://www.rabbitmq.com/nettick.html"},{"line_number":122,"context_line":"# The default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: 60"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4d4fd0a1_72c189c9","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":25},"in_reply_to":"d98f3a7c_b06f9106","updated":"2023-12-19 16:02:07.000000000","message":"As described it is necessary to restart all rabbitmq instances without long delays between the restart steps to ensure a proper function of the cluster.\nIf the conversion to quorum queues needs a complete shutdown or a shirt time restart of all rabbitmq nodes, we should take the chance to also activate this.\nIn the longer term, I would highly recommend this as the default.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"03a87181dbc03fef82722165cba4f24a654e62a6","unresolved":true,"context_lines":[{"line_number":120,"context_line":"# of the cluster were restarted within a short period of time"},{"line_number":121,"context_line":"# For new setups it is recommended to set this to 10 seconds, therefore it will be the future default after the quorum queue migration."},{"line_number":122,"context_line":"# The rabbitmq default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: \"{{ \u002710\u0027 if om_enable_rabbitmq_quorum_queues else \u002760\u0027 }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"23ec9fb7_832ab1ed","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":2},"updated":"2024-06-11 08:19:01.000000000","message":"I don\u0027t think we can\u0027t currently set this to 10 seconds, see e.g. this recent CI run:\n\nhttps://zuul.opendev.org/t/openstack/build/bf1f23474aa74ef89bd2ab68b2cdf29b/log/primary/logs/kolla/rabbitmq/rabbit@primary.txt#182\n\n2024-06-07 15:11:17.519055+00:00 [info] \u003c0.9.0\u003e Time to start RabbitMQ: 19026 ms\n\nI think we need either more CI resources/discover why starting rmq takes so long in CI.\n\nIn fact I\u0027m investigating there, because the rmq healthcheck frequently times out / the 60 seconds in this change seem to be not enough, currently:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/921381","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"0de384920f6cbcb61a1824f4b4a38f19a54cb375","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# of the cluster were restarted within a short period of time"},{"line_number":121,"context_line":"# For new setups it is recommended to set this to 10 seconds, therefore it will be the future default after the quorum queue migration."},{"line_number":122,"context_line":"# The rabbitmq default value is 60 Seconds (https://www.rabbitmq.com/nettick.html#frequency)"},{"line_number":123,"context_line":"rabbitmq_net_ticktime: \"{{ \u002710\u0027 if om_enable_rabbitmq_quorum_queues else \u002760\u0027 }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":"# Plugins"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"92e22cd1_f2339a9a","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":2},"in_reply_to":"23ec9fb7_832ab1ed","updated":"2024-07-03 17:49:51.000000000","message":"As already discussed with Sven (a few days ago): The changed value does not affect the formation time of the cluster or any time constraints during RabbitMQ startup.\n\nThe note in ansible/roles/rabbitmq/defaults/main.yml refers to the fact that the new default can be set in any case if the cluster has to be restarted completely anyway due to the conversion to quorum queues.\nFor security reasons, we keep the old value if quorum queues are not activated.\n\nAs soon as all active RabbitMQ nodes have the same setting for this value once, the changed value only shortens the time between which a failure can be detected or also enables error situations to be automatically resolved more quickly.\n  \nI have now revised the commentary again to avoid misunderstandings in the interpretation of the commentary.\n\nPerhaps the change will still be accepted at some point :-)\n\nDone","commit_id":"03b5ec50736de41406b8436360f05e55b7ba05c9"}],"ansible/roles/rabbitmq/templates/advanced.config.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":1,"context_line":"["},{"line_number":2,"context_line":"  {kernel, ["},{"line_number":3,"context_line":"    {net_ticktime,  {{ rabbitmq_net_ticktime }}},"},{"line_number":4,"context_line":"    {inet_dist_use_interface, {% raw %}{{% endraw %}{{ api_interface_address | put_address_in_context(\u0027rabbitmq\u0027) }}}},"},{"line_number":5,"context_line":"    {inet_dist_listen_min, {{ role_rabbitmq_cluster_port }}},"},{"line_number":6,"context_line":"    {inet_dist_listen_max, {{ role_rabbitmq_cluster_port }}}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"96578eac_155a3fca","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":20},"updated":"2023-12-19 12:39:12.000000000","message":"nit: one extra whitespace\nCan we rework this so it\u0027s alphabetically sorted?","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"["},{"line_number":2,"context_line":"  {kernel, ["},{"line_number":3,"context_line":"    {net_ticktime,  {{ rabbitmq_net_ticktime }}},"},{"line_number":4,"context_line":"    {inet_dist_use_interface, {% raw %}{{% endraw %}{{ api_interface_address | put_address_in_context(\u0027rabbitmq\u0027) }}}},"},{"line_number":5,"context_line":"    {inet_dist_listen_min, {{ role_rabbitmq_cluster_port }}},"},{"line_number":6,"context_line":"    {inet_dist_listen_max, {{ role_rabbitmq_cluster_port }}}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"f4f5091f_ad7f8fde","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":20},"in_reply_to":"8065d37b_6582e036","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"["},{"line_number":2,"context_line":"  {kernel, ["},{"line_number":3,"context_line":"    {net_ticktime,  {{ rabbitmq_net_ticktime }}},"},{"line_number":4,"context_line":"    {inet_dist_use_interface, {% raw %}{{% endraw %}{{ api_interface_address | put_address_in_context(\u0027rabbitmq\u0027) }}}},"},{"line_number":5,"context_line":"    {inet_dist_listen_min, {{ role_rabbitmq_cluster_port }}},"},{"line_number":6,"context_line":"    {inet_dist_listen_max, {{ role_rabbitmq_cluster_port }}}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8065d37b_6582e036","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":20},"in_reply_to":"96578eac_155a3fca","updated":"2023-12-19 16:02:07.000000000","message":"Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"}],"ansible/roles/rabbitmq/templates/rabbitmq-env.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8e7350652d8541e090983bce1f86819e987331c0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"RABBITMQ_DIST_PORT\u003d{{ role_rabbitmq_cluster_port }}"},{"line_number":4,"context_line":"RABBITMQ_PID_FILE\u003d{{ rabbitmq_pid_file }}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-kernel inetrc \u0027/etc/rabbitmq/erl_inetrc\u0027\""},{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(30,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"db598e28_79b403ec","line":11,"range":{"start_line":6,"start_character":0,"end_line":11,"end_character":116},"updated":"2023-11-09 14:44:44.000000000","message":"just a general notice that this was inconsistent even before this patchset, so imho this could be cleaned up in a future patchset.\n\nwhat exactly do I mean?\n\nwell, we have split the addtional erlang arguments over several places:\n\n1. in `rabbitmq/defaults/main.yml` as ansible variable `rabbitmq_server_additional_erl_args`\n2. as bash variables inside this script.\n\nimho it would be more consistent - in a future patchset - to set the variables\ncompletely in `defaults/main.yml` and only stitch them together here via jinja templating instead of relying on an implementation detail of rabbitmq that the resulting `rabbitmq-env.conf` will get sourced with `/bin/sh` which may or may not change in the future and may or may not support the style of bash variable merging used here.\n\nsee also: https://www.rabbitmq.com/rabbitmq-env.conf.5.html#DESCRIPTION","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8e7350652d8541e090983bce1f86819e987331c0","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them."},{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"04512432_1ec549c8","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":41},"updated":"2023-11-09 14:44:44.000000000","message":"nit: a - only slightly - better link:\n\nhttps://www.erlang.org/doc/man/erl.html#emulator-flags\n\nyou still have to CTRL-F for \"unbound\" though because there is unfortunately no HTML-anchor at the right place in the docs.","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"48106f0ad94f53ed85683acb2e0e419ca4384d4e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them."},{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ad359e72_e79eccb1","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":41},"in_reply_to":"04512432_1ec549c8","updated":"2023-11-09 15:21:11.000000000","message":"Ack","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8e7350652d8541e090983bce1f86819e987331c0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"},{"line_number":25,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6239d051_360bcd35","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":43},"updated":"2023-11-09 14:44:44.000000000","message":"nit, this deeper link might be useful here:\n\nhttps://www.rabbitmq.com/runtime.html#scheduler-bind-type","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"48106f0ad94f53ed85683acb2e0e419ca4384d4e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"},{"line_number":25,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5e78d238_b74a3494","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":43},"in_reply_to":"6239d051_360bcd35","updated":"2023-11-09 15:21:11.000000000","message":"Ack","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"64d028265c15db08e73dfe18c7e9c1cfdebe6be5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(30,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8aadab03_933b3c52","line":10,"range":{"start_line":10,"start_character":146,"end_line":10,"end_character":148},"updated":"2023-11-27 10:23:46.000000000","message":"the readme says we change this to 20, not 30?\nI remember we talked about this but I can\u0027t really remember atm which value was better, I believe it was 30? Not sure anymore.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(30,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c3ed0e44_21e67adf","line":10,"range":{"start_line":10,"start_character":146,"end_line":10,"end_character":148},"in_reply_to":"8aadab03_933b3c52","updated":"2023-12-12 16:18:19.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them."},{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"d71fdf00_b7d3c773","line":21,"updated":"2023-12-05 09:01:03.000000000","message":"Can we merge this comment section with the following one? In particular it seems unneccessary to have this link to the erlang docs twice.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them."},{"line_number":21,"context_line":"# https://www.erlang.org/doc/man/erl.html"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with \"tnnps\""},{"line_number":24,"context_line":"# see https://www.rabbitmq.com/runtime.html and https://www.erlang.org/doc/man/erl.html"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"931f87c7_150b5541","line":21,"in_reply_to":"d71fdf00_b7d3c773","updated":"2023-12-12 16:18:19.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"613c7b4ef3ff81945f4435a7f9bc5e26359bba20","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them (https://www.erlang.org/doc/man/erl.html#emulator-flags)."},{"line_number":21,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with its own default \"tnnps\""},{"line_number":22,"context_line":"# see https://www.rabbitmq.com/runtime.html#scheduler-bind-type"},{"line_number":23,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0bfb99a7_3e1c8e8f","line":21,"range":{"start_line":21,"start_character":68,"end_line":21,"end_character":76},"updated":"2023-12-18 14:35:15.000000000","message":"typo: overrides","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"352707d2af44c0645155bf06b3df05cada1f2d64","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them (https://www.erlang.org/doc/man/erl.html#emulator-flags)."},{"line_number":21,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overides this with its own default \"tnnps\""},{"line_number":22,"context_line":"# see https://www.rabbitmq.com/runtime.html#scheduler-bind-type"},{"line_number":23,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba6deb20_5d54d511","line":21,"range":{"start_line":21,"start_character":68,"end_line":21,"end_character":76},"in_reply_to":"0bfb99a7_3e1c8e8f","updated":"2023-12-19 09:56:29.000000000","message":"Done","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(20,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"10ebd1a7_602c4011","line":10,"range":{"start_line":10,"start_character":102,"end_line":10,"end_character":103},"updated":"2023-12-19 12:39:12.000000000","message":"nit: one extra whitespace","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(20,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"4fd2d231_a78e2c5b","line":10,"range":{"start_line":10,"start_character":102,"end_line":10,"end_character":103},"in_reply_to":"10ebd1a7_602c4011","updated":"2023-12-19 16:02:07.000000000","message":"Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}"},{"line_number":8,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -proto_dist inet6_tcp\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS -mnesia no_table_loaders {{  rabbitmq_server_no_table_loaders | default(20,true) }}\""},{"line_number":11,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"$RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS {{ rabbitmq_server_additional_erl_args }}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RABBITMQ_CTL_ERL_ARGS\u003d\"{% if api_address_family \u003d\u003d \u0027ipv6\u0027 %}-proto_dist inet6_tcp {% endif %}\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"6d0d8ec3_0e057b7f","line":10,"range":{"start_line":10,"start_character":102,"end_line":10,"end_character":103},"in_reply_to":"4fd2d231_a78e2c5b","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Acknowledged","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":16,"context_line":"export ERL_EPMD_PORT\u003d{{ role_rabbitmq_epmd_port }}"},{"line_number":17,"context_line":"export ERL_INETRC\u003d/etc/rabbitmq/erl_inetrc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them (https://www.erlang.org/doc/man/erl.html#emulator-flags)."},{"line_number":21,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overrides this with its own default \"tnnps\""},{"line_number":22,"context_line":"# see https://www.rabbitmq.com/runtime.html#scheduler-bind-type"},{"line_number":23,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"a8670ca0_1d7b2cfa","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":63},"updated":"2023-12-19 12:39:12.000000000","message":"these comments will be templated out to the file - are we sure we want to?","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":16,"context_line":"export ERL_EPMD_PORT\u003d{{ role_rabbitmq_epmd_port }}"},{"line_number":17,"context_line":"export ERL_INETRC\u003d/etc/rabbitmq/erl_inetrc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them (https://www.erlang.org/doc/man/erl.html#emulator-flags)."},{"line_number":21,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overrides this with its own default \"tnnps\""},{"line_number":22,"context_line":"# see https://www.rabbitmq.com/runtime.html#scheduler-bind-type"},{"line_number":23,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"375d0867_f290fb7b","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":63},"in_reply_to":"4592ac5b_471f83bd","updated":"2024-05-04 12:14:00.000000000","message":"\u003e That was intended. If later generations are inspecting this, this helps to understand the intention.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"export ERL_EPMD_PORT\u003d{{ role_rabbitmq_epmd_port }}"},{"line_number":17,"context_line":"export ERL_INETRC\u003d/etc/rabbitmq/erl_inetrc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# unbound - Schedulers are not bound to logical processors, that is, the operating system decides where the"},{"line_number":20,"context_line":"# scheduler threads execute, and when to migrate them (https://www.erlang.org/doc/man/erl.html#emulator-flags)."},{"line_number":21,"context_line":"# Erlang typically uses that as default, but unfortunately Rabbitmq overrides this with its own default \"tnnps\""},{"line_number":22,"context_line":"# see https://www.rabbitmq.com/runtime.html#scheduler-bind-type"},{"line_number":23,"context_line":"export RABBITMQ_SCHEDULER_BIND_TYPE\u003d\"u\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"4592ac5b_471f83bd","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":63},"in_reply_to":"a8670ca0_1d7b2cfa","updated":"2023-12-19 16:02:07.000000000","message":"That was intended. If later generations are inspecting this, this helps to understand the intention.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"}],"ansible/roles/rabbitmq/templates/rabbitmq.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"# https://www.rabbitmq.com/ha.html#queue-leader-location"},{"line_number":38,"context_line":"# The default \"balanced\" is pretty ok for the most queues especially for quorum-queues"},{"line_number":39,"context_line":"# We activate this for queues which are still not replicated and which are still not quorum queues"},{"line_number":40,"context_line":"queue_leader_locator \u003d {{ rabbitmq_queue_leader_locator | default(\"client-local\", true) }}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Limiting the amount of memory to prevent critical memory situations and to use memory based flow control"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bf5e71dc_122b1ad0","line":40,"updated":"2023-12-05 09:01:03.000000000","message":"According to https://docs.openstack.org/large-scale/journey/configure/rabbitmq.html#master-locator \"client-local\" is the default? The document linked above doesn\u0027t really tell the default.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# https://www.rabbitmq.com/ha.html#queue-leader-location"},{"line_number":38,"context_line":"# The default \"balanced\" is pretty ok for the most queues especially for quorum-queues"},{"line_number":39,"context_line":"# We activate this for queues which are still not replicated and which are still not quorum queues"},{"line_number":40,"context_line":"queue_leader_locator \u003d {{ rabbitmq_queue_leader_locator | default(\"client-local\", true) }}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Limiting the amount of memory to prevent critical memory situations and to use memory based flow control"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1d70f092_326cfbe2","line":40,"in_reply_to":"bf5e71dc_122b1ad0","updated":"2023-12-12 16:18:19.000000000","message":"It looks like kolla-ansible has not configured this to match the documentation you mentioned. You can see this on the current state of Master (https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/rabbitmq/templates/rabbitmq.conf.j2) as well as when doing a CIAB installation and inspecting the installation. I have now added a reference to the default value to the text.","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"# We activate this for queues which are still not replicated and which are still not quorum queues"},{"line_number":40,"context_line":"queue_leader_locator \u003d {{ rabbitmq_queue_leader_locator | default(\"client-local\", true) }}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Limiting the amount of memory to prevent critical memory situations and to use memory based flow control"},{"line_number":44,"context_line":"# Without this the erlang mechanisms of rabbitmq consider all of the available memory of the node to be available for rabbitmq."},{"line_number":45,"context_line":"# (see https://www.rabbitmq.com/memory.html, all other memory settings are calculated from this value)"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a587a1f_ff10951d","line":42,"updated":"2023-12-05 09:01:03.000000000","message":"nit: one empty line is enough?","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# We activate this for queues which are still not replicated and which are still not quorum queues"},{"line_number":40,"context_line":"queue_leader_locator \u003d {{ rabbitmq_queue_leader_locator | default(\"client-local\", true) }}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Limiting the amount of memory to prevent critical memory situations and to use memory based flow control"},{"line_number":44,"context_line":"# Without this the erlang mechanisms of rabbitmq consider all of the available memory of the node to be available for rabbitmq."},{"line_number":45,"context_line":"# (see https://www.rabbitmq.com/memory.html, all other memory settings are calculated from this value)"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"f34c5d55_0467814d","line":42,"in_reply_to":"3a587a1f_ff10951d","updated":"2023-12-12 16:18:19.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"}],"releasenotes/notes/rabbitmq-reliability-6c61627b14ce3e6b.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8e7350652d8541e090983bce1f86819e987331c0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b1a6aff_c332751f","line":18,"range":{"start_line":18,"start_character":32,"end_line":18,"end_character":37},"updated":"2023-11-09 14:44:44.000000000","message":"nit: erlang","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"48106f0ad94f53ed85683acb2e0e419ca4384d4e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"852e9903_62fc9e89","line":18,"range":{"start_line":18,"start_character":32,"end_line":18,"end_character":37},"in_reply_to":"2b1a6aff_c332751f","updated":"2023-11-09 15:21:11.000000000","message":"Ack","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8e7350652d8541e090983bce1f86819e987331c0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"},{"line_number":22,"context_line":"      wokloads on nodes"},{"line_number":23,"context_line":"    - fix rabbitmq memory sizing to enable flow-control in"},{"line_number":24,"context_line":"      a meaningful way (the previous scenarion assumed that to high amount"},{"line_number":25,"context_line":"      of node memory can be used by rabbitmq)"},{"line_number":26,"context_line":"    - configure a disk free limit to ensure that there is enough memory to"},{"line_number":27,"context_line":"      persist messages"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4195ac90_6acd3193","line":24,"range":{"start_line":24,"start_character":37,"end_line":24,"end_character":46},"updated":"2023-11-09 14:44:44.000000000","message":"nit: scenario","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"48106f0ad94f53ed85683acb2e0e419ca4384d4e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"},{"line_number":22,"context_line":"      wokloads on nodes"},{"line_number":23,"context_line":"    - fix rabbitmq memory sizing to enable flow-control in"},{"line_number":24,"context_line":"      a meaningful way (the previous scenarion assumed that to high amount"},{"line_number":25,"context_line":"      of node memory can be used by rabbitmq)"},{"line_number":26,"context_line":"    - configure a disk free limit to ensure that there is enough memory to"},{"line_number":27,"context_line":"      persist messages"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"01af8188_803a4bbc","line":24,"range":{"start_line":24,"start_character":37,"end_line":24,"end_character":46},"in_reply_to":"4195ac90_6acd3193","updated":"2023-11-09 15:21:11.000000000","message":"Ack","commit_id":"9141b0e83915b5438fee9d4347b6a2fb26d36780"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"987484f0f916fb43edaf45ac1ca41f6d09028f1d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Openstack should benefit from them."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    - Allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"      for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"      (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"      It is recommended to the set the parameter \"rabbitmq_net_ticktime\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71fe5a0e_81b2e333","line":10,"updated":"2023-12-05 09:01:03.000000000","message":"Don\u0027t use another \"-\" level here.\n\nUse double-backticks for variable names or similar, e.g. ``net_ticktime``","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Openstack should benefit from them."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    - Allow to set the net_ticktime (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"      for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"      (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"      It is recommended to the set the parameter \"rabbitmq_net_ticktime\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a1b7341_ea3fa251","line":10,"in_reply_to":"71fe5a0e_81b2e333","updated":"2023-12-12 16:18:19.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"64d028265c15db08e73dfe18c7e9c1cfdebe6be5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"677cef97_923b72d5","line":18,"range":{"start_line":18,"start_character":61,"end_line":18,"end_character":63},"updated":"2023-11-27 10:23:46.000000000","message":"the code changes this to 30 by default?","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"64d028265c15db08e73dfe18c7e9c1cfdebe6be5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2e4cb043_d6504342","line":18,"range":{"start_line":18,"start_character":32,"end_line":18,"end_character":37},"updated":"2023-11-27 10:23:46.000000000","message":"typo: erlang","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a9ef3b91_13c7d94e","line":18,"range":{"start_line":18,"start_character":32,"end_line":18,"end_character":37},"in_reply_to":"2e4cb043_d6504342","updated":"2023-12-12 16:18:19.000000000","message":"Adapted it to 20 (the more conservative)\nDone","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"6d5154cf0925e0612ccbb7b125ead57b3498b6da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      brokers."},{"line_number":16,"context_line":"fixes:"},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    - increase the default of 2 elang nesia table loaders to 20 for faster"},{"line_number":19,"context_line":"      startup times of the brokers"},{"line_number":20,"context_line":"    - change the default behavior of the rabbitmq erlang scheduler-to-core"},{"line_number":21,"context_line":"      binding back to the erlang default, make it more suitable for mixed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cae27670_8029c3a2","line":18,"range":{"start_line":18,"start_character":61,"end_line":18,"end_character":63},"in_reply_to":"677cef97_923b72d5","updated":"2023-12-12 16:18:19.000000000","message":"Done","commit_id":"a822b757fc11cc2999c187a256076362ef5ec742"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"613c7b4ef3ff81945f4435a7f9bc5e26359bba20","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Openstack should benefit from them."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Allow to set the `net_ticktime` (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"    for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"    (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"    It is recommended to the set the parameter `rabbitmq_net_ticktime`"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7abec336_a2dd28cc","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":35},"updated":"2023-12-18 14:35:15.000000000","message":"these are no double backticks, unfortunately they got rendered in Jens previous reply, so you were not able to see what he meant.\nThis should be changed like this for sphinx to pick it up correctly:\n\\`\\`net_ticktime\\`\\`\n\nso use two single backticks before and after a keyword, e.g. a variable you want to have rendered in a code block.","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"352707d2af44c0645155bf06b3df05cada1f2d64","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Openstack should benefit from them."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Allow to set the `net_ticktime` (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"    for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"    (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"    It is recommended to the set the parameter `rabbitmq_net_ticktime`"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"63b3fc17_d4a644e6","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":35},"in_reply_to":"7abec336_a2dd28cc","updated":"2023-12-19 09:56:29.000000000","message":"Done","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"613c7b4ef3ff81945f4435a7f9bc5e26359bba20","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    Allow to set the `net_ticktime` (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"    for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"    (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"    It is recommended to the set the parameter `rabbitmq_net_ticktime`"},{"line_number":14,"context_line":"    to 10 seconds, but this requires a sequential restart of all RabbitMQ"},{"line_number":15,"context_line":"    brokers."},{"line_number":16,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cbae7e1b_eba3d72b","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":70},"updated":"2023-12-18 14:35:15.000000000","message":"see above","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"352707d2af44c0645155bf06b3df05cada1f2d64","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Allow to set the `net_ticktime` (https://www.rabbitmq.com/nettick.html)"},{"line_number":11,"context_line":"    for faster detection of unavailable or broken nodes."},{"line_number":12,"context_line":"    (default value is the standard rabbitmq default of 60 seconds)"},{"line_number":13,"context_line":"    It is recommended to the set the parameter `rabbitmq_net_ticktime`"},{"line_number":14,"context_line":"    to 10 seconds, but this requires a sequential restart of all RabbitMQ"},{"line_number":15,"context_line":"    brokers."},{"line_number":16,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"56a7eb63_82344fc7","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":70},"in_reply_to":"cbae7e1b_eba3d72b","updated":"2023-12-19 09:56:29.000000000","message":"Done","commit_id":"d9df5537939eb4945ddb29b07a060cba29719fb0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b07254b70163b2a64ae10c9cfe52c795f3801f03","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Reliability and performance improvements for the general rabbitmq"},{"line_number":4,"context_line":"    broker configuration.  The adjustments solve or prevent potential"},{"line_number":5,"context_line":"    problems for the performance and reliability of the RabbitMQ Broker."},{"line_number":6,"context_line":"    The changes are designed so that all types of queues used for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"92cb6217_4664871e","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":69},"updated":"2023-12-19 12:39:12.000000000","message":"nit: RabbitMQ","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"04309e4287e8d3e92abdc98cee9dbd14718ff95f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Reliability and performance improvements for the general rabbitmq"},{"line_number":4,"context_line":"    broker configuration.  The adjustments solve or prevent potential"},{"line_number":5,"context_line":"    problems for the performance and reliability of the RabbitMQ Broker."},{"line_number":6,"context_line":"    The changes are designed so that all types of queues used for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"92d0bb8a_497186c0","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":69},"in_reply_to":"92cb6217_4664871e","updated":"2023-12-19 16:02:07.000000000","message":"Adapted that on all occurrences.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"},{"author":{"_account_id":36465,"name":"scoopex","display_name":"Marc Schöchlin","email":"ms-openstack@256bit.org","username":"scoopex"},"change_message_id":"f83869815144e5b68049db0059217ef95be7fa51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Reliability and performance improvements for the general rabbitmq"},{"line_number":4,"context_line":"    broker configuration.  The adjustments solve or prevent potential"},{"line_number":5,"context_line":"    problems for the performance and reliability of the RabbitMQ Broker."},{"line_number":6,"context_line":"    The changes are designed so that all types of queues used for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"12deff4f_8efe7d92","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":69},"in_reply_to":"92d0bb8a_497186c0","updated":"2024-05-04 12:14:00.000000000","message":"\u003e Adapted that on all occurrences.","commit_id":"12f8d04151a20d61d4e50851165fb78eabe94173"}]}