)]}'
{"ansible/roles/glance/templates/glance-api.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"81e5bafefd9320b2074b585895e3d45f97391a0d","unresolved":true,"context_lines":[{"line_number":153,"context_line":"{% endif %}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"[cors]"},{"line_number":156,"context_line":"allow_headers \u003d origin,content-md5,x-image-meta-checksum,x-storage-token,accept-encoding,x-auth-token,x-identity-status,x-roles,x-service-catalog,x-user-id,x-tenant-id,x-openstack-request-id"},{"line_number":157,"context_line":"allow_methods \u003d GET,POST,PUT,PATCH,DELETE"},{"line_number":158,"context_line":"allowed_origin \u003d {{ horizon_public_endpoint }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ec2c4e3_29b734b0","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":190},"updated":"2023-11-16 10:16:42.000000000","message":"will there ever be a need to modify it on a deployment?","commit_id":"c1846305b2c040cc69ca3b8d6de9808ecc933fe7"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c9cd723121b6764d1f55540c0b027e40661b8dcf","unresolved":true,"context_lines":[{"line_number":153,"context_line":"{% endif %}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"[cors]"},{"line_number":156,"context_line":"allow_headers \u003d origin,content-md5,x-image-meta-checksum,x-storage-token,accept-encoding,x-auth-token,x-identity-status,x-roles,x-service-catalog,x-user-id,x-tenant-id,x-openstack-request-id"},{"line_number":157,"context_line":"allow_methods \u003d GET,POST,PUT,PATCH,DELETE"},{"line_number":158,"context_line":"allowed_origin \u003d {{ horizon_public_endpoint }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ef3e8162_76e0575b","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":190},"in_reply_to":"1ec2c4e3_29b734b0","updated":"2023-11-16 14:18:58.000000000","message":"In the meantime I found out the glance cors settings are even documented with defaults here:\n\nhttps://docs.openstack.org/glance/latest/configuration/glance_api.html#cors\n\nthe only addition to the defaults is to allow the \"origin\" header as well.\n\nregarding your question:\n\nI don\u0027t know, but given that it\u0027s not configurable in openstack-ansible I guess it\u0027s a sensible default?\n\nThe nature of security changes is, of course, always to disallow stuff that was possible before, so by definition users that had a valid usecase for stuff that does not work now anymore are impacted.\n\nthe question is, if we want to support these hypothetical usecases.\n\nso all in all I personally don\u0027t think this should be configurable by the user.","commit_id":"c1846305b2c040cc69ca3b8d6de9808ecc933fe7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2a905ac5b6ce663bf557d1ecde5bd80f60518d65","unresolved":true,"context_lines":[{"line_number":153,"context_line":"{% endif %}"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"[cors]"},{"line_number":156,"context_line":"allow_headers \u003d origin,content-md5,x-image-meta-checksum,x-storage-token,accept-encoding,x-auth-token,x-identity-status,x-roles,x-service-catalog,x-user-id,x-tenant-id,x-openstack-request-id"},{"line_number":157,"context_line":"allow_methods \u003d GET,POST,PUT,PATCH,DELETE"},{"line_number":158,"context_line":"allowed_origin \u003d {{ horizon_public_endpoint }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d8a4f64d_a8c3c28a","line":156,"range":{"start_line":156,"start_character":16,"end_line":156,"end_character":190},"in_reply_to":"ef3e8162_76e0575b","updated":"2023-11-16 14:28:24.000000000","message":"Second question is if it\u0027s more secure than the defaults, if it adds another header ;-)","commit_id":"c1846305b2c040cc69ca3b8d6de9808ecc933fe7"}]}
