)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aabe869e434389fd168601729fea133a0fa61fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9ff10f33_7a1ca5e4","updated":"2023-11-28 14:48:23.000000000","message":"recheck (depends on changed)","commit_id":"0d3178a642cf2c46a7971cce8accf46a4f4a476e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f488b145e108f26f1aa59a9e5ce94eb9a15b1477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"fe82c0d9_d549d56f","updated":"2023-11-30 12:11:08.000000000","message":"recheck (new images uploaded with labels)","commit_id":"06baa8f63f6b07b1d8f9d48b4601b78d17ddbb2a"}],"ansible/roles/common/tasks/config.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"10603d16fe4dfd26d4951f0a4d6c53a1f3e995e4","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    action: \"ensure_image\""},{"line_number":49,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":50,"context_line":"    image: \"{{ service.image }}\""},{"line_number":51,"context_line":"  when: enable_fluentd | bool"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Fetch fluentd Docker image labels"},{"line_number":54,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"daad933f_8bc1c141","line":51,"updated":"2023-11-29 14:10:03.000000000","message":"Can we make these conditional on fluentd_cmd and fluentd_user not being set? So we can do gen-config without pulling images?","commit_id":"06baa8f63f6b07b1d8f9d48b4601b78d17ddbb2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7862e3753d17d3c206272f60ffe6841f1d63b56c","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    action: \"ensure_image\""},{"line_number":49,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":50,"context_line":"    image: \"{{ service.image }}\""},{"line_number":51,"context_line":"  when: enable_fluentd | bool"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Fetch fluentd Docker image labels"},{"line_number":54,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"330d5b32_cc1eb42b","line":51,"in_reply_to":"daad933f_8bc1c141","updated":"2023-11-29 17:52:28.000000000","message":"I\u0027ll do that in a followup - want to merge the bump so we can release","commit_id":"06baa8f63f6b07b1d8f9d48b4601b78d17ddbb2a"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"a99e39386103886cf09d28c6314923aaf8b61e98","unresolved":true,"context_lines":[{"line_number":89,"context_line":"  when:"},{"line_number":90,"context_line":"    - kolla_container_engine \u003d\u003d \"podman\""},{"line_number":91,"context_line":"    - enable_fluentd | bool"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Copying over config.json files for services"},{"line_number":94,"context_line":"  template:"},{"line_number":95,"context_line":"    src: \"{{ item.key }}.json.j2\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"f4b21b5f_95da2245","line":92,"updated":"2023-11-29 14:29:31.000000000","message":"Couldn\u0027t we register the fluentD labels as `fluentd_labels` on both podman and docker tasks so we can have only one `Set fluentd facts` task ?\n\n```\n- name: Fetch fluentd Docker image labels\n  vars:\n    service_name: \"fluentd\"\n    service: \"{{ common_services[service_name] }}\"\n  become: true\n  docker_image_info:\n    name: \"{{ service.image }}\"\n  register: fluentd_labels\n  when:\n    - kolla_container_engine \u003d\u003d \"docker\"\n    - enable_fluentd | bool\n\n- name: Fetch fluentd Podman image labels\n  vars:\n    service_name: \"fluentd\"\n    service: \"{{ common_services[service_name] }}\"\n  become: true\n  podman_image_info:\n    name: \"{{ service.image }}\"\n  register: fluentd_labels\n  when:\n    - kolla_container_engine \u003d\u003d \"podman\"\n    - enable_fluentd | bool\n\n- name: Set fluentd facts\n  set_fact:\n    fluentd_cmd: \"{{ fluentd_labels.images[0].ContainerConfig.Labels.fluentd_binary | default(\u0027td-agent\u0027) }}\"\n    fluentd_user: \"{{ fluentd_labels.images[0].ContainerConfig.Labels.fluentd_user | default(\u0027td-agent\u0027) }}\"\n  when:\n    - enable_fluentd | bool\n```","commit_id":"06baa8f63f6b07b1d8f9d48b4601b78d17ddbb2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7862e3753d17d3c206272f60ffe6841f1d63b56c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  when:"},{"line_number":90,"context_line":"    - kolla_container_engine \u003d\u003d \"podman\""},{"line_number":91,"context_line":"    - enable_fluentd | bool"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Copying over config.json files for services"},{"line_number":94,"context_line":"  template:"},{"line_number":95,"context_line":"    src: \"{{ item.key }}.json.j2\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"46c52b03_8c060e3b","line":92,"in_reply_to":"f4b21b5f_95da2245","updated":"2023-11-29 17:52:28.000000000","message":"No, because then if podman is skipped - you get a var with data that task was skipped.","commit_id":"06baa8f63f6b07b1d8f9d48b4601b78d17ddbb2a"}]}