)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f01b2cca1764dfbefa5f60dfb555071494f82984","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-01 15:02:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"enable quorum queues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This implements a global toggle `om_enable_rabbitmq_quorum_queues`"},{"line_number":10,"context_line":"to enable quorum queues for each service in RabbitMQ, similar to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"15628909_06413bec","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2023-12-02 21:37:46.000000000","message":"Maybe change the commit title too, which currently suggests that quorum queues are enabled by default.","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32c873fdf6f719fdb1aaba86f45143570b078fdf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-01 15:02:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"enable quorum queues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This implements a global toggle `om_enable_rabbitmq_quorum_queues`"},{"line_number":10,"context_line":"to enable quorum queues for each service in RabbitMQ, similar to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3cd5a4f7_c539f0f6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"in_reply_to":"15628909_06413bec","updated":"2023-12-18 10:00:30.000000000","message":"Done","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32c873fdf6f719fdb1aaba86f45143570b078fdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb2ac626_41e1c0dd","updated":"2023-12-18 10:00:30.000000000","message":"all comments should be addressed, please re-review.","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"02582a590d10a46d9a278c4527a053dd8e7a3cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b1e9a80e_c8fbe805","updated":"2023-12-19 18:01:51.000000000","message":"changed the service_check syntax again to please new ansible-lint settings.","commit_id":"f6f157c650a66f751f866adf552a0f50a774d016"}],"ansible/roles/prechecks/tasks/service_checks.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f01b2cca1764dfbefa5f60dfb555071494f82984","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    msg: \"We are sorry but enable_ceph is no longer supported. Please use external ceph support.\""},{"line_number":62,"context_line":"  when:"},{"line_number":63,"context_line":"    - (enable_ceph | default()) | bool"},{"line_number":64,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD   (f45a5c Merge \"Move [oslo_policy] back inside Jinja if block\" into s)"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Validate that enable_zun is disabled"},{"line_number":68,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"43db9346_a37ade25","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":7},"updated":"2023-12-02 21:37:46.000000000","message":"Oops ;)","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32c873fdf6f719fdb1aaba86f45143570b078fdf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    msg: \"We are sorry but enable_ceph is no longer supported. Please use external ceph support.\""},{"line_number":62,"context_line":"  when:"},{"line_number":63,"context_line":"    - (enable_ceph | default()) | bool"},{"line_number":64,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD   (f45a5c Merge \"Move [oslo_policy] back inside Jinja if block\" into s)"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Validate that enable_zun is disabled"},{"line_number":68,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"479c3803_f64f26ed","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":7},"in_reply_to":"43db9346_a37ade25","updated":"2023-12-18 10:00:30.000000000","message":"Done","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f01b2cca1764dfbefa5f60dfb555071494f82984","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"},{"line_number":82,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e CHANGE (645755 enable quorum queues)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ae9ebbf7_897f3aa5","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":44},"updated":"2023-12-02 21:37:46.000000000","message":"Oops again ;)","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"32c873fdf6f719fdb1aaba86f45143570b078fdf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    msg: |"},{"line_number":80,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":81,"context_line":"  when: (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)"},{"line_number":82,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e CHANGE (645755 enable quorum queues)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"34500755_04283d41","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":44},"in_reply_to":"ae9ebbf7_897f3aa5","updated":"2023-12-18 10:00:30.000000000","message":"Done","commit_id":"3327a18d239258493e24fde776cbc9bce2c54a3d"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"1dcad63d04bcffd61823db2a3f7ff1d8aed56638","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Validate rabbitmq variables"},{"line_number":66,"context_line":"  run_once: True"},{"line_number":67,"context_line":"  fail:"},{"line_number":68,"context_line":"    msg: |"},{"line_number":69,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":70,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"35907bcb_f2a9836d","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":6},"updated":"2023-12-18 15:23:05.000000000","message":"NIT: assert module is better for visibility when the task fail","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"741386133c71ebdd0ad4717adaa2cc62dbe4e7f9","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Validate rabbitmq variables"},{"line_number":66,"context_line":"  run_once: True"},{"line_number":67,"context_line":"  fail:"},{"line_number":68,"context_line":"    msg: |"},{"line_number":69,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":70,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"44b1d92f_c36347f4","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":6},"in_reply_to":"35907bcb_f2a9836d","updated":"2023-12-18 17:46:16.000000000","message":"this is a cherry pick, please raise this on master branch, where this already got merged. so either please open a new bug report or propose a patch.","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"1dcad63d04bcffd61823db2a3f7ff1d8aed56638","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    msg: |"},{"line_number":69,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - (om_enable_rabbitmq_high_availability | bool and not om_enable_rabbitmq_quorum_queues | bool) or (not om_enable_rabbitmq_high_availability | bool and om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"601d1b6e_a0728be8","line":71,"updated":"2023-12-18 15:23:05.000000000","message":"Logic could be simpler:\n\n```\n- (om_enable_rabbitmq_high_availability | bool) \u003d\u003d (om_enable_rabbitmq_quorum_queues | bool)\n```","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"},{"author":{"_account_id":34579,"name":"Juan Pablo Suazo","email":"jsuazo@whitestack.com","username":"jsuazo"},"change_message_id":"5c4157e449e3f6decfd5075bae5a46deb8f715a9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    msg: |"},{"line_number":69,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - (om_enable_rabbitmq_high_availability | bool and not om_enable_rabbitmq_quorum_queues | bool) or (not om_enable_rabbitmq_high_availability | bool and om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c5f72bdb_e09e872e","line":71,"in_reply_to":"1be0239e_f08496d3","updated":"2023-12-18 18:18:03.000000000","message":"Done","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"741386133c71ebdd0ad4717adaa2cc62dbe4e7f9","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    msg: |"},{"line_number":69,"context_line":"      Please set only one of om_enable_rabbitmq_high_availability or om_enable_rabbitmq_quorum_queues"},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - (om_enable_rabbitmq_high_availability | bool and not om_enable_rabbitmq_quorum_queues | bool) or (not om_enable_rabbitmq_high_availability | bool and om_enable_rabbitmq_quorum_queues | bool)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1be0239e_f08496d3","line":71,"in_reply_to":"601d1b6e_a0728be8","updated":"2023-12-18 17:46:16.000000000","message":"no, it was implemented this way before in master, and applies to master this way. but not to this backport.\n\nthis backport needs to really ensure that only one of these is set by the user, your variant evaluates also as true if both are false.\n\nBut both being false is fine on older releases, so we can\u0027t fail on that.\n\nNeverthelesse the check was still wrong, doing classical XOR which also fails if both are false, I have adjusted the code accordingly to only fail if both are set to true.","commit_id":"f39cfcafe8a7aee4a419dd02b6856fb3fcb71ff8"}],"doc/source/reference/message-queues/rabbitmq.rst":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2be4e28f7953e4801312356bd079d8dc4c01c945","unresolved":true,"context_lines":[{"line_number":125,"context_line":"After enabling this value on a running system, there are some additional steps"},{"line_number":126,"context_line":"needed to migrate from transient to durable queues."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. warning::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"   Since the default changed from non-HA to Quorum queues in Bobcat release,"},{"line_number":131,"context_line":"   following procedure is required to be carried out before an upgrade."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"1. Stop all OpenStack services which use RabbitMQ, so that they will not"},{"line_number":134,"context_line":"   attempt to recreate any queues yet."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"c7bd744a_48f2e38d","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":1},"updated":"2023-12-19 10:14:06.000000000","message":"Given the default value isn\u0027t being backported, this should be changed to say it only applies if an operator chooses to enable either HA or quorum queues.","commit_id":"7cd5a4e1a9fe103c2ee4b82939eee66d5972bbbe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9e66331740964da7a8793bf0057562200cbf8db2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"After enabling this value on a running system, there are some additional steps"},{"line_number":126,"context_line":"needed to migrate from transient to durable queues."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. warning::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"   Since the default changed from non-HA to Quorum queues in Bobcat release,"},{"line_number":131,"context_line":"   following procedure is required to be carried out before an upgrade."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"1. Stop all OpenStack services which use RabbitMQ, so that they will not"},{"line_number":134,"context_line":"   attempt to recreate any queues yet."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"84cc4520_69854f1d","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":1},"in_reply_to":"77915e95_4213c18a","updated":"2023-12-19 16:23:00.000000000","message":"Looks good to me","commit_id":"7cd5a4e1a9fe103c2ee4b82939eee66d5972bbbe"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"ba9ac2b1b74d4161b9cfb4ca5f5cbf4205d381fa","unresolved":true,"context_lines":[{"line_number":125,"context_line":"After enabling this value on a running system, there are some additional steps"},{"line_number":126,"context_line":"needed to migrate from transient to durable queues."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. warning::"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"   Since the default changed from non-HA to Quorum queues in Bobcat release,"},{"line_number":131,"context_line":"   following procedure is required to be carried out before an upgrade."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"1. Stop all OpenStack services which use RabbitMQ, so that they will not"},{"line_number":134,"context_line":"   attempt to recreate any queues yet."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"77915e95_4213c18a","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":1},"in_reply_to":"c7bd744a_48f2e38d","updated":"2023-12-19 16:18:56.000000000","message":"That seems fair. I adjusted the text accordingly. I still left a sentence, that the default is changed in the bobcat release, so people are prepared, once they upgrade.","commit_id":"7cd5a4e1a9fe103c2ee4b82939eee66d5972bbbe"}]}