)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"753dbe132505f4a1304abec81a815e7645bb9caf","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a precheck to fail if non-quorum queues are found in RabbitMQ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Currently exludes fanout and reply queues, pending support in"},{"line_number":12,"context_line":"oslo.messaging [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://review.opendev.org/c/openstack/oslo.messaging/+/888479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e036da71_27953e82","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":17},"updated":"2023-12-11 16:55:06.000000000","message":"excludes","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19a63b8c8ba3087366d8ed8e91246fb307a51cb8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a precheck to fail if non-quorum queues are found in RabbitMQ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Currently exludes fanout and reply queues, pending support in"},{"line_number":12,"context_line":"oslo.messaging [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: https://review.opendev.org/c/openstack/oslo.messaging/+/888479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e465d785_9c39c16f","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":17},"in_reply_to":"e036da71_27953e82","updated":"2023-12-12 09:42:50.000000000","message":"Done","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"a386373c693895a0f7e44d65e90b2df735c779f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20f063db_367c723a","updated":"2023-12-06 16:27:21.000000000","message":"should we add a reno for this?","commit_id":"a47e8b966acc3a13ddafcabba0367aacf21a0134"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8daf5dceb39539f7dbaa7ca80628b26cc2919f4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7bc6a3f_f50ee058","in_reply_to":"20f063db_367c723a","updated":"2023-12-07 09:24:07.000000000","message":"Done","commit_id":"a47e8b966acc3a13ddafcabba0367aacf21a0134"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"70c5bce18b2aa3a9c02dc74fb51603f911351f13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7a49347_f8480422","in_reply_to":"20f063db_367c723a","updated":"2023-12-07 09:21:40.000000000","message":"Done","commit_id":"a47e8b966acc3a13ddafcabba0367aacf21a0134"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"75ca68908e93f8ccf968c566cca67a0f22d8a07b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"877e5fe9_addbb19e","updated":"2023-12-07 09:38:03.000000000","message":"Needs backporting to Bobcat :)","commit_id":"cd434d970df1446b91b70058d4bf6765e3eabc6e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"db8827797270a3a8d7432bf2dc4dc0f5d6fe1ec6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d933c310_02a1b27b","updated":"2023-12-07 14:27:09.000000000","message":"investigating CI failure","commit_id":"a5a4e78b0ff531678c11bd21a648f1dd24189fa4"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5aed09824bceeb1ad5afd69b9e746edce7afdb69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf8fdb40_0761d218","in_reply_to":"d933c310_02a1b27b","updated":"2023-12-08 08:36:50.000000000","message":"Done","commit_id":"a5a4e78b0ff531678c11bd21a648f1dd24189fa4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c4a04f33f18bb99c6ab4a9cdd96a338f1556eccd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d5f74ab_bb696a79","updated":"2023-12-08 09:19:07.000000000","message":"I would prefer we do run that precheck - instead of skipping it.\nSo either move running prechecks after we switch queues - or run the rabbitmq precheck, check if it fails, and then run it again after cleaning out RMQ","commit_id":"69dd6d80eb784f30e10b3fe3494fe6ce8c85cf34"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d596b2e403ef5150e484a90ecdef5588e6bb4994","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"613929c4_d7551756","in_reply_to":"2d5f74ab_bb696a79","updated":"2023-12-08 09:38:09.000000000","message":"Running the precheck after ``rabbitmq-reset-state``, but before ``upgrade``, would fail as there will be no queues. I\u0027ve instead proposed to still skip the rabbitmq-ha-precheck beforehand, so that the rest of the prechecks run before the upgrade; but also that we run the rabbitmq-ha-precheck after the upgrade. This will therefore ensure that all queues have been recreated as quorum during ``upgrade``.\n\nDoes this capture what you want from running the precheck?","commit_id":"69dd6d80eb784f30e10b3fe3494fe6ce8c85cf34"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8f7786e5d55c4dd99aa58731fdafcfd8acd78e56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"adc52d78_7b3eed21","in_reply_to":"613929c4_d7551756","updated":"2023-12-08 09:57:21.000000000","message":"Makes sense now","commit_id":"69dd6d80eb784f30e10b3fe3494fe6ce8c85cf34"}],"ansible/roles/rabbitmq/tasks/precheck.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f8adab14cf36878104565d26326029266c177125","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    - name: List RabbitMQ queues"},{"line_number":229,"context_line":"      become: true"},{"line_number":230,"context_line":"      shell:"},{"line_number":231,"context_line":"        cmd: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl list_queues --silent name type | egrep -v \u0027(fanout|reply)\u0027 | awk \u0027{ print $NF }\u0027\""},{"line_number":232,"context_line":"      register: rabbitmq_queues"},{"line_number":233,"context_line":"      changed_when: false"},{"line_number":234,"context_line":"      check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0648c9df_abd995f6","line":231,"range":{"start_line":231,"start_character":112,"end_line":231,"end_character":127},"updated":"2023-12-06 16:18:44.000000000","message":"please add a `#TODO: remove this, once https://review.opendev.org/c/openstack/oslo.messaging/+/888479 is merged` comment here, so we don\u0027t miss fanout and reply queues, once these are also transitioned to quorum queues.","commit_id":"3ca846547e70d2645208483cb0e559a22217a9c3"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"5e7cb0ba937e9793164c79fcaf082ddaa0fd85e1","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    - name: List RabbitMQ queues"},{"line_number":229,"context_line":"      become: true"},{"line_number":230,"context_line":"      shell:"},{"line_number":231,"context_line":"        cmd: \"{{ kolla_container_engine }} exec rabbitmq rabbitmqctl list_queues --silent name type | egrep -v \u0027(fanout|reply)\u0027 | awk \u0027{ print $NF }\u0027\""},{"line_number":232,"context_line":"      register: rabbitmq_queues"},{"line_number":233,"context_line":"      changed_when: false"},{"line_number":234,"context_line":"      check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cd3cda06_7e620bd5","line":231,"range":{"start_line":231,"start_character":112,"end_line":231,"end_character":127},"in_reply_to":"0648c9df_abd995f6","updated":"2023-12-06 16:25:02.000000000","message":"Good shout, done.","commit_id":"3ca846547e70d2645208483cb0e559a22217a9c3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"753dbe132505f4a1304abec81a815e7645bb9caf","unresolved":true,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    - name: Check if RabbitMQ quorum queues need to be configured"},{"line_number":242,"context_line":"      assert:"},{"line_number":243,"context_line":"        that: \"{{ ((rabbitmq_queue_types | length \u003d\u003d 1) | bool) and ((rabbitmq_queue_types | first \u003d\u003d \u0027quorum\u0027) | bool) }}\""},{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"01362ffb_1121b631","line":243,"range":{"start_line":243,"start_character":56,"end_line":243,"end_character":62},"updated":"2023-12-11 16:55:06.000000000","message":"I don\u0027t understand these parts, the result of doing \"\u003d\u003d\" should already be a boolean?","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19a63b8c8ba3087366d8ed8e91246fb307a51cb8","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    - name: Check if RabbitMQ quorum queues need to be configured"},{"line_number":242,"context_line":"      assert:"},{"line_number":243,"context_line":"        that: \"{{ ((rabbitmq_queue_types | length \u003d\u003d 1) | bool) and ((rabbitmq_queue_types | first \u003d\u003d \u0027quorum\u0027) | bool) }}\""},{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cf7d5823_ad114ff7","line":243,"range":{"start_line":243,"start_character":56,"end_line":243,"end_character":62},"in_reply_to":"01362ffb_1121b631","updated":"2023-12-12 09:42:50.000000000","message":"Yes you\u0027re right, have corrected.","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"297f540983487892dd5a101a89f5d60eb5ad17b2","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    - name: Check if RabbitMQ quorum queues need to be configured"},{"line_number":242,"context_line":"      assert:"},{"line_number":243,"context_line":"        that: \"{{ ((rabbitmq_queue_types | length \u003d\u003d 1) | bool) and ((rabbitmq_queue_types | first \u003d\u003d \u0027quorum\u0027) | bool) }}\""},{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"01017c7a_d00dd37f","line":243,"range":{"start_line":243,"start_character":56,"end_line":243,"end_character":62},"in_reply_to":"98f9d8b7_99102582","updated":"2023-12-13 14:49:32.000000000","message":"My bad, forgot to stage the change. Done now","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ae075ec586c7f52534e88903fc816c671752d7a3","unresolved":true,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    - name: Check if RabbitMQ quorum queues need to be configured"},{"line_number":242,"context_line":"      assert:"},{"line_number":243,"context_line":"        that: \"{{ ((rabbitmq_queue_types | length \u003d\u003d 1) | bool) and ((rabbitmq_queue_types | first \u003d\u003d \u0027quorum\u0027) | bool) }}\""},{"line_number":244,"context_line":"        fail_msg: \u003e"},{"line_number":245,"context_line":"          om_enable_rabbitmq_quorum_queues is True but non-quorum queues have been found."},{"line_number":246,"context_line":"          Currently the procedure to migrate to quorum queues is manual."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"98f9d8b7_99102582","line":243,"range":{"start_line":243,"start_character":56,"end_line":243,"end_character":62},"in_reply_to":"cf7d5823_ad114ff7","updated":"2023-12-13 14:37:19.000000000","message":"Did you? I don\u0027t see a change here.","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"}],"tests/upgrade.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8f7786e5d55c4dd99aa58731fdafcfd8acd78e56","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv pull \u0026\u003e /tmp/logs/ansible/pull-upgrade"},{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appripriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"69301819_1eb71897","line":47,"range":{"start_line":47,"start_character":21,"end_line":47,"end_character":32},"updated":"2023-12-08 09:57:21.000000000","message":"nit: appropriate","commit_id":"49633d5309c8b6fda45eff397e88462868afe592"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"eb4f1d7991de7f3665f365e6d359975da494b012","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv pull \u0026\u003e /tmp/logs/ansible/pull-upgrade"},{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appripriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"f49caebe_a40b05e3","line":47,"range":{"start_line":47,"start_character":21,"end_line":47,"end_character":32},"in_reply_to":"69301819_1eb71897","updated":"2023-12-08 10:44:29.000000000","message":"Done","commit_id":"49633d5309c8b6fda45eff397e88462868afe592"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"753dbe132505f4a1304abec81a815e7645bb9caf","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to"},{"line_number":18,"context_line":"    # true in Bobcat, we need to perform a migration to durable queues."}],"source_content_type":"text/x-sh","patch_set":8,"id":"a941ea7c_7ec568d7","line":15,"updated":"2023-12-11 16:55:06.000000000","message":"Why can that precheck not run here? Do we also need to update the documentation with this for people doing an actual upgrade?","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ae075ec586c7f52534e88903fc816c671752d7a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to"},{"line_number":18,"context_line":"    # true in Bobcat, we need to perform a migration to durable queues."}],"source_content_type":"text/x-sh","patch_set":8,"id":"60a56f4b_6669da39","line":15,"in_reply_to":"6a970a3a_1040d6e7","updated":"2023-12-13 14:37:19.000000000","message":"hmm, ok","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19a63b8c8ba3087366d8ed8e91246fb307a51cb8","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --skip-tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    # NOTE(mattcrees): As om_enable_rabbitmq_quorum_queues now defaults to"},{"line_number":18,"context_line":"    # true in Bobcat, we need to perform a migration to durable queues."}],"source_content_type":"text/x-sh","patch_set":8,"id":"6a970a3a_1040d6e7","line":15,"in_reply_to":"a941ea7c_7ec568d7","updated":"2023-12-12 09:42:50.000000000","message":"This precheck is deliberately meant to fail here, as the OS services are still running classic queues at this point. For a user, the message in the precheck then points them to the docs for the migration steps they need to run. \n\nWe already have docs on this procedure, although I do have some fixes under review: https://review.opendev.org/c/openstack/kolla-ansible/+/902789","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"753dbe132505f4a1304abec81a815e7645bb9caf","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9a593d81_3d60d712","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":45},"updated":"2023-12-11 16:55:06.000000000","message":"we are in caracal now. if you only want this in bobcat, better propose it there directly?","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"cc0a85e3ddcc4acdfd5a425f397ea282c629e65e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"}],"source_content_type":"text/x-sh","patch_set":8,"id":"b1b96068_4f2143b3","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":45},"in_reply_to":"4c947e2c_ca9f0b70","updated":"2023-12-12 11:22:35.000000000","message":"There is an argument that these prechecks are still useful in Caracal onwards, as an operator may choose not to enable quorum queues right away. \n\nWhat should the stance of Kolla-Ansible be here? Just support the default config?","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ae075ec586c7f52534e88903fc816c671752d7a3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"}],"source_content_type":"text/x-sh","patch_set":8,"id":"08f12526_d5792124","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":45},"in_reply_to":"52634005_fe0048da","updated":"2023-12-13 14:37:19.000000000","message":"Acknowledged","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19a63b8c8ba3087366d8ed8e91246fb307a51cb8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"}],"source_content_type":"text/x-sh","patch_set":8,"id":"4c947e2c_ca9f0b70","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":45},"in_reply_to":"9a593d81_3d60d712","updated":"2023-12-12 09:42:50.000000000","message":"Yes, I wanted to squeeze these into Bobcat before release but was too slow.\nBobcat patch here: https://review.opendev.org/c/openstack/kolla-ansible/+/903462","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"49151407925403c0dab6c7d5560c53aa5be1c8a6","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv upgrade \u0026\u003e /tmp/logs/ansible/upgrade"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"}],"source_content_type":"text/x-sh","patch_set":8,"id":"52634005_fe0048da","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":45},"in_reply_to":"b1b96068_4f2143b3","updated":"2023-12-13 08:23:34.000000000","message":"knowing many operators and real life deployments I would encourage us to also merge this for the C release and do a backport for bobcat as well.","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"753dbe132505f4a1304abec81a815e7645bb9caf","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"1d6adc13_924e0721","line":49,"updated":"2023-12-11 16:55:06.000000000","message":"from where this is running, it is not really a precheck, but an post-upgrade-check, maybe name it accordingly, even if that means adding an extra command?","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19a63b8c8ba3087366d8ed8e91246fb307a51cb8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    # Check that all appropriate RabbitMQ queues are now quorum queues."},{"line_number":48,"context_line":"    # TODO(mattcrees): Remove this in Caracal."},{"line_number":49,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks --tags rabbitmq-ha-precheck \u0026\u003e /tmp/logs/ansible/rabbitmq-ha-precheck"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/upgrade-post-deploy"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"cf04557d_1473e5c0","line":49,"in_reply_to":"1d6adc13_924e0721","updated":"2023-12-12 09:42:50.000000000","message":"So as mentioned in my other comment, this is intended to be run as a precheck. We run it afterwards in CI to make sure that the migration procedure actually works as intended. \n\nI do like the idea of a separate post-upgrade-check command though, it would be useful here and potentially for other services too. I\u0027ll add writing one to my work pile ;)","commit_id":"bc3ebef85d7016ab9526c4281035e4cac43a816e"}]}