)]}'
{"roles/openstack-clients/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"abad2170ff1e24a820a030795816ca033e08d37d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  - package: python-barbicanclient"},{"line_number":27,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0ebac3de_dc2cff85","line":29,"updated":"2023-12-14 10:19:53.000000000","message":"Can we keep the list of package names sorted?\n\nAlso using the \"scenario\" var here makes this role strictly limited to being used in the CI, should it at least be named accordingly? Or would it make sense to have it be applicable for use within real deployments, too?","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d1c6d17a42f493990952e1514b3ce475dd3c64c6","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  - package: python-barbicanclient"},{"line_number":27,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a0e92ad5_7af9341e","line":29,"in_reply_to":"0ebac3de_dc2cff85","updated":"2023-12-14 10:40:19.000000000","message":"I think if somebody wants to use it - he can override those variable defaults, but we should default to something that works for CI.\nI can add a README - just waiting for the CI to really pass.","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"828052a251b5b9f5076d1a027876e2be6237ba27","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  - package: python-barbicanclient"},{"line_number":27,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"654ae1ee_ca24c88c","line":29,"in_reply_to":"399a5e91_9455a41d","updated":"2023-12-14 16:00:52.000000000","message":"ok","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f042130670425378254ec46f49e26bf42090fb9a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  - package: python-barbicanclient"},{"line_number":27,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"399a5e91_9455a41d","line":29,"in_reply_to":"a0e92ad5_7af9341e","updated":"2023-12-14 10:55:10.000000000","message":"ah my bad, I commented more or less the same thing on an old patchset, didn\u0027t see your comments yet.\nI think a Readme would be fine.","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"abad2170ff1e24a820a030795816ca033e08d37d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""},{"line_number":33,"context_line":"openstack_clients_venv_path: \"{{ openstack_clients_venv_base }}/{{ openstack_clients_venv_name }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5c03571d_6d6b5430","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":41},"updated":"2023-12-14 10:19:53.000000000","message":"Use \"{{ ansible_user_dir }}\" instead in order to be more generic? I don\u0027t think opendev even promises that the CI user name will always be \"zuul\".","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"4291b478e125815cd738e85c1e79df0359f61759","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""},{"line_number":33,"context_line":"openstack_clients_venv_path: \"{{ openstack_clients_venv_base }}/{{ openstack_clients_venv_name }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1e69a087_76188d58","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":40},"updated":"2023-12-14 10:52:59.000000000","message":"question is, if this should evolve into a generic openstackclient role or if this role is specific to testing inside zuul.\n\nif it is the former we should not hardcode the venv base in this way imho.\n\nif it is the latter we should maybe put some disclaimer somewhere, that this role is only meant to be used for testing inside upstream CI?","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f042130670425378254ec46f49e26bf42090fb9a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""},{"line_number":33,"context_line":"openstack_clients_venv_path: \"{{ openstack_clients_venv_base }}/{{ openstack_clients_venv_name }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e6f96e56_a21fc22c","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":40},"in_reply_to":"1e69a087_76188d58","updated":"2023-12-14 10:55:10.000000000","message":"see discussion above.","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d1c6d17a42f493990952e1514b3ce475dd3c64c6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - package: python-mistralclient"},{"line_number":29,"context_line":"    enabled: \"{{ scenario \u003d\u003d \u0027scenario_nfv\u0027 }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack_clients_venv_base: \"/home/zuul\""},{"line_number":32,"context_line":"openstack_clients_venv_name: \"openstackclient-venv\""},{"line_number":33,"context_line":"openstack_clients_venv_path: \"{{ openstack_clients_venv_base }}/{{ openstack_clients_venv_name }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b9a8b988_61d37c0f","line":31,"range":{"start_line":31,"start_character":29,"end_line":31,"end_character":41},"in_reply_to":"5c03571d_6d6b5430","updated":"2023-12-14 10:40:19.000000000","message":"Done","commit_id":"2d805be5d14e748617b33874bd3432ab44ed47d5"}],"roles/openstack-clients/tasks/main.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9d34a7fe66b2e20e5f5ef17fd050776cb6be0faa","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Setup OpenStack clients"},{"line_number":3,"context_line":"  pip:"},{"line_number":4,"context_line":"    name: \"{{ item.package }}\""},{"line_number":5,"context_line":"    virtualenv: \"~/openstackclient-venv\""},{"line_number":6,"context_line":"    virtualenv_command: \"python3 -m venv\""},{"line_number":7,"context_line":"  when: item.enabled"},{"line_number":8,"context_line":"  loop: \"{{ openstack_clients_pip_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"04dd9ab3_6bc9623e","line":5,"range":{"start_line":5,"start_character":17,"end_line":5,"end_character":18},"updated":"2023-12-12 10:06:03.000000000","message":"nit: not sure we should use the shorthand for the home directory here.","commit_id":"583f884f1a6fe216b2fa84dd64beb63f1616c647"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"40572e611eb69f689a9848064c93738e5f5087e7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Setup OpenStack clients"},{"line_number":3,"context_line":"  pip:"},{"line_number":4,"context_line":"    name: \"{{ item.package }}\""},{"line_number":5,"context_line":"    virtualenv: \"~/openstackclient-venv\""},{"line_number":6,"context_line":"    virtualenv_command: \"python3 -m venv\""},{"line_number":7,"context_line":"  when: item.enabled"},{"line_number":8,"context_line":"  loop: \"{{ openstack_clients_pip_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5681133_65bd3733","line":5,"range":{"start_line":5,"start_character":17,"end_line":5,"end_character":18},"in_reply_to":"04dd9ab3_6bc9623e","updated":"2023-12-12 12:42:02.000000000","message":"done","commit_id":"583f884f1a6fe216b2fa84dd64beb63f1616c647"}]}
