)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f329aa309dc4cd4f58feedf2b21f0f7b54d7860","unresolved":true,"context_lines":[{"line_number":10,"context_line":"however there is no such function in Kolla Ansible."},{"line_number":11,"context_line":"Redis has many advantages to Memcached, for example"},{"line_number":12,"context_line":"TLS support.  This commit introduces ability to"},{"line_number":13,"context_line":"change cahcing backend to Redis, however there"},{"line_number":14,"context_line":"is still no TLS support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Implements: redis-caching-backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa2491fa_e3f5a13f","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":14},"updated":"2023-12-20 11:40:20.000000000","message":"caching","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":10,"context_line":"however there is no such function in Kolla Ansible."},{"line_number":11,"context_line":"Redis has many advantages to Memcached, for example"},{"line_number":12,"context_line":"TLS support.  This commit introduces ability to"},{"line_number":13,"context_line":"change cahcing backend to Redis, however there"},{"line_number":14,"context_line":"is still no TLS support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Implements: redis-caching-backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4c82d2c7_e02d9b14","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":14},"in_reply_to":"98b9d098_e88b5f58","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a14c00fd39c88c0fe13f07103e654a650ed8a96f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"however there is no such function in Kolla Ansible."},{"line_number":11,"context_line":"Redis has many advantages to Memcached, for example"},{"line_number":12,"context_line":"TLS support.  This commit introduces ability to"},{"line_number":13,"context_line":"change cahcing backend to Redis, however there"},{"line_number":14,"context_line":"is still no TLS support."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Implements: redis-caching-backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"98b9d098_e88b5f58","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":14},"in_reply_to":"fa2491fa_e3f5a13f","updated":"2024-01-08 08:56:14.000000000","message":"Thanks for finding the typos, they will be corrected with next commit changes","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f329aa309dc4cd4f58feedf2b21f0f7b54d7860","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecd7ec43_25b63cb3","updated":"2023-12-20 11:40:20.000000000","message":"Thanks for your contribution!\n\nSo, I have mainly two questions and some opinions:\n\n1. Why not use redis via the established oslo_cache backend? It seems to support TLS as well, at least that is what I read from the oslo docs.\n\nIs oslo_cache somehow lacking in any regard?\n\nI would have expected this reasoning in the commit message or in updated documentation in the changeset to be honest.\n\n2. Why use a dedicated role for caching, that interacts with every other role?\n\nThis complicates things imho unnecessarily.\n\nI don\u0027t think it\u0027s idiomatic to directly reference a file inside role \"a\" from role \"b\". if they have some kind of dependency this should be clearly spelled out in the code, e.g. by including the role in the other role.\n\nI checked our codebase and we do not do this anywhere, afaik.\n\nHowever I think it is not necessary to introduce a new role here at all, the single file inside this role is the `cache.conf.j2` template, there are no tasks, nothing else.\n\nSo I think it would be better to adjust each individual service template with the necessary lines to adjust for the redis cache.\n\nThis has the advantage that the roles are as self contained as possible and dependencies are clearly spelled out in the code.\n\nAlso this cache role can\u0027t be triggered independently anyway, because it has no tasks or triggers/handlers associated with it. It doesn\u0027t do anything.\n\nSo, tl;dr:\n\n1. I think this does not need a separate role\n2. I think this should use oslo_cache for all backends and if this is not possible it needs to explain why.\n\nPS: This is also missing release notes and possibly updated documentation on how to configure caching in kolla-ansible.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"113f57b34cb4799e1e994f50edd48c8449bec308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14c463a1_5cf56522","updated":"2023-12-20 11:21:39.000000000","message":"This will need a release note that mentions the new option. Likely also having a job that verifies the functionality would be good, maybe amending an existing job to use redis would be easiest.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af5bc183_e5d4072b","in_reply_to":"ecd7ec43_25b63cb3","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"794944ee89c00ff13fecea3db64772aacde0bdf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d6cf621_910bb092","updated":"2024-01-30 15:24:07.000000000","message":"I am curious, do you have some test data to compare with memcached ? I like redis more, but everywhere in openstack upstream docs memcached is always mentioned as cache backend.","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f29e73fced8ecc2672eb575c90c4b4335db30aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08a7c3ad_acc86a97","in_reply_to":"4d6cf621_910bb092","updated":"2024-01-31 09:32:31.000000000","message":"I think there is currently no test data available, we are mostly interested in redis for the TLS support.\n\nWe need to implement this in oslo.cache first, though:\n\nhttps://review.opendev.org/c/openstack/oslo.cache/+/907211","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0d3b9023_9aa90d20","updated":"2024-02-14 08:58:42.000000000","message":"Just resolving some comments that are no more relevant","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f2c4cd60c1a6da166a15f5ef059201d6338adf10","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"269c5a90_47000c59","updated":"2024-02-14 12:37:15.000000000","message":"That\u0027s quite a big patch - is there an option to split out Redis TLS support to a separate patch?","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"b8439a9c7d88fc8da4686a024701ceaba590b211","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"74bbec9e_74a2a36d","in_reply_to":"1b460e48_cc995db3","updated":"2024-02-15 08:50:50.000000000","message":"Allright, that makes sense. Should I abandon this patch then?","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"d191b54365f2cc8999b0245c0ed7abce0fc6efb7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f4dd04d5_f2dcfcfb","in_reply_to":"269c5a90_47000c59","updated":"2024-02-15 08:29:54.000000000","message":"I don\u0027t see the point in that, because one of the patches would be still pretty big.","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a8797bfe8b5430f98626162e6e213ee767c542b7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fa1d6ca0_6c74d74e","in_reply_to":"74bbec9e_74a2a36d","updated":"2024-02-15 09:02:04.000000000","message":"not needed, just make new patch only with role, and create other new patches later","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4d880a7934c8d71d13fea824acb6f4aade24e2e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1b460e48_cc995db3","in_reply_to":"f4dd04d5_f2dcfcfb","updated":"2024-02-15 08:36:21.000000000","message":"it can be several patches, for example one for the redis role itself, second for tls support, next several patches each one for integration in nova, keystone, heat, etc.","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a65262fecdaf40bc8cc64b522edbb7ddb68fab56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"667a93b6_556960b0","in_reply_to":"fa1d6ca0_6c74d74e","updated":"2024-02-15 09:30:03.000000000","message":"I will use this add TLS support to Redis, because that\u0027s what other patches will depend on.","commit_id":"4c3a1778f2ff442ddc832e8bdba781a6f734beaf"}],"ansible/roles/cache/templates/cache.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f329aa309dc4cd4f58feedf2b21f0f7b54d7860","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[cache]"},{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b7f7293c_247cafce","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":29},"updated":"2023-12-20 11:40:20.000000000","message":"what is the reason to use dogpile directly here?\n`oslo_cache` seems to support redis: https://docs.openstack.org/oslo.cache/latest/configuration/index.html#cache.backend\n\na uniform way to access all caches would be preferential, don\u0027t you think?","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a14c00fd39c88c0fe13f07103e654a650ed8a96f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[cache]"},{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e7aa6cf4_67526141","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":29},"in_reply_to":"b7f7293c_247cafce","updated":"2024-01-08 08:56:14.000000000","message":"Thanks for the review.\nI am not sure what you mean by this, the only Redis backend I see there is `dogpile.cache.redis`. I cannot see `oslo_cache.redis` neither in docs you linked nor in the oslo_cache source code.\nHowever, I agree with the uniform way, perhaps we can add redis backend to oslo_cache library.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[cache]"},{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9cfb8081_d9d12b42","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":29},"in_reply_to":"ce74dc9c_c594339d","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c59b1d478548881fe684f6fb20c8fe508b7bbf8c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[cache]"},{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ce74dc9c_c594339d","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":29},"in_reply_to":"e7aa6cf4_67526141","updated":"2024-01-09 11:16:03.000000000","message":"sorry, you are right, I was confused by the oslo_cache docs. Indeed it seems the only current supported way to use redis is `dogpile.cache.redis` as is documented in the linked oslo.cache docs.\n\nHowever another question arises when looking closer at the docs, they state:\n\n\u003e Cache backend module. For eventlet-based or environments with hundreds of threaded servers, Memcache with pooling (oslo_cache.memcache_pool) is recommended. For environments with less than 100 threaded servers, Memcached (dogpile.cache.memcached) or Redis (dogpile.cache.redis) is recommended. Test environments with a single instance of the server can use the dogpile.cache.memory backend.\n\ndid you do any testing or have experience with the different caching modules when it comes to performance?\n\nthe docs at least seem to indicate that memcache is faster or more suitable for larger environments.\n\nshould we at least document this somewhere?\n\nmaybe someone else has experience with the different backends?","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"113f57b34cb4799e1e994f50edd48c8449bec308","unresolved":true,"context_lines":[{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":8,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9805edfc_94299333","line":5,"updated":"2023-12-20 11:21:39.000000000","message":"how is this supposed to work in a HA deployment?","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":8,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6e4076a4_009ddc1d","line":5,"in_reply_to":"28132c50_21bf4ce6","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a14c00fd39c88c0fe13f07103e654a650ed8a96f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"enabled \u003d True"},{"line_number":3,"context_line":"{% if kolla_caching_backend \u003d\u003d \"redis\" %}"},{"line_number":4,"context_line":"backend \u003d dogpile.cache.redis"},{"line_number":5,"context_line":"backend_argument \u003d url:redis://default:{{ redis_master_password }}@{{ api_interface_address }}:{{ redis_port }}"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":8,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027memcache\u0027) }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"28132c50_21bf4ce6","line":5,"in_reply_to":"9805edfc_94299333","updated":"2024-01-08 08:56:14.000000000","message":"good point, i\u0027ve used this for single node just for testing and forgot to replace it with real connection string. I will update that, thank you.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"}],"ansible/roles/ceilometer/tasks/config.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f329aa309dc4cd4f58feedf2b21f0f7b54d7860","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"16e9be1b_04385564","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":2},"updated":"2023-12-20 11:40:20.000000000","message":"I don\u0027t think this is the idiomatic way to include templates from different roles.\n\neither use `include_role`  (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_role_module.html) and let the role handle the templating or maybe put the caching config template in the ceilometer role itself.\n\nI\u0027m actually not sure which approach is better here.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"113f57b34cb4799e1e994f50edd48c8449bec308","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb484f53_cfa77008","line":202,"updated":"2023-12-20 11:21:39.000000000","message":"I\u0027m not sure yet how to resolve this, but using \"..\" in a path seems very ugly to me","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a14c00fd39c88c0fe13f07103e654a650ed8a96f","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db47f62a_9c164262","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":2},"in_reply_to":"16e9be1b_04385564","updated":"2024-01-08 08:56:14.000000000","message":"The reason I did separate template for caching is that we don\u0027t have to edit all the files when we need change to cache configuration, i.e. add TLS certificates in the future (Do not repeat yourself is a good coding habit)\nI will change it using `include_role`","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1d5c050a_a225018d","line":202,"in_reply_to":"6ea575b8_13b01a91","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0d21af80dd78ef492e00d9dbfbf886242306305f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6ded581f_0ff037f7","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":2},"in_reply_to":"db47f62a_9c164262","updated":"2024-02-01 13:29:34.000000000","message":"I guess this is resolved now.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"a14c00fd39c88c0fe13f07103e654a650ed8a96f","unresolved":true,"context_lines":[{"line_number":199,"context_line":"  merge_configs:"},{"line_number":200,"context_line":"    sources:"},{"line_number":201,"context_line":"      - \"{{ role_path }}/templates/ceilometer.conf.j2\""},{"line_number":202,"context_line":"      - \"{{ role_path }}/../cache/templates/cache.conf.j2\""},{"line_number":203,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":204,"context_line":"      - \"{{ node_custom_config }}/ceilometer.conf\""},{"line_number":205,"context_line":"      - \"{{ node_custom_config }}/ceilometer/{{ item.key }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6ea575b8_13b01a91","line":202,"in_reply_to":"eb484f53_cfa77008","updated":"2024-01-08 08:56:14.000000000","message":"This was also mentioned by Sven, i am working on resolving that.","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"}],"ansible/roles/ceilometer/templates/ceilometer.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"113f57b34cb4799e1e994f50edd48c8449bec308","unresolved":true,"context_lines":[{"line_number":44,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":45,"context_line":"amqp_durable_queues \u003d true"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":49,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":50,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a1047708_19464ad4","line":47,"updated":"2023-12-20 11:21:39.000000000","message":"unrelated?","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":45,"context_line":"amqp_durable_queues \u003d true"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":49,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":50,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"094427e0_a953270a","line":47,"in_reply_to":"a1047708_19464ad4","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5e4f8eda86626236ded14af08366bbd9252b5b61","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{% if oslo_cache_backend \u003d\u003d \u0027oslo_cache.redis_sentinel\u0027 %}"},{"line_number":61,"context_line":"backend_argument \u003d sentinels:{{ oslo_cache_redis_sentinel_servers }}"},{"line_number":62,"context_line":"backend_argument \u003d service_name:{{ oslo_cache_redis_sentinel_service_name }}"},{"line_number":63,"context_line":"backend_argument \u003d username:default"},{"line_number":64,"context_line":"backend_argument \u003d password:{{ redis_master_password }}"},{"line_number":65,"context_line":"{% if redis_enable_tls | bool %}"},{"line_number":66,"context_line":"backend_argument \u003d ssl:True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"458dc92a_104d354f","line":63,"range":{"start_line":63,"start_character":28,"end_line":63,"end_character":35},"updated":"2024-01-31 11:12:24.000000000","message":"can we make the username configurable as well?","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% if oslo_cache_backend \u003d\u003d \u0027oslo_cache.redis_sentinel\u0027 %}"},{"line_number":61,"context_line":"backend_argument \u003d sentinels:{{ oslo_cache_redis_sentinel_servers }}"},{"line_number":62,"context_line":"backend_argument \u003d service_name:{{ oslo_cache_redis_sentinel_service_name }}"},{"line_number":63,"context_line":"backend_argument \u003d username:default"},{"line_number":64,"context_line":"backend_argument \u003d password:{{ redis_master_password }}"},{"line_number":65,"context_line":"{% if redis_enable_tls | bool %}"},{"line_number":66,"context_line":"backend_argument \u003d ssl:True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a6012bf8_8499cf00","line":63,"range":{"start_line":63,"start_character":28,"end_line":63,"end_character":35},"in_reply_to":"082dc7a7_561ad3b7","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"56b83732b6c09acc2b67f027fe4532f30adf7e6e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{% if oslo_cache_backend \u003d\u003d \u0027oslo_cache.redis_sentinel\u0027 %}"},{"line_number":61,"context_line":"backend_argument \u003d sentinels:{{ oslo_cache_redis_sentinel_servers }}"},{"line_number":62,"context_line":"backend_argument \u003d service_name:{{ oslo_cache_redis_sentinel_service_name }}"},{"line_number":63,"context_line":"backend_argument \u003d username:default"},{"line_number":64,"context_line":"backend_argument \u003d password:{{ redis_master_password }}"},{"line_number":65,"context_line":"{% if redis_enable_tls | bool %}"},{"line_number":66,"context_line":"backend_argument \u003d ssl:True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"082dc7a7_561ad3b7","line":63,"range":{"start_line":63,"start_character":28,"end_line":63,"end_character":35},"in_reply_to":"458dc92a_104d354f","updated":"2024-02-06 12:03:02.000000000","message":"We can, but AFAIK redis just ignores it anyway unless [ACL](https://redis.io/docs/management/security/acl/) is configured which we do not have currently.","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"}],"ansible/roles/common/tasks/config_cache.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5e4f8eda86626236ded14af08366bbd9252b5b61","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    state: file"},{"line_number":4,"context_line":"    suffix: temp"},{"line_number":5,"context_line":"  register: cache_config_tempfile"},{"line_number":6,"context_line":"- name: Create  configuration for oslo cache"},{"line_number":7,"context_line":"  template:"},{"line_number":8,"context_line":"    src: cache.conf.j2"},{"line_number":9,"context_line":"    dest: \"{{ cache_config_tempfile.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df1f6a38_04d92e88","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":16},"updated":"2024-01-31 11:12:24.000000000","message":"nit: unnecessary double space","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    state: file"},{"line_number":4,"context_line":"    suffix: temp"},{"line_number":5,"context_line":"  register: cache_config_tempfile"},{"line_number":6,"context_line":"- name: Create  configuration for oslo cache"},{"line_number":7,"context_line":"  template:"},{"line_number":8,"context_line":"    src: cache.conf.j2"},{"line_number":9,"context_line":"    dest: \"{{ cache_config_tempfile.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2062801b_9a179f78","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":16},"in_reply_to":"1d012070_8dfa77e2","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"56b83732b6c09acc2b67f027fe4532f30adf7e6e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    state: file"},{"line_number":4,"context_line":"    suffix: temp"},{"line_number":5,"context_line":"  register: cache_config_tempfile"},{"line_number":6,"context_line":"- name: Create  configuration for oslo cache"},{"line_number":7,"context_line":"  template:"},{"line_number":8,"context_line":"    src: cache.conf.j2"},{"line_number":9,"context_line":"    dest: \"{{ cache_config_tempfile.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d012070_8dfa77e2","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":16},"in_reply_to":"df1f6a38_04d92e88","updated":"2024-02-06 12:03:02.000000000","message":"This is part of the old aproach from late december, which I mistakenly included. I will remove it.","commit_id":"b2ea551c9127b6027d6e8d68b1e03ee8c928cb59"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"113f57b34cb4799e1e994f50edd48c8449bec308","unresolved":true,"context_lines":[{"line_number":63,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"amqp_durable_queues \u003d true"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":68,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":69,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"64815a26_532a3c65","line":66,"updated":"2023-12-20 11:21:39.000000000","message":"unrelated?","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":63,"context_line":"{% if om_enable_rabbitmq_high_availability | bool %}"},{"line_number":64,"context_line":"amqp_durable_queues \u003d true"},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"{% if om_enable_rabbitmq_quorum_queues | bool %}"},{"line_number":68,"context_line":"rabbit_quorum_queue \u003d true"},{"line_number":69,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2f6858e4_c015e41c","line":66,"in_reply_to":"64815a26_532a3c65","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"f626c7e4b3d925289011c3a046369dbb6491293e"}],"ansible/roles/placement/templates/placement.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"775b0a104563fc64c36d653f1cdfeda57b17f168","unresolved":true,"context_lines":[{"line_number":66,"context_line":"{% for argument, value in oslo_cache_additional_backend_arguments.items() %}"},{"line_number":67,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"},{"line_number":68,"context_line":"{% endfor %}"},{"line_number":69,"context_line":"{% if oslo_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 %}"},{"line_number":70,"context_line":"memcache_servers \u003d {{ oslo_cache_memcache_servers }}"},{"line_number":71,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"b40cd701_aa0ce7fa","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":2},"updated":"2024-02-09 08:15:50.000000000","message":"I\u0027m not sure this check is sufficient, it\u0027s at least different.\n\nImho we should do both checks, first check if the backend is memcache_pool and then if the list of memcache_servers is longer than zero?","commit_id":"934f549c54dff25eb45e6ff88c7618836da357e2"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"22dbaee4f9cda40222d81d9479cc518517358895","unresolved":false,"context_lines":[{"line_number":66,"context_line":"{% for argument, value in oslo_cache_additional_backend_arguments.items() %}"},{"line_number":67,"context_line":"backend_argument \u003d {{ argument ~\u0027:\u0027~ value}}"},{"line_number":68,"context_line":"{% endfor %}"},{"line_number":69,"context_line":"{% if oslo_cache_backend \u003d\u003d \u0027oslo_cache.memcache_pool\u0027 %}"},{"line_number":70,"context_line":"memcache_servers \u003d {{ oslo_cache_memcache_servers }}"},{"line_number":71,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"0783405c_6314e41b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":2},"in_reply_to":"b40cd701_aa0ce7fa","updated":"2024-02-14 08:58:42.000000000","message":"Acknowledged","commit_id":"934f549c54dff25eb45e6ff88c7618836da357e2"}]}