)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"eb8cb2ed05978439baa90eaf5509adbb2e5356c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"926aa32d_eaad8ed0","updated":"2024-01-03 11:35:16.000000000","message":"Nice :)","commit_id":"ff96606631986319fbf7e8106d437e54cb25ca74"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c877782f268c1b3fb98ec313bfa0069c7a62af42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dba2b47d_161d9849","updated":"2024-01-09 09:21:01.000000000","message":"We need to remove this var:\nhttps://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/neutron/templates/neutron_ovn_metadata_agent.ini.j2#L4","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"cd66770e358443320d9d094acd14898edef2e276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8cc1d521_4538059a","updated":"2024-01-09 09:15:43.000000000","message":"please add short upgrade reno","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"60788f28d0918d5c0bd0e6eeeec353d53ae2e0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"efb7131b_e0160dd5","in_reply_to":"15bcb5f6_3e4147aa","updated":"2024-01-09 09:23:07.000000000","message":"I agree that it is not breaking change for default setup - however pretty significant if somebody does some non default stuff with neutron state - I think we should mention it","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cffb3878157c778fabccb5f907f553c4568fd07d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15bcb5f6_3e4147aa","in_reply_to":"8cc1d521_4538059a","updated":"2024-01-09 09:18:04.000000000","message":"Is it really needed ? Upgrade section of release notes should include breaking changes, but this does not have to attract attention at all..","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"491845f6a834994f6867749ee41a0829beaba5d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec76e7f3_4d538ef2","in_reply_to":"dba2b47d_161d9849","updated":"2024-01-09 09:24:46.000000000","message":"Done","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e47f2b467d47ea2a2ef8e8ec069904ba66571c38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31f314dc_c948e15f","in_reply_to":"dba2b47d_161d9849","updated":"2024-01-09 09:24:38.000000000","message":"Good catch !","commit_id":"954c50d2752f58a45318907a8671d327d303d369"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"54c62464145d63fd7203d24c0a3979ae195ea75d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29dd9cc8_647630d1","updated":"2024-01-09 09:34:18.000000000","message":"config.json files need also adaptation","commit_id":"ca0b2592d363e80a6dfd6f656c830f9f8b636a9f"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f730934497db6e68a36e61a7481cd3fdb7933b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9eabe36d_54653fed","in_reply_to":"29dd9cc8_647630d1","updated":"2024-02-06 08:48:56.000000000","message":"Done","commit_id":"ca0b2592d363e80a6dfd6f656c830f9f8b636a9f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"88b0419879b2532f0635c7a4adbdc7f0007293b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"005b69d0_a5166401","updated":"2024-02-06 08:58:43.000000000","message":"I don\u0027t see the need for this change, can you add some motivation in the commit message?\n\nAlso I do see the possibility that this make break some custom configurations, so adding a release note seems needed IMO.","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b5d076b4387cb6ae18ab29adeff119ac502c391b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f36bcd7_c9d3a7da","updated":"2024-04-22 12:51:21.000000000","message":"as stated before by other a RENO and at least a more elaborate commit message would be welcome (stating that we revert back to upstreams default paths).\n\nCode itself LGTM","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e8ff3fa954d2e2b6ae04258767f3eba5dc1abc95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"112a7384_94427b0b","in_reply_to":"005b69d0_a5166401","updated":"2024-02-06 09:57:01.000000000","message":"neutron_metadata_socket volume name is bad, it\u0027s actually neutron volume for neutron state data.\nI don\u0027t see any possibility to break some custom configurations - can u specify some ? \n\nI\u0027ve tested this on my environment and everything works very nice, (also i merged in my downstream repositories .. so I will be very glad to merge this)\nMoreover, in past we had neutron state_path pointed to /var/lib/neutron and only socket data was in kolla subfolder, then it was fixed by config ..etc etc ..\n\nSo the same situation was caused in  past by config..\n\nThis patch finally fix all stuff , volume name, default state path and not affecting anything. Upgrade jobs working ...tested locally ..so where is a problem ?","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"de6bcb0f439f15ae5544d295c5c511e198084c29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b42b6530_ec4c4f3e","in_reply_to":"09f2cd37_f8305f8d","updated":"2024-02-08 11:08:06.000000000","message":"well I can\u0027t promise to merge anything on my own, but I don\u0027t plan to block this and the original author seems also to be in favor of it, so chances are not bad I\u0027d say","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"18a081454d9a47789e3a1adb6dace8411798429f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cdfa05c7_2a31b317","in_reply_to":"112a7384_94427b0b","updated":"2024-02-06 10:32:30.000000000","message":"a) commits without a proper commit message are always bad. and just having a nicer name for some random volume nobody cares about ... is that worth this effort? and if you want to discuss whether the path change is a real improvement, I could start arguing that using /var/run/something instead would be an even better solution\n\nb) I\u0027m not sure if there is a real chance to break something, we don\u0027t override state_path in tests, so an issue wouldn\u0027t be caught there. why are you so opposed to having release notes?","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c2ef7a51570d2ad850fac60100a13e43bee62035","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09f2cd37_f8305f8d","in_reply_to":"cdfa05c7_2a31b317","updated":"2024-02-06 10:54:33.000000000","message":"a) Yes, I agree that commit message should be improved, I can of course do it. If nobody cares about, why to not change the name to desribe more what is the purpose of that volume ? I don\u0027t think its better solution to change default (as kolla is trying to not change default - only when it\u0027s *really needed*)\n\nb) It\u0027s not - because https://review.opendev.org/c/openstack/kolla-ansible/+/877036 actually fixed this issue by specifing state_path to location where volume is mounted. So that basically means that before this patch all state files was under /var/lib/neutron (as it\u0027s default) and only socket was under /var/lib/neutron/kolla, so that means when we replaced container during the upgrade ..all state files dissapeared and still working from upgrade to upgrade .. This is same situation but addressing all above.\n\nI can add reno for sure. Just let me know if we are going to merge this ...or you will be against and should be abandoned ... I really want to know if i should remove this commit from my downstream repo or not :) \n\nThanks","commit_id":"644d9089e7fb15180e77accc1a8c356d94b42eff"}]}