)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"96da4c093499476660a9f06899e21c779672dfa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c642ba2b_94021239","updated":"2024-01-11 10:44:30.000000000","message":"Thanks for your nice contribution!\n\nCould you please add a release note for this new feature?\n\nIf you are new to the process you can find docs on how to write release notes here:\n\nhttps://docs.openstack.org/kolla/latest/contributor/release-notes.html\n\nyou can also look at other commits that added features with a release note as an example.\n\nif you have any questions, you can also ask on our IRC Chat channel on irc.oftc.net in channel #openstack-kolla.\n\nHTH","commit_id":"65f6d3eef2953288f685f67e1989cb8ed5334ad1"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"85c9d9f2_56009efe","in_reply_to":"129c166c_cbcbde7f","updated":"2024-01-11 13:17:30.000000000","message":"Done","commit_id":"65f6d3eef2953288f685f67e1989cb8ed5334ad1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"dbddbf9060a505939788d0fdc830c8db8997ed57","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"129c166c_cbcbde7f","in_reply_to":"c642ba2b_94021239","updated":"2024-01-11 10:45:19.000000000","message":"this was not meant to be a resolved discussion.","commit_id":"65f6d3eef2953288f685f67e1989cb8ed5334ad1"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"9e7e664f8fe00f7b7bf6c133b5fff80801a5d7d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e530cc2a_fcbb2ab2","updated":"2024-01-11 12:39:56.000000000","message":"Thank you. Feature release notes are now added","commit_id":"c22f27ce214955401ce4a4e5a123fbf5cbbd19e0"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"af086a1c69100cc1c81a88afc80223deaa2375da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b6590d83_0af58716","updated":"2024-01-11 12:53:00.000000000","message":"thanks for adding a release note","commit_id":"bd930931dacf4d7a3cb954ed769927eb332af0ec"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c44716b8_fc35a920","updated":"2024-01-11 13:17:30.000000000","message":"| why to not use service-cert-copy ?\nMy mistake, due to internal patching on a different project. I have reverted so we can use the service-cert-copy and adjusted the manila-api template accordingly","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"bb0f1fbaabaf7dc2bbc4fa808a36a9f11465c993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20cf2ff4_42f4e757","updated":"2024-01-11 13:38:03.000000000","message":"\u003e why manila_services ?\nIt was based on my previous config setup. Removed","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c00f221ef790ec74b1893599590162cde4872a7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"96236988_1745636e","updated":"2024-01-11 13:44:32.000000000","message":"Thanks, better","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e06bc57a7898a1530483dc2ceac2bfd7ddd86e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c812e314_87cc9ed7","updated":"2024-01-15 07:56:16.000000000","message":"\u003emanila_enable_tls_backend ?\nThis is set in ansible/roles/manila/defaults/main.yml similar to other services and depends on kolla_enable_tls_backend. It is now explained in the release notes upgrade section","commit_id":"369cd0a364c348f6a53d0e1420a52884fcc0be5b"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"3a51cd09ac5f88274ac416c03486bd443675af46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"63ac336a_b1e36156","in_reply_to":"152e2374_1291b63e","updated":"2024-01-15 10:26:57.000000000","message":"Done","commit_id":"369cd0a364c348f6a53d0e1420a52884fcc0be5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cd843d38fdfe17c3e84cd467223c4b901d35eb63","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"152e2374_1291b63e","in_reply_to":"c812e314_87cc9ed7","updated":"2024-01-15 10:12:31.000000000","message":"I guess this comment was meant to go under https://review.opendev.org/c/openstack/kolla-ansible/+/905010/comment/09623d28_6bd2266a/\n\nthis should imho still depend on manila_enable_tls_backend and not on kolla_enable_tls_backend, to be consistent with the rest of the changes.","commit_id":"369cd0a364c348f6a53d0e1420a52884fcc0be5b"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"879b76490b77ae0b5ec2ecbc2af775ea54d08972","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bf0f61e7_b3aedb1a","updated":"2024-02-19 07:00:56.000000000","message":"I am not setting osapi_share_use_ssl value automatically to allow the user the choice of using TLS for the service manually. If you thing that is not necessary, I will update it","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3e6f719a9ca03aeb91943e7c503c0a270aaf48bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e2f49fd3_6c320035","updated":"2024-02-15 07:15:11.000000000","message":"Why are you not setting osapi_share_use_ssl automatically based on the value of manila_enable_tls_backend? Is there a technical reason preventing it?","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"3a51cd09ac5f88274ac416c03486bd443675af46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"179226ad_9f6ad722","updated":"2024-01-15 10:26:57.000000000","message":"Yes, this was missed by mistake. Fixed now","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"55e5759ec8327f29985bd022a4ce39bc3e96db60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f26ad02a_f247a70e","in_reply_to":"102bb8cd_81ec3aa0","updated":"2024-03-07 09:18:01.000000000","message":"Done","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7fe86dd6144a43c64e169677332ecc0cf529a210","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"102bb8cd_81ec3aa0","in_reply_to":"7d8a9e9c_fb0520f9","updated":"2024-02-19 15:55:32.000000000","message":"+1 on configuring TLS completely if there are no drawbacks to it - I\u0027m not aware of any.","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4d5d71b56718c563ac9d5b19ef091b91f3e457a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7d8a9e9c_fb0520f9","in_reply_to":"bf0f61e7_b3aedb1a","updated":"2024-02-19 08:42:49.000000000","message":"As far as I know, for other services TLS gets fully configured when the TLS enable flag is toggled.","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"55e5759ec8327f29985bd022a4ce39bc3e96db60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a2d22cd0_34b8c2c1","in_reply_to":"e2f49fd3_6c320035","updated":"2024-03-07 09:18:01.000000000","message":"Done","commit_id":"2e9b0b008a9fa08685b7ad70b4c31d058b63cc8d"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e5280d40d217f855a76192c6b55387585f0eb2d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"39a80919_869d512a","updated":"2024-03-07 09:16:17.000000000","message":"osapi_share_use_ssl is now set based on manila_enable_tls_backend in the manila.conf","commit_id":"955e5f50f7314389e566e34386ea4ee8a8886058"}],"ansible/roles/manila/tasks/config.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"51d869c2c894842c50d88329c7831418c48928a0","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":42,"context_line":"    - item.value.enabled | bool"},{"line_number":43,"context_line":"    - manila_enable_tls_backend | bool"},{"line_number":44,"context_line":"  with_dict: \"{{ manila_services }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Copying over config.json files for services"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5677e85a_48858bb1","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":38},"updated":"2024-01-11 12:47:42.000000000","message":"kolla_copy_ca_into_containers | bool or manila_enable_tls_backend | bool","commit_id":"c22f27ce214955401ce4a4e5a123fbf5cbbd19e0"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":42,"context_line":"    - item.value.enabled | bool"},{"line_number":43,"context_line":"    - manila_enable_tls_backend | bool"},{"line_number":44,"context_line":"  with_dict: \"{{ manila_services }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Copying over config.json files for services"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"32a5b1b7_525dea93","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":38},"in_reply_to":"5677e85a_48858bb1","updated":"2024-01-11 13:17:30.000000000","message":"Done","commit_id":"c22f27ce214955401ce4a4e5a123fbf5cbbd19e0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7b8435af3ef06742bea97da279e4454bbcce9e83","unresolved":true,"context_lines":[{"line_number":39,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - kolla_copy_ca_into_containers | bool or manila_enable_tls_backend | bool"},{"line_number":42,"context_line":"  with_dict: \"{{ manila_services }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Copying over config.json files for services"},{"line_number":45,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9cdfc53f_1210c1d4","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"updated":"2024-01-11 13:30:29.000000000","message":"why manila_services ? role service-cert-copy already handling this ...","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"bb0f1fbaabaf7dc2bbc4fa808a36a9f11465c993","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":40,"context_line":"  when:"},{"line_number":41,"context_line":"    - kolla_copy_ca_into_containers | bool or manila_enable_tls_backend | bool"},{"line_number":42,"context_line":"  with_dict: \"{{ manila_services }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Copying over config.json files for services"},{"line_number":45,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5501b88d_11d104b5","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":36},"in_reply_to":"9cdfc53f_1210c1d4","updated":"2024-01-11 13:38:03.000000000","message":"\u003e why manila_services ? role service-cert-copy already handling this ...","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"}],"ansible/roles/manila/tasks/copy-certs.yml":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"51d869c2c894842c50d88329c7831418c48928a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"640af260_786c17eb","line":39,"range":{"start_line":2,"start_character":0,"end_line":39,"end_character":0},"updated":"2024-01-11 12:47:42.000000000","message":"why to not use service-cert-copy ?","commit_id":"c22f27ce214955401ce4a4e5a123fbf5cbbd19e0"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"205e8611_4cc6cba9","line":39,"range":{"start_line":2,"start_character":0,"end_line":39,"end_character":0},"in_reply_to":"640af260_786c17eb","updated":"2024-01-11 13:17:30.000000000","message":"\u003e why to not use service-cert-copy ?","commit_id":"c22f27ce214955401ce4a4e5a123fbf5cbbd19e0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7b8435af3ef06742bea97da279e4454bbcce9e83","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: \"Copy certificates and keys for {{ project_name }}\""},{"line_number":2,"context_line":"  import_role:"},{"line_number":3,"context_line":"    role: service-cert-copy"},{"line_number":4,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e9593620_9af747d3","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":59},"updated":"2024-01-11 13:30:29.000000000","message":"removed \u0027---\u0027","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"bb0f1fbaabaf7dc2bbc4fa808a36a9f11465c993","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: \"Copy certificates and keys for {{ project_name }}\""},{"line_number":2,"context_line":"  import_role:"},{"line_number":3,"context_line":"    role: service-cert-copy"},{"line_number":4,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d3951042_b177cb04","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":59},"in_reply_to":"e9593620_9af747d3","updated":"2024-01-11 13:38:03.000000000","message":"Done","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"}],"ansible/roles/manila/templates/manila-api.json.j2":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7b8435af3ef06742bea97da279e4454bbcce9e83","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","},{"line_number":13,"context_line":"            \"owner\": \"manila\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"cd4ad88e_6c6cb6a4","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":99},"updated":"2024-01-11 13:30:29.000000000","message":"what ? \n\nDid you mean {{ container_config_directory }}/manila-cert.pem","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"bb0f1fbaabaf7dc2bbc4fa808a36a9f11465c993","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","},{"line_number":13,"context_line":"            \"owner\": \"manila\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0ad3cd6d_293875a9","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":99},"in_reply_to":"cd4ad88e_6c6cb6a4","updated":"2024-01-11 13:38:03.000000000","message":"Acknowledged","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7b8435af3ef06742bea97da279e4454bbcce9e83","unresolved":true,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/manila/manila-key.pem\","},{"line_number":19,"context_line":"            \"owner\": \"manila\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1472d0f8_2b9c2314","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":105},"updated":"2024-01-11 13:30:29.000000000","message":"ditto","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"bb0f1fbaabaf7dc2bbc4fa808a36a9f11465c993","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ kolla_certificates_dir }}/{{ inventory_hostname }}/{{ project_name }}-key.pem\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/manila/manila-key.pem\","},{"line_number":19,"context_line":"            \"owner\": \"manila\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"81e76d88_abc07c3a","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":105},"in_reply_to":"1472d0f8_2b9c2314","updated":"2024-01-11 13:38:03.000000000","message":"Done","commit_id":"6e496180d6efedc9df673a601b418c8de77be118"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"feb3535c84b0f0ac4d61dd7c8796550fc5ca70de","unresolved":true,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","},{"line_number":13,"context_line":"            \"owner\": \"manila\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"d8afd809_a0aa8a68","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":74},"updated":"2024-01-11 13:40:07.000000000","message":"{{ project_name }} \u003d\u003e manila","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c00f221ef790ec74b1893599590162cde4872a7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","},{"line_number":13,"context_line":"            \"owner\": \"manila\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1b8ff6d4_c8687a2b","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":74},"in_reply_to":"d8afd809_a0aa8a68","updated":"2024-01-11 13:44:32.000000000","message":"Done","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e06bc57a7898a1530483dc2ceac2bfd7ddd86e9a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","},{"line_number":13,"context_line":"            \"owner\": \"manila\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"328c7768_0768bab1","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":74},"in_reply_to":"d8afd809_a0aa8a68","updated":"2024-01-15 07:56:16.000000000","message":"Done","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"feb3535c84b0f0ac4d61dd7c8796550fc5ca70de","unresolved":true,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-key.pem\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/manila/manila-key.pem\","},{"line_number":19,"context_line":"            \"owner\": \"manila\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"2465a3a9_efec995b","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":74},"updated":"2024-01-11 13:40:07.000000000","message":"{{ project_name }} \u003d\u003e manila","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e06bc57a7898a1530483dc2ceac2bfd7ddd86e9a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-key.pem\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/manila/manila-key.pem\","},{"line_number":19,"context_line":"            \"owner\": \"manila\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1238425b_9ecf82d1","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":74},"in_reply_to":"2465a3a9_efec995b","updated":"2024-01-15 07:56:16.000000000","message":"Done","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c00f221ef790ec74b1893599590162cde4872a7a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/{{ project_name }}-key.pem\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/manila/manila-key.pem\","},{"line_number":19,"context_line":"            \"owner\": \"manila\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"b363d16e_378bf93a","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":74},"in_reply_to":"2465a3a9_efec995b","updated":"2024-01-11 13:44:32.000000000","message":"Done","commit_id":"abef88382efa38abd59bff05ed39e457bc62d3e5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"92236ed44a1f0e24ba5bbe1fcbaa5176da1df3db","unresolved":true,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/manila/manila.conf\","},{"line_number":7,"context_line":"            \"owner\": \"manila\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/manila-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"09623d28_6bd2266a","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"updated":"2024-01-12 15:24:54.000000000","message":"manila_enable_tls_backend ?","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e06bc57a7898a1530483dc2ceac2bfd7ddd86e9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/manila/manila.conf\","},{"line_number":7,"context_line":"            \"owner\": \"manila\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/manila-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"c0716827_4c95f213","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"in_reply_to":"09623d28_6bd2266a","updated":"2024-01-15 07:56:16.000000000","message":"\u003e manila_enable_tls_backend ?","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d69c590bc56680d1549bcd03aee02d875384cb46","unresolved":true,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/manila/manila.conf\","},{"line_number":7,"context_line":"            \"owner\": \"manila\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/manila-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"dda810b8_c6fd4ceb","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"in_reply_to":"c0716827_4c95f213","updated":"2024-01-15 10:09:46.000000000","message":"this still says \"kolla_enable_tls_backend\" instead of \"manila_enable_tls_backend\".\n\ndid you just miss this by accident?","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"3a51cd09ac5f88274ac416c03486bd443675af46","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/manila/manila.conf\","},{"line_number":7,"context_line":"            \"owner\": \"manila\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if kolla_enable_tls_backend %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/manila-cert.pem\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/manila/manila-cert.pem\","}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"60c69c44_b2f5eb76","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":39},"in_reply_to":"dda810b8_c6fd4ceb","updated":"2024-01-15 10:26:57.000000000","message":"Done","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"}],"releasenotes/notes/add-manila-tls-support-f6355a9a26d4fdd4.yaml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"af086a1c69100cc1c81a88afc80223deaa2375da","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"},{"line_number":6,"context_line":"    and copies SSL certificates based on the value of "},{"line_number":7,"context_line":"    \"kolla_enable_tls_backend\" configuration parameter."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"79e7f7c1_c4df8432","line":6,"range":{"start_line":6,"start_character":53,"end_line":6,"end_character":54},"updated":"2024-01-11 12:53:00.000000000","message":"nit: space at end of line","commit_id":"bd930931dacf4d7a3cb954ed769927eb332af0ec"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"},{"line_number":6,"context_line":"    and copies SSL certificates based on the value of "},{"line_number":7,"context_line":"    \"kolla_enable_tls_backend\" configuration parameter."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d08151c5_b95717c7","line":6,"range":{"start_line":6,"start_character":53,"end_line":6,"end_character":54},"in_reply_to":"79e7f7c1_c4df8432","updated":"2024-01-11 13:17:30.000000000","message":"Done","commit_id":"bd930931dacf4d7a3cb954ed769927eb332af0ec"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"af086a1c69100cc1c81a88afc80223deaa2375da","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"},{"line_number":6,"context_line":"    and copies SSL certificates based on the value of "},{"line_number":7,"context_line":"    \"kolla_enable_tls_backend\" configuration parameter."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8bf01390_928c3f68","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":30},"updated":"2024-01-11 12:53:00.000000000","message":"write this using double single backticks:\n\n\\`\\`kolla_enable_tls_backend\\`\\`","commit_id":"bd930931dacf4d7a3cb954ed769927eb332af0ec"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e66a504992befc5884260c931dbc840fb94494ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"},{"line_number":6,"context_line":"    and copies SSL certificates based on the value of "},{"line_number":7,"context_line":"    \"kolla_enable_tls_backend\" configuration parameter."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8fef18a8_a0e7b3a2","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":30},"in_reply_to":"8bf01390_928c3f68","updated":"2024-01-11 13:17:30.000000000","message":"Done","commit_id":"bd930931dacf4d7a3cb954ed769927eb332af0ec"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"92236ed44a1f0e24ba5bbe1fcbaa5176da1df3db","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"01612bbd_9263c3c9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-01-12 15:24:54.000000000","message":"you may want to add this information to the \"upgrades:\" section, as I\u0027m not sure what a user of manila would expect here.\n\nat least the behaviour changes on upgrades, because the manila backend is now TLS encrypted, when \"kolla_enable_tls_backend\" was set before.\n\nI don\u0027t know if this can cause trouble for users using the non encrypted channel.","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":36626,"name":"Darin Chakalov","display_name":"Darin Chakalov","email":"dchakalov@godaddy.com","username":"dchakalov"},"change_message_id":"e06bc57a7898a1530483dc2ceac2bfd7ddd86e9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds Manila TLS support."},{"line_number":5,"context_line":"    Allows to enable TLS encryption for the Manila service"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ea663438_b9debbf7","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"01612bbd_9263c3c9","updated":"2024-01-15 07:56:16.000000000","message":"Done","commit_id":"5a0357fd668e857cb16e9bd02d9a6b61db6ba3aa"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fad83a4453bf78a9a958bc9b790fbef6305395d6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    ``kolla_enable_tls_backend`` configuration parameter."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Manila TLS support is disabled by default."},{"line_number":11,"context_line":"    To enable TLS encryption support for the Manila service,"},{"line_number":12,"context_line":"    set ``manila_enable_tls_backend`` to ``yes`` in ``globals.yml``."},{"line_number":13,"context_line":"    This will copy SSL certificates to the Manila containers, but"},{"line_number":14,"context_line":"    the service will still be configured to use plain HTTP unless"},{"line_number":15,"context_line":"    osapi_share_use_ssl is set to True in manila.conf."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f29cc84a_f75e4ffd","line":15,"range":{"start_line":10,"start_character":0,"end_line":15,"end_character":54},"updated":"2024-03-07 16:42:07.000000000","message":"please update this to reflect the changes from the latest patch (osapi_share_use_ssl being set to true by default).\n\nalso this should imho mention to enable `kolla_enable_tls_backend` as an easier way to enable encryption not just for manila.","commit_id":"955e5f50f7314389e566e34386ea4ee8a8886058"}]}