)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d3495dafe08862adc41e7c42f90c12b72303a33c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 12:00:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable instace usage audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch disables periodic compute.instance.exists"},{"line_number":10,"context_line":"notifications as this is definitely not needed for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ef9aa6af_f6e821ab","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"updated":"2024-01-17 11:30:51.000000000","message":"nit: instance","commit_id":"4ab952cbb6a71ebcc467f2baf398b1b8118c6a57"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3eb58d2b208aaa92843fc5052a323d859b459a6c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-17 12:00:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable instace usage audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch disables periodic compute.instance.exists"},{"line_number":10,"context_line":"notifications as this is definitely not needed for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"34b1b245_13a1bcdb","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"ef9aa6af_f6e821ab","updated":"2024-01-17 11:35:25.000000000","message":"Done","commit_id":"4ab952cbb6a71ebcc467f2baf398b1b8118c6a57"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d3495dafe08862adc41e7c42f90c12b72303a33c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable instace usage audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch disables periodic compute.instance.exists"},{"line_number":10,"context_line":"notifications as this is definitely not needed for"},{"line_number":11,"context_line":"designate."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I39fe2db9182de23c1df814d911eec15e86317702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ada0ef5c_9dd30ee1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":13},"updated":"2024-01-17 11:30:51.000000000","message":"nit: if designate is enabled","commit_id":"4ab952cbb6a71ebcc467f2baf398b1b8118c6a57"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3eb58d2b208aaa92843fc5052a323d859b459a6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable instace usage audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch disables periodic compute.instance.exists"},{"line_number":10,"context_line":"notifications as this is definitely not needed for"},{"line_number":11,"context_line":"designate."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I39fe2db9182de23c1df814d911eec15e86317702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b7c59ac8_59629c77","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":13},"in_reply_to":"ada0ef5c_9dd30ee1","updated":"2024-01-17 11:35:25.000000000","message":"Done","commit_id":"4ab952cbb6a71ebcc467f2baf398b1b8118c6a57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92a5b9fd75a217f41f8543bb5da0a55462b8006f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f31e7216_c8128153","updated":"2024-01-16 16:18:45.000000000","message":"so where does this actually stop running the designate-sink container?","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bd9282bed20d70e4aeb8eae49407dc55ef4e27e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"148b99d8_a4fc22d6","in_reply_to":"0d07b6d8_c641c70e","updated":"2024-01-17 08:25:32.000000000","message":"Btw, do you agree that DNS can be configured as below ? \n\n\n\nNeutron DNS\n\n1. The Networking service internal DNS resolution\n   a) To enable:\n   - Change default dns_domain \u0027openstacklocal\u0027 to something different (used for host fqdn generation, sits in dnsmasq)\n   - Use neutron extension driver [dns, dns_domain_ports]\n   b) To disable:\n   - Leave dns_domain in default - \u0027openstacklocal\u0027\n   - Don\u0027t add neutron externsion [dns, dns_domain_ports]\n   c) Tests:\n   - Cover scenarios specified in https://docs.openstack.org/neutron/latest/admin/config-dns-int.html\n\n 2. Networking service integration with an external DNS service is enabled\n   a) To enable:\n   - Repeat 1a) + set external_dns_driver \u003d designate\n   - Add designate config snippet to neutron.conf\n   b) To disable:\n   - Remove external_dns_driver \u003d designate\n   - set neutron extenstion to [dns, dns_domain_ports] IF neutron DNS integration turned ON\n   - Repeat 1a) IF no DNS neutron integration turned on\n\n 3. Only designate turned on without integration","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9b3e10cff68ff7d668179a781baeb18ee733007","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc1d24ba_cd360cfa","in_reply_to":"148b99d8_a4fc22d6","updated":"2024-01-17 09:37:19.000000000","message":"let\u0027s rather discuss this in a review, where one can better comment on individual items. I\u0027m not sure that all these variants are needed, neutron internal DNS resolution happens whether external dns is enabled or not\n\nnote also that only a single neutron dns extension may be enabled at a time, wild errors happen if you enable multiple ones. they are all ordered by an increasing set of features, so dns_domain_ports includes dns, subnet_dns_publish_fixed_ip includes both of them, etc. pp.\n\nI\u0027d suggest to stick with subnet_dns_publish_fixed_ip which is the current default","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ba91b2aa33fae5de5f65d258adb4d7fd32c56c4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83164364_4ad37caa","in_reply_to":"15c00527_22690039","updated":"2024-01-16 17:45:24.000000000","message":"Or, better said check the patch in this relation chain where designate-sink is turned off.","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"320e521fe24d47881a028a5a0d72518ba2594484","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5981fe0_b82bdcea","in_reply_to":"83164364_4ad37caa","updated":"2024-01-17 06:47:56.000000000","message":"Ah, I see, so essentially designate_enable_notifications_sink already is the vsriable that has the same function as enable_designate_sink, it is just weirdly named. So IMO it makes no sense to create yet another variable here.\n\nDeployers can just set \"designate_enable_notifications_sink: no\" and the designate-sink service will be disabled. Adding this to the documentation if needed will be good enough.","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bae06d3f7cb82b7cb5c50fa7e396c229d24cf1f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"537cc1e9_5714f877","in_reply_to":"bc1d24ba_cd360cfa","updated":"2024-01-17 11:48:07.000000000","message":"let\u0027s rather discuss this in a review, where one can better comment on individual items. I\u0027m not sure that all these variants are needed, neutron internal DNS resolution happens whether external dns is enabled or not\n\nIf you meant external DNS as designate with integration - you are right \n\nBUT\n\nYou can have also situation that you didn\u0027t enable internal DNS integration, didn\u0027t enable external DNS integration and you are using designate only as DNS - that means you can add,update,delete the records in designate but without integration.\n\nWhat is true, neutron is always writing entries for hosts into dnsmasq so you are partial right ... BUT if you didn\u0027t change openstacklocal to something non-default ..it generates host-ip-ip-ip-ip.openstacklocal entries which is actually not internal DNS \n\nBut let\u0027s discuss everything in patch for neutron in this relation chain.","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"78bf6b1340c08bbfdc73ff49ac32a0aec9c08681","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d07b6d8_c641c70e","in_reply_to":"c5981fe0_b82bdcea","updated":"2024-01-17 08:04:44.000000000","message":"Hmm, okay, agree. I will change the commit message and turn off audit notification as this is needed only for ceilometer, not for designate, do you agree ?","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"799b0655a3f93f1b4c916cbdfcf714139b2c8339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15c00527_22690039","in_reply_to":"f31e7216_c8128153","updated":"2024-01-16 17:41:43.000000000","message":"designate-sink:\n    container_name: designate_sink\n    group: designate-sink\n    enabled: \"{{ designate_enable_notifications_sink | bool }}\"\n    image: \"{{ designate_sink_image_full }}\"\n    volumes: \"{{ designate_sink_default_volumes + designate_sink_extra_volumes }}\"\n    dimensions: \"{{ designate_sink_dimensions }}\"\n    healthcheck: \"{{ designate_sink_healthcheck }}\"\n\n\nIn this review variable below is changed : \n\n- designate_enable_notifications_sink: \"{{ enable_designate | bool }}\"\n+ designate_enable_notifications_sink: \"{{ enable_designate_sink | bool }}\"\n\nSo ^^ here.","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a72ef872c9622f1c5b5be447b124b1c19be80879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6ac2b752_59050408","updated":"2024-01-20 23:17:58.000000000","message":"can we link the bugreport and backport this to all stable versions?","commit_id":"51f4583c4d215f4e592512f8f3e352fd70a79ef5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"527d7ac6fd45dd6ef4e5aa4f5b7e3ffcbbdd7190","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbcaa75e_2eef7ee6","in_reply_to":"6ac2b752_59050408","updated":"2024-01-21 10:57:59.000000000","message":"Yes, probably Related-Bug ? ..","commit_id":"51f4583c4d215f4e592512f8f3e352fd70a79ef5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"34ebf1b23f8eca99226108ce62870ed27f0b9018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70158053_f2e7b92a","updated":"2024-01-21 14:41:01.000000000","message":"Nah, something really bad was meged somehwere :D all failing now :(","commit_id":"c8a0e930610257b08ad6e0cac8d24a14e9721dad"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"55d2f7df96690a8f98548660a2ff3888833af351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"06fcc95a_8da30dbc","in_reply_to":"70158053_f2e7b92a","updated":"2024-01-21 17:25:11.000000000","message":"horizon image is broken :(","commit_id":"c8a0e930610257b08ad6e0cac8d24a14e9721dad"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"431ea02776a901f4ec17199d40a12305ddfd1aed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eac6b8a8_ed3c83ca","updated":"2024-01-21 21:09:14.000000000","message":"recheck different constraints","commit_id":"e029e63b6049857962d3748b368fdd04e49992e1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"669413e04b5f8385e5865e0e45de2aeccecd3480","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"365b63b8_6b2b4d4b","updated":"2024-01-24 14:14:55.000000000","message":"still need the bugreport","commit_id":"58983a77108ef71bde140c3ce9a7b9d2ae8cea17"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd5651a8f2b53df70e25e548b5d6a8451ab4afcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bc53f15f_35812110","in_reply_to":"1b408c6b_a0a81c61","updated":"2024-01-24 22:25:49.000000000","message":"thanks, now we can backport it","commit_id":"58983a77108ef71bde140c3ce9a7b9d2ae8cea17"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a85aaf5e9de3bd8e513debc7c70d9cc30a1b7b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1b408c6b_a0a81c61","in_reply_to":"365b63b8_6b2b4d4b","updated":"2024-01-24 20:58:30.000000000","message":"Done","commit_id":"58983a77108ef71bde140c3ce9a7b9d2ae8cea17"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2ec614d31e755d464f25940df90766d93ab8f405","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"535b2f7e_7a20e02a","updated":"2024-01-25 06:14:30.000000000","message":"Not sure about backporting without a reno, does it make sense to backport only this patch without the one on top of it?\n\nBut the patch itself is still fine.","commit_id":"82ccb521aca1e758dbfddc98a7028522e6b13f83"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a8a9dd17f9cb7b305b631687fc0a874ff53417cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5f22fa52_0fae9e6b","in_reply_to":"535b2f7e_7a20e02a","updated":"2024-01-25 07:40:57.000000000","message":"Well, this is not breaking anything for user who enabled ceilometer as he really need and use audit data from rabbit. For user who enabled designate it will just disable audit data, so less data sent into rabbitmq. \n\nWell, admit it yourself, a user who has thousands of instances and nova sends notifications for each of them, it can be quite a lot - what\u0027s worse, they are completely useless and require unnecessary rabbit resources.\n\nIf I will backport this patch to my downstream repos ? - Of course !","commit_id":"82ccb521aca1e758dbfddc98a7028522e6b13f83"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b7bee791cebdee8e2226998a7a346b1331187728","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"eaaa742f_134a9243","in_reply_to":"5f22fa52_0fae9e6b","updated":"2024-01-25 08:41:57.000000000","message":"Michal, please just add a reno with \"Fixed bla..bla..bla...\"","commit_id":"82ccb521aca1e758dbfddc98a7028522e6b13f83"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4b5c569575c26574659ccb3b091b31bff32204ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7613a925_b32f4657","in_reply_to":"c697f67b_9f46c139","updated":"2024-01-25 13:56:11.000000000","message":"Done","commit_id":"82ccb521aca1e758dbfddc98a7028522e6b13f83"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"55dc03dd7bfec0dd6c3e727b11f38ee6ea01107e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c697f67b_9f46c139","in_reply_to":"eaaa742f_134a9243","updated":"2024-01-25 09:01:50.000000000","message":"How I hate it :D ..okay","commit_id":"82ccb521aca1e758dbfddc98a7028522e6b13f83"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"17b0f4c8e1b2bf8de08a3274c048d8d99117226a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ee067cfb_2bb7f3df","updated":"2024-01-25 16:17:37.000000000","message":"recheck again unrelated rocky podman while ubuntu podman is ok","commit_id":"9031dcad1e1a7f2df3f165ee22bde7e8ab854259"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"79a781145cc7851c09ca86c594c481c0c96a3563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"135b461c_0ab5bc70","updated":"2024-01-25 13:55:52.000000000","message":"recheck non-related errors","commit_id":"9031dcad1e1a7f2df3f165ee22bde7e8ab854259"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92f006e9c68f1d8def28ff4b10b2abdef74d8dff","unresolved":true,"context_lines":[{"line_number":1129,"context_line":"designate_internal_endpoint: \"{{ designate_internal_fqdn | kolla_url(internal_protocol, designate_api_port) }}\""},{"line_number":1130,"context_line":"designate_public_endpoint: \"{{ designate_external_fqdn | kolla_url(public_protocol, designate_api_public_port) }}\""},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"designate_enable_notifications_sink: \"{{ enable_designate_sink | bool }}\""},{"line_number":1133,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b521afa4_870c4f6f","line":1132,"updated":"2024-01-17 06:52:06.000000000","message":"Actually given that most deployments won\u0027t need this, setting the default to \"no\" might be a good idea.","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bae06d3f7cb82b7cb5c50fa7e396c229d24cf1f4","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"designate_internal_endpoint: \"{{ designate_internal_fqdn | kolla_url(internal_protocol, designate_api_port) }}\""},{"line_number":1130,"context_line":"designate_public_endpoint: \"{{ designate_external_fqdn | kolla_url(public_protocol, designate_api_public_port) }}\""},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"designate_enable_notifications_sink: \"{{ enable_designate_sink | bool }}\""},{"line_number":1133,"context_line":"designate_notifications_topic_name: \"notifications_designate\""},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8f962234_ffe2a4fc","line":1132,"in_reply_to":"b521afa4_870c4f6f","updated":"2024-01-17 11:48:07.000000000","message":"Done","commit_id":"92fb5f0a34a69262b65d204923f149e7386cc99c"}],"ansible/roles/nova-cell/templates/nova.conf.j2":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"addd7fc9293aa152cfc46cdb24abc5464ef4951a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":27,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if enable_ceilometer | bool %}"},{"line_number":30,"context_line":"instance_usage_audit \u003d True"},{"line_number":31,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":32,"context_line":"{% if enable_watcher | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"91e7b9a2_33ca5ad1","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":25},"updated":"2024-01-30 11:41:44.000000000","message":"should it be also on when designate_enable_notifications_sink is enabled?","commit_id":"66c4f72c509e3746f090d8b48888a9c42d37705b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4014c1cf995f6d8529080f9db065662398a58b51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":27,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if enable_ceilometer | bool %}"},{"line_number":30,"context_line":"instance_usage_audit \u003d True"},{"line_number":31,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":32,"context_line":"{% if enable_watcher | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"4f6fb734_9c778763","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":25},"in_reply_to":"91e7b9a2_33ca5ad1","updated":"2024-01-30 11:47:11.000000000","message":"No, https://github.com/openstack/nova/blob/a66a0dd113d0b57acf9f69d76785be39479eebc0/nova/conf/compute.py#L620-L626 . If turned on - you periodically sends audit_usage for instance existence ... which is consumed by ceilometer but not needed for designate.\n\nDesignate needs know where instance was created and destroyed. I\u0027ve also locally tested ...","commit_id":"66c4f72c509e3746f090d8b48888a9c42d37705b"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2321dc7b1d94c69b2525c026dd8a7ccee00886f1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":17,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if enable_ceilometer | bool or enable_designate_sink | bool %}"},{"line_number":20,"context_line":"instance_usage_audit \u003d True"},{"line_number":21,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"cc1def51_da0ef2b3","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":55},"updated":"2024-01-15 10:02:55.000000000","message":"are you sure this should only be enabled for the sink?\n\nIt\u0027s not clear to me from the initial implementation in a9ade20beebfef0709949ce383ff7a59b360549c tbh.","commit_id":"cf9f7d8d6cb03b20ba6c94e3e35346264db71698"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"854bbc9d1cc128d34ca99d9f85be4d19303ea965","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":17,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if enable_ceilometer | bool or enable_designate_sink | bool %}"},{"line_number":20,"context_line":"instance_usage_audit \u003d True"},{"line_number":21,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"28d13fe8_c5255195","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":55},"in_reply_to":"94aa808f_9c585f51","updated":"2024-01-16 07:56:08.000000000","message":"Check https://review.opendev.org/c/openstack/kolla-ansible/+/905644/1?usp\u003drelated-change where sink is turned off and test removed sink usage... And it\u0027s working...","commit_id":"cf9f7d8d6cb03b20ba6c94e3e35346264db71698"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bc859f2ee9956253597583c1cdf09765dc419812","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":17,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% if enable_ceilometer | bool or enable_designate_sink | bool %}"},{"line_number":20,"context_line":"instance_usage_audit \u003d True"},{"line_number":21,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"94aa808f_9c585f51","line":19,"range":{"start_line":19,"start_character":34,"end_line":19,"end_character":55},"in_reply_to":"cc1def51_da0ef2b3","updated":"2024-01-15 17:32:09.000000000","message":"Well, you are right, this is not needed for designate nor designate-sink, i will remove it. \n\nUsage audits are for telemetry service ..","commit_id":"cf9f7d8d6cb03b20ba6c94e3e35346264db71698"}]}