)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b923b6157543eb3f755b71f68338e4076343a4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffd16664_edecb551","updated":"2024-01-16 17:44:14.000000000","message":"This test is only demonstration that sink is not needed, of course tests need to be reworked to test more situations... \n\nBut this test proves that the designate-sink is not necessary","commit_id":"f753ec0162a0ff1a78bd505eb7a7d072d2a01b26"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0b2891f81b7769fc0c668bbb27c60ce59c42daec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"953196df_4a0c78ed","in_reply_to":"ffd16664_edecb551","updated":"2024-01-17 06:58:48.000000000","message":"I wouldn\u0027t have doubted that, but I agree that testing some more relevant scenarios instead of designate-sink is a good idea","commit_id":"f753ec0162a0ff1a78bd505eb7a7d072d2a01b26"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83fb4529c3169bad8cf72de4e48b269630b36670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"7dcb386a_f1af2a4b","updated":"2024-01-25 06:32:43.000000000","message":"didn\u0027t check in detail yet because this small typo is causing the magnum test to fail halfway through","commit_id":"2c218511403cbd2814a665782e336aad1e7c9ec4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4df22e3ba07ab61b0e4414a9dbb407aef4f35e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"f095217a_c8234ef1","updated":"2024-01-25 13:25:16.000000000","message":"Done, everything passing, ready for review","commit_id":"1a29ae9dcf7d556eebb27b2bc12817812d128636"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"09deabb371ed7df5c7c13d3b8059453cca0e9813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"59ee44f9_9cc2e6ea","updated":"2024-01-25 13:26:34.000000000","message":"octavia triggered (only internal DNS enabled) in https://review.opendev.org/c/openstack/kolla-ansible/+/906099","commit_id":"1a29ae9dcf7d556eebb27b2bc12817812d128636"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"844582754d823ad0b12af1b9324a5ba0e78fa8cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"c0e651bc_42a5bba5","updated":"2024-01-30 15:09:07.000000000","message":"I\u0027m wondering if we need to spawn another VM to make test even longer. Can we add internal dns functions and test them while spawning regular vm?","commit_id":"f0b7bf33abb6faff506599c99863b823ca108ef5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d7079eedc6c7f22b2ec1ba9a743346ef42d99f92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"c1d5643c_d614dcc0","in_reply_to":"c0e651bc_42a5bba5","updated":"2024-01-30 15:13:49.000000000","message":"It\u0027s already tested in octavia scenario - as you can see there is check that dns_assignment (FQDN) and hostaname are properly set after server is created. This values are then rendered in DNSmasq. So from my perspetive of view it\u0027s useless.\n\nBUT if you want, I can do it in followup.","commit_id":"f0b7bf33abb6faff506599c99863b823ca108ef5"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"748048b83ad6c9b61ad04f8fc5fd8917f9826989","unresolved":true,"context_lines":[{"line_number":212,"context_line":"{% endif %}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"{% if scenario \u003d\u003d \"octavia\" %}"},{"line_number":215,"context_line":"neutron_dns_integration: \"yes\""},{"line_number":216,"context_line":"neutron_dns_domain: \"example.org.\""},{"line_number":217,"context_line":"enable_octavia: \"yes\""},{"line_number":218,"context_line":"# NOTE(wuchunyang): work around for qemu-kvm 5.1 can not attach second NIC."}],"source_content_type":"text/x-jinja2","patch_set":47,"id":"1911f6c2_834fcf4c","line":215,"updated":"2024-01-30 14:07:08.000000000","message":"so do we need another scenario that tests this plus enable_designate?","commit_id":"f0b7bf33abb6faff506599c99863b823ca108ef5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"191500d79dde6fc4493e229e57cc59c3fece2a07","unresolved":false,"context_lines":[{"line_number":212,"context_line":"{% endif %}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"{% if scenario \u003d\u003d \"octavia\" %}"},{"line_number":215,"context_line":"neutron_dns_integration: \"yes\""},{"line_number":216,"context_line":"neutron_dns_domain: \"example.org.\""},{"line_number":217,"context_line":"enable_octavia: \"yes\""},{"line_number":218,"context_line":"# NOTE(wuchunyang): work around for qemu-kvm 5.1 can not attach second NIC."}],"source_content_type":"text/x-jinja2","patch_set":47,"id":"7007fe21_23b56593","line":215,"in_reply_to":"1911f6c2_834fcf4c","updated":"2024-01-30 14:14:50.000000000","message":"No, here is summary : \n\n1. Core scenario - no DNS integration\n2. Magnum scenario - DNS integration with external DNS service aka Designate (external-dns-integration)\n3. Octavia DNS internal integration","commit_id":"f0b7bf33abb6faff506599c99863b823ca108ef5"}],"tests/test-core-openstack.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2f67ed63f30583fef460a3bdd515a414ca6d89ab","unresolved":true,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"function test_internal_dns_integration {"},{"line_number":412,"context_line":"    DNS_NAME\u003d\"my-port\""},{"line_number":413,"context_line":"    DNS_DOMAIN\u003d$(grep \u0027neutron_dns_domain:\u0027 /etc/kolla/globals.yml \\"},{"line_number":414,"context_line":"                        | awk -F \u0027:\u0027 \u0027{print $2}\u0027 \\"},{"line_number":415,"context_line":"                        | sed -e \u0027s/\"//g\u0027 -e \"s/\u0027//g\" -e \"s/\\ *//g\")"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    openstack network create dns-test-network"},{"line_number":418,"context_line":"    openstack subnet create --network dns-test-network --subnet-range 192.168.88.0/24 dns-test-subnet"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"5022a59d_31f46591","line":416,"range":{"start_line":413,"start_character":16,"end_line":416,"end_character":1},"updated":"2024-01-26 15:20:10.000000000","message":"this can be at least simplified to:\n\n```\nawk -F \u0027:\u0027 \u0027/neutron_dns_domain:/ { print $2 }\u0027 /etc/kolla/globals.yml \\\n| sed -e \u0027s/\"//g\u0027 -e \"s/\u0027//g\" -e \"s/\\ *//g\"\n```","commit_id":"4d8fd609fc64cad5a738686f117d2af61b3c79e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"531a6b1b38025c94baa8a4755c2fb3e196e91e17","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"function test_internal_dns_integration {"},{"line_number":412,"context_line":"    DNS_NAME\u003d\"my-port\""},{"line_number":413,"context_line":"    DNS_DOMAIN\u003d$(grep \u0027neutron_dns_domain:\u0027 /etc/kolla/globals.yml \\"},{"line_number":414,"context_line":"                        | awk -F \u0027:\u0027 \u0027{print $2}\u0027 \\"},{"line_number":415,"context_line":"                        | sed -e \u0027s/\"//g\u0027 -e \"s/\u0027//g\" -e \"s/\\ *//g\")"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    openstack network create dns-test-network"},{"line_number":418,"context_line":"    openstack subnet create --network dns-test-network --subnet-range 192.168.88.0/24 dns-test-subnet"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"1c31f402_5b78146d","line":416,"range":{"start_line":413,"start_character":16,"end_line":416,"end_character":1},"in_reply_to":"5022a59d_31f46591","updated":"2024-01-26 19:02:29.000000000","message":"Done","commit_id":"4d8fd609fc64cad5a738686f117d2af61b3c79e6"}],"tests/test-magnum.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2f67ed63f30583fef460a3bdd515a414ca6d89ab","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    # Smoke test."},{"line_number":46,"context_line":"    openstack zone list --all"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    SERVER_NAME\u003d\"my_vm\""},{"line_number":49,"context_line":"    SERVER_NAME_SANITIZED\u003d$(echo ${SERVER_NAME} | sed -e \u0027s/_/-/g\u0027)"},{"line_number":50,"context_line":"    DNS_DOMAIN\u003d\"floating.example.org.\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    openstack zone create --email admin@example.org ${DNS_DOMAIN}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"69383f8f_2d1dc63b","line":49,"range":{"start_line":48,"start_character":4,"end_line":49,"end_character":67},"updated":"2024-01-26 15:20:10.000000000","message":"why not create the servername directly without underscores? or is this on purpose?","commit_id":"4d8fd609fc64cad5a738686f117d2af61b3c79e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ab1d9b824b5ca56f8d3126757e727e9ef33150ff","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    # Smoke test."},{"line_number":46,"context_line":"    openstack zone list --all"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    SERVER_NAME\u003d\"my_vm\""},{"line_number":49,"context_line":"    SERVER_NAME_SANITIZED\u003d$(echo ${SERVER_NAME} | sed -e \u0027s/_/-/g\u0027)"},{"line_number":50,"context_line":"    DNS_DOMAIN\u003d\"floating.example.org.\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    openstack zone create --email admin@example.org ${DNS_DOMAIN}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"789eb073_e8cfb0db","line":49,"range":{"start_line":48,"start_character":4,"end_line":49,"end_character":67},"in_reply_to":"69383f8f_2d1dc63b","updated":"2024-01-26 15:45:01.000000000","message":"it is intended, designate must be able to modify this name, check https://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html","commit_id":"4d8fd609fc64cad5a738686f117d2af61b3c79e6"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0a2e55f34d1c2796aff8efadf66e076f31a34341","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # Smoke test."},{"line_number":46,"context_line":"    openstack zone list --all"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    SERVER_NAME\u003d\"my_vm\""},{"line_number":49,"context_line":"    SERVER_NAME_SANITIZED\u003d$(echo ${SERVER_NAME} | sed -e \u0027s/_/-/g\u0027)"},{"line_number":50,"context_line":"    DNS_DOMAIN\u003d\"floating.example.org.\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    openstack zone create --email admin@example.org ${DNS_DOMAIN}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"0e1e6be5_9d14f67f","line":49,"range":{"start_line":48,"start_character":4,"end_line":49,"end_character":67},"in_reply_to":"789eb073_e8cfb0db","updated":"2024-01-26 18:46:05.000000000","message":"Done","commit_id":"4d8fd609fc64cad5a738686f117d2af61b3c79e6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83fb4529c3169bad8cf72de4e48b269630b36670","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    FLOATING_IP_ID\u003d$(openstack floating ip list --port ${PORT_ID} -f value -c ID)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    openstack server remove floating ip ${SERVER_ID} ${FLOATING_IP_ID}"},{"line_number":73,"context_line":"    openstack floating id delete ${FLOATING_IP_ID}"},{"line_number":74,"context_line":"    openstack server delete ${SERVER_ID}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    DNS_DOMAIN\u003d\"floating-2.example.org.\""}],"source_content_type":"text/x-sh","patch_set":39,"id":"fdfbddbb_9479790b","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":25},"updated":"2024-01-25 06:32:43.000000000","message":"ip","commit_id":"2c218511403cbd2814a665782e336aad1e7c9ec4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c8db3f81e9e29606c07315ee39d498df79c292b4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    FLOATING_IP_ID\u003d$(openstack floating ip list --port ${PORT_ID} -f value -c ID)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    openstack server remove floating ip ${SERVER_ID} ${FLOATING_IP_ID}"},{"line_number":73,"context_line":"    openstack floating id delete ${FLOATING_IP_ID}"},{"line_number":74,"context_line":"    openstack server delete ${SERVER_ID}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    DNS_DOMAIN\u003d\"floating-2.example.org.\""}],"source_content_type":"text/x-sh","patch_set":39,"id":"fd405031_2b3631a5","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":25},"in_reply_to":"213e1d45_91acb1fa","updated":"2024-01-25 06:48:12.000000000","message":"aaa ...I see..","commit_id":"2c218511403cbd2814a665782e336aad1e7c9ec4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4a64d426fe9876c0274c4f2c57427201b1bb7e83","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    FLOATING_IP_ID\u003d$(openstack floating ip list --port ${PORT_ID} -f value -c ID)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    openstack server remove floating ip ${SERVER_ID} ${FLOATING_IP_ID}"},{"line_number":73,"context_line":"    openstack floating id delete ${FLOATING_IP_ID}"},{"line_number":74,"context_line":"    openstack server delete ${SERVER_ID}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    DNS_DOMAIN\u003d\"floating-2.example.org.\""}],"source_content_type":"text/x-sh","patch_set":39,"id":"2f8f4b49_04f916af","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":25},"in_reply_to":"fd405031_2b3631a5","updated":"2024-01-25 07:04:28.000000000","message":"Done","commit_id":"2c218511403cbd2814a665782e336aad1e7c9ec4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"147b3a0bc95e665337195c84641ebe866da2efac","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    FLOATING_IP_ID\u003d$(openstack floating ip list --port ${PORT_ID} -f value -c ID)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    openstack server remove floating ip ${SERVER_ID} ${FLOATING_IP_ID}"},{"line_number":73,"context_line":"    openstack floating id delete ${FLOATING_IP_ID}"},{"line_number":74,"context_line":"    openstack server delete ${SERVER_ID}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    DNS_DOMAIN\u003d\"floating-2.example.org.\""}],"source_content_type":"text/x-sh","patch_set":39,"id":"213e1d45_91acb1fa","line":73,"range":{"start_line":73,"start_character":23,"end_line":73,"end_character":25},"in_reply_to":"fdfbddbb_9479790b","updated":"2024-01-25 06:45:18.000000000","message":"which small typo ?","commit_id":"2c218511403cbd2814a665782e336aad1e7c9ec4"}],"tests/test-octavia.sh":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b3219058aa00f27a3e16f424685d3043f344aebc","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        HOSTNAME\u003d$(echo ${DNS_ASSIGNMENT} | python -c \u0027import json,sys;obj\u003djson.load(sys.stdin);print(obj[\"dns_assignment\"][0][\"hostname\"]);\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if [ \"${DNS_NAME}.${DNS_DOMAIN}\" \u003d\u003d \"${FQDN}\" ]; then"},{"line_number":106,"context_line":"            echo \"[i] Test neutron internal DNS integration FQDN check port - PASS\""},{"line_number":107,"context_line":"        else"},{"line_number":108,"context_line":"            echo \"[e] Test neutron internal DNS integration FQDN check port - FAIL\""},{"line_number":109,"context_line":"            exit 1"}],"source_content_type":"text/x-sh","patch_set":46,"id":"7da317a0_4fd145e1","line":106,"range":{"start_line":106,"start_character":18,"end_line":106,"end_character":21},"updated":"2024-01-29 12:26:31.000000000","message":"can we maybe use something greppable like \"info\" and \"error\" here? see also below.\nI assume these lines show up in CI logs.","commit_id":"5f9643b3c2159beba331e7897c28dac268a76059"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4af3b51cd83793bc8308a87ecf1d54188865e8c2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        HOSTNAME\u003d$(echo ${DNS_ASSIGNMENT} | python -c \u0027import json,sys;obj\u003djson.load(sys.stdin);print(obj[\"dns_assignment\"][0][\"hostname\"]);\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if [ \"${DNS_NAME}.${DNS_DOMAIN}\" \u003d\u003d \"${FQDN}\" ]; then"},{"line_number":106,"context_line":"            echo \"[i] Test neutron internal DNS integration FQDN check port - PASS\""},{"line_number":107,"context_line":"        else"},{"line_number":108,"context_line":"            echo \"[e] Test neutron internal DNS integration FQDN check port - FAIL\""},{"line_number":109,"context_line":"            exit 1"}],"source_content_type":"text/x-sh","patch_set":46,"id":"9ee6f638_83940239","line":106,"range":{"start_line":106,"start_character":18,"end_line":106,"end_character":21},"in_reply_to":"7da317a0_4fd145e1","updated":"2024-01-30 09:04:47.000000000","message":"From CI you can see which script failed, you can check what to grep. I still can remove that as it is in all other scripts (and it\u0027s fine ..).","commit_id":"5f9643b3c2159beba331e7897c28dac268a76059"}]}