)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"73159a2debc607f7e1e3cce6190aa5b7e6233efd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Split ipv4 and ipv6 systemctl config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This ways the playbooks won\u0027t try to set ipv6 systemctl options unless ipv6 is explicitly required."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icccfc1c509179c3cfd59650b7917a637f9af9646"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4fe67463_6458a9c6","line":10,"updated":"2024-01-24 16:43:12.000000000","message":"link the bug https://bugs.launchpad.net/kolla-ansible/+bug/1906306 here","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c9c521150cd89f3e9ee0b5595e4abb8f9ea98d20","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Split ipv4 and ipv6 systemctl config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This ways the playbooks won\u0027t try to set ipv6 systemctl options unless ipv6 is explicitly required."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icccfc1c509179c3cfd59650b7917a637f9af9646"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3e7f6def_46d33d2a","line":10,"in_reply_to":"4fe67463_6458a9c6","updated":"2024-01-26 10:24:54.000000000","message":"Done","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"55bb5128f4e7e09d6aa19d2daca5777b93cd0ccb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Split ipv4 and ipv6 systemctl config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This ways the playbooks won\u0027t try to set ipv6 systemctl options unless ipv6 is explicitly required."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icccfc1c509179c3cfd59650b7917a637f9af9646"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc7f2bb_dce890b6","line":10,"in_reply_to":"4fe67463_6458a9c6","updated":"2024-02-01 10:09:21.000000000","message":"Done","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3bed12133799c69a0ceec9b5c82eca0e81e46228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"124f449b_c836341b","updated":"2024-01-22 04:32:39.000000000","message":"recheck","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3b49ffee9cc32842ed3c31bdbe3f3114e9bd24d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a037e71d_178015e7","updated":"2024-01-22 09:18:03.000000000","message":"recheck","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"76782e3f92eac357cfdfb19931d96325d0094062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d87d45ac_ea228889","updated":"2024-01-24 09:41:37.000000000","message":"recheck","commit_id":"78670e1cc50616df0682ae732bbec240ffc2f939"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"55bb5128f4e7e09d6aa19d2daca5777b93cd0ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"78287df0_39106f63","updated":"2024-02-01 10:09:21.000000000","message":"recheck","commit_id":"610d8966d765b2350218b89b1913badf07432e2a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"be1971e679aa1b4dc47fe0b5ea87b045f7a10445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a492416b_b210df99","in_reply_to":"78287df0_39106f63","updated":"2024-02-01 11:09:01.000000000","message":"please don\u0027t use bare rechecks, always state the reason why you are rechecking (e.g. \"recheck job timeout\", \"recheck external mirror failure\" etc). the openstack CI team actually looks at these and creates a statistic out of it and tries to tackle the most common recheck problems, improving the CI for all of us. Thanks!","commit_id":"610d8966d765b2350218b89b1913badf07432e2a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c669d3cee7709a5df10c4cbf05573bca93691e4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fbf33e1f_433935fa","updated":"2024-02-05 08:20:29.000000000","message":"Since we use that in two places - wouldn\u0027t it be better to break out sysctl setting to a separate role in a followup?\n\nI\u0027m fine with doing as it is now, to back port the fix to stable branches.","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8c9728becaac4b056740a9b0368e57e45258d0f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"310681ec_e5b3ddd7","in_reply_to":"0f2c9eb4_d7172545","updated":"2024-03-13 16:40:35.000000000","message":"Done","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"2a93e19151cde51d5b934744d74e5243e56aae42","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0f2c9eb4_d7172545","in_reply_to":"18adb4de_edb442d1","updated":"2024-03-13 15:01:04.000000000","message":"Followup here https://review.opendev.org/c/openstack/kolla-ansible/+/912351","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"622f139109fc6a6d7e6ae831fbb1716b10d56b8b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"18adb4de_edb442d1","in_reply_to":"fbf33e1f_433935fa","updated":"2024-02-09 09:15:01.000000000","message":"I agree, also about the followup and the backporting.","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c6678b026ea42bcd0e22473c5a17b24530941a41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"68473dcd_b1a8d9fc","updated":"2024-03-06 14:43:33.000000000","message":"as mentioned on the meeting - for back porting you would need to not introduce a role and refactor in a separate patch that would be not back ported.","commit_id":"939fbeff7938ef2af76a7e97fbbbf17db571f7de"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"3d25a4cbc796de56449c9e19a35347ba6125e71e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0080f9e4_6a781685","updated":"2024-03-10 14:42:18.000000000","message":"recheck shared connection closed","commit_id":"4277c83b3ad97c5faf9cf42b195f6fb1983a4f35"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e2bd17b213c907d39dc4155af23ead01dc373b0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b925f920_d86d3dae","updated":"2024-03-10 22:21:26.000000000","message":"what about reno?","commit_id":"4277c83b3ad97c5faf9cf42b195f6fb1983a4f35"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c1367e9dae3749a2c921de730567bb6ad1a2a188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7c43d1bb_3e6c0ce6","updated":"2024-03-11 17:24:09.000000000","message":"LGTM, just one suggestion to maybe reduce the number of tasks (untested, but should work)","commit_id":"2683de7ca691c7143bff70f879e9b6adc9a3d531"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"211300a3de79c209a3cb67cf5e92a58afcd6fb22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5ed5b7e6_35ca6cff","updated":"2024-03-22 11:01:28.000000000","message":"Are there any more steps that need to be taken that before this is accepted?","commit_id":"9301e82d7bd56e214e406319ee75db42b03a5167"}],"ansible/roles/loadbalancer/tasks/config-host.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c9c521150cd89f3e9ee0b5595e4abb8f9ea98d20","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  stat:"},{"line_number":22,"context_line":"    path: \"/proc/net/if_inet6\""},{"line_number":23,"context_line":"  register: ipv6_check"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"472558e0_8b3852a4","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":30},"updated":"2024-01-26 10:24:54.000000000","message":"this is an okayish variant that works. However reading stuff directly from the procfs has it\u0027s own pitfalls: it might not be mounted all the time and it\u0027s rather slow, also meaning of stuff in procfs can change all the time, it\u0027s no stable kernel API afaik, because it exposes, by it\u0027s nature kernel internal data structures, which are subject to change.\n\nslightly more in line with what we do and with hopefully less maintenance , would be to just use sysctl to probe for ipv6 support, though, no?\n\nyou can do so by querying `sysctl -n net.ipv6.conf.all.disable_ipv6` with the output of `0` meaning IPv6 is enabled globally and with the output of `1` meaning IPv6 is disabled globally.\n\nIt\u0027s just a suggestion though, the current method probably works for 95% of usecases and it\u0027s maybe a good bet that the ipv6 stuff will not change that much in the future - I don\u0027t know. :)","commit_id":"ef57d63f9c4cf7b8206ad4a9d9a257709b78e1d6"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"55bb5128f4e7e09d6aa19d2daca5777b93cd0ccb","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  stat:"},{"line_number":22,"context_line":"    path: \"/proc/net/if_inet6\""},{"line_number":23,"context_line":"  register: ipv6_check"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d6a73a37_306d674a","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":30},"in_reply_to":"472558e0_8b3852a4","updated":"2024-02-01 10:09:21.000000000","message":"Thank you for your suggestion. I think that 95 % is little too low and implemented your suggestion.","commit_id":"ef57d63f9c4cf7b8206ad4a9d9a257709b78e1d6"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"43f68fbdf2c4dd438026786e50cfa0853babf312","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  stat:"},{"line_number":22,"context_line":"    path: \"/proc/net/if_inet6\""},{"line_number":23,"context_line":"  register: ipv6_check"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"02dda8df_b5b4a6d8","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":30},"in_reply_to":"d6a73a37_306d674a","updated":"2024-02-01 11:04:42.000000000","message":"Done","commit_id":"ef57d63f9c4cf7b8206ad4a9d9a257709b78e1d6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c669d3cee7709a5df10c4cbf05573bca93691e4d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"},{"line_number":22,"context_line":"  register: ipv6_disabled"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2e92c233_29c63493","line":21,"updated":"2024-02-05 08:20:29.000000000","message":"changed_when: false","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e380b2ba461aaecc6f2beeb7d6a0ac7bd6625eb9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"},{"line_number":22,"context_line":"  register: ipv6_disabled"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a6ae06d_c826aa4d","line":21,"in_reply_to":"2e92c233_29c63493","updated":"2024-02-05 11:04:56.000000000","message":"Acknowledged","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8646b6c897f3ad8e62895512a538569d8e25891b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"},{"line_number":22,"context_line":"  register: ipv6_disabled"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b25330be_8e0fc30b","line":21,"in_reply_to":"5a6ae06d_c826aa4d","updated":"2024-02-05 15:32:05.000000000","message":"Done","commit_id":"201bf89045abb384bf00ab6a498d1e2a276f95ed"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8646b6c897f3ad8e62895512a538569d8e25891b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    name: sysctl"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    neutron_l3_agent: \"{{ neutron_services[\u0027neutron-l3-agent\u0027] }}\""},{"line_number":7,"context_line":"    settings: "},{"line_number":8,"context_line":"      - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":9,"context_line":"      - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":10,"context_line":"      - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"af884fd8_17f99601","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":14},"updated":"2024-02-05 15:32:05.000000000","message":"nit: unnecessary space","commit_id":"a20b76744a64bcb76e8541ef76369b2c91601305"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"622f139109fc6a6d7e6ae831fbb1716b10d56b8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: sysctl"},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    neutron_l3_agent: \"{{ neutron_services[\u0027neutron-l3-agent\u0027] }}\""},{"line_number":7,"context_line":"    settings: "},{"line_number":8,"context_line":"      - { name: \"net.ipv6.ip_nonlocal_bind\", value: 1 }"},{"line_number":9,"context_line":"      - { name: \"net.ipv4.ip_nonlocal_bind\", value: 1 }"},{"line_number":10,"context_line":"      - { name: \"net.ipv4.tcp_retries2\", value: \"{{ haproxy_host_ipv4_tcp_retries2 }}\" }"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fca31319_f40755dc","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":14},"in_reply_to":"af884fd8_17f99601","updated":"2024-02-09 09:15:01.000000000","message":"Done","commit_id":"a20b76744a64bcb76e8541ef76369b2c91601305"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"c1367e9dae3749a2c921de730567bb6ad1a2a188","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":16,"context_line":"  when:"},{"line_number":17,"context_line":"    - set_sysctl | bool"},{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bf9c2336_e1105759","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"updated":"2024-03-11 17:24:09.000000000","message":"I guess we could omit the additional task for IPv6, if you introduce another when conditional, like this:\n\n```yaml\n  when:\n    - set_sysctl | bool\n    - item.value !\u003d \u0027KOLLA_SKIP\u0027\n    - item.name !\u003d \"net.ipv6.ip_nonlocal_bind\" or (item.name \u003d\u003d \"net.ipv6.ip_nonlocal_bind\" and not ipv6_disabled.stdout | bool)\n```\n\nWhat do you think?","commit_id":"2683de7ca691c7143bff70f879e9b6adc9a3d531"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8ae125806153c75097e6e2683c53816f7d769b94","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":16,"context_line":"  when:"},{"line_number":17,"context_line":"    - set_sysctl | bool"},{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8eaa173e_de6e0db8","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"in_reply_to":"45035d6d_ecec2452","updated":"2024-03-13 14:45:36.000000000","message":"Done","commit_id":"2683de7ca691c7143bff70f879e9b6adc9a3d531"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"ad12d2ddad70dea14e20a8c6cbe96c18d23be998","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - { name: \"net.unix.max_dgram_qlen\", value: 128 }"},{"line_number":16,"context_line":"  when:"},{"line_number":17,"context_line":"    - set_sysctl | bool"},{"line_number":18,"context_line":"    - item.value !\u003d \u0027KOLLA_SKIP\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Check IPv6 support"},{"line_number":21,"context_line":"  command: /usr/sbin/sysctl -n net.ipv6.conf.all.disable_ipv6"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"45035d6d_ecec2452","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"in_reply_to":"bf9c2336_e1105759","updated":"2024-03-13 08:50:14.000000000","message":"I tried to take it a step further by implementing a conditional that would skip all IPv6 settings to make it more general.","commit_id":"2683de7ca691c7143bff70f879e9b6adc9a3d531"}],"ansible/roles/neutron/tasks/config-host.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2e5fbb41945ab01d52f04ecf0e65115b677c34dd","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    - (neutron_l3_agent.enabled | bool and neutron_l3_agent.host_in_groups | bool)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Check IPv6 support"},{"line_number":36,"context_line":"  command: sysctl -n net.ipv6.conf.all.disable_ipv6"},{"line_number":37,"context_line":"  register: ipv6_disabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b8ce373c_edd3e371","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2024-02-01 11:16:56.000000000","message":"this errors currently with: `\"msg\": \"[Errno 2] No such file or directory: b\u0027sysctl\u0027\",`\non my local machine the path to sysctl is `/usr/sbin/sysctl`, might be worth to try it with the full path?","commit_id":"610d8966d765b2350218b89b1913badf07432e2a"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"edf3cea0a4e61c93eff80fac006463cbe192b7ac","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - (neutron_l3_agent.enabled | bool and neutron_l3_agent.host_in_groups | bool)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Check IPv6 support"},{"line_number":36,"context_line":"  command: sysctl -n net.ipv6.conf.all.disable_ipv6"},{"line_number":37,"context_line":"  register: ipv6_disabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Setting sysctl values for IPv6"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"808b5cd9_293ebc81","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"b8ce373c_edd3e371","updated":"2024-02-19 11:22:30.000000000","message":"Done","commit_id":"610d8966d765b2350218b89b1913badf07432e2a"}],"ansible/roles/sysctl/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c6678b026ea42bcd0e22473c5a17b24530941a41","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check IPv6 support"},{"line_number":3,"context_line":"  command: \"{{ sysctl_path }} -n net.ipv6.conf.all.disable_ipv6\""},{"line_number":4,"context_line":"  register: ipv6_disabled"},{"line_number":5,"context_line":"  changed_when: false"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"db937839_d1e423e3","line":3,"updated":"2024-03-06 14:43:33.000000000","message":"set_fact and use {{ ansible_all_ipv6_addresses | length \u003e 0 }} instead of command?","commit_id":"939fbeff7938ef2af76a7e97fbbbf17db571f7de"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"40bc45d9ad7ce58d6bad4ccfb5d64eeaade22a64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check IPv6 support"},{"line_number":3,"context_line":"  command: \"{{ sysctl_path }} -n net.ipv6.conf.all.disable_ipv6\""},{"line_number":4,"context_line":"  register: ipv6_disabled"},{"line_number":5,"context_line":"  changed_when: false"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a6e470f7_74df951a","line":3,"in_reply_to":"90fa7ac4_c4143999","updated":"2024-03-13 14:42:17.000000000","message":"Acknowledged","commit_id":"939fbeff7938ef2af76a7e97fbbbf17db571f7de"},{"author":{"_account_id":36702,"name":"Roman Krcek","display_name":"Roman Krček","email":"roman.krcek@tietoevry.com","username":"r-krcek"},"change_message_id":"efe5792bfd1b562fa8e6fd8e73debbac79ee8008","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check IPv6 support"},{"line_number":3,"context_line":"  command: \"{{ sysctl_path }} -n net.ipv6.conf.all.disable_ipv6\""},{"line_number":4,"context_line":"  register: ipv6_disabled"},{"line_number":5,"context_line":"  changed_when: false"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"90fa7ac4_c4143999","line":3,"in_reply_to":"b86dceb5_baf6348e","updated":"2024-03-10 20:58:33.000000000","message":"I wanted to restrain this to systems that have IPv6 disabled in kernel - thats the systems on which the changing the sysctl setting will result in an error.","commit_id":"939fbeff7938ef2af76a7e97fbbbf17db571f7de"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"8f50d388f5b3fd4aa920f0c77b3ecb1dd05a08e2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check IPv6 support"},{"line_number":3,"context_line":"  command: \"{{ sysctl_path }} -n net.ipv6.conf.all.disable_ipv6\""},{"line_number":4,"context_line":"  register: ipv6_disabled"},{"line_number":5,"context_line":"  changed_when: false"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b86dceb5_baf6348e","line":3,"in_reply_to":"db937839_d1e423e3","updated":"2024-03-07 16:12:08.000000000","message":"this is not testing for the same thing?\n\nthe sysctl command checks if ipv6 is disabled in the kernel. your ansible test checks if there is any ipv6 address configured.\n\nyou can have ipv6 enabled but not have any address - yet - configured.","commit_id":"939fbeff7938ef2af76a7e97fbbbf17db571f7de"}]}
