)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"83edd71af40ba3dfce17839bfdc05e68fab2f91d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"55369009_9792593c","updated":"2024-01-26 10:38:54.000000000","message":"I\u0027m not that familiar with this part of the code but it seems this needs adjustments to the `test_kolla_container.py` script in `tests`, as this is currently failing in CI.","commit_id":"046c6c80fc4e7ae0643e4016f66b688d4bef8033"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"85e4bb5280642eef244119f23c81cc8a4c8c6f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"50a15b5e_28badec7","in_reply_to":"55369009_9792593c","updated":"2024-01-29 16:10:30.000000000","message":"Done","commit_id":"046c6c80fc4e7ae0643e4016f66b688d4bef8033"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3d33212ec7f95e19608e0c2a79412e9b1e433dfb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8e41ee4a_d4294d0b","updated":"2024-02-14 14:44:20.000000000","message":"What is wrong with https://github.com/openstack/kolla-ansible/blob/master/ansible/library/kolla_container_facts.py?","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"65a049cec1004b0cad5044a35618d9a2619aafd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dd68cf1a_1edb86aa","in_reply_to":"1230ee9c_dc4ef699","updated":"2024-02-16 16:41:00.000000000","message":"I get it. The functionality can be moved to _facts module but how would we extend it? Introduce \u0027action\u0027 option like kolla_container? Empty \u0027name\u0027 option returns just the list of names of all the containers?","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a570dcb9e9e979b71f2336f8db5868bb322abfcf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b301dbd6_df7984f1","in_reply_to":"72a4a9ea_00555ce5","updated":"2024-02-21 14:30:42.000000000","message":"Sounds good for me :-)","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"46ecd2883cb347ed32e50065fe260796c9e326ae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8f407a04_51f06966","in_reply_to":"8e41ee4a_d4294d0b","updated":"2024-02-15 13:29:32.000000000","message":"It isn\u0027t simple to extract just the names in Ansible when using output of that module. Docker has key \u0027Names\u0027 and value is list of names starting with \u0027/\u0027. Podman has key \u0027Name\u0027 and simple string value.\nThat\u0027s why I think it\u0027s better (and easier) to take care of it inside of a module and work with just simple list of names in Ansible.","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2fb98ca3936d662da732ec8de245a5c5148e8512","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e4f64d66_790cf16b","in_reply_to":"8f407a04_51f06966","updated":"2024-02-15 14:05:29.000000000","message":"I\u0027m asking what the _facts module is not giving, and why are we moving _facts functionality to kolla_container module?","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"313502a29d854842dcc80ff6af9aad3a5f742881","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"74ace801_8e432dc2","in_reply_to":"a4ad0be8_ce8c917b","updated":"2024-03-20 15:32:26.000000000","message":"Ack. This change was sidelined, at least in it\u0027s current form, by the other patchsets for kolla_container_facts. The functionality it provides is still relevant so I\u0027m marking this as a WIP for the time being.","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d678a43c532fbbdb29a4680325287b4f215dc5cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1230ee9c_dc4ef699","in_reply_to":"a671faf5_e2c7f0df","updated":"2024-02-16 16:32:47.000000000","message":"I like the distinction (which is also how Ansible upstream does things) between an action module and a _facts module","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1dbba34266bf086863607efa056c26f2144dc582","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a4ad0be8_ce8c917b","in_reply_to":"b301dbd6_df7984f1","updated":"2024-03-20 13:49:59.000000000","message":"So, I\u0027m confused: Is this patchset still relevant/needs to be reviewed? Because your discussion seems to indicate to me that you want to solve this in a different way now, but I see neither a new patchset in this Change that does this nor some other sign of activity like: should this be abandoned and a new change be started? or mark this as WIP or something?\n\nplease state the actual status of this, thanks.","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":36701,"name":"Ivan Halomi","display_name":"Ivan Halomi","email":"ivan.halomi@gmail.com","username":"ivanhalomi"},"change_message_id":"c9f240686d0e5d9679048ce54de6a1abfe9372d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"72a4a9ea_00555ce5","in_reply_to":"dd68cf1a_1edb86aa","updated":"2024-02-19 11:19:24.000000000","message":"There are actions get_container_env and get_container_state in kolla_container, by this logic it should be also moved to _facts module. And adding this would create overhead in _facts since we would have to introduce more logic and docker/podman client separations. In the end maybe it would be better to create module called container_facts which would use higher docker API and then it could be used same way for getting info about podman/docker containers and volumes, so kolla_container_facts and kolla_container_volumes_facts could be merged, what do you think?","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"debef8ef3ba33eef3c6f6e7ca0f1070aaa3d650b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a671faf5_e2c7f0df","in_reply_to":"e4f64d66_790cf16b","updated":"2024-02-16 16:27:40.000000000","message":"_facts, as it currently is, is not giving simple enough output. Also kolla_container is easier to cleanly extend because it already uses actions, unlike _facts module.","commit_id":"e7281adb7baa0f1c36f629eb52a93bb617b2a8f3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"567cf46951c88ab8bf5f3df6fe3e7f91af59f555","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2879ba8a_04176052","updated":"2024-05-27 15:43:02.000000000","message":"I\u0027m again asking: what is the status of this?\n\nLast time I asked I was told this would be marked as WIP, but I don\u0027t see that this has ever happened.\n\nPlease state if this is ready for review, thanks.","commit_id":"45acf41b768662c97f109abe205925e4b453fcc2"},{"author":{"_account_id":34113,"name":"Martin Hiner","email":"martin.hiner@tietoevry.com","username":"hinermar"},"change_message_id":"cee18aaf50563ac3179dd71bb33514a0b6de9f82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"dfb8dda7_e3dfd38c","in_reply_to":"2879ba8a_04176052","updated":"2024-05-29 10:15:38.000000000","message":"Functionality provided in this patch is better suited to be added to kolla_container_facts module, instead of kolla_container. It will get rewritten as such and added to the group of kolla_container_facts patches under Ivan\u0027s ownership. For now, I have removed it from being a dependency for migration patch - it can be incorporated later.\n\nSorry for not marking it as WIP earlier. I was under the impression it is enough to put it in the commit message, not realizing the owner has to mark it as WIP. It is marked now.","commit_id":"45acf41b768662c97f109abe205925e4b453fcc2"}],"ansible/library/kolla_container.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5f1d98fda1ff3b8dac055c61747778d4e81b21fc","unresolved":true,"context_lines":[{"line_number":58,"context_line":"      - start_container"},{"line_number":59,"context_line":"      - stop_container"},{"line_number":60,"context_line":"      - stop_container_and_remove_container"},{"line_number":61,"context_line":"      - get_container_names"},{"line_number":62,"context_line":"  api_version:"},{"line_number":63,"context_line":"    description:"},{"line_number":64,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":2,"id":"c36bb41d_17cebddd","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":2},"updated":"2024-01-18 13:38:10.000000000","message":"please keep this list alphabetically sorted","commit_id":"1738f1d06896eee84834ef5fff7bd8dd97382127"},{"author":{"_account_id":36701,"name":"Ivan Halomi","display_name":"Ivan Halomi","email":"ivan.halomi@gmail.com","username":"ivanhalomi"},"change_message_id":"019e1b6d969048e44b7fc1a26d88511c4b2e1e47","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - start_container"},{"line_number":59,"context_line":"      - stop_container"},{"line_number":60,"context_line":"      - stop_container_and_remove_container"},{"line_number":61,"context_line":"      - get_container_names"},{"line_number":62,"context_line":"  api_version:"},{"line_number":63,"context_line":"    description:"},{"line_number":64,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aeb9e98_d53601bd","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":2},"in_reply_to":"7d9bcc8b_7086e824","updated":"2024-01-25 09:12:40.000000000","message":"it was there on patchset 4 and patchset 5 removed it for some reason :D should be okay now","commit_id":"1738f1d06896eee84834ef5fff7bd8dd97382127"},{"author":{"_account_id":36701,"name":"Ivan Halomi","display_name":"Ivan Halomi","email":"ivan.halomi@gmail.com","username":"ivanhalomi"},"change_message_id":"f0809c3ef574f7e587357b2c7d81925149404f04","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - start_container"},{"line_number":59,"context_line":"      - stop_container"},{"line_number":60,"context_line":"      - stop_container_and_remove_container"},{"line_number":61,"context_line":"      - get_container_names"},{"line_number":62,"context_line":"  api_version:"},{"line_number":63,"context_line":"    description:"},{"line_number":64,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":2,"id":"d4db9260_526dd409","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":2},"in_reply_to":"c36bb41d_17cebddd","updated":"2024-01-19 12:06:51.000000000","message":"Done","commit_id":"1738f1d06896eee84834ef5fff7bd8dd97382127"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cd1352d2b50f1c1c615268ace3b2084b31bdb61d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"      - start_container"},{"line_number":59,"context_line":"      - stop_container"},{"line_number":60,"context_line":"      - stop_container_and_remove_container"},{"line_number":61,"context_line":"      - get_container_names"},{"line_number":62,"context_line":"  api_version:"},{"line_number":63,"context_line":"    description:"},{"line_number":64,"context_line":"      - The version of the api for docker-py to use when contacting docker"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d9bcc8b_7086e824","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":2},"in_reply_to":"d4db9260_526dd409","updated":"2024-01-24 11:00:12.000000000","message":"no it\u0027s not done, did you miss to publish a patchset for this?","commit_id":"1738f1d06896eee84834ef5fff7bd8dd97382127"}]}