)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"02007bcacf218e2479451eb4c738f91bb8b9abeb","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:51:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix neutron DNS integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I90f0f8dcec6fa0112179f050d96e9d9db5956cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dbe0aa43_6930061d","line":8,"updated":"2024-01-18 08:37:00.000000000","message":"If this is a fix, where is the bug? Also some kind of actual commit message would be nice","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5395cc34bb2b0379a81cc6832f2db877d274f837","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:51:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix neutron DNS integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I90f0f8dcec6fa0112179f050d96e9d9db5956cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e299aa52_6469611b","line":8,"in_reply_to":"dbe0aa43_6930061d","updated":"2024-01-18 13:58:14.000000000","message":"This should be the bugreport, I think: https://bugs.launchpad.net/kolla-ansible/+bug/2049503","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45e444dace3bc53e12bd8d0e31c89898ffc3e13d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-17 16:51:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix neutron DNS integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I90f0f8dcec6fa0112179f050d96e9d9db5956cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f3ac1734_63862073","line":8,"in_reply_to":"e299aa52_6469611b","updated":"2024-01-19 09:09:11.000000000","message":"Done","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5395cc34bb2b0379a81cc6832f2db877d274f837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc6968a3_ae7ffcba","updated":"2024-01-18 13:58:14.000000000","message":"I agree with most of the other comments. I\u0027m not sure if it\u0027s really good practice to separate necessary checks from the actual code though (the precheck thing).","commit_id":"a41804daee640004b7e09edb6148376c2fb09de0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a6486a4483e057baefac22140d2b64e703888ae2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"15fc9d5f_a9a41609","updated":"2024-01-25 22:02:31.000000000","message":"recheck non-related cinder volume detach failure","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a4201a4211db16ab2f3b5f4204e32a2279ffa284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"31e579f1_86ceace7","updated":"2024-01-26 22:06:33.000000000","message":"recheck ovn upgrade non-related error","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1068a15fcf9444562382b610cde1eda0777f855d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"8ca57838_c9c54c59","updated":"2024-01-30 11:17:46.000000000","message":"lgtm, thx","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"02007bcacf218e2479451eb4c738f91bb8b9abeb","unresolved":true,"context_lines":[{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool and enable_designate | bool }}\""},{"line_number":701,"context_line":"  - name: \"dns_domain_ports\""},{"line_number":702,"context_line":"    enabled: \"{{ neutron_dns_integration | bool and not enable_designate | bool }}\""},{"line_number":703,"context_line":"  - name: \"sfc\""},{"line_number":704,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""},{"line_number":705,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a74e36f6_422278f3","line":702,"updated":"2024-01-18 08:37:00.000000000","message":"Why not use subnet_dns_publish_fixed_ip in this case, too? It might not be too useful to have that flag available, but it also should not hurt and it leads to more consistency in the API responses. Also less complexity here.","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2e76377a28db9eced9b4871475ddfecbb5f4e459","unresolved":false,"context_lines":[{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool and enable_designate | bool }}\""},{"line_number":701,"context_line":"  - name: \"dns_domain_ports\""},{"line_number":702,"context_line":"    enabled: \"{{ neutron_dns_integration | bool and not enable_designate | bool }}\""},{"line_number":703,"context_line":"  - name: \"sfc\""},{"line_number":704,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""},{"line_number":705,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6dd3a5d8_130a2191","line":702,"in_reply_to":"a74e36f6_422278f3","updated":"2024-01-18 12:58:15.000000000","message":"Done","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"02007bcacf218e2479451eb4c738f91bb8b9abeb","unresolved":true,"context_lines":[{"line_number":927,"context_line":"# Check http://www.haproxy.org/download/1.5/doc/configuration.txt for available options"},{"line_number":928,"context_line":"neutron_tls_proxy_defaults_balance: \"roundrobin\""},{"line_number":929,"context_line":"neutron_dns_integration: \"yes\""},{"line_number":930,"context_line":"neutron_dns_domain:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ecca6ac_632826c8","line":930,"updated":"2024-01-18 08:37:00.000000000","message":"This doesn\u0027t belong to TLS, either move it beside the extension drivers or make a new \"DNS\" section?\n\nWe also plan to get rid of empty defaults, what about copying the neutron default \"openstacklocal.\"? Then it could always be used in the template without any condition around it.","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45e444dace3bc53e12bd8d0e31c89898ffc3e13d","unresolved":false,"context_lines":[{"line_number":927,"context_line":"# Check http://www.haproxy.org/download/1.5/doc/configuration.txt for available options"},{"line_number":928,"context_line":"neutron_tls_proxy_defaults_balance: \"roundrobin\""},{"line_number":929,"context_line":"neutron_dns_integration: \"yes\""},{"line_number":930,"context_line":"neutron_dns_domain:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ee05ec8d_7aaf95fa","line":930,"in_reply_to":"9ecca6ac_632826c8","updated":"2024-01-19 09:09:11.000000000","message":"Done","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1189ccb36d8e161082b175910f71303ce95f2bd6","unresolved":true,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"514b9068_76f86e83","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"updated":"2024-01-21 00:00:01.000000000","message":"forgot the dot here?","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"894a87901505f7d88e6b4caad039c61d47ce2a44","unresolved":true,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c85b208a_d8159183","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"in_reply_to":"4989ac86_b6033ba3","updated":"2024-01-21 19:56:01.000000000","message":"ok, lgtm, then this should be well described in the documentation, and the reno is absent too, so -1 for now","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1e422705f68fb87cae38eb7376caaca717ec004f","unresolved":false,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5658e4cd_a4a8f19a","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"in_reply_to":"514b9068_76f86e83","updated":"2024-01-21 11:13:45.000000000","message":"No I didn\u0027t, this value has to end with dot, but neutron default is without dot as you can see here https://github.com/openstack/neutron/blob/5ce17647c60448c9cae00ffc886d4e17a9fe0890/neutron/conf/common.py#L91 and documentation here https://docs.openstack.org/neutron/latest/admin/config-dns-int.html.\n\nSo I basically suppose there\u0027s a reason for that. Based on that the neutron code works differently, because when I tried  DNS integration .. this value simply had to be other than \u0027openstacklocal\u0027, otherwise it didn\u0027t work correctly.\n\nIn previous patches I just didn\u0027t render that value to neutron config, but frickler suggested to not use empty ansible values and just set to default - which \u0027openstacklocal\u0027 (without dot on the end) is...","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2de1e544fc6699cadd3659a9cf8628e317f1b084","unresolved":true,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f8e96c78_dade8b72","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"in_reply_to":"5658e4cd_a4a8f19a","updated":"2024-01-21 13:32:03.000000000","message":"but precheck here: https://review.opendev.org/c/openstack/kolla-ansible/+/905852/10/ansible/roles/neutron/tasks/precheck.yml#62\nwould fail ? if we enable integration.\nwhich is not tested here btw","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"aae7268a_f0ae0ed4","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"in_reply_to":"c85b208a_d8159183","updated":"2024-01-25 12:22:43.000000000","message":"Done","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3e1e1aa7a89e181fcf11ee2317fb304a70b104e3","unresolved":false,"context_lines":[{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4989ac86_b6033ba3","line":933,"range":{"start_line":933,"start_character":35,"end_line":933,"end_character":36},"in_reply_to":"f8e96c78_dade8b72","updated":"2024-01-21 14:26:48.000000000","message":"Yes, of course, If you enable integration - that means you NEED to set neutron_dns_domain ... so where is the problem ? \n\nCI tests are here https://review.opendev.org/c/openstack/kolla-ansible/+/905644/23?usp\u003drelated-change in relation chain.\n\nSo DNS internal integration i\u0027ve put to octavia test scenario, external integration is in magnum scenario (as it was before ..but now it\u0027s really tested as I\u0027ve added scenarios for it) and on the end there is test for disabled dns integration as it is now.","commit_id":"c38ee334fcfb90ffe771bbfa65b9fe9a87dbf04a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":928,"context_line":"####################"},{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"e89d3e7f_03afb2fe","line":931,"updated":"2024-01-25 06:38:38.000000000","message":"what\u0027s the difference to simply using\n\n\"{{ enable_designate }}\"\n\nhere?","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"36c29fc4e88ddf1b184d010cdc067fc7848f8278","unresolved":true,"context_lines":[{"line_number":928,"context_line":"####################"},{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"6b4e6f3c_d1de7655","line":931,"in_reply_to":"540cc415_e0ffe8e9","updated":"2024-01-25 12:42:56.000000000","message":"Dr. Jens Harbott just say that \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\" can be simple replaced with \"{{ enable_designate }}\". I can say much better use \"{{ enable_designate | bool }}\".","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3d5a33a73532b1a9b7a89eab037176fd274f1a1a","unresolved":false,"context_lines":[{"line_number":928,"context_line":"####################"},{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"63d212cb_d9959ef5","line":931,"in_reply_to":"6b4e6f3c_d1de7655","updated":"2024-01-25 16:42:30.000000000","message":"Haha, sorry, I am probably overworked :D, changed of course.","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":928,"context_line":"####################"},{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ \u0027yes\u0027 if enable_designate | bool else \u0027no\u0027 }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"540cc415_e0ffe8e9","line":931,"in_reply_to":"e89d3e7f_03afb2fe","updated":"2024-01-25 12:22:43.000000000","message":"Well, because currently in kolla deployments neutron DNS integration is enabled only if designata is enabled and disabled if designate is disabled (neutron extension)\n\nSo you probably agree that it\u0027s nothing changed and backward compatible.\nBut with this approach user can also disable integration of neutron If he want and use designate as standalone DNS zone manager...\n\nAlso, he can now enable DNS integration even if designate is disabled.\n\nNeutron ONLY internal DNS integration:   neutron_dns_integration -\u003e yes\nNeutron without DNS integration:   neutron_dns_integration -\u003e no\nDesignate ONLY without DNS integration: neutron_dns_integration -\u003e no\n\nAbove can be overriden by user, this is just default value as it works now and  backward compatible.","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e2fc3cea9c5c11d2dd7eab62dbe901dc3a83d7d2","unresolved":true,"context_lines":[{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ enable_designate | bool }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ae2fd5da_ac10d986","line":932,"range":{"start_line":932,"start_character":7,"end_line":932,"end_character":16},"updated":"2024-01-29 14:21:35.000000000","message":"nit: overridden","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11c32a84155c3a7a64a6dfe4f2eb28177f3e4ca","unresolved":false,"context_lines":[{"line_number":929,"context_line":"# DNS"},{"line_number":930,"context_line":"####################"},{"line_number":931,"context_line":"neutron_dns_integration: \"{{ enable_designate | bool }}\""},{"line_number":932,"context_line":"# When overriden by the user, this value must end with a dot."},{"line_number":933,"context_line":"neutron_dns_domain: \"openstacklocal\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"6b69f18e_38a705e7","line":932,"range":{"start_line":932,"start_character":7,"end_line":932,"end_character":16},"in_reply_to":"ae2fd5da_ac10d986","updated":"2024-01-30 09:02:23.000000000","message":"Done","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"33223788ffc577c351115c4cfdfbb83e4465a154","unresolved":true,"context_lines":[{"line_number":696,"context_line":"    enabled: \"{{ enable_neutron_qos | bool }}\""},{"line_number":697,"context_line":"  - name: \"port_security\""},{"line_number":698,"context_line":"    enabled: true"},{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool }}\""},{"line_number":701,"context_line":"  - name: \"sfc\""},{"line_number":702,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"4c022eb5_25539533","line":699,"updated":"2024-01-30 15:12:16.000000000","message":"do we need this extension driver for internal DNS only?","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"58c63c3c20e2542d01eccb4d79ea08430ebefef1","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    enabled: \"{{ enable_neutron_qos | bool }}\""},{"line_number":697,"context_line":"  - name: \"port_security\""},{"line_number":698,"context_line":"    enabled: true"},{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool }}\""},{"line_number":701,"context_line":"  - name: \"sfc\""},{"line_number":702,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"fab97ee2_c25d7997","line":699,"in_reply_to":"4c022eb5_25539533","updated":"2024-01-30 15:36:33.000000000","message":"No, but it\u0027s useless to regenerate between switches... because subnet_dns_publish_fixed_ip includes dns_domain_ports.  As @frickler mentioned in previous comments newer neutron extension includes older extensions\n\ndns -\u003e dns_domain_ports -\u003e subnet_dns_publish_fixed_ip","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"33223788ffc577c351115c4cfdfbb83e4465a154","unresolved":true,"context_lines":[{"line_number":697,"context_line":"  - name: \"port_security\""},{"line_number":698,"context_line":"    enabled: true"},{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool }}\""},{"line_number":701,"context_line":"  - name: \"sfc\""},{"line_number":702,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""},{"line_number":703,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"db628380_ee47c46b","line":700,"updated":"2024-01-30 15:12:16.000000000","message":"last time I checked (in ml2/ovn@yoga) I needed to enable explicitly dns or dns_domain_ports extension drivers to make internal dns work - similarly as stated here - https://docs.openstack.org/neutron/latest/admin/config-dns-int.html#the-networking-service-internal-dns-resolution","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1ce7801c2157c40da5180cdf5586d96219fde68d","unresolved":false,"context_lines":[{"line_number":697,"context_line":"  - name: \"port_security\""},{"line_number":698,"context_line":"    enabled: true"},{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool }}\""},{"line_number":701,"context_line":"  - name: \"sfc\""},{"line_number":702,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""},{"line_number":703,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"f31d643f_e999d070","line":700,"in_reply_to":"475043d8_2082def5","updated":"2024-01-30 15:39:08.000000000","message":"it will work here cause we\u0027re enabling subnet_dns_publish_fixed_ip","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"58c63c3c20e2542d01eccb4d79ea08430ebefef1","unresolved":true,"context_lines":[{"line_number":697,"context_line":"  - name: \"port_security\""},{"line_number":698,"context_line":"    enabled: true"},{"line_number":699,"context_line":"  - name: \"subnet_dns_publish_fixed_ip\""},{"line_number":700,"context_line":"    enabled: \"{{ neutron_dns_integration | bool }}\""},{"line_number":701,"context_line":"  - name: \"sfc\""},{"line_number":702,"context_line":"    enabled: \"{{ enable_neutron_sfc | bool }}\""},{"line_number":703,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"475043d8_2082def5","line":700,"in_reply_to":"db628380_ee47c46b","updated":"2024-01-30 15:36:33.000000000","message":"I don\u0027t think so, I\u0027ve created backport for yoga to just test it here https://review.opendev.org/q/topic:%22yoga-neutron-test%22 , let\u0027s see","commit_id":"6f847610b5e31cab912de2c83709e68e8d771125"}],"ansible/roles/neutron/tasks/precheck.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5395cc34bb2b0379a81cc6832f2db877d274f837","unresolved":true,"context_lines":[{"line_number":60,"context_line":"      - neutron_dns_domain !\u003d None"},{"line_number":61,"context_line":"      - neutron_dns_domain | length !\u003d 0"},{"line_number":62,"context_line":"      - neutron_dns_domain[-1] \u003d\u003d \u0027.\u0027"},{"line_number":63,"context_line":"    fail_msg: \"The neutron_dns_domain value has to be non-empty and must end with a period (.)\""},{"line_number":64,"context_line":"  changed_when: false"},{"line_number":65,"context_line":"  run_once: True"},{"line_number":66,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3b3f8dcf_681d92e5","line":63,"range":{"start_line":63,"start_character":91,"end_line":63,"end_character":94},"updated":"2024-01-18 13:58:14.000000000","message":"\u0027.\u0027","commit_id":"a41804daee640004b7e09edb6148376c2fb09de0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45e444dace3bc53e12bd8d0e31c89898ffc3e13d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      - neutron_dns_domain !\u003d None"},{"line_number":61,"context_line":"      - neutron_dns_domain | length !\u003d 0"},{"line_number":62,"context_line":"      - neutron_dns_domain[-1] \u003d\u003d \u0027.\u0027"},{"line_number":63,"context_line":"    fail_msg: \"The neutron_dns_domain value has to be non-empty and must end with a period (.)\""},{"line_number":64,"context_line":"  changed_when: false"},{"line_number":65,"context_line":"  run_once: True"},{"line_number":66,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e682959c_40d9612a","line":63,"range":{"start_line":63,"start_character":91,"end_line":63,"end_character":94},"in_reply_to":"3b3f8dcf_681d92e5","updated":"2024-01-19 09:09:11.000000000","message":"Done","commit_id":"a41804daee640004b7e09edb6148376c2fb09de0"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"02007bcacf218e2479451eb4c738f91bb8b9abeb","unresolved":true,"context_lines":[{"line_number":61,"context_line":"router_distributed \u003d True"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% if neutron_dns_integration | bool and neutron_dns_domain !\u003d None and neutron_dns_domain | length !\u003d 0 and neutron_dns_domain[-1] \u003d\u003d \u0027.\u0027 %}"},{"line_number":65,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}"},{"line_number":66,"context_line":"{% endif %}"},{"line_number":67,"context_line":"{% if enable_designate | bool and neutron_dns_integration | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"26ebbe22_48c1bad1","line":64,"updated":"2024-01-18 08:37:00.000000000","message":"All conditions except the first are handled by the precheck, so not needed at all?","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45e444dace3bc53e12bd8d0e31c89898ffc3e13d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"router_distributed \u003d True"},{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% if neutron_dns_integration | bool and neutron_dns_domain !\u003d None and neutron_dns_domain | length !\u003d 0 and neutron_dns_domain[-1] \u003d\u003d \u0027.\u0027 %}"},{"line_number":65,"context_line":"dns_domain \u003d {{ neutron_dns_domain }}"},{"line_number":66,"context_line":"{% endif %}"},{"line_number":67,"context_line":"{% if enable_designate | bool and neutron_dns_integration | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6c51cce3_9444a448","line":64,"in_reply_to":"26ebbe22_48c1bad1","updated":"2024-01-19 09:09:11.000000000","message":"Done","commit_id":"b1a46a5622ee56d93fc1a47a2775dcb41eb68e0d"}],"doc/source/reference/networking/designate-guide.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   add ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfigure with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":24,"id":"2d4a6678_f629cd4f","line":35,"range":{"start_line":35,"start_character":3,"end_line":35,"end_character":6},"updated":"2024-01-25 06:38:38.000000000","message":"adding","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   add ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfigure with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":24,"id":"57fb59e2_22e828ec","line":35,"range":{"start_line":35,"start_character":3,"end_line":35,"end_character":6},"in_reply_to":"2d4a6678_f629cd4f","updated":"2024-01-25 12:22:43.000000000","message":"Done","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   add ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfigure with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":24,"id":"8ba469da_96203042","line":37,"range":{"start_line":36,"start_character":7,"end_line":37,"end_character":1},"updated":"2024-01-25 06:38:38.000000000","message":"... reconfiguring with ``--tags neutron``.","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   add ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfigure with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. important::"}],"source_content_type":"text/x-rst","patch_set":24,"id":"2558084c_013522ec","line":37,"range":{"start_line":36,"start_character":7,"end_line":37,"end_character":1},"in_reply_to":"8ba469da_96203042","updated":"2024-01-25 12:22:43.000000000","message":"Done","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":102,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The ``designate-sink`` is an optional service which listens for event"},{"line_number":105,"context_line":"notifications, such as compute.instance.create.end, handlers are"},{"line_number":106,"context_line":"available for Nova and Neutron. Notification events can then be used"},{"line_number":107,"context_line":"to trigger record creation \u0026 deletion."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"ed2bf3eb_0bf077b5","line":105,"range":{"start_line":105,"start_character":23,"end_line":105,"end_character":50},"updated":"2024-01-25 06:38:38.000000000","message":"``compute.instance.create.end``","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The ``designate-sink`` is an optional service which listens for event"},{"line_number":105,"context_line":"notifications, such as compute.instance.create.end, handlers are"},{"line_number":106,"context_line":"available for Nova and Neutron. Notification events can then be used"},{"line_number":107,"context_line":"to trigger record creation \u0026 deletion."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"982a439a_a78bd2eb","line":105,"range":{"start_line":105,"start_character":23,"end_line":105,"end_character":50},"in_reply_to":"ed2bf3eb_0bf077b5","updated":"2024-01-25 12:22:43.000000000","message":"You wrote same as I wrote :D  ... actually that text is from designate doc..","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"   Service ``designate-sink`` in kolla deployments is enabled by default when ``enable_designate: yes``"},{"line_number":111,"context_line":"   and can be disabled by ``designate_enable_notifications_sink: no``."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Create default Designate Zone for Neutron:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"07c722c5_05edb2a2","line":111,"updated":"2024-01-25 06:38:38.000000000","message":"Didn\u0027t we want to change this to be disabled by default? With the previous patch you have disabled notifications being sent by nova, so we would have nothing to trigger on?","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"   Service ``designate-sink`` in kolla deployments is enabled by default when ``enable_designate: yes``"},{"line_number":111,"context_line":"   and can be disabled by ``designate_enable_notifications_sink: no``."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Create default Designate Zone for Neutron:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"2b0c7ad9_e135f9f7","line":111,"in_reply_to":"07c722c5_05edb2a2","updated":"2024-01-25 12:22:43.000000000","message":"True, but I\u0027ve changed to be backward compatible. So this is only about decision if  leave it enabled or disabled....\n\nDone","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e2fc3cea9c5c11d2dd7eab62dbe901dc3a83d7d2","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. important::"},{"line_number":30,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":31,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"}],"source_content_type":"text/x-rst","patch_set":28,"id":"30f0e402_93a0e116","line":31,"range":{"start_line":31,"start_character":52,"end_line":31,"end_character":55},"updated":"2024-01-29 14:21:35.000000000","message":"nit: maybe better to format this with double backticks instead of braces?","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11c32a84155c3a7a64a6dfe4f2eb28177f3e4ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. important::"},{"line_number":30,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":31,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"}],"source_content_type":"text/x-rst","patch_set":28,"id":"59de9ebe_d8d41e3e","line":31,"range":{"start_line":31,"start_character":52,"end_line":31,"end_character":55},"in_reply_to":"30f0e402_93a0e116","updated":"2024-01-30 09:02:23.000000000","message":"if it pleases you, why not, however, neutron official documentation uses it exactly like this (i\u0027ve just ctrl+c and ctrl+v with modification :) ).","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e2fc3cea9c5c11d2dd7eab62dbe901dc3a83d7d2","unresolved":true,"context_lines":[{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   adding ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfiguring with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"cc29bc7e_16c951e7","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":32},"updated":"2024-01-29 14:21:35.000000000","message":"at least my browser renders this in the preview (https://7c0b724b0ddcf96ebb58-1f01c4de10139c366cbd7ac49c7ab3d8.ssl.cf2.rackcdn.com/905852/28/check/openstack-tox-docs/e362eac/docs/reference/networking/designate-guide.html) with a single long dash instead of a double dash `–tags`.\n\nCan we maybe put this also in double backticks to avoid this? ``--tags``\n\nThanks!","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11c32a84155c3a7a64a6dfe4f2eb28177f3e4ca","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. important::"},{"line_number":34,"context_line":"   ``DNS Integration`` is enabled by default and can be disabled by"},{"line_number":35,"context_line":"   adding ``neutron_dns_integration: no`` to ``/etc/kolla/globals.yml``"},{"line_number":36,"context_line":"   and reconfiguring with --tags neutron."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Configure Designate options in ``/etc/kolla/globals.yml``"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"43079dc6_292162cd","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":32},"in_reply_to":"cc29bc7e_16c951e7","updated":"2024-01-30 09:02:23.000000000","message":"Done","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"}],"doc/source/reference/networking/neutron.rst":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e2fc3cea9c5c11d2dd7eab62dbe901dc3a83d7d2","unresolved":true,"context_lines":[{"line_number":121,"context_line":"   neutron_dns_domain: \"example.org.\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. important::"},{"line_number":124,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":125,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. note::"},{"line_number":128,"context_line":"   The integration of the Networking service with an external DNSaaS (DNS-as-a-Service)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"5e173b56_df02e004","line":125,"range":{"start_line":124,"start_character":3,"end_line":125,"end_character":56},"updated":"2024-01-29 14:21:35.000000000","message":"maybe I missed it, but do we actually _explain_ anywhere what `neutron_dns_domain` actually is/what it is used for?\n\nIf not it might be good to state this here.","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e2fc3cea9c5c11d2dd7eab62dbe901dc3a83d7d2","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. important::"},{"line_number":124,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":125,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. note::"},{"line_number":128,"context_line":"   The integration of the Networking service with an external DNSaaS (DNS-as-a-Service)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"989ecd9b_0bedd706","line":125,"range":{"start_line":125,"start_character":52,"end_line":125,"end_character":55},"updated":"2024-01-29 14:21:35.000000000","message":"nit: see my other comment comment about formatting.","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11c32a84155c3a7a64a6dfe4f2eb28177f3e4ca","unresolved":false,"context_lines":[{"line_number":121,"context_line":"   neutron_dns_domain: \"example.org.\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. important::"},{"line_number":124,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":125,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. note::"},{"line_number":128,"context_line":"   The integration of the Networking service with an external DNSaaS (DNS-as-a-Service)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"e943c465_7d57c8ef","line":125,"range":{"start_line":124,"start_character":3,"end_line":125,"end_character":56},"in_reply_to":"5e173b56_df02e004","updated":"2024-01-30 09:02:23.000000000","message":"Sorry but I am not going to document every single variable in kolla-ansible, how DNS assignment works depends on implementation which is described now in documentation very well. Hovewer it\u0027s here -\u003e doc/source/reference/networking/neutron.rst.\n\nI just want to say, I am not going to documment that \"kolla_useless_var\" sets \"useless_var\" in /etc/kolla/whatewer/whatewer.conf.","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b11c32a84155c3a7a64a6dfe4f2eb28177f3e4ca","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. important::"},{"line_number":124,"context_line":"   The ``neutron_dns_domain`` value has to be different to ``openstacklocal``"},{"line_number":125,"context_line":"   (its default value) and has to end with a period (.)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. note::"},{"line_number":128,"context_line":"   The integration of the Networking service with an external DNSaaS (DNS-as-a-Service)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"88d73723_f3178a0a","line":125,"range":{"start_line":125,"start_character":52,"end_line":125,"end_character":55},"in_reply_to":"989ecd9b_0bedd706","updated":"2024-01-30 09:02:23.000000000","message":"Done","commit_id":"5011116b36c9ca64f0c578a0e40e588b77dd50ea"}],"releasenotes/notes/fix-neutron-and-designate-DNS-integration-5abedb5e09e4fc15.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variable to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allows to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"d0b2273d_eac2caa2","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":23},"updated":"2024-01-25 06:38:38.000000000","message":"new variables","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variable to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allows to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"8c38dad0_48093e2a","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":23},"in_reply_to":"d0b2273d_eac2caa2","updated":"2024-01-25 12:22:43.000000000","message":"Done","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4471a9910f8034068c9af1987a61fda85515cc5f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variable to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allows to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5a240cb4_5a9fe7df","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":15},"updated":"2024-01-25 06:38:38.000000000","message":"allow","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"487b966e1913bf9b558adaad61d9840830c65f7b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variable to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allows to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."},{"line_number":8,"context_line":"fixes:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"96c689cc_dec434c4","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":15},"in_reply_to":"5a240cb4_5a9fe7df","updated":"2024-01-25 12:22:43.000000000","message":"Done","commit_id":"f46a3b975273a338771f5de3e3c96d15be413083"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b8431c461aa8395921d797766958aad5ed159b13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"2400355e_3575bae8","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-01-26 15:31:48.000000000","message":"I think we miss an `upgrade` section here, for the people who use designate_sink on purpose and rely on our old default of enabling it? or is designate_sink useless these days anyhow? I\u0027m not sure anymore.","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e38387e7838496426b0b2af0c21a6d3d8a77140c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"f85035ed_b7da07bc","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"186cf1bb_74ed826d","updated":"2024-01-26 19:00:09.000000000","message":"Done","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5ac28108d3ff0011f12fce8d725b80885551da4d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"186cf1bb_74ed826d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"2400355e_3575bae8","updated":"2024-01-26 15:37:55.000000000","message":"Good catch, I should probably add upgrade section and mention it.","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b8431c461aa8395921d797766958aad5ed159b13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allow to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"fb306d95_38095916","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":10},"updated":"2024-01-26 15:31:48.000000000","message":"2","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e38387e7838496426b0b2af0c21a6d3d8a77140c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allow to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"9a5dc568_db041492","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":10},"in_reply_to":"dfcfcc9e_62d5846b","updated":"2024-01-26 19:00:09.000000000","message":"Done","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5ac28108d3ff0011f12fce8d725b80885551da4d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new variables to be used by the neutron role,"},{"line_number":5,"context_line":"    ``neutron_dns_integration`` and ``neutron_dns_domain``."},{"line_number":6,"context_line":"    They allow to enable/disable internal/external DNS integrations,"},{"line_number":7,"context_line":"    or their combinations."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfcfcc9e_62d5846b","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":10},"in_reply_to":"fb306d95_38095916","updated":"2024-01-26 15:37:55.000000000","message":"will fix.","commit_id":"73d0b0478d3ab4f78fd760a1030600d29eb49cbd"}]}